@aaronshaf/ger 1.2.11 → 2.0.0

package/package.json

@@ -1,33 +1,100 @@
 {
   "name": "@aaronshaf/ger",
-  "version": "1.2.11",
-  "description": "Gerrit CLI",
-  "main": "src/ger.ts",
+  "version": "2.0.0",
+  "description": "Gerrit CLI and SDK - A modern CLI tool and TypeScript SDK for Gerrit Code Review, built with Effect-TS",
+  "keywords": [
+    "gerrit",
+    "code-review",
+    "cli",
+    "sdk",
+    "effect",
+    "effect-ts",
+    "typescript",
+    "api-client"
+  ],
+  "module": "index.ts",
+  "type": "module",
   "bin": {
     "ger": "./bin/ger"
   },
+  "exports": {
+    ".": {
+      "import": "./index.ts",
+      "types": "./index.ts"
+    },
+    "./api": {
+      "import": "./src/api/gerrit.ts",
+      "types": "./src/api/gerrit.ts"
+    },
+    "./services/config": {
+      "import": "./src/services/config.ts",
+      "types": "./src/services/config.ts"
+    },
+    "./services/review-strategy": {
+      "import": "./src/services/review-strategy.ts",
+      "types": "./src/services/review-strategy.ts"
+    },
+    "./services/git-worktree": {
+      "import": "./src/services/git-worktree.ts",
+      "types": "./src/services/git-worktree.ts"
+    },
+    "./schemas/gerrit": {
+      "import": "./src/schemas/gerrit.ts",
+      "types": "./src/schemas/gerrit.ts"
+    },
+    "./schemas/config": {
+      "import": "./src/schemas/config.ts",
+      "types": "./src/schemas/config.ts"
+    },
+    "./utils": {
+      "import": "./src/utils/index.ts",
+      "types": "./src/utils/index.ts"
+    }
+  },
   "repository": {
     "type": "git",
     "url": "git+https://github.com/aaronshaf/ger.git"
   },
-  "keywords": [
-    "gerrit"
-  ],
-  "author": "Aaron Shafovaloff <aaronshaf@gmail.com>",
-  "license": "MIT",
   "bugs": {
     "url": "https://github.com/aaronshaf/ger/issues"
   },
   "homepage": "https://github.com/aaronshaf/ger#readme",
   "devDependencies": {
-    "@commander-js/extra-typings": "^10.0.3",
-    "@types/node": "^18.16.1",
-    "cli-table3": "^0.6.3",
-    "eslint": "^8.39.0",
-    "ts-node": "^10.9.1",
-    "typescript": "^5.0.4"
+    "@biomejs/biome": "^2.2.2",
+    "@types/node": "^24.3.1",
+    "ast-grep": "^0.1.0",
+    "bun-types": "^1.2.21",
+    "husky": "^9.1.7",
+    "lint-staged": "^16.1.6",
+    "msw": "^2.11.1",
+    "oxlint": "^1.14.0",
+    "typescript": "^5.9.2"
+  },
+  "peerDependencies": {
+    "typescript": "^5.0.0"
   },
   "dependencies": {
-    "commander": "^10.0.1"
+    "@effect/platform": "^0.90.10",
+    "@effect/platform-node": "^0.94.2",
+    "@effect/schema": "^0.75.5",
+    "@inquirer/prompts": "^7.8.4",
+    "chalk": "^5.6.0",
+    "cli-table3": "^0.6.5",
+    "commander": "^14.0.0",
+    "effect": "^3.18.4",
+    "signal-exit": "3.0.7"
+  },
+  "scripts": {
+    "prepare": "husky",
+    "dev": "bun run src/cli/index.ts",
+    "build": "tsc --noEmit && echo 'Build successful - CLI runs directly with bun'",
+    "test": "bun test",
+    "test:coverage": "bun test --coverage",
+    "test:coverage:check": "bun scripts/check-coverage.ts",
+    "typecheck": "tsc --noEmit",
+    "lint": "oxlint src/ tests/",
+    "format": "biome format --write src/ tests/",
+    "format:check": "biome check src/ tests/",
+    "check:all": "bun run typecheck && bun run lint && bun run format:check && bun run test:coverage"
   }
 }

package/scripts/check-coverage.ts

@@ -0,0 +1,69 @@
+#!/usr/bin/env bun
+
+import { execSync } from 'child_process'
+
+// Coverage thresholds
+const THRESHOLDS = {
+  lines: 80,
+  functions: 80,
+}
+
+console.log('Running tests with coverage...\n')
+
+try {
+  // Run tests with coverage and capture both stdout and stderr
+  const output = execSync('bun test --coverage 2>&1', { encoding: 'utf8' })
+  
+  // Print the output
+  console.log(output)
+  
+  // Parse coverage from output
+  const coverageMatch = output.match(/All files\s*\|\s*([\d.]+)\s*\|\s*([\d.]+)\s*\|/)
+  if (!coverageMatch) {
+    console.log('\n⚠️  Could not parse coverage output')
+    // Still exit with success if we can't parse but tests passed
+    process.exit(0)
+  }
+
+  const functionsCoverage = parseFloat(coverageMatch[1])
+  const linesCoverage = parseFloat(coverageMatch[2])
+
+  console.log(`\n📊 Coverage Summary:`)
+  console.log(`   Functions: ${functionsCoverage}%`)
+  console.log(`   Lines: ${linesCoverage}%`)
+
+  // Check thresholds
+  let failed = false
+  if (functionsCoverage < THRESHOLDS.functions) {
+    console.log(`\n❌ Functions coverage (${functionsCoverage}%) is below threshold (${THRESHOLDS.functions}%)`)
+    failed = true
+  }
+
+  if (linesCoverage < THRESHOLDS.lines) {
+    console.log(`\n❌ Lines coverage (${linesCoverage}%) is below threshold (${THRESHOLDS.lines}%)`)
+    failed = true
+  }
+
+  if (failed) {
+    console.log('\n⚠️  Coverage is below threshold but not failing CI (adjust if needed)')
+    // For now, don't fail CI on coverage - this can be enabled later
+    // process.exit(1)
+    process.exit(0)
+  } else {
+    console.log('\n✅ Coverage meets all thresholds!')
+    process.exit(0)
+  }
+} catch (error: any) {
+  // If tests failed, the exit code will be non-zero
+  if (error.status !== 0) {
+    console.log('\n❌ Tests failed!')
+    // Still print the output if available
+    if (error.stdout) {
+      console.log(error.stdout.toString())
+    }
+    process.exit(1)
+  }
+  // Other errors
+  console.error('Error running coverage check:', error.message)
+  process.exit(1)
+}

package/scripts/check-file-size.ts

@@ -0,0 +1,38 @@
+#!/usr/bin/env bun
+
+import { readdir, stat } from 'node:fs/promises'
+import { join } from 'node:path'
+
+const MAX_LINES = 700
+const WARN_LINES = 500
+
+async function checkFileSize(dir: string): Promise<void> {
+  const files = await readdir(dir, { withFileTypes: true })
+  let hasErrors = false
+  let hasWarnings = false
+
+  for (const file of files) {
+    const fullPath = join(dir, file.name)
+    
+    if (file.isDirectory() && !['node_modules', 'dist', 'tmp', '.git'].includes(file.name)) {
+      await checkFileSize(fullPath)
+    } else if (file.isFile() && file.name.endsWith('.ts')) {
+      const content = await Bun.file(fullPath).text()
+      const lines = content.split('\n').length
+      
+      if (lines > MAX_LINES) {
+        console.error(`❌ ERROR: ${fullPath} has ${lines} lines (max: ${MAX_LINES})`)
+        hasErrors = true
+      } else if (lines > WARN_LINES) {
+        console.warn(`⚠️  WARNING: ${fullPath} has ${lines} lines (recommended max: ${WARN_LINES})`)
+        hasWarnings = true
+      }
+    }
+  }
+
+  if (hasErrors) {
+    process.exit(1)
+  }
+}
+
+checkFileSize('./src').catch(console.error)

package/scripts/fix-test-mocks.ts

@@ -0,0 +1,55 @@
+#!/usr/bin/env bun
+
+import * as fs from 'fs'
+import * as path from 'path'
+
+const testsDir = path.join(process.cwd(), 'tests')
+
+// Find all test files
+const testFiles = fs.readdirSync(testsDir)
+  .filter(file => file.endsWith('.test.ts'))
+  .map(file => path.join(testsDir, file))
+
+for (const file of testFiles) {
+  let content = fs.readFileSync(file, 'utf8')
+  
+  // Skip if already using the helper
+  if (content.includes('createMockConfigService')) {
+    continue
+  }
+  
+  // Check if file uses ConfigService mock
+  if (!content.includes('ConfigService.of({')) {
+    continue
+  }
+  
+  console.log(`Updating ${path.basename(file)}...`)
+  
+  // Add import for helper if ConfigService is used
+  if (content.includes('ConfigService')) {
+    // Add import after other imports
+    const importMatch = content.match(/(import[\s\S]*?from\s+['"].*?['"][\s\n]*)+/)
+    if (importMatch) {
+      const lastImportEnd = importMatch.index! + importMatch[0].length
+      content = content.slice(0, lastImportEnd) +
+        `import { createMockConfigService } from './helpers/config-mock'\n` +
+        content.slice(lastImportEnd)
+    }
+    
+    // Replace ConfigService.of({ ... }) with createMockConfigService()
+    content = content.replace(
+      /ConfigService\.of\(\{[\s\S]*?getCredentials:\s*Effect\.succeed\(\{[\s\S]*?\}\),[\s\S]*?saveCredentials:[\s\S]*?deleteCredentials:[\s\S]*?\}\)/g,
+      'createMockConfigService()'
+    )
+    
+    // Simpler pattern for common cases
+    content = content.replace(
+      /ConfigService\.of\(\{[\s\n\s]*getCredentials:\s*Effect\.succeed\(\{[\s\n\s]*host:\s*['"].*?['"],[\s\n\s]*username:\s*['"].*?['"],[\s\n\s]*password:\s*['"].*?['"],?[\s\n\s]*\}\),[\s\n\s]*saveCredentials:\s*\(\)\s*=>\s*Effect\.succeed\(undefined\),[\s\n\s]*deleteCredentials:\s*Effect\.succeed\(undefined\),?[\s\n\s]*\}\)/g,
+      'createMockConfigService()'
+    )
+  }
+  
+  fs.writeFileSync(file, content, 'utf8')
+}
+
+console.log('Done!')

package/skills/gerrit-workflow/SKILL.md

@@ -0,0 +1,247 @@
+---
+name: gerrit-workflow
+description: Work with Gerrit code reviews using the ger CLI tool. Use when reviewing changes, posting comments, managing patches, or interacting with Gerrit. Covers common workflows like fetching changes, viewing diffs, adding comments, and managing change status.
+allowed-tools: Bash, Read, Write, Edit, Grep, Glob
+---
+
+# Gerrit Workflow with ger CLI
+
+This skill helps you work effectively with Gerrit code reviews using the `ger` CLI tool.
+
+## Prerequisites
+
+The `ger` CLI tool must be installed and accessible in your PATH. It's available globally if installed from `~/github/ger`.
+
+## Core Commands
+
+### Viewing Changes
+
+**Show comprehensive change information:**
+```bash
+ger show [change-id]
+```
+Displays metadata, diff, and all comments for a change. If no change-id is provided, uses the current branch.
+
+**View specific diff:**
+```bash
+ger diff [change-id]
+```
+Get diffs with various formatting options.
+
+**View all comments:**
+```bash
+ger comments [change-id]
+```
+View all comments on a change with context.
+
+### Managing Changes
+
+**View your changes:**
+```bash
+ger mine
+```
+List all changes owned by you.
+
+**View incoming changes (review requests):**
+```bash
+ger incoming
+```
+List changes that need your review.
+
+**View open changes:**
+```bash
+ger open
+```
+List all open changes in the project.
+
+**Abandon a change:**
+```bash
+ger abandon [change-id]
+```
+Mark a change as abandoned.
+
+### Pushing Changes
+
+**Push changes to Gerrit:**
+```bash
+ger push
+```
+
+**Push with options:**
+```bash
+# Push to specific branch
+ger push -b main
+
+# Push with topic
+ger push -t my-feature
+
+# Push with reviewers
+ger push -r alice@example.com -r bob@example.com
+
+# Push as work-in-progress (WIP)
+ger push --wip
+
+# Mark change as ready for review
+ger push --ready
+
+# Combine options
+ger push -b main -t feature-auth -r alice@example.com --wip
+```
+
+**WIP Workflow (Optional):**
+Work-in-progress changes are useful when you want to push changes that aren't ready for review:
+```bash
+# Push initial work as WIP (won't notify reviewers)
+ger push --wip
+
+# Continue updating (stays WIP)
+ger push --wip
+
+# Mark ready when done (will notify reviewers)
+ger push --ready
+```
+
+**Search for WIP changes:**
+```bash
+# Find all WIP changes
+ger search "is:wip"
+
+# Your WIP changes
+ger search "owner:self is:wip"
+```
+
+### Commenting on Changes
+
+**Post a comment:**
+```bash
+ger comment [change-id] -m "Your comment"
+```
+
+**Post comment with piped input (useful for AI integration):**
+```bash
+echo "Review feedback" | ger comment [change-id]
+```
+
+**Post inline comments:**
+```bash
+ger comment [change-id] --file path/to/file --line 42 -m "Comment on specific line"
+```
+
+## Common Workflows
+
+### Reviewing a Change
+
+1. **Fetch the change details:**
+   ```bash
+   ger show [change-id]
+   ```
+
+2. **Review the diff:**
+   ```bash
+   ger diff [change-id]
+   ```
+
+3. **Post your review:**
+   ```bash
+   ger comment [change-id] -m "LGTM! Great work on the refactoring."
+   ```
+
+### AI-Assisted Code Review
+
+Use the ger CLI with AI tools for enhanced code review:
+
+1. **Get the diff:**
+   ```bash
+   ger diff [change-id] > /tmp/review.diff
+   ```
+
+2. **Analyze with AI and post comments:**
+   ```bash
+   # AI analyzes the diff and generates feedback
+   ai-tool analyze /tmp/review.diff | ger comment [change-id]
+   ```
+
+### Work-in-Progress (WIP) Workflow (Optional)
+
+If you need to push changes that aren't ready for review, you can use the WIP flag:
+
+1. **Start with WIP:**
+   ```bash
+   # Make changes
+   git add .
+   git commit -m "feat: add new feature"
+
+   # Push as WIP (won't notify reviewers)
+   ger push --wip
+   ```
+
+2. **Continue iterating:**
+   ```bash
+   # Make more changes
+   git add .
+   git commit --amend
+
+   # Push updates (stays WIP)
+   ger push --wip
+   ```
+
+3. **Mark ready when complete:**
+   ```bash
+   # Final polish
+   git add .
+   git commit --amend
+
+   # Mark ready for review (notifies reviewers)
+   ger push --ready
+   ```
+
+4. **Find WIP changes:**
+   ```bash
+   # List all your WIP changes
+   ger search "owner:self is:wip"
+   ```
+
+## Best Practices
+
+### When Reviewing Code
+
+1. **Always read the full change context** using `ger show` before commenting
+2. **Check all comments** with `ger comments` to avoid duplicate feedback
+3. **Be specific** in your comments - reference file paths and line numbers
+4. **Use constructive language** - focus on improvements, not criticism
+
+### When Managing Changes
+
+1. **Keep changes focused** - one logical change per Gerrit change
+2. **Respond to comments promptly** - address reviewer feedback
+3. **Use meaningful commit messages** - follow conventional commit format
+4. **Test before submitting** - ensure builds pass before requesting review
+5. **Consider WIP flag (optional)** - use `--wip` for changes not ready for review
+
+## Troubleshooting
+
+**Change not found:**
+- Ensure you're in the correct repository
+- Verify the change-id is correct
+- Check your Gerrit authentication
+
+**Permission denied:**
+- Verify your Gerrit credentials are configured
+- Check you have access to the project
+- Ensure you're added as a reviewer (for private changes)
+
+**Build failures:**
+- Use `ger build-status` to monitor build progress
+- Extract build URLs with `ger extract-url`
+- Check build logs for detailed failure information
+
+## Additional Resources
+
+For more detailed information, see [reference.md](reference.md) for complete command documentation and [examples.md](examples.md) for real-world usage examples.
+
+## Notes
+
+- Commands assume you're running from within a Gerrit repository
+- Most commands accept an optional change-id; if omitted, they use the current branch
+- The tool uses local SQLite caching for offline-first functionality
+- All output supports internationalization via i18next