@aaronshaf/ger 0.3.2 → 0.3.3

package/tests/add-reviewer.test.ts

@@ -0,0 +1,393 @@
+import { afterAll, afterEach, beforeAll, beforeEach, describe, expect, it, mock } from 'bun:test'
+import { Effect, Layer } from 'effect'
+import { HttpResponse, http } from 'msw'
+import { setupServer } from 'msw/node'
+import { GerritApiServiceLive } from '@/api/gerrit'
+import { addReviewerCommand } from '@/cli/commands/add-reviewer'
+import { ConfigService } from '@/services/config'
+import { createMockConfigService } from './helpers/config-mock'
+
+// Create MSW server
+const server = setupServer(
+  // Default handler for auth check
+  http.get('*/a/accounts/self', ({ request }) => {
+    const auth = request.headers.get('Authorization')
+    if (!auth || !auth.startsWith('Basic ')) {
+      return HttpResponse.text('Unauthorized', { status: 401 })
+    }
+    return HttpResponse.json({
+      _account_id: 1000,
+      name: 'Test User',
+      email: 'test@example.com',
+    })
+  }),
+)
+
+describe('add-reviewer command', () => {
+  let mockConsoleLog: ReturnType<typeof mock>
+  let mockConsoleError: ReturnType<typeof mock>
+
+  beforeAll(() => {
+    server.listen({ onUnhandledRequest: 'bypass' })
+  })
+
+  afterAll(() => {
+    server.close()
+  })
+
+  beforeEach(() => {
+    mockConsoleLog = mock(() => {})
+    mockConsoleError = mock(() => {})
+    console.log = mockConsoleLog
+    console.error = mockConsoleError
+  })
+
+  afterEach(() => {
+    server.resetHandlers()
+  })
+
+  it('should add a single reviewer successfully', async () => {
+    server.use(
+      http.post('*/a/changes/12345/reviewers', async ({ request }) => {
+        const body = (await request.json()) as { reviewer: string; state?: string }
+        expect(body.reviewer).toBe('reviewer@example.com')
+        expect(body.state).toBe('REVIEWER')
+        return HttpResponse.text(
+          `)]}'\n${JSON.stringify({
+            input: 'reviewer@example.com',
+            reviewers: [
+              {
+                _account_id: 2000,
+                name: 'Reviewer User',
+                email: 'reviewer@example.com',
+              },
+            ],
+          })}`,
+        )
+      }),
+    )
+
+    const mockConfigLayer = Layer.succeed(ConfigService, createMockConfigService())
+    const program = addReviewerCommand(['reviewer@example.com'], {
+      change: '12345',
+    }).pipe(Effect.provide(GerritApiServiceLive), Effect.provide(mockConfigLayer))
+
+    await Effect.runPromise(program)
+
+    const output = mockConsoleLog.mock.calls.map((call) => call[0]).join('\n')
+    expect(output).toContain('Added Reviewer User as reviewer')
+  })
+
+  it('should add multiple reviewers successfully', async () => {
+    let callCount = 0
+    server.use(
+      http.post('*/a/changes/12345/reviewers', async ({ request }) => {
+        const body = (await request.json()) as { reviewer: string }
+        callCount++
+        const reviewerName = callCount === 1 ? 'User One' : 'User Two'
+        return HttpResponse.text(
+          `)]}'\n${JSON.stringify({
+            input: body.reviewer,
+            reviewers: [
+              {
+                _account_id: 2000 + callCount,
+                name: reviewerName,
+                email: body.reviewer,
+              },
+            ],
+          })}`,
+        )
+      }),
+    )
+
+    const mockConfigLayer = Layer.succeed(ConfigService, createMockConfigService())
+    const program = addReviewerCommand(['user1@example.com', 'user2@example.com'], {
+      change: '12345',
+    }).pipe(Effect.provide(GerritApiServiceLive), Effect.provide(mockConfigLayer))
+
+    await Effect.runPromise(program)
+
+    const output = mockConsoleLog.mock.calls.map((call) => call[0]).join('\n')
+    expect(output).toContain('Added User One as reviewer')
+    expect(output).toContain('Added User Two as reviewer')
+    expect(callCount).toBe(2)
+  })
+
+  it('should add as CC when --cc flag is used', async () => {
+    server.use(
+      http.post('*/a/changes/12345/reviewers', async ({ request }) => {
+        const body = (await request.json()) as { reviewer: string; state?: string }
+        expect(body.reviewer).toBe('cc@example.com')
+        expect(body.state).toBe('CC')
+        return HttpResponse.text(
+          `)]}'\n${JSON.stringify({
+            input: 'cc@example.com',
+            ccs: [
+              {
+                _account_id: 2000,
+                name: 'CC User',
+                email: 'cc@example.com',
+              },
+            ],
+          })}`,
+        )
+      }),
+    )
+
+    const mockConfigLayer = Layer.succeed(ConfigService, createMockConfigService())
+    const program = addReviewerCommand(['cc@example.com'], {
+      change: '12345',
+      cc: true,
+    }).pipe(Effect.provide(GerritApiServiceLive), Effect.provide(mockConfigLayer))
+
+    await Effect.runPromise(program)
+
+    const output = mockConsoleLog.mock.calls.map((call) => call[0]).join('\n')
+    expect(output).toContain('Added CC User as cc')
+  })
+
+  it('should pass notify option to API', async () => {
+    server.use(
+      http.post('*/a/changes/12345/reviewers', async ({ request }) => {
+        const body = (await request.json()) as { reviewer: string; notify?: string }
+        expect(body.notify).toBe('NONE')
+        return HttpResponse.text(
+          `)]}'\n${JSON.stringify({
+            input: 'reviewer@example.com',
+            reviewers: [
+              {
+                _account_id: 2000,
+                name: 'Reviewer',
+                email: 'reviewer@example.com',
+              },
+            ],
+          })}`,
+        )
+      }),
+    )
+
+    const mockConfigLayer = Layer.succeed(ConfigService, createMockConfigService())
+    const program = addReviewerCommand(['reviewer@example.com'], {
+      change: '12345',
+      notify: 'none',
+    }).pipe(Effect.provide(GerritApiServiceLive), Effect.provide(mockConfigLayer))
+
+    await Effect.runPromise(program)
+
+    const output = mockConsoleLog.mock.calls.map((call) => call[0]).join('\n')
+    expect(output).toContain('Added Reviewer as reviewer')
+  })
+
+  it('should handle API error in result', async () => {
+    server.use(
+      http.post('*/a/changes/12345/reviewers', async () => {
+        return HttpResponse.text(
+          `)]}'\n${JSON.stringify({
+            input: 'nonexistent@example.com',
+            error: 'Account not found: nonexistent@example.com',
+          })}`,
+        )
+      }),
+    )
+
+    const mockConfigLayer = Layer.succeed(ConfigService, createMockConfigService())
+    const program = addReviewerCommand(['nonexistent@example.com'], {
+      change: '12345',
+    }).pipe(Effect.provide(GerritApiServiceLive), Effect.provide(mockConfigLayer))
+
+    await Effect.runPromise(program)
+
+    const errorOutput = mockConsoleError.mock.calls.map((call) => call[0]).join('\n')
+    expect(errorOutput).toContain('Failed to add nonexistent@example.com')
+    expect(errorOutput).toContain('Account not found')
+  })
+
+  it('should show error when change ID is not provided', async () => {
+    const mockConfigLayer = Layer.succeed(ConfigService, createMockConfigService())
+    const program = addReviewerCommand(['reviewer@example.com'], {}).pipe(
+      Effect.provide(GerritApiServiceLive),
+      Effect.provide(mockConfigLayer),
+    )
+
+    const result = await Effect.runPromiseExit(program)
+    expect(result._tag).toBe('Failure')
+
+    const errorOutput = mockConsoleError.mock.calls.map((call) => call[0]).join('\n')
+    expect(errorOutput).toContain('Change ID is required')
+  })
+
+  it('should show error when no reviewers are provided', async () => {
+    const mockConfigLayer = Layer.succeed(ConfigService, createMockConfigService())
+    const program = addReviewerCommand([], {
+      change: '12345',
+    }).pipe(Effect.provide(GerritApiServiceLive), Effect.provide(mockConfigLayer))
+
+    const result = await Effect.runPromiseExit(program)
+    expect(result._tag).toBe('Failure')
+
+    const errorOutput = mockConsoleError.mock.calls.map((call) => call[0]).join('\n')
+    expect(errorOutput).toContain('At least one reviewer is required')
+  })
+
+  it('should output XML format when --xml flag is used', async () => {
+    server.use(
+      http.post('*/a/changes/12345/reviewers', async () => {
+        return HttpResponse.text(
+          `)]}'\n${JSON.stringify({
+            input: 'reviewer@example.com',
+            reviewers: [
+              {
+                _account_id: 2000,
+                name: 'Reviewer User',
+                email: 'reviewer@example.com',
+              },
+            ],
+          })}`,
+        )
+      }),
+    )
+
+    const mockConfigLayer = Layer.succeed(ConfigService, createMockConfigService())
+    const program = addReviewerCommand(['reviewer@example.com'], {
+      change: '12345',
+      xml: true,
+    }).pipe(Effect.provide(GerritApiServiceLive), Effect.provide(mockConfigLayer))
+
+    await Effect.runPromise(program)
+
+    const output = mockConsoleLog.mock.calls.map((call) => call[0]).join('\n')
+    expect(output).toContain('<?xml version="1.0" encoding="UTF-8"?>')
+    expect(output).toContain('<add_reviewer_result>')
+    expect(output).toContain('<change_id>12345</change_id>')
+    expect(output).toContain('<state>reviewer</state>')
+    expect(output).toContain('<reviewer status="added">')
+    expect(output).toContain('<input>reviewer@example.com</input>')
+    expect(output).toContain('<name><![CDATA[Reviewer User]]></name>')
+    expect(output).toContain('<status>success</status>')
+    expect(output).toContain('</add_reviewer_result>')
+  })
+
+  it('should output XML format for errors when --xml flag is used', async () => {
+    const mockConfigLayer = Layer.succeed(ConfigService, createMockConfigService())
+    const program = addReviewerCommand(['reviewer@example.com'], {
+      xml: true,
+    }).pipe(Effect.provide(GerritApiServiceLive), Effect.provide(mockConfigLayer))
+
+    const result = await Effect.runPromiseExit(program)
+    expect(result._tag).toBe('Failure')
+
+    const output = mockConsoleLog.mock.calls.map((call) => call[0]).join('\n')
+    expect(output).toContain('<?xml version="1.0" encoding="UTF-8"?>')
+    expect(output).toContain('<add_reviewer_result>')
+    expect(output).toContain('<status>error</status>')
+    expect(output).toContain('<error><![CDATA[Change ID is required')
+    expect(output).toContain('</add_reviewer_result>')
+  })
+
+  it('should handle network errors gracefully', async () => {
+    server.use(
+      http.post('*/a/changes/12345/reviewers', () => {
+        return HttpResponse.text('Internal Server Error', { status: 500 })
+      }),
+    )
+
+    const mockConfigLayer = Layer.succeed(ConfigService, createMockConfigService())
+    const program = addReviewerCommand(['reviewer@example.com'], {
+      change: '12345',
+    }).pipe(Effect.provide(GerritApiServiceLive), Effect.provide(mockConfigLayer))
+
+    await Effect.runPromise(program)
+
+    const errorOutput = mockConsoleError.mock.calls.map((call) => call[0]).join('\n')
+    expect(errorOutput).toContain('Failed to add reviewer@example.com')
+  })
+
+  it('should handle partial success with multiple reviewers', async () => {
+    let callCount = 0
+    server.use(
+      http.post('*/a/changes/12345/reviewers', async ({ request }) => {
+        const body = (await request.json()) as { reviewer: string }
+        callCount++
+        if (callCount === 1) {
+          return HttpResponse.text(
+            `)]}'\n${JSON.stringify({
+              input: body.reviewer,
+              reviewers: [
+                {
+                  _account_id: 2001,
+                  name: 'Valid User',
+                  email: body.reviewer,
+                },
+              ],
+            })}`,
+          )
+        }
+        return HttpResponse.text(
+          `)]}'\n${JSON.stringify({
+            input: body.reviewer,
+            error: 'Account not found',
+          })}`,
+        )
+      }),
+    )
+
+    const mockConfigLayer = Layer.succeed(ConfigService, createMockConfigService())
+    const program = addReviewerCommand(['valid@example.com', 'invalid@example.com'], {
+      change: '12345',
+      xml: true,
+    }).pipe(Effect.provide(GerritApiServiceLive), Effect.provide(mockConfigLayer))
+
+    await Effect.runPromise(program)
+
+    const output = mockConsoleLog.mock.calls.map((call) => call[0]).join('\n')
+    expect(output).toContain('<status>partial_failure</status>')
+    expect(output).toContain('<reviewer status="added">')
+    expect(output).toContain('<reviewer status="failed">')
+  })
+
+  it('should reject invalid notify option', async () => {
+    const mockConfigLayer = Layer.succeed(ConfigService, createMockConfigService())
+    const program = addReviewerCommand(['reviewer@example.com'], {
+      change: '12345',
+      notify: 'invalid',
+    }).pipe(Effect.provide(GerritApiServiceLive), Effect.provide(mockConfigLayer))
+
+    const result = await Effect.runPromiseExit(program)
+    expect(result._tag).toBe('Failure')
+
+    const errorOutput = mockConsoleError.mock.calls.map((call) => call[0]).join('\n')
+    expect(errorOutput).toContain('Invalid notify level: invalid')
+    expect(errorOutput).toContain('Valid values: none, owner, owner_reviewers, all')
+  })
+
+  it('should pass REVIEWER state by default (not CC)', async () => {
+    let receivedState: string | undefined
+    server.use(
+      http.post('*/a/changes/12345/reviewers', async ({ request }) => {
+        const body = (await request.json()) as { reviewer: string; state?: string }
+        receivedState = body.state
+        return HttpResponse.text(
+          `)]}'\n${JSON.stringify({
+            input: body.reviewer,
+            reviewers: [
+              {
+                _account_id: 2000,
+                name: 'Reviewer',
+                email: body.reviewer,
+              },
+            ],
+          })}`,
+        )
+      }),
+    )
+
+    const mockConfigLayer = Layer.succeed(ConfigService, createMockConfigService())
+    const program = addReviewerCommand(['reviewer@example.com'], {
+      change: '12345',
+    }).pipe(Effect.provide(GerritApiServiceLive), Effect.provide(mockConfigLayer))
+
+    await Effect.runPromise(program)
+
+    expect(receivedState).toBe('REVIEWER')
+  })
+})

package/tests/integration/commit-hook.test.ts

@@ -0,0 +1,246 @@
+import { afterAll, afterEach, beforeAll, describe, expect, test } from 'bun:test'
+import { Effect, Layer } from 'effect'
+import { HttpResponse, http } from 'msw'
+import { setupServer } from 'msw/node'
+import { ConfigService } from '@/services/config'
+import { CommitHookService, CommitHookServiceLive } from '@/services/commit-hook'
+import { createMockConfigService } from '../helpers/config-mock'
+
+// Sample valid commit-msg hook script
+const VALID_HOOK_SCRIPT = `#!/bin/sh
+# From Gerrit Code Review 3.x
+#
+# Part of Gerrit Code Review (https://www.gerritcodereview.com/)
+
+# Add a Change-Id line to commit messages that don't have one
+add_change_id() {
+  # ... hook implementation
+  echo "Change-Id: I$(git hash-object -t blob /dev/null)"
+}
+
+add_change_id
+`
+
+// Create MSW server for hook download tests
+const server = setupServer()
+
+describe('CommitHookService Integration Tests', () => {
+  beforeAll(() => {
+    server.listen({ onUnhandledRequest: 'bypass' })
+  })
+
+  afterAll(() => {
+    server.close()
+  })
+
+  afterEach(() => {
+    server.resetHandlers()
+  })
+
+  describe('installHook', () => {
+    test('should successfully download hook from Gerrit server', async () => {
+      // Setup handler for successful hook download
+      server.use(
+        http.get('https://test.gerrit.com/tools/hooks/commit-msg', () => {
+          return HttpResponse.text(VALID_HOOK_SCRIPT, { status: 200 })
+        }),
+      )
+
+      const mockConfigLayer = Layer.succeed(ConfigService, createMockConfigService())
+
+      // Note: We can't fully test installHook without git repo context,
+      // but we can verify the HTTP request is made correctly
+      const effect = Effect.gen(function* () {
+        const service = yield* CommitHookService
+        yield* service.installHook()
+      }).pipe(Effect.provide(CommitHookServiceLive), Effect.provide(mockConfigLayer))
+
+      // Run with Effect.exit to capture the result without throwing
+      const exit = await Effect.runPromiseExit(effect)
+
+      // The test verifies the service can be constructed and HTTP fetch succeeds
+      // It will fail with NotGitRepoError because we're not in a git repo,
+      // but it should NOT fail due to HTTP issues
+      if (exit._tag === 'Failure') {
+        const errorStr = String(exit.cause)
+        // Should fail due to git repo issues, not HTTP issues
+        expect(errorStr).not.toContain('Failed to download')
+        expect(errorStr).not.toContain('fetch')
+      }
+    })
+
+    test('should handle 404 error when hook URL is not found', async () => {
+      server.use(
+        http.get('https://test.gerrit.com/tools/hooks/commit-msg', () => {
+          return HttpResponse.text('Not Found', { status: 404 })
+        }),
+      )
+
+      const mockConfigLayer = Layer.succeed(ConfigService, createMockConfigService())
+
+      const effect = Effect.gen(function* () {
+        const service = yield* CommitHookService
+        yield* service.installHook()
+      }).pipe(Effect.provide(CommitHookServiceLive), Effect.provide(mockConfigLayer))
+
+      const result = await Effect.runPromise(effect).catch((e) => e)
+
+      // Should fail with HookInstallError due to 404
+      expect(result).toBeInstanceOf(Error)
+      expect(String(result)).toContain('Failed to download')
+    })
+
+    test('should handle 500 server error gracefully', async () => {
+      server.use(
+        http.get('https://test.gerrit.com/tools/hooks/commit-msg', () => {
+          return HttpResponse.text('Internal Server Error', { status: 500 })
+        }),
+      )
+
+      const mockConfigLayer = Layer.succeed(ConfigService, createMockConfigService())
+
+      const effect = Effect.gen(function* () {
+        const service = yield* CommitHookService
+        yield* service.installHook()
+      }).pipe(Effect.provide(CommitHookServiceLive), Effect.provide(mockConfigLayer))
+
+      const result = await Effect.runPromise(effect).catch((e) => e)
+
+      expect(result).toBeInstanceOf(Error)
+      expect(String(result)).toContain('Failed to download')
+    })
+
+    test('should reject invalid hook content (not a script)', async () => {
+      server.use(
+        http.get('https://test.gerrit.com/tools/hooks/commit-msg', () => {
+          // Return HTML instead of shell script
+          return HttpResponse.text('<html><body>Error page</body></html>', { status: 200 })
+        }),
+      )
+
+      const mockConfigLayer = Layer.succeed(ConfigService, createMockConfigService())
+
+      const effect = Effect.gen(function* () {
+        const service = yield* CommitHookService
+        yield* service.installHook()
+      }).pipe(Effect.provide(CommitHookServiceLive), Effect.provide(mockConfigLayer))
+
+      const result = await Effect.runPromise(effect).catch((e) => e)
+
+      expect(result).toBeInstanceOf(Error)
+      expect(String(result)).toContain('valid script')
+    })
+
+    test('should handle network timeout', async () => {
+      server.use(
+        http.get('https://test.gerrit.com/tools/hooks/commit-msg', async () => {
+          // Simulate network delay that would cause timeout
+          await new Promise((resolve) => setTimeout(resolve, 100))
+          return HttpResponse.error()
+        }),
+      )
+
+      const mockConfigLayer = Layer.succeed(ConfigService, createMockConfigService())
+
+      const effect = Effect.gen(function* () {
+        const service = yield* CommitHookService
+        yield* service.installHook()
+      }).pipe(Effect.provide(CommitHookServiceLive), Effect.provide(mockConfigLayer))
+
+      const result = await Effect.runPromise(effect).catch((e) => e)
+
+      expect(result).toBeInstanceOf(Error)
+    })
+
+    test('should handle host with trailing slash', async () => {
+      // Use a host with trailing slash
+      const configWithTrailingSlash = createMockConfigService({
+        host: 'https://test.gerrit.com/',
+        username: 'testuser',
+        password: 'testpass',
+      })
+
+      server.use(
+        // The trailing slash should be normalized, so this handler should match
+        http.get('https://test.gerrit.com/tools/hooks/commit-msg', () => {
+          return HttpResponse.text(VALID_HOOK_SCRIPT, { status: 200 })
+        }),
+      )
+
+      const mockConfigLayer = Layer.succeed(ConfigService, configWithTrailingSlash)
+
+      const effect = Effect.gen(function* () {
+        const service = yield* CommitHookService
+        yield* service.installHook()
+      }).pipe(Effect.provide(CommitHookServiceLive), Effect.provide(mockConfigLayer))
+
+      // Should not fail due to double slash in URL
+      await Effect.runPromise(effect).catch((e) => {
+        // May fail for git repo reasons, but should not fail for URL issues
+        expect(String(e)).not.toContain('//tools')
+      })
+    })
+  })
+
+  describe('hook script validation', () => {
+    test('should accept sh shebang', async () => {
+      server.use(
+        http.get('https://test.gerrit.com/tools/hooks/commit-msg', () => {
+          return HttpResponse.text('#!/bin/sh\necho "hook"', { status: 200 })
+        }),
+      )
+
+      const mockConfigLayer = Layer.succeed(ConfigService, createMockConfigService())
+
+      const effect = Effect.gen(function* () {
+        const service = yield* CommitHookService
+        yield* service.installHook()
+      }).pipe(Effect.provide(CommitHookServiceLive), Effect.provide(mockConfigLayer))
+
+      const result = await Effect.runPromise(effect).catch((e) => e)
+
+      // Should not fail with "not a valid script" error
+      expect(String(result)).not.toContain('valid script')
+    })
+
+    test('should accept bash shebang', async () => {
+      server.use(
+        http.get('https://test.gerrit.com/tools/hooks/commit-msg', () => {
+          return HttpResponse.text('#!/bin/bash\necho "hook"', { status: 200 })
+        }),
+      )
+
+      const mockConfigLayer = Layer.succeed(ConfigService, createMockConfigService())
+
+      const effect = Effect.gen(function* () {
+        const service = yield* CommitHookService
+        yield* service.installHook()
+      }).pipe(Effect.provide(CommitHookServiceLive), Effect.provide(mockConfigLayer))
+
+      const result = await Effect.runPromise(effect).catch((e) => e)
+
+      // Should not fail with "not a valid script" error
+      expect(String(result)).not.toContain('valid script')
+    })
+
+    test('should accept env shebang', async () => {
+      server.use(
+        http.get('https://test.gerrit.com/tools/hooks/commit-msg', () => {
+          return HttpResponse.text('#!/usr/bin/env sh\necho "hook"', { status: 200 })
+        }),
+      )
+
+      const mockConfigLayer = Layer.succeed(ConfigService, createMockConfigService())
+
+      const effect = Effect.gen(function* () {
+        const service = yield* CommitHookService
+        yield* service.installHook()
+      }).pipe(Effect.provide(CommitHookServiceLive), Effect.provide(mockConfigLayer))
+
+      const result = await Effect.runPromise(effect).catch((e) => e)
+
+      // Should not fail with "not a valid script" error
+      expect(String(result)).not.toContain('valid script')
+    })
+  })
+})