@aaronshaf/ger 0.2.2 → 0.2.5

package/tests/show.test.ts

@@ -27,6 +27,7 @@ const server = setupServer(
 // Store captured output
 let capturedLogs: string[] = []
 let capturedErrors: string[] = []
+let capturedStdout: string[] = []
 
 // Mock console.log and console.error
 const mockConsoleLog = mock((...args: any[]) => {
@@ -36,9 +37,20 @@ const mockConsoleError = mock((...args: any[]) => {
   capturedErrors.push(args.join(' '))
 })
 
-// Store original console methods
+// Mock process.stdout.write to capture JSON output and handle callbacks
+const mockStdoutWrite = mock((chunk: any, callback?: any) => {
+  capturedStdout.push(String(chunk))
+  // Call the callback synchronously if provided
+  if (typeof callback === 'function') {
+    callback()
+  }
+  return true
+})
+
+// Store original methods
 const originalConsoleLog = console.log
 const originalConsoleError = console.error
+const originalStdoutWrite = process.stdout.write
 
 beforeAll(() => {
   server.listen({ onUnhandledRequest: 'bypass' })
@@ -46,20 +58,26 @@ beforeAll(() => {
   console.log = mockConsoleLog
   // @ts-ignore
   console.error = mockConsoleError
+  // @ts-ignore
+  process.stdout.write = mockStdoutWrite
 })
 
 afterAll(() => {
   server.close()
   console.log = originalConsoleLog
   console.error = originalConsoleError
+  // @ts-ignore
+  process.stdout.write = originalStdoutWrite
 })
 
 afterEach(() => {
   server.resetHandlers()
   mockConsoleLog.mockClear()
   mockConsoleError.mockClear()
+  mockStdoutWrite.mockClear()
   capturedLogs = []
   capturedErrors = []
+  capturedStdout = []
 })
 
 describe('show command', () => {
@@ -201,7 +219,7 @@ describe('show command', () => {
 
     await Effect.runPromise(program)
 
-    const output = capturedLogs.join('\n')
+    const output = capturedStdout.join('')
 
     expect(output).toContain('<?xml version="1.0" encoding="UTF-8"?>')
     expect(output).toContain('<show_result>')
@@ -258,7 +276,7 @@ describe('show command', () => {
 
     await Effect.runPromise(program)
 
-    const output = capturedLogs.join('\n')
+    const output = capturedStdout.join('')
 
     expect(output).toContain('<?xml version="1.0" encoding="UTF-8"?>')
     expect(output).toContain('<show_result>')
@@ -301,7 +319,7 @@ describe('show command', () => {
 
     await Effect.runPromise(program)
 
-    const output = capturedLogs.join('\n')
+    const output = capturedStdout.join('')
 
     expect(output).toContain('<subject><![CDATA[Fix "quotes" & <tags> in auth]]></subject>')
     expect(output).toContain('<branch>feature/fix&amp;improve</branch>')
@@ -450,7 +468,7 @@ describe('show command', () => {
 
     await Effect.runPromise(program)
 
-    const output = capturedLogs.join('\n')
+    const output = capturedStdout.join('')
 
     // Parse JSON to verify it's valid
     const parsed = JSON.parse(output)
@@ -495,7 +513,7 @@ describe('show command', () => {
 
     await Effect.runPromise(program)
 
-    const output = capturedLogs.join('\n')
+    const output = capturedStdout.join('')
 
     // Parse JSON to verify it's valid
     const parsed = JSON.parse(output)
@@ -516,7 +534,7 @@ describe('show command', () => {
 
     await Effect.runPromise(program)
 
-    const output = capturedLogs.join('\n')
+    const output = capturedStdout.join('')
 
     // Extract comment sections to verify order
     const commentMatches = output.matchAll(
@@ -581,7 +599,7 @@ describe('show command', () => {
 
     await Effect.runPromise(program)
 
-    const output = capturedLogs.join('\n')
+    const output = capturedStdout.join('')
     const parsed = JSON.parse(output)
 
     expect(parsed.messages).toBeDefined()
@@ -592,4 +610,204 @@ describe('show command', () => {
     expect(parsed.messages[0].author.name).toBe('Jenkins Bot')
     expect(parsed.messages[0].revision).toBe(2)
   })
+
+  test('should handle large JSON output without truncation', async () => {
+    // Create a large diff to simulate output > 64KB
+    const largeDiff = '--- a/large-file.js\n+++ b/large-file.js\n' + 'x'.repeat(100000)
+
+    const mockChange = generateMockChange({
+      _number: 12345,
+      subject: 'Large change with extensive diff',
+    })
+
+    // Create many comments to increase JSON size
+    const manyComments: Record<string, any[]> = {
+      'src/file.js': Array.from({ length: 100 }, (_, i) => ({
+        id: `comment${i}`,
+        path: 'src/file.js',
+        line: i + 1,
+        message: `Comment ${i}: ${'a'.repeat(500)}`, // Make comments substantial
+        author: {
+          name: 'Reviewer',
+          email: 'reviewer@example.com',
+        },
+        updated: '2024-01-15 11:30:00.000000000',
+        unresolved: false,
+      })),
+    }
+
+    server.use(
+      http.get('*/a/changes/:changeId', () => {
+        return HttpResponse.text(`)]}'\n${JSON.stringify(mockChange)}`)
+      }),
+      http.get('*/a/changes/:changeId/revisions/current/patch', () => {
+        return HttpResponse.text(btoa(largeDiff))
+      }),
+      http.get('*/a/changes/:changeId/revisions/current/comments', () => {
+        return HttpResponse.text(`)]}'\n${JSON.stringify(manyComments)}`)
+      }),
+      http.get('*/a/changes/:changeId/revisions/current/files/:fileName/diff', () => {
+        return HttpResponse.text('context')
+      }),
+    )
+
+    const mockConfigLayer = createMockConfigLayer()
+    const program = showCommand('12345', { json: true }).pipe(
+      Effect.provide(GerritApiServiceLive),
+      Effect.provide(mockConfigLayer),
+    )
+
+    await Effect.runPromise(program)
+
+    const output = capturedStdout.join('')
+
+    // Verify output is larger than 64KB (the previous truncation point)
+    expect(output.length).toBeGreaterThan(65536)
+
+    // Verify JSON is valid and complete
+    const parsed = JSON.parse(output)
+    expect(parsed.status).toBe('success')
+    expect(parsed.diff).toContain('x'.repeat(100000))
+    expect(parsed.comments.length).toBe(100)
+
+    // Verify last comment is present (proves no truncation)
+    const lastComment = parsed.comments[parsed.comments.length - 1]
+    expect(lastComment.message).toContain('Comment 99')
+  })
+
+  test('should handle stdout drain event when buffer is full', async () => {
+    setupMockHandlers()
+
+    // Store original stdout.write
+    const originalStdoutWrite = process.stdout.write
+
+    let drainCallback: (() => void) | null = null
+    let errorCallback: ((err: Error) => void) | null = null
+    let writeCallbackFn: ((err?: Error) => void) | null = null
+
+    // Mock stdout.write to simulate full buffer
+    const mockWrite = mock((chunk: any, callback?: any) => {
+      capturedStdout.push(String(chunk))
+      writeCallbackFn = callback
+      // Return false to simulate full buffer
+      return false
+    })
+
+    // Mock stdout.once to capture drain and error listeners
+    const mockOnce = mock((event: string, callback: any) => {
+      if (event === 'drain') {
+        drainCallback = callback
+        // Simulate drain event after a short delay
+        setTimeout(() => {
+          if (drainCallback) {
+            drainCallback()
+            if (writeCallbackFn) {
+              writeCallbackFn()
+            }
+          }
+        }, 10)
+      } else if (event === 'error') {
+        errorCallback = callback
+      }
+      return process.stdout
+    })
+
+    // Apply mocks
+    // @ts-ignore
+    process.stdout.write = mockWrite
+    // @ts-ignore
+    process.stdout.once = mockOnce
+
+    const mockConfigLayer = createMockConfigLayer()
+    const program = showCommand('12345', { json: true }).pipe(
+      Effect.provide(GerritApiServiceLive),
+      Effect.provide(mockConfigLayer),
+    )
+
+    await Effect.runPromise(program)
+
+    // Restore original stdout.write
+    // @ts-ignore
+    process.stdout.write = originalStdoutWrite
+
+    // Verify that write returned false (buffer full)
+    expect(mockWrite).toHaveBeenCalled()
+
+    // Verify that drain listener was registered
+    expect(mockOnce).toHaveBeenCalledWith('drain', expect.any(Function))
+
+    // Verify that error listener was registered for robustness
+    expect(mockOnce).toHaveBeenCalledWith('error', expect.any(Function))
+
+    // Verify output is still valid JSON despite drain handling
+    const output = capturedStdout.join('')
+    const parsed = JSON.parse(output)
+    expect(parsed.status).toBe('success')
+    expect(parsed.change.id).toBe('I123abc456def')
+  })
+
+  test('should handle large XML output without truncation', async () => {
+    // Create a large diff to simulate output > 64KB
+    const largeDiff = '--- a/large-file.js\n+++ b/large-file.js\n' + 'x'.repeat(100000)
+
+    const mockChange = generateMockChange({
+      _number: 12345,
+      subject: 'Large change with extensive diff',
+    })
+
+    // Create many comments to increase XML size
+    const manyComments: Record<string, any[]> = {
+      'src/file.js': Array.from({ length: 100 }, (_, i) => ({
+        id: `comment${i}`,
+        path: 'src/file.js',
+        line: i + 1,
+        message: `Comment ${i}: ${'a'.repeat(500)}`,
+        author: {
+          name: 'Reviewer',
+          email: 'reviewer@example.com',
+        },
+        updated: '2024-01-15 11:30:00.000000000',
+        unresolved: false,
+      })),
+    }
+
+    server.use(
+      http.get('*/a/changes/:changeId', () => {
+        return HttpResponse.text(`)]}'\n${JSON.stringify(mockChange)}`)
+      }),
+      http.get('*/a/changes/:changeId/revisions/current/patch', () => {
+        return HttpResponse.text(btoa(largeDiff))
+      }),
+      http.get('*/a/changes/:changeId/revisions/current/comments', () => {
+        return HttpResponse.text(`)]}'\n${JSON.stringify(manyComments)}`)
+      }),
+      http.get('*/a/changes/:changeId/revisions/current/files/:fileName/diff', () => {
+        return HttpResponse.text('context')
+      }),
+    )
+
+    const mockConfigLayer = createMockConfigLayer()
+    const program = showCommand('12345', { xml: true }).pipe(
+      Effect.provide(GerritApiServiceLive),
+      Effect.provide(mockConfigLayer),
+    )
+
+    await Effect.runPromise(program)
+
+    const output = capturedStdout.join('')
+
+    // Verify output is larger than 64KB
+    expect(output.length).toBeGreaterThan(65536)
+
+    // Verify XML is valid and complete
+    expect(output).toContain('<?xml version="1.0" encoding="UTF-8"?>')
+    expect(output).toContain('<show_result>')
+    expect(output).toContain('<status>success</status>')
+    expect(output).toContain('x'.repeat(100000))
+    expect(output).toContain('<count>100</count>')
+    expect(output).toContain('</show_result>')
+
+    // Verify last comment is present (proves no truncation)
+    expect(output).toContain('Comment 99')
+  })
 })

package/tests/mocks/fetch-mock.ts

@@ -1,142 +0,0 @@
-import { mock } from 'bun:test'
-import { Schema } from '@effect/schema'
-import { ChangeInfo } from '@/schemas/gerrit'
-import {
-  generateMockAccount,
-  generateMockChange,
-  generateMockFileDiff,
-  generateMockFiles,
-} from '@/test-utils/mock-generator'
-
-// Generate consistent mock data using Effect Schema
-const mockChange = generateMockChange()
-const mockFiles = generateMockFiles()
-const mockDiff = generateMockFileDiff()
-const mockAccount = generateMockAccount()
-
-// Keep the old mockChange definition for now as backup (disabled to fix unused variable)
-// const _mockChange: Schema.Schema.Type<typeof ChangeInfo> = {
-//   id: 'myProject~master~I8473b95934b5732ac55d26311a706c9c2bde9940',
-//   project: 'myProject',
-//   branch: 'master',
-//   change_id: 'I8473b95934b5732ac55d26311a706c9c2bde9940',
-//   subject: 'Implementing new feature',
-//   status: 'NEW',
-//   created: '2023-12-01 10:00:00.000000000',
-//   updated: '2023-12-01 12:00:00.000000000',
-//   _number: 123456,
-//   owner: {
-//     _account_id: 1000000,
-//     name: 'John Doe',
-//     email: 'john.doe@example.com',
-//   },
-//   labels: {},
-//   permitted_labels: {},
-//   removable_reviewers: [],
-//   reviewers: {},
-//   requirements: [],
-// }
-
-export const setupFetchMock = (): ((
-  url: string | URL,
-  options?: RequestInit,
-) => Promise<Response>) => {
-  return mock(async (url: string | URL, options?: RequestInit): Promise<Response> => {
-    const urlStr = url.toString()
-    const method = options?.method || 'GET'
-
-    // Check authentication
-    const authHeader =
-      options?.headers && 'Authorization' in options.headers
-        ? (options.headers as Record<string, string>).Authorization
-        : undefined
-
-    if (!authHeader || !authHeader.startsWith('Basic ')) {
-      return new Response(`)]}'\n${JSON.stringify({ message: 'Unauthorized' })}`, { status: 401 })
-    }
-
-    // Authentication endpoint
-    if (urlStr.includes('/a/accounts/self')) {
-      return new Response(`)]}'\n${JSON.stringify(mockAccount)}`, { status: 200 })
-    }
-
-    // List changes endpoint (must come before get change endpoint)
-    if (urlStr.includes('/a/changes/?q=')) {
-      return new Response(`)]}'\n${JSON.stringify([mockChange])}`, { status: 200 })
-    }
-
-    // Get change endpoint
-    if (
-      urlStr.includes('/a/changes/') &&
-      method === 'GET' &&
-      !urlStr.includes('/files') &&
-      !urlStr.includes('/diff') &&
-      !urlStr.includes('/patch') &&
-      !urlStr.includes('/review')
-    ) {
-      if (urlStr.includes('notfound')) {
-        return new Response(`)]}'\n${JSON.stringify({ message: 'Not found' })}`, { status: 404 })
-      }
-
-      // Validate response against schema
-      const validated = Schema.decodeUnknownSync(ChangeInfo)(mockChange)
-      return new Response(`)]}'\n${JSON.stringify(validated)}`, { status: 200 })
-    }
-
-    // Get file diff endpoint - must be checked BEFORE other file endpoints
-    if (urlStr.includes('/files/') && urlStr.includes('/diff') && method === 'GET') {
-      return new Response(`)]}'\n${JSON.stringify(mockDiff)}`, { status: 200 })
-    }
-
-    // Get files endpoint (list of files)
-    if (
-      urlStr.includes('/files') &&
-      method === 'GET' &&
-      !urlStr.includes('/diff') &&
-      !urlStr.includes('/content')
-    ) {
-      return new Response(`)]}'\n${JSON.stringify(mockFiles)}`, { status: 200 })
-    }
-
-    // Get file content endpoint
-    if (urlStr.includes('/content') && method === 'GET' && !urlStr.includes('/diff')) {
-      const content =
-        'function main() {\n  console.log("Hello, world!")\n  return process.exit(0)\n}'
-      const base64Content = btoa(content)
-      return new Response(base64Content, { status: 200 })
-    }
-
-    // Get patch endpoint
-    if (urlStr.includes('/patch') && method === 'GET') {
-      const patch = `--- a/src/main.ts
-+++ b/src/main.ts
-@@ -1,3 +1,3 @@
- function main() {
-   console.log("Hello, world!")
--  return 0
-+  return process.exit(0)
- }`
-      const base64Patch = btoa(patch)
-      return new Response(base64Patch, { status: 200 })
-    }
-
-    // Post review endpoint
-    if (urlStr.includes('/review') && method === 'POST') {
-      return new Response(
-        ")]}'\n" +
-          JSON.stringify({
-            labels: {},
-            ready: true,
-          }),
-        { status: 200 },
-      )
-    }
-
-    // Default 404 for unhandled requests
-    return new Response(`)]}'\n${JSON.stringify({ message: 'Not found' })}`, { status: 404 })
-  })
-}
-
-export const restoreFetch: () => void = () => {
-  // Restore original fetch (Bun handles this automatically after tests)
-}

package/tests/setup.ts

@@ -1,13 +0,0 @@
-import { afterEach, beforeAll } from 'bun:test'
-import { setupFetchMock } from './mocks/fetch-mock'
-
-// Setup Bun's native fetch mocking before all tests
-beforeAll(() => {
-  setupFetchMock()
-})
-
-// Clean up after each test (Bun automatically restores mocks)
-afterEach(() => {
-  // Bun automatically handles mock cleanup
-  // But we can reset if needed
-})