@aaronshaf/ger 0.1.6 → 0.1.7

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@aaronshaf/ger",
-  "version": "0.1.6",
+  "version": "0.1.7",
   "module": "index.ts",
   "type": "module",
   "bin": {

package/src/cli/commands/comment.ts

@@ -443,9 +443,9 @@ const formatHumanOutput = (
       console.log(`File: ${options.file}, Line: ${options.line}`)
       console.log(`Message: ${options.message}`)
       if (options.unresolved) console.log(`Status: Unresolved`)
-    } else {
-      console.log(`Message: ${review.message}`)
     }
+    // Note: For overall review messages, we don't display the content here
+    // since it was already shown in the "OVERALL REVIEW TO POST" section
   })
 
 // Main output formatter

package/src/cli/commands/setup.ts

@@ -66,14 +66,54 @@ const verifyCredentials = (credentials: GerritCredentials) =>
     },
     catch: (error) => {
       if (error instanceof Error) {
+        // Authentication/permission errors
         if (error.message.includes('401')) {
           return new ConfigError({
             message: 'Invalid credentials. Please check your username and password.',
           })
         }
+        if (error.message.includes('403')) {
+          return new ConfigError({
+            message: 'Access denied. Please verify your credentials and server permissions.',
+          })
+        }
+
+        // Network/hostname errors
         if (error.message.includes('ENOTFOUND')) {
-          return new ConfigError({ message: 'Could not connect to Gerrit. Please check the URL.' })
+          return new ConfigError({
+            message: `Hostname not found. Please check that the Gerrit URL is correct.\nExample: https://gerrit.example.com (without /a/ or paths)`,
+          })
+        }
+        if (error.message.includes('ECONNREFUSED')) {
+          return new ConfigError({
+            message: `Connection refused. The server may be down or the port may be incorrect.\nPlease verify the URL and try again.`,
+          })
         }
+        if (error.message.includes('ETIMEDOUT')) {
+          return new ConfigError({
+            message: `Connection timed out. Please check:\n• Your internet connection\n• The Gerrit server URL\n• Any firewall or VPN settings`,
+          })
+        }
+        if (error.message.includes('certificate') || error.message.includes('SSL')) {
+          return new ConfigError({
+            message: `SSL/Certificate error. Please ensure the URL uses HTTPS and the certificate is valid.`,
+          })
+        }
+
+        // URL format errors
+        if (error.message.includes('Invalid URL') || error.message.includes('fetch failed')) {
+          return new ConfigError({
+            message: `Invalid URL format. Please use the full URL including https://\nExample: https://gerrit.example.com`,
+          })
+        }
+
+        // Generic network errors
+        if (error.message.includes('network') || error.message.includes('fetch')) {
+          return new ConfigError({
+            message: `Network error: ${error.message}\nPlease check your connection and the Gerrit server URL.`,
+          })
+        }
+
         return new ConfigError({ message: error.message })
       }
       return new ConfigError({ message: 'Unknown error occurred' })
@@ -112,64 +152,82 @@ const setupEffect = (configService: ConfigServiceImpl) =>
             try: async () => {
               console.log('')
 
-              // Gerrit Host URL
-              const host = await input({
-                message: 'Gerrit Host URL (e.g., https://gerrit.example.com)',
-                default: existingConfig?.host,
-              })
+              // Enable raw mode for proper password masking
+              const wasRawMode = process.stdin.isRaw
+              if (process.stdin.isTTY && !wasRawMode) {
+                process.stdin.setRawMode(true)
+              }
 
-              // Username
-              const username = await input({
-                message: 'Username (your Gerrit username)',
-                default: existingConfig?.username,
-              })
+              try {
+                // Gerrit Host URL
+                const host = await input({
+                  message: 'Gerrit Host URL (e.g., https://gerrit.example.com)',
+                  default: existingConfig?.host,
+                })
 
-              // Password - similar to ji's pattern
-              const passwordValue =
-                (await password({
-                  message: 'HTTP Password (generated from Gerrit settings)',
-                })) ||
-                existingConfig?.password ||
-                ''
+                // Username
+                const username = await input({
+                  message: 'Username (your Gerrit username)',
+                  default: existingConfig?.username,
+                })
 
-              console.log('')
-              console.log(chalk.yellow('Optional: AI Configuration'))
+                // Password - with proper masking and visual feedback
+                const passwordMessage = existingConfig?.password
+                  ? `HTTP Password (generated from Gerrit settings) ${chalk.dim('(press Enter to keep existing)')}`
+                  : 'HTTP Password (generated from Gerrit settings)'
 
-              // Show detected AI tools
-              if (availableTools.length > 0) {
-                console.log(chalk.dim(`Detected AI tools: ${availableTools.join(', ')}`))
-              }
+                const passwordValue =
+                  (await password({
+                    message: passwordMessage,
+                    mask: true, // Show * characters as user types
+                  })) ||
+                  existingConfig?.password ||
+                  ''
 
-              // Get default suggestion
-              const defaultCommand =
-                existingConfig?.aiTool ||
-                (availableTools.includes('claude') ? 'claude' : availableTools[0]) ||
-                ''
-
-              // AI tool command with smart default
-              const aiToolCommand = await input({
-                message:
-                  availableTools.length > 0
-                    ? 'AI tool command (detected from system)'
-                    : 'AI tool command (e.g., claude, llm, opencode, gemini)',
-                default: defaultCommand || 'claude',
-              })
+                console.log('')
+                console.log(chalk.yellow('Optional: AI Configuration'))
 
-              // Build flat config
-              const configData = {
-                host: host.trim().replace(/\/$/, ''), // Remove trailing slash
-                username: username.trim(),
-                password: passwordValue,
-                ...(aiToolCommand && {
-                  aiTool: aiToolCommand,
-                }),
-                aiAutoDetect: !aiToolCommand,
-              }
+                // Show detected AI tools
+                if (availableTools.length > 0) {
+                  console.log(chalk.dim(`Detected AI tools: ${availableTools.join(', ')}`))
+                }
 
-              // Validate config using Schema instead of type assertion
-              const fullConfig = Schema.decodeUnknownSync(AppConfig)(configData)
+                // Get default suggestion
+                const defaultCommand =
+                  existingConfig?.aiTool ||
+                  (availableTools.includes('claude') ? 'claude' : availableTools[0]) ||
+                  ''
 
-              return fullConfig
+                // AI tool command with smart default
+                const aiToolCommand = await input({
+                  message:
+                    availableTools.length > 0
+                      ? 'AI tool command (detected from system)'
+                      : 'AI tool command (e.g., claude, llm, opencode, gemini)',
+                  default: defaultCommand || 'claude',
+                })
+
+                // Build flat config
+                const configData = {
+                  host: host.trim().replace(/\/$/, ''), // Remove trailing slash
+                  username: username.trim(),
+                  password: passwordValue,
+                  ...(aiToolCommand && {
+                    aiTool: aiToolCommand,
+                  }),
+                  aiAutoDetect: !aiToolCommand,
+                }
+
+                // Validate config using Schema instead of type assertion
+                const fullConfig = Schema.decodeUnknownSync(AppConfig)(configData)
+
+                return fullConfig
+              } finally {
+                // Restore raw mode state
+                if (process.stdin.isTTY && !wasRawMode) {
+                  process.stdin.setRawMode(false)
+                }
+              }
             },
             catch: (error) => {
               if (error instanceof Error && error.message.includes('User force closed')) {
@@ -205,11 +263,8 @@ const setupEffect = (configService: ConfigServiceImpl) =>
     Effect.catchAll((error) =>
       pipe(
         Console.error(
-          chalk.red(
-            `\nAuthentication failed: ${error instanceof ConfigError ? error.message : 'Unknown error'}`,
-          ),
+          chalk.red(`\n${error instanceof ConfigError ? error.message : `Setup failed: ${error}`}`),
         ),
-        Effect.flatMap(() => Console.error('Please check your credentials and try again.')),
         Effect.flatMap(() => Effect.fail(error)),
       ),
     ),

package/tests/comment.test.ts

@@ -556,7 +556,8 @@ describe('comment command', () => {
 
     const output = mockConsoleLog.mock.calls.map((call) => call[0]).join('\n')
     expect(output).toContain('✓ Comment posted successfully!')
-    expect(output).toContain('Message: Piped comment message')
+    // Note: The message content is no longer displayed after successful posting
+    // to avoid duplication with the review preview section
 
     // Restore process.stdin
     Object.defineProperty(process, 'stdin', {