@aaronshaf/ger 0.1.10 → 0.2.0

package/.github/workflows/claude-code-review.yml

@@ -2,77 +2,82 @@ name: Claude Code Review
 
 on:
   pull_request:
-    types: [opened, synchronize]
-    # Optional: Only run on specific file changes
-    # paths:
-    #   - "src/**/*.ts"
-    #   - "src/**/*.tsx"
-    #   - "src/**/*.js"
-    #   - "src/**/*.jsx"
+    types: [opened, synchronize, ready_for_review, reopened]
+    paths:
+      - "src/**/*.ts"
+      - "tests/**/*.ts"
+      - "scripts/**/*.ts"
+      - "package.json"
+      - "tsconfig.json"
 
 jobs:
   claude-review:
-    # Optional: Filter by PR author
-    # if: |
-    #   github.event.pull_request.user.login == 'external-contributor' ||
-    #   github.event.pull_request.user.login == 'new-developer' ||
-    #   github.event.pull_request.author_association == 'FIRST_TIME_CONTRIBUTOR'
-    
+    # Skip draft PRs and PRs from bots
+    if: |
+      github.event.pull_request.draft == false &&
+      github.event.pull_request.user.login != 'dependabot[bot]'
+
     runs-on: ubuntu-latest
     permissions:
       contents: read
-      pull-requests: read
-      issues: read
+      pull-requests: write
       id-token: write
-    
+
     steps:
       - name: Checkout repository
-        uses: actions/checkout@v4
+        uses: actions/checkout@v5
         with:
           fetch-depth: 1
 
       - name: Run Claude Code Review
         id: claude-review
-        uses: anthropics/claude-code-action@beta
+        uses: anthropics/claude-code-action@v1
         with:
           claude_code_oauth_token: ${{ secrets.CLAUDE_CODE_OAUTH_TOKEN }}
 
-          # Optional: Specify model (defaults to Claude Sonnet 4, uncomment for Claude Opus 4)
-          # model: "claude-opus-4-20250514"
-          
-          # Direct prompt for automated review (no @claude mention needed)
-          direct_prompt: |
-            Please review this pull request and provide feedback on:
-            - Code quality and best practices
-            - Potential bugs or issues
-            - Performance considerations
-            - Security concerns
-            - Test coverage
-            
-            Be constructive and helpful in your feedback.
-
-          # Optional: Use sticky comments to make Claude reuse the same comment on subsequent pushes to the same PR
-          # use_sticky_comment: true
-          
-          # Optional: Customize review based on file types
-          # direct_prompt: |
-          #   Review this PR focusing on:
-          #   - For TypeScript files: Type safety and proper interface usage
-          #   - For API endpoints: Security, input validation, and error handling
-          #   - For React components: Performance, accessibility, and best practices
-          #   - For tests: Coverage, edge cases, and test quality
-          
-          # Optional: Different prompts for different authors
-          # direct_prompt: |
-          #   ${{ github.event.pull_request.author_association == 'FIRST_TIME_CONTRIBUTOR' && 
-          #   'Welcome! Please review this PR from a first-time contributor. Be encouraging and provide detailed explanations for any suggestions.' ||
-          #   'Please provide a thorough code review focusing on our coding standards and best practices.' }}
-          
-          # Optional: Add specific tools for running tests or linting
-          # allowed_tools: "Bash(npm run test),Bash(npm run lint),Bash(npm run typecheck)"
-          
-          # Optional: Skip review for certain conditions
-          # if: |
-          #   !contains(github.event.pull_request.title, '[skip-review]') &&
-          #   !contains(github.event.pull_request.title, '[WIP]')
+          # Enable progress tracking for sticky comments
+          track_progress: true
+
+          prompt: |
+            REPO: ${{ github.repository }}
+            PR NUMBER: ${{ github.event.pull_request.number }}
+
+            Perform a comprehensive code review focusing on:
+
+            1. **Code Quality & Standards**
+               - Adherence to CLAUDE.md project rules
+               - TypeScript best practices with isolatedDeclarations
+               - No implicit any or as typecasting (except as const/as unknown)
+               - Functional programming patterns with Effect
+               - Files should not exceed 700 lines (block) or 500 lines (warn)
+
+            2. **Testing & Coverage**
+               - Minimum 80% code coverage requirement
+               - Both unit tests and integration tests for command changes
+               - Proper HTTP mocking with Bun's native fetch
+               - Effect Schema validation in tests
+
+            3. **Security**
+               - No sensitive data in code or error messages
+               - Effect Schema validation for all inputs
+               - SQL injection prevention
+
+            4. **Architecture & Patterns**
+               - Effect services implementation
+               - Cache-first strategy with SQLite
+               - Regional error boundaries
+               - Proper i18n with i18next
+
+            5. **Performance**
+               - Efficient caching strategies
+               - Minimized API calls
+               - Bundle size optimization
+
+            Provide detailed feedback using inline comments for specific issues.
+            Use top-level comments for general observations.
+            Reference file:line_number for all findings.
+
+          # Tools for comprehensive PR review with inline comments
+          claude_args: |
+            --allowedTools "mcp__github_inline_comment__create_inline_comment,Bash(gh pr comment:*),Bash(gh pr diff:*),Bash(gh pr view:*),Bash(gh pr list:*)"
 

package/.github/workflows/claude.yml

@@ -32,33 +32,19 @@ jobs:
 
       - name: Run Claude Code
         id: claude
-        uses: anthropics/claude-code-action@beta
+        uses: anthropics/claude-code-action@v1
         with:
           claude_code_oauth_token: ${{ secrets.CLAUDE_CODE_OAUTH_TOKEN }}
-
+          
           # This is an optional setting that allows Claude to read CI results on PRs
           additional_permissions: |
             actions: read
-          
-          # Optional: Specify model (defaults to Claude Sonnet 4, uncomment for Claude Opus 4)
-          # model: "claude-opus-4-20250514"
-          
-          # Optional: Customize the trigger phrase (default: @claude)
-          # trigger_phrase: "/claude"
-          
-          # Optional: Trigger when specific user is assigned to an issue
-          # assignee_trigger: "claude-bot"
-          
-          # Optional: Allow Claude to run specific commands
-          # allowed_tools: "Bash(npm install),Bash(npm run build),Bash(npm run test:*),Bash(npm run lint:*)"
-          
-          # Optional: Add custom instructions for Claude to customize its behavior for your project
-          # custom_instructions: |
-          #   Follow our coding standards
-          #   Ensure all new code has tests
-          #   Use TypeScript for new files
-          
-          # Optional: Custom environment variables for Claude
-          # claude_env: |
-          #   NODE_ENV: test
+
+          # Optional: Give a custom prompt to Claude. If this is not specified, Claude will perform the instructions specified in the comment that tagged it.
+          # prompt: 'Update the pull request description to include a summary of changes.'
+
+          # Optional: Add claude_args to customize behavior and configuration
+          # See https://github.com/anthropics/claude-code-action/blob/main/docs/usage.md
+          # or https://docs.anthropic.com/en/docs/claude-code/sdk#command-line for available options
+          # claude_args: '--model claude-opus-4-1-20250805 --allowed-tools Bash(gh pr:*)'
 

package/README.md

@@ -1,14 +1,12 @@
 # ger
 
-Gerrit CLI built with Bun. XML output by default for LLM/automation compatibility, human-readable output with `--pretty`.
+Gerrit CLI built with Bun.
 
 ## Features
 
 - **LLM-Friendly**: XML output for AI/automation pipelines
-- **Interactive UI**: Terminal UI for change selection and navigation  
-- **Secure**: Credentials stored in system keychain
+- **Interactive UI**: Terminal UI for change selection and navigation
 - **Effect-based**: Robust error handling and functional architecture
-- **Batch Comments**: JSON array input with line/range targeting and side support
 
 ## Installation
 
@@ -31,8 +29,6 @@ This will prompt for your Gerrit credentials:
 - Username
 - HTTP password (from Gerrit settings)
 
-Credentials are securely stored in your system keychain.
-
 ## Common Commands
 
 ### Daily Workflow
@@ -56,6 +52,9 @@ ger comment 12345 -m "LGTM"
 # Get diff for review
 ger diff 12345
 
+# Extract URLs from messages (e.g., Jenkins build links)
+ger extract-url "build-summary-report" | tail -1
+
 # AI-powered code review (requires claude, llm, or opencode CLI)
 ger review 12345
 ger review 12345 --dry-run  # Preview without posting
@@ -195,6 +194,54 @@ ger comments 12345
 ger comments 12345 --pretty
 ```
 
+### Extract URLs
+
+Extract URLs from change messages and comments for automation and scripting:
+
+```bash
+# Extract all Jenkins build-summary-report URLs
+ger extract-url "build-summary-report"
+
+# Get the latest build URL (using tail)
+ger extract-url "build-summary-report" | tail -1
+
+# Get the first/oldest build URL (using head)
+ger extract-url "jenkins" | head -1
+
+# For a specific change
+ger extract-url "build-summary" 12345
+
+# Use regex for precise matching
+ger extract-url "job/Canvas/job/main/\d+/" --regex
+
+# Search both messages and inline comments
+ger extract-url "github.com" --include-comments
+
+# JSON output for scripting
+ger extract-url "jenkins" --json | jq -r '.urls[-1]'
+
+# XML output
+ger extract-url "jenkins" --xml
+```
+
+#### How it works:
+- **Pattern matching**: Substring match by default, regex with `--regex`
+- **Sources**: Searches messages by default, add `--include-comments` to include inline comments
+- **Ordering**: URLs are output in chronological order (oldest first)
+- **Composable**: Pipe to `tail -1` for latest, `head -1` for oldest
+
+#### Common use cases:
+```bash
+# Get latest Jenkins build URL for a change
+ger extract-url "jenkins.inst-ci.net" | tail -1
+
+# Find all GitHub PR references
+ger extract-url "github.com" --include-comments
+
+# Extract specific build job URLs with regex
+ger extract-url "job/[^/]+/job/[^/]+/\d+/$" --regex
+```
+
 ### Diff
 ```bash
 # Full diff

package/bun.lock

@@ -4,25 +4,25 @@
     "": {
       "name": "ger",
       "dependencies": {
-        "@effect/platform": "^0.90.6",
+        "@effect/platform": "^0.90.10",
         "@effect/platform-node": "^0.94.2",
         "@effect/schema": "^0.75.5",
         "@inquirer/prompts": "^7.8.4",
         "chalk": "^5.6.0",
         "cli-table3": "^0.6.5",
         "commander": "^14.0.0",
-        "effect": "^3.17.9",
+        "effect": "^3.18.4",
         "signal-exit": "3.0.7",
       },
       "devDependencies": {
         "@biomejs/biome": "^2.2.2",
-        "@types/node": "^24.3.0",
+        "@types/node": "^24.3.1",
         "ast-grep": "^0.1.0",
         "bun-types": "^1.2.21",
         "husky": "^9.1.7",
-        "lint-staged": "^16.1.5",
-        "msw": "^2.10.5",
-        "oxlint": "^1.13.0",
+        "lint-staged": "^16.1.6",
+        "msw": "^2.11.1",
+        "oxlint": "^1.14.0",
         "typescript": "^5.9.2",
       },
       "peerDependencies": {
@@ -77,7 +77,7 @@
 
     "@effect/experimental": ["@effect/experimental@0.54.6", "", { "dependencies": { "uuid": "^11.0.3" }, "peerDependencies": { "@effect/platform": "^0.90.2", "effect": "^3.17.7", "ioredis": "^5", "lmdb": "^3" }, "optionalPeers": ["ioredis", "lmdb"] }, "sha512-UqHMvCQmrZT6kUVoUC0lqyno4Yad+j9hBGCdUjW84zkLwAq08tPqySiZUKRwY+Ae5B2Ab8rISYJH7nQvct9DMQ=="],
 
-    "@effect/platform": ["@effect/platform@0.90.6", "", { "dependencies": { "find-my-way-ts": "^0.1.6", "msgpackr": "^1.11.4", "multipasta": "^0.2.7" }, "peerDependencies": { "effect": "^3.17.8" } }, "sha512-aT7aLJR1+rYrSLdw5af2UZzwnWoAy8WmkTxTUD3pFY6vjFmh+8137RhbwKiWjIJBTm2DVyPXl1dx1kGg28xt6Q=="],
+    "@effect/platform": ["@effect/platform@0.90.10", "", { "dependencies": { "find-my-way-ts": "^0.1.6", "msgpackr": "^1.11.4", "multipasta": "^0.2.7" }, "peerDependencies": { "effect": "^3.17.13" } }, "sha512-QhDPgCaLfIMQKOCoCPQvRUS+Y34iYJ07jdZ/CBAvYFvg/iUBebsmFuHL63RCD/YZH9BuK/kqqLYAA3M0fmUEgg=="],
 
     "@effect/platform-node": ["@effect/platform-node@0.94.2", "", { "dependencies": { "@effect/platform-node-shared": "^0.47.2", "mime": "^3.0.0", "undici": "^7.10.0", "ws": "^8.18.2" }, "peerDependencies": { "@effect/cluster": "^0.46.4", "@effect/platform": "^0.90.0", "@effect/rpc": "^0.68.3", "@effect/sql": "^0.44.1", "effect": "^3.17.6" } }, "sha512-iI7vUjNqd1DOFCa/9Tyf6Cu00Y4oLKMrpa2lx8+bUIHxtYbk696Yd9VFIDLMXVWrKFUru4Fw7WgWaA/YDor/sw=="],
 
@@ -283,7 +283,7 @@
 
     "dunder-proto": ["dunder-proto@1.0.1", "", { "dependencies": { "call-bind-apply-helpers": "^1.0.1", "es-errors": "^1.3.0", "gopd": "^1.2.0" } }, "sha512-KIN/nDJBQRcXw0MLVhZE9iQHmG68qAVIBg9CqmUYjmQIhgij9U5MFvrqkUL5FbtyyzZuOeOt0zdeRe4UY7ct+A=="],
 
-    "effect": ["effect@3.17.13", "", { "dependencies": { "@standard-schema/spec": "^1.0.0", "fast-check": "^3.23.1" } }, "sha512-JMz5oBxs/6mu4FP9Csjub4jYMUwMLrp+IzUmSDVIzn2NoeoyOXMl7x1lghfr3dLKWffWrdnv/d8nFFdgrHXPqw=="],
+    "effect": ["effect@3.18.4", "", { "dependencies": { "@standard-schema/spec": "^1.0.0", "fast-check": "^3.23.1" } }, "sha512-b1LXQJLe9D11wfnOKAk3PKxuqYshQ0Heez+y5pnkd3jLj1yx9QhM72zZ9uUrOQyNvrs2GZZd/3maL0ZV18YuDA=="],
 
     "emoji-regex": ["emoji-regex@8.0.0", "", {}, "sha512-MSjYzcWNOA0ewAHpz0MxpYFvwg6yjy1NG3xteoqz644VCo/RPgnr1/GGt+ic3iJTzQ8Eu3TdM14SawnVUmGE6A=="],
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@aaronshaf/ger",
-  "version": "0.1.10",
+  "version": "0.2.0",
   "module": "index.ts",
   "type": "module",
   "bin": {
@@ -29,14 +29,14 @@
     "typescript": "^5.0.0"
   },
   "dependencies": {
-    "@effect/platform": "^0.90.6",
+    "@effect/platform": "^0.90.10",
     "@effect/platform-node": "^0.94.2",
     "@effect/schema": "^0.75.5",
     "@inquirer/prompts": "^7.8.4",
     "chalk": "^5.6.0",
     "cli-table3": "^0.6.5",
     "commander": "^14.0.0",
-    "effect": "^3.17.13",
+    "effect": "^3.18.4",
     "signal-exit": "3.0.7"
   },
   "scripts": {

package/src/api/gerrit.ts

@@ -13,6 +13,7 @@ import {
 } from '@/schemas/gerrit'
 import { filterMeaningfulMessages } from '@/utils/message-filters'
 import { ConfigService } from '@/services/config'
+import { normalizeChangeIdentifier } from '@/utils/change-id'
 
 export interface GerritApiServiceImpl {
   readonly getChange: (changeId: string) => Effect.Effect<ChangeInfo, ApiError>
@@ -51,15 +52,32 @@ export interface GerritApiServiceImpl {
   readonly getMessages: (changeId: string) => Effect.Effect<readonly MessageInfo[], ApiError>
 }
 
-export class GerritApiService extends Context.Tag('GerritApiService')<
-  GerritApiService,
-  GerritApiServiceImpl
->() {}
+// Export both the tag value and the type for use in Effect requirements
+export const GerritApiService: Context.Tag<GerritApiServiceImpl, GerritApiServiceImpl> =
+  Context.GenericTag<GerritApiServiceImpl>('GerritApiService')
+export type GerritApiService = Context.Tag.Identifier<typeof GerritApiService>
 
-export class ApiError extends Schema.TaggedError<ApiError>()('ApiError', {
+// Export ApiError fields interface explicitly
+export interface ApiErrorFields {
+  readonly message: string
+  readonly status?: number
+}
+
+// Define error schema (not exported, so type can be implicit)
+const ApiErrorSchema = Schema.TaggedError<ApiErrorFields>()('ApiError', {
   message: Schema.String,
   status: Schema.optional(Schema.Number),
-} as const) {}
+} as const) as unknown
+
+// Export the error class with explicit constructor signature for isolatedDeclarations
+export class ApiError
+  extends (ApiErrorSchema as new (
+    args: ApiErrorFields,
+  ) => ApiErrorFields & Error & { readonly _tag: 'ApiError' })
+  implements Error
+{
+  readonly name = 'ApiError'
+}
 
 const createAuthHeader = (credentials: GerritCredentials): string => {
   const auth = btoa(`${credentials.username}:${credentials.password}`)
@@ -150,10 +168,21 @@ export const GerritApiServiceLive: Layer.Layer<GerritApiService, never, ConfigSe
         return { credentials: normalizedCredentials, authHeader }
       })
 
+      // Helper to normalize and validate change identifier
+      const normalizeAndValidate = (changeId: string): Effect.Effect<string, ApiError> =>
+        Effect.try({
+          try: () => normalizeChangeIdentifier(changeId),
+          catch: (error) =>
+            new ApiError({
+              message: error instanceof Error ? error.message : String(error),
+            }),
+        })
+
       const getChange = (changeId: string) =>
         Effect.gen(function* () {
           const { credentials, authHeader } = yield* getCredentialsAndAuth
-          const url = `${credentials.host}/a/changes/${encodeURIComponent(changeId)}`
+          const normalized = yield* normalizeAndValidate(changeId)
+          const url = `${credentials.host}/a/changes/${encodeURIComponent(normalized)}`
           return yield* makeRequest(url, authHeader, 'GET', undefined, ChangeInfo)
         })
 
@@ -169,14 +198,16 @@ export const GerritApiServiceLive: Layer.Layer<GerritApiService, never, ConfigSe
       const postReview = (changeId: string, review: ReviewInput) =>
         Effect.gen(function* () {
           const { credentials, authHeader } = yield* getCredentialsAndAuth
-          const url = `${credentials.host}/a/changes/${encodeURIComponent(changeId)}/revisions/current/review`
+          const normalized = yield* normalizeAndValidate(changeId)
+          const url = `${credentials.host}/a/changes/${encodeURIComponent(normalized)}/revisions/current/review`
           yield* makeRequest(url, authHeader, 'POST', review)
         })
 
       const abandonChange = (changeId: string, message?: string) =>
         Effect.gen(function* () {
           const { credentials, authHeader } = yield* getCredentialsAndAuth
-          const url = `${credentials.host}/a/changes/${encodeURIComponent(changeId)}/abandon`
+          const normalized = yield* normalizeAndValidate(changeId)
+          const url = `${credentials.host}/a/changes/${encodeURIComponent(normalized)}/abandon`
           const body = message ? { message } : {}
           yield* makeRequest(url, authHeader, 'POST', body)
         })
@@ -199,14 +230,16 @@ export const GerritApiServiceLive: Layer.Layer<GerritApiService, never, ConfigSe
       const getRevision = (changeId: string, revisionId = 'current') =>
         Effect.gen(function* () {
           const { credentials, authHeader } = yield* getCredentialsAndAuth
-          const url = `${credentials.host}/a/changes/${encodeURIComponent(changeId)}/revisions/${revisionId}`
+          const normalized = yield* normalizeAndValidate(changeId)
+          const url = `${credentials.host}/a/changes/${encodeURIComponent(normalized)}/revisions/${revisionId}`
           return yield* makeRequest(url, authHeader, 'GET', undefined, RevisionInfo)
         })
 
       const getFiles = (changeId: string, revisionId = 'current') =>
         Effect.gen(function* () {
           const { credentials, authHeader } = yield* getCredentialsAndAuth
-          const url = `${credentials.host}/a/changes/${encodeURIComponent(changeId)}/revisions/${revisionId}/files`
+          const normalized = yield* normalizeAndValidate(changeId)
+          const url = `${credentials.host}/a/changes/${encodeURIComponent(normalized)}/revisions/${revisionId}/files`
           return yield* makeRequest(
             url,
             authHeader,
@@ -224,7 +257,8 @@ export const GerritApiServiceLive: Layer.Layer<GerritApiService, never, ConfigSe
       ) =>
         Effect.gen(function* () {
           const { credentials, authHeader } = yield* getCredentialsAndAuth
-          let url = `${credentials.host}/a/changes/${encodeURIComponent(changeId)}/revisions/${revisionId}/files/${encodeURIComponent(filePath)}/diff`
+          const normalized = yield* normalizeAndValidate(changeId)
+          let url = `${credentials.host}/a/changes/${encodeURIComponent(normalized)}/revisions/${revisionId}/files/${encodeURIComponent(filePath)}/diff`
           if (base) {
             url += `?base=${encodeURIComponent(base)}`
           }
@@ -234,7 +268,8 @@ export const GerritApiServiceLive: Layer.Layer<GerritApiService, never, ConfigSe
       const getFileContent = (changeId: string, filePath: string, revisionId = 'current') =>
         Effect.gen(function* () {
           const { credentials, authHeader } = yield* getCredentialsAndAuth
-          const url = `${credentials.host}/a/changes/${encodeURIComponent(changeId)}/revisions/${revisionId}/files/${encodeURIComponent(filePath)}/content`
+          const normalized = yield* normalizeAndValidate(changeId)
+          const url = `${credentials.host}/a/changes/${encodeURIComponent(normalized)}/revisions/${revisionId}/files/${encodeURIComponent(filePath)}/content`
 
           const response = yield* Effect.tryPromise({
             try: () =>
@@ -274,7 +309,8 @@ export const GerritApiServiceLive: Layer.Layer<GerritApiService, never, ConfigSe
       const getPatch = (changeId: string, revisionId = 'current') =>
         Effect.gen(function* () {
           const { credentials, authHeader } = yield* getCredentialsAndAuth
-          const url = `${credentials.host}/a/changes/${encodeURIComponent(changeId)}/revisions/${revisionId}/patch`
+          const normalized = yield* normalizeAndValidate(changeId)
+          const url = `${credentials.host}/a/changes/${encodeURIComponent(normalized)}/revisions/${revisionId}/patch`
 
           const response = yield* Effect.tryPromise({
             try: () =>
@@ -417,7 +453,8 @@ export const GerritApiServiceLive: Layer.Layer<GerritApiService, never, ConfigSe
       const getComments = (changeId: string, revisionId = 'current') =>
         Effect.gen(function* () {
           const { credentials, authHeader } = yield* getCredentialsAndAuth
-          const url = `${credentials.host}/a/changes/${encodeURIComponent(changeId)}/revisions/${revisionId}/comments`
+          const normalized = yield* normalizeAndValidate(changeId)
+          const url = `${credentials.host}/a/changes/${encodeURIComponent(normalized)}/revisions/${revisionId}/comments`
           return yield* makeRequest(
             url,
             authHeader,
@@ -430,7 +467,8 @@ export const GerritApiServiceLive: Layer.Layer<GerritApiService, never, ConfigSe
       const getMessages = (changeId: string) =>
         Effect.gen(function* () {
           const { credentials, authHeader } = yield* getCredentialsAndAuth
-          const url = `${credentials.host}/a/changes/${encodeURIComponent(changeId)}?o=MESSAGES`
+          const normalized = yield* normalizeAndValidate(changeId)
+          const url = `${credentials.host}/a/changes/${encodeURIComponent(normalized)}?o=MESSAGES`
           const response = yield* makeRequest(url, authHeader, 'GET')
 
           // Extract messages from the change response with runtime validation