@aaronshaf/confluence-cli 0.1.15

package/src/test/file-rename.test.ts

@@ -0,0 +1,305 @@
+import { afterEach, beforeEach, describe, expect, test } from 'bun:test';
+import { existsSync, mkdirSync, readFileSync, rmSync, writeFileSync } from 'node:fs';
+import { join } from 'node:path';
+import { handleFileRename } from '../cli/commands/file-rename.js';
+
+describe('handleFileRename', () => {
+  const testDir = join(import.meta.dir, '.test-file-rename');
+
+  beforeEach(() => {
+    // Clean up and create test directory
+    if (existsSync(testDir)) {
+      rmSync(testDir, { recursive: true });
+    }
+    mkdirSync(testDir, { recursive: true });
+  });
+
+  afterEach(() => {
+    // Clean up test directory
+    if (existsSync(testDir)) {
+      rmSync(testDir, { recursive: true });
+    }
+  });
+
+  test('does not rename README.md even with different title', () => {
+    const filePath = join(testDir, 'README.md');
+    const content = `---
+title: "Engineering Wiki"
+page_id: page-123
+---
+
+# Engineering Wiki
+
+Welcome to the wiki.
+`;
+    writeFileSync(filePath, content);
+
+    const result = handleFileRename(filePath, 'README.md', 'Engineering Wiki', content);
+
+    expect(result.wasRenamed).toBe(false);
+    expect(result.finalPath).toBe('README.md');
+    expect(existsSync(filePath)).toBe(true);
+    expect(readFileSync(filePath, 'utf-8')).toBe(content);
+  });
+
+  test('does not rename readme.md (lowercase) even with different title', () => {
+    const filePath = join(testDir, 'readme.md');
+    const content = `---
+title: "My Custom Title"
+page_id: page-456
+---
+
+# My Custom Title
+
+Content here.
+`;
+    writeFileSync(filePath, content);
+
+    const result = handleFileRename(filePath, 'readme.md', 'My Custom Title', content);
+
+    expect(result.wasRenamed).toBe(false);
+    expect(result.finalPath).toBe('readme.md');
+    expect(existsSync(filePath)).toBe(true);
+  });
+
+  test('does not rename index.md even with different title', () => {
+    const filePath = join(testDir, 'index.md');
+    const content = `---
+title: "Home Page"
+page_id: page-789
+---
+
+# Home Page
+
+Welcome.
+`;
+    writeFileSync(filePath, content);
+
+    const result = handleFileRename(filePath, 'index.md', 'Home Page', content);
+
+    expect(result.wasRenamed).toBe(false);
+    expect(result.finalPath).toBe('index.md');
+    expect(existsSync(filePath)).toBe(true);
+  });
+
+  test('renames regular file when title changes', () => {
+    const filePath = join(testDir, 'old-name.md');
+    const content = `---
+title: "New Name"
+page_id: page-101
+---
+
+# New Name
+
+Content.
+`;
+    writeFileSync(filePath, content);
+
+    const result = handleFileRename(filePath, 'old-name.md', 'New Name', content);
+
+    expect(result.wasRenamed).toBe(true);
+    expect(result.finalPath).toBe('new-name.md');
+    expect(existsSync(join(testDir, 'new-name.md'))).toBe(true);
+    expect(existsSync(filePath)).toBe(false);
+  });
+
+  test('does not rename if target file already exists', () => {
+    const filePath = join(testDir, 'old-name.md');
+    const existingPath = join(testDir, 'new-name.md');
+    const content = `---
+title: "New Name"
+---
+
+# New Name
+`;
+    writeFileSync(filePath, content);
+    writeFileSync(existingPath, 'existing content');
+
+    const result = handleFileRename(filePath, 'old-name.md', 'New Name', content);
+
+    expect(result.wasRenamed).toBe(false);
+    expect(result.finalPath).toBe('old-name.md');
+    expect(existsSync(filePath)).toBe(true);
+  });
+
+  test('preserves README.md in subdirectory', () => {
+    const subDir = join(testDir, 'docs');
+    mkdirSync(subDir);
+    const filePath = join(subDir, 'README.md');
+    const content = `---
+title: "Documentation Overview"
+page_id: page-docs
+---
+
+# Documentation Overview
+`;
+    writeFileSync(filePath, content);
+
+    const result = handleFileRename(filePath, 'docs/README.md', 'Documentation Overview', content);
+
+    expect(result.wasRenamed).toBe(false);
+    expect(result.finalPath).toBe('docs/README.md');
+    expect(existsSync(filePath)).toBe(true);
+  });
+
+  test('handles file in subdirectory with rename', () => {
+    const subDir = join(testDir, 'guides');
+    mkdirSync(subDir);
+    const filePath = join(subDir, 'old-guide.md');
+    const content = `---
+title: "New Guide Name"
+---
+
+# New Guide Name
+`;
+    writeFileSync(filePath, content);
+
+    const result = handleFileRename(filePath, 'guides/old-guide.md', 'New Guide Name', content);
+
+    expect(result.wasRenamed).toBe(true);
+    expect(result.finalPath).toBe('guides/new-guide-name.md');
+    expect(existsSync(join(subDir, 'new-guide-name.md'))).toBe(true);
+  });
+
+  test('updates references in other files when renamed with spaceRoot', () => {
+    // Create a file that links to another file
+    const linkingFile = join(testDir, 'index.md');
+    writeFileSync(
+      linkingFile,
+      `---
+title: Index
+---
+
+See [Old Guide](./old-guide.md) for details.
+`,
+    );
+
+    // Create the file that will be renamed
+    const filePath = join(testDir, 'old-guide.md');
+    const content = `---
+title: "New Guide Name"
+---
+
+# New Guide Name
+`;
+    writeFileSync(filePath, content);
+
+    // Rename with spaceRoot to trigger reference updates
+    const result = handleFileRename(filePath, 'old-guide.md', 'New Guide Name', content, testDir);
+
+    expect(result.wasRenamed).toBe(true);
+    expect(result.finalPath).toBe('new-guide-name.md');
+
+    // Verify the link in the other file was updated
+    const linkingContent = readFileSync(linkingFile, 'utf-8');
+    expect(linkingContent).toContain('./new-guide-name.md');
+    expect(linkingContent).not.toContain('./old-guide.md');
+  });
+
+  test('updates references without ./ prefix when renamed with spaceRoot', () => {
+    // Create a file that links without ./ prefix
+    const linkingFile = join(testDir, 'README.md');
+    writeFileSync(
+      linkingFile,
+      `---
+title: README
+---
+
+See [Guide](old-guide.md) for details.
+`,
+    );
+
+    // Create the file that will be renamed
+    const filePath = join(testDir, 'old-guide.md');
+    const content = `---
+title: "New Guide Name"
+---
+
+# New Guide Name
+`;
+    writeFileSync(filePath, content);
+
+    // Rename with spaceRoot to trigger reference updates
+    const result = handleFileRename(filePath, 'old-guide.md', 'New Guide Name', content, testDir);
+
+    expect(result.wasRenamed).toBe(true);
+
+    // Verify the link was updated (preserving no-prefix style)
+    const linkingContent = readFileSync(linkingFile, 'utf-8');
+    expect(linkingContent).toContain('new-guide-name.md');
+    expect(linkingContent).not.toContain('old-guide.md');
+  });
+
+  test('updates references in subdirectory files when renamed with spaceRoot', () => {
+    // Create subdirectory
+    const docsDir = join(testDir, 'docs');
+    mkdirSync(docsDir);
+
+    // Create a file in subdirectory that links to root file
+    const linkingFile = join(docsDir, 'guide.md');
+    writeFileSync(
+      linkingFile,
+      `---
+title: Guide
+---
+
+See [Overview](../overview.md) for details.
+`,
+    );
+
+    // Create the file that will be renamed (at root)
+    const filePath = join(testDir, 'overview.md');
+    const content = `---
+title: "Project Overview"
+---
+
+# Project Overview
+`;
+    writeFileSync(filePath, content);
+
+    // Rename with spaceRoot to trigger reference updates
+    const result = handleFileRename(filePath, 'overview.md', 'Project Overview', content, testDir);
+
+    expect(result.wasRenamed).toBe(true);
+    expect(result.finalPath).toBe('project-overview.md');
+
+    // Verify the relative link in subdirectory file was updated
+    const linkingContent = readFileSync(linkingFile, 'utf-8');
+    expect(linkingContent).toContain('../project-overview.md');
+    expect(linkingContent).not.toContain('../overview.md');
+  });
+
+  test('does not update references when no spaceRoot provided', () => {
+    // Create a file that links to another file
+    const linkingFile = join(testDir, 'index.md');
+    writeFileSync(
+      linkingFile,
+      `---
+title: Index
+---
+
+See [Old Guide](./old-guide.md) for details.
+`,
+    );
+
+    // Create the file that will be renamed
+    const filePath = join(testDir, 'old-guide.md');
+    const content = `---
+title: "New Guide Name"
+---
+
+# New Guide Name
+`;
+    writeFileSync(filePath, content);
+
+    // Rename WITHOUT spaceRoot - should not update references
+    const result = handleFileRename(filePath, 'old-guide.md', 'New Guide Name', content);
+
+    expect(result.wasRenamed).toBe(true);
+
+    // Verify the link in the other file was NOT updated (no spaceRoot)
+    const linkingContent = readFileSync(linkingFile, 'utf-8');
+    expect(linkingContent).toContain('./old-guide.md');
+    expect(linkingContent).not.toContain('./new-guide-name.md');
+  });
+});

package/src/test/file-scanner.test.ts

@@ -0,0 +1,331 @@
+import { afterEach, beforeEach, describe, expect, test } from 'bun:test';
+import { mkdirSync, mkdtempSync, rmSync, utimesSync, writeFileSync } from 'node:fs';
+import { tmpdir } from 'node:os';
+import { join } from 'node:path';
+import { detectPushCandidates, RESERVED_FILENAMES, scanMarkdownFiles } from '../lib/file-scanner.js';
+
+describe('file-scanner', () => {
+  let testDir: string;
+
+  beforeEach(() => {
+    testDir = mkdtempSync(join(tmpdir(), 'cn-test-'));
+  });
+
+  afterEach(() => {
+    rmSync(testDir, { recursive: true, force: true });
+  });
+
+  describe('scanMarkdownFiles', () => {
+    test('finds markdown files in directory', () => {
+      writeFileSync(join(testDir, 'page1.md'), '# Page 1');
+      writeFileSync(join(testDir, 'page2.md'), '# Page 2');
+      writeFileSync(join(testDir, 'readme.txt'), 'not markdown');
+
+      const files = scanMarkdownFiles(testDir);
+
+      expect(files).toEqual(['page1.md', 'page2.md']);
+    });
+
+    test('finds markdown files recursively', () => {
+      mkdirSync(join(testDir, 'subdir'));
+      writeFileSync(join(testDir, 'page1.md'), '# Page 1');
+      writeFileSync(join(testDir, 'subdir', 'page2.md'), '# Page 2');
+
+      const files = scanMarkdownFiles(testDir);
+
+      expect(files).toEqual(['page1.md', 'subdir/page2.md']);
+    });
+
+    test('excludes hidden files and directories', () => {
+      mkdirSync(join(testDir, '.git'));
+      writeFileSync(join(testDir, '.hidden.md'), 'hidden');
+      writeFileSync(join(testDir, '.git', 'config.md'), 'git');
+      writeFileSync(join(testDir, 'visible.md'), '# Visible');
+
+      const files = scanMarkdownFiles(testDir);
+
+      expect(files).toEqual(['visible.md']);
+    });
+
+    test('excludes common build directories', () => {
+      mkdirSync(join(testDir, 'node_modules'));
+      mkdirSync(join(testDir, 'dist'));
+      writeFileSync(join(testDir, 'node_modules', 'package.md'), 'dep');
+      writeFileSync(join(testDir, 'dist', 'output.md'), 'build');
+      writeFileSync(join(testDir, 'page.md'), '# Page');
+
+      const files = scanMarkdownFiles(testDir);
+
+      expect(files).toEqual(['page.md']);
+    });
+
+    test('returns empty array for directory with no markdown files', () => {
+      writeFileSync(join(testDir, 'readme.txt'), 'not markdown');
+
+      const files = scanMarkdownFiles(testDir);
+
+      expect(files).toEqual([]);
+    });
+
+    test('returns files sorted alphabetically', () => {
+      writeFileSync(join(testDir, 'zebra.md'), 'Z');
+      writeFileSync(join(testDir, 'alpha.md'), 'A');
+      writeFileSync(join(testDir, 'beta.md'), 'B');
+
+      const files = scanMarkdownFiles(testDir);
+
+      expect(files).toEqual(['alpha.md', 'beta.md', 'zebra.md']);
+    });
+
+    test('excludes reserved filenames (CLAUDE.md, AGENTS.md)', () => {
+      writeFileSync(join(testDir, 'CLAUDE.md'), '# Claude instructions');
+      writeFileSync(join(testDir, 'AGENTS.md'), '# Agent instructions');
+      writeFileSync(join(testDir, 'page.md'), '# Regular page');
+
+      const files = scanMarkdownFiles(testDir);
+
+      expect(files).toEqual(['page.md']);
+    });
+
+    test('excludes reserved filenames case-insensitively', () => {
+      // Use subdirectories to test different case variants
+      // (on case-insensitive filesystems like macOS, claude.md and Claude.md are the same file)
+      mkdirSync(join(testDir, 'lower'));
+      mkdirSync(join(testDir, 'upper'));
+      mkdirSync(join(testDir, 'mixed'));
+      writeFileSync(join(testDir, 'lower', 'claude.md'), '# Claude instructions');
+      writeFileSync(join(testDir, 'upper', 'CLAUDE.MD'), '# Claude instructions');
+      writeFileSync(join(testDir, 'mixed', 'Agents.md'), '# Agent instructions');
+      writeFileSync(join(testDir, 'page.md'), '# Regular page');
+
+      const files = scanMarkdownFiles(testDir);
+
+      // Only page.md should be included (case-insensitive matching for reserved names)
+      expect(files).toEqual(['page.md']);
+    });
+
+    test('excludes reserved filenames in subdirectories', () => {
+      mkdirSync(join(testDir, 'subdir'));
+      writeFileSync(join(testDir, 'subdir', 'CLAUDE.md'), '# Claude instructions');
+      writeFileSync(join(testDir, 'subdir', 'AGENTS.md'), '# Agent instructions');
+      writeFileSync(join(testDir, 'subdir', 'page.md'), '# Regular page');
+
+      const files = scanMarkdownFiles(testDir);
+
+      expect(files).toEqual(['subdir/page.md']);
+    });
+  });
+
+  describe('RESERVED_FILENAMES', () => {
+    test('includes claude.md and agents.md', () => {
+      expect(RESERVED_FILENAMES.has('claude.md')).toBe(true);
+      expect(RESERVED_FILENAMES.has('agents.md')).toBe(true);
+    });
+  });
+
+  describe('detectPushCandidates', () => {
+    test('detects new files without page_id', () => {
+      const content = `---
+title: New Page
+---
+
+Content here.`;
+      writeFileSync(join(testDir, 'new-page.md'), content);
+
+      const candidates = detectPushCandidates(testDir);
+
+      expect(candidates).toHaveLength(1);
+      expect(candidates[0]).toMatchObject({
+        path: 'new-page.md',
+        type: 'new',
+        title: 'New Page',
+      });
+      expect(candidates[0].pageId).toBeUndefined();
+    });
+
+    test('detects modified files with mtime after synced_at', () => {
+      const syncedAt = new Date('2026-01-15T12:00:00.000Z');
+      const content = `---
+page_id: '12345'
+title: Existing Page
+synced_at: '${syncedAt.toISOString()}'
+---
+
+Content here.`;
+      const filePath = join(testDir, 'modified.md');
+      writeFileSync(filePath, content);
+
+      // Set file mtime to 2 seconds after synced_at (beyond tolerance)
+      const modifiedTime = new Date(syncedAt.getTime() + 2000);
+      utimesSync(filePath, modifiedTime, modifiedTime);
+
+      const candidates = detectPushCandidates(testDir);
+
+      expect(candidates).toHaveLength(1);
+      expect(candidates[0]).toMatchObject({
+        path: 'modified.md',
+        type: 'modified',
+        title: 'Existing Page',
+        pageId: '12345',
+      });
+    });
+
+    test('ignores files with mtime within tolerance window', () => {
+      const syncedAt = new Date('2026-01-15T12:00:00.000Z');
+      const content = `---
+page_id: '12345'
+title: Just Synced Page
+synced_at: '${syncedAt.toISOString()}'
+---
+
+Content here.`;
+      const filePath = join(testDir, 'just-synced.md');
+      writeFileSync(filePath, content);
+
+      // Set file mtime to 500ms after synced_at (within 1 second tolerance)
+      const justAfterSync = new Date(syncedAt.getTime() + 500);
+      utimesSync(filePath, justAfterSync, justAfterSync);
+
+      const candidates = detectPushCandidates(testDir);
+
+      expect(candidates).toHaveLength(0);
+    });
+
+    test('detects files without synced_at as modified', () => {
+      const content = `---
+page_id: '12345'
+title: Legacy Page
+---
+
+Content here.`;
+      writeFileSync(join(testDir, 'legacy.md'), content);
+
+      const candidates = detectPushCandidates(testDir);
+
+      expect(candidates).toHaveLength(1);
+      expect(candidates[0]).toMatchObject({
+        path: 'legacy.md',
+        type: 'modified',
+        title: 'Legacy Page',
+        pageId: '12345',
+      });
+    });
+
+    test('uses filename as title when no title in frontmatter', () => {
+      const content = `---
+page_id: '12345'
+synced_at: '2026-01-15T12:00:00.000Z'
+---
+
+Content here.`;
+      const filePath = join(testDir, 'untitled-page.md');
+      writeFileSync(filePath, content);
+
+      // Modify to be detected
+      const modifiedTime = new Date('2026-01-15T12:00:02.000Z');
+      utimesSync(filePath, modifiedTime, modifiedTime);
+
+      const candidates = detectPushCandidates(testDir);
+
+      expect(candidates).toHaveLength(1);
+      expect(candidates[0].title).toBe('untitled-page');
+    });
+
+    test('returns multiple candidates sorted by path', () => {
+      // New file
+      writeFileSync(
+        join(testDir, 'new.md'),
+        `---
+title: New
+---
+Content`,
+      );
+
+      // Modified file
+      const syncedAt = new Date('2026-01-15T12:00:00.000Z');
+      const modifiedPath = join(testDir, 'modified.md');
+      writeFileSync(
+        modifiedPath,
+        `---
+page_id: '12345'
+title: Modified
+synced_at: '${syncedAt.toISOString()}'
+---
+Content`,
+      );
+      const modifiedTime = new Date(syncedAt.getTime() + 2000);
+      utimesSync(modifiedPath, modifiedTime, modifiedTime);
+
+      const candidates = detectPushCandidates(testDir);
+
+      expect(candidates).toHaveLength(2);
+      expect(candidates[0].path).toBe('modified.md');
+      expect(candidates[1].path).toBe('new.md');
+    });
+
+    test('ignores unmodified files', () => {
+      const syncedAt = new Date('2026-01-15T12:00:00.000Z');
+      const content = `---
+page_id: '12345'
+title: Unmodified Page
+synced_at: '${syncedAt.toISOString()}'
+---
+
+Content here.`;
+      const filePath = join(testDir, 'unmodified.md');
+      writeFileSync(filePath, content);
+
+      // Set file mtime to BEFORE synced_at
+      const olderTime = new Date(syncedAt.getTime() - 1000);
+      utimesSync(filePath, olderTime, olderTime);
+
+      const candidates = detectPushCandidates(testDir);
+
+      expect(candidates).toHaveLength(0);
+    });
+
+    test('handles files in subdirectories', () => {
+      mkdirSync(join(testDir, 'subfolder'));
+      const content = `---
+title: Nested Page
+---
+
+Content here.`;
+      writeFileSync(join(testDir, 'subfolder', 'nested.md'), content);
+
+      const candidates = detectPushCandidates(testDir);
+
+      expect(candidates).toHaveLength(1);
+      expect(candidates[0].path).toBe('subfolder/nested.md');
+    });
+
+    test('excludes reserved filenames from push candidates', () => {
+      writeFileSync(
+        join(testDir, 'CLAUDE.md'),
+        `---
+title: Claude
+---
+Instructions`,
+      );
+      writeFileSync(
+        join(testDir, 'AGENTS.md'),
+        `---
+title: Agents
+---
+Instructions`,
+      );
+      writeFileSync(
+        join(testDir, 'page.md'),
+        `---
+title: Regular Page
+---
+Content`,
+      );
+
+      const candidates = detectPushCandidates(testDir);
+
+      expect(candidates).toHaveLength(1);
+      expect(candidates[0].path).toBe('page.md');
+    });
+  });
+});