@aarongoldenthal/eslint-config-standard 22.0.0 → 23.0.0

package/index.js

@@ -4,7 +4,7 @@
 const complexityThreshold = 20;
 const maxFunctionLinesThreshold = 30;
 const maxLinesThreshold = 300;
-const maxParametersThreshold = 3;
+const maxParametersThreshold = 4;
 const maxStatementsPerLineThreshold = 1;
 const maxStatementsThreshold = 50;
 const nestedThreshold = 5;
@@ -227,7 +227,8 @@ module.exports = {
         'no-ternary': 'off',
         'no-throw-literal': 'error',
         'no-undef-init': 'error',
-        'no-undefined': 'error',
+        // Disabled, too many valid positives
+        'no-undefined': 'off',
         'no-underscore-dangle': 'error',
         'no-unneeded-ternary': 'error',
         'no-unused-expressions': [
@@ -245,7 +246,10 @@ module.exports = {
         'no-useless-return': 'error',
         'no-var': 'error',
         'no-void': 'error',
-        'no-warning-comments': 'error',
+        'no-warning-comments': [
+            'error',
+            { terms: ['TODO', 'FIXME', 'HACK', 'XXX', 'BUG'] }
+        ],
         'no-with': 'error', // Recommended
         'object-shorthand': 'error',
         'one-var': 'off',

package/jsdoc-config.js

@@ -35,12 +35,13 @@ module.exports = {
         'jsdoc/check-values': 'error', // Recommended
         'jsdoc/empty-tags': 'error', // Recommended
         'jsdoc/implements-on-classes': 'error', // Recommended
+        'jsdoc/imports-as-dependencies': 'error',
         'jsdoc/informative-docs': 'error',
         'jsdoc/match-description': 'error',
         'jsdoc/multiline-blocks': 'error', // Recommended
         'jsdoc/no-bad-blocks': 'error',
         'jsdoc/no-blank-blocks': 'error',
-        'jsdoc/no-defaults': 'off',
+        'jsdoc/no-defaults': ['error', { contexts: ['any'] }],
         'jsdoc/no-missing-syntax': 'off',
         'jsdoc/no-multi-asterisks': 'error', // Recommended
         'jsdoc/no-restricted-syntax': 'off',

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@aarongoldenthal/eslint-config-standard",
-  "version": "22.0.0",
+  "version": "23.0.0",
   "description": "Standard ESLint configuration settings",
   "main": "index.js",
   "scripts": {
@@ -9,8 +9,8 @@
     "lint": "npm run lint-js && npm run lint-md",
     "lint-js": "eslint .",
     "lint-md": "markdownlint-cli2 \"**/*.md\" \"#node_modules\"",
-    "prettier-check": "prettier --check --ignore-path=.gitignore .",
-    "prettier-fix": "prettier --write --ignore-path=.gitignore .",
+    "prettier-check": "prettier --check .",
+    "prettier-fix": "prettier --write .",
     "test": "jest --ci"
   },
   "repository": {
@@ -34,25 +34,23 @@
     "url": "https://gitlab.com/gitlab-ci-utils/eslint-config-standard/issues"
   },
   "homepage": "https://gitlab.com/gitlab-ci-utils/eslint-config-standard",
-  "dependencies": {
+  "devDependencies": {
+    "eslint": "8.45.0",
+    "jest": "29.6.1",
+    "jest-junit": "16.0.0",
+    "markdownlint-cli2": "0.8.1",
+    "prettier": "3.0.0"
+  },
+  "peerDependencies": {
     "@eslint-community/eslint-plugin-eslint-comments": "3.2.1",
+    "eslint": "^8.27.0",
     "eslint-config-prettier": "8.8.0",
-    "eslint-plugin-jest": "27.2.1",
-    "eslint-plugin-jsdoc": "44.2.3",
-    "eslint-plugin-n": "15.7.0",
-    "eslint-plugin-playwright": "0.12.0",
+    "eslint-plugin-jest": "27.2.3",
+    "eslint-plugin-jsdoc": "46.4.4",
+    "eslint-plugin-n": "16.0.1",
+    "eslint-plugin-playwright": "0.15.3",
     "eslint-plugin-promise": "6.1.1",
     "eslint-plugin-sonarjs": "0.19.0",
-    "eslint-plugin-unicorn": "47.0.0"
-  },
-  "devDependencies": {
-    "eslint": "^8.40.0",
-    "jest": "^29.5.0",
-    "jest-junit": "^16.0.0",
-    "markdownlint-cli2": "^0.7.1",
-    "prettier": "^2.8.8"
-  },
-  "peerDependencies": {
-    "eslint": "^8.27.0"
+    "eslint-plugin-unicorn": "48.0.0"
   }
 }

package/playwright-config.js

@@ -9,6 +9,7 @@ module.exports = {
             files: ['**/*.pwtest.[jt]s'],
             plugins: ['playwright'],
             rules: {
+                'playwright/expect-expect': 'error',
                 'playwright/max-nested-describe': 'error',
                 'playwright/missing-playwright-await': 'error',
                 'playwright/no-conditional-in-test': 'error',
@@ -16,14 +17,20 @@ module.exports = {
                 'playwright/no-eval': 'error',
                 'playwright/no-focused-test': 'error',
                 'playwright/no-force-option': 'error',
+                'playwright/no-nested-step': 'error',
+                'playwright/no-networkidle': 'error',
+                'playwright/no-nth-methods': 'error',
                 'playwright/no-page-pause': 'error',
                 'playwright/no-skipped-test': 'error',
+                'playwright/no-useless-await': 'error',
                 'playwright/no-useless-not': 'error',
                 'playwright/no-wait-for-timeout': 'error',
                 'playwright/prefer-lowercase-title': 'error',
                 'playwright/prefer-strict-equal': 'error',
                 'playwright/prefer-to-be': 'error',
+                'playwright/prefer-to-contain': 'error',
                 'playwright/prefer-to-have-length': 'error',
+                'playwright/prefer-web-first-assertions': 'error',
                 'playwright/require-soft-assertions': 'off',
                 'playwright/require-top-level-describe': 'error',
                 'playwright/valid-expect': 'error'

package/unicorn-config.js

@@ -56,7 +56,6 @@ module.exports = {
         'unicorn/no-unnecessary-await': 'error', // Recommended
         'unicorn/no-unreadable-array-destructuring': 'error', // Recommended
         'unicorn/no-unreadable-iife': 'error', // Recommended
-        'unicorn/no-unsafe-regex': 'error',
         'unicorn/no-unused-properties': 'error',
         'unicorn/no-useless-fallback-in-spread': 'error', // Recommended
         'unicorn/no-useless-length-check': 'error', // Recommended