@aaqu/fromcubes-portal-react 0.1.0-alpha.24 → 0.1.0-alpha.25

package/README.md

@@ -227,7 +227,8 @@ Import **Shared Components** first — it provides the UI building blocks (Page,
 | Red status "legacy endpoint" on deploy | Flow was saved before the `/fromcubes/` prefix became hardcoded. Open the node, set **Sub-path**, redeploy. Automatic migration is disabled to avoid silent URL changes. |
 | Red status "bad sub-path" | Sub-path is empty or violates the rules (no leading `/`, no whitespace, no `..`, segments must start alphanumerically, `public`/`_ws` reserved). |
 | Yellow status "css-fail" | Tailwind generation failed (usually an invalid class in JSX). Page still loads but unstyled. Fix the class, redeploy — the status clears on the next successful build. |
-| `npm install @aaqu/fromcubes-portal-react` ends with `EACCES` on `postinstall` | `scripts/sync-resources.js` copies Monaco into `resources/vs/` after install. The Node-RED `userDir/node_modules/...` install path must be writable by the user running Node-RED. Re-run `npm install` from a shell with the right ownership. |
+| Code editor stays blank / `portal-react/vs/loader.js` 404s | Monaco is served live from the package's own `node_modules` at `/portal-react/vs` (no postinstall copy step). The 404 means `RED.httpAdmin` is mounted under a non-root `httpAdminRoot` the editor didn't account for, or `monaco-editor` failed to install. Reinstall the package and hard-refresh the editor (`Cmd/Ctrl-Shift-R`). |
+| `npm install @aaqu/fromcubes-portal-react` ends with `EACCES` | The Node-RED `userDir/node_modules` install path is not writable by the user running Node-RED. Re-run `npm install` from a shell with the right ownership. |
 | Browser request `/portal-react/css/<hash>.css` returns 404 | The portal's deploy hasn't produced a CSS bundle yet — open the editor, redeploy. If the URL is bookmarked from before a deploy, the hash is stale; reload the portal page itself. |
 | WebSocket reconnects in an endless loop | Reverse-proxy is not forwarding `Upgrade: websocket` on `/fromcubes/<sub-path>/_ws`. Check the proxy config — nginx needs `proxy_set_header Upgrade $http_upgrade`, Traefik needs the `websocket` middleware. |
 | `libs` packages fail to install on deploy | The user-installed npm packages declared in **Libs** install via Node-RED's `dynamicModuleList` mechanism, which needs network access from `userDir` and a writable `node_modules`. Behind a corporate proxy set `npm config set proxy …` for the Node-RED user. |

package/nodes/lib/helpers.js

@@ -387,6 +387,20 @@ function serveableHash(state) {
   return state.compiled.js ? state.contentHash || "" : "";
 }
 
+/**
+ * True only when `state` holds a real, serveable build. Used by the no-op
+ * redeploy guard to decide whether a rebuild can be skipped. MUST be false
+ * after close() nulls `compiled` (`{ ...compiled: null }` teardown window),
+ * otherwise the guard treats the destroyed build as valid, skips the rebuild,
+ * and the GET route serves the holding page forever (permanent spinner).
+ *
+ * @param {?PageState} state  pageState[endpoint] (may be null/torn down).
+ * @returns {boolean}
+ */
+function hasFreshBuild(state) {
+  return !!state && !state.building && !!state.compiled && !state.compiled.error;
+}
+
 module.exports = function (RED) {
   return createHelpers(RED);
 };
@@ -398,6 +412,7 @@ module.exports.formatEsbuildError = formatEsbuildError;
 module.exports.extractPortalUser = extractPortalUser;
 module.exports.findMissingComponentRefs = findMissingComponentRefs;
 module.exports.serveableHash = serveableHash;
+module.exports.hasFreshBuild = hasFreshBuild;
 module.exports.NAME_MAX_LEN = NAME_MAX_LEN;
 module.exports.MAX_GROUPS_HEADER_BYTES = MAX_GROUPS_HEADER_BYTES;
 
@@ -619,6 +634,7 @@ function createHelpers(RED) {
     generateCSS,
     extractPortalUser,
     serveableHash,
+    hasFreshBuild,
     removeRoute,
     isSafeName,
     validateSubPath,

package/nodes/portal-react.js

@@ -545,6 +545,7 @@ module.exports = function (RED) {
     generateCSS,
     extractPortalUser,
     serveableHash,
+    hasFreshBuild,
     removeRoute,
     isSafeName,
     validateSubPath,
@@ -1549,8 +1550,11 @@ module.exports = function (RED) {
     );
     const prevSig = portalSig[nodeId];
     const existing = pageState[endpoint];
-    const hasValidBuild =
-      !!existing && !existing.building && !existing.compiled?.error;
+    // hasFreshBuild also requires `compiled` to be present — close() nulls it on
+    // redeploy, and a guard that ignored that (checking only building/error)
+    // would treat the destroyed build as valid and skip the rebuild, leaving the
+    // GET route serving the holding page forever. See helpers.hasFreshBuild.
+    const hasValidBuild = hasFreshBuild(existing);
     portalSig[nodeId] = sig;
 
     if (prevSig !== sig || !hasValidBuild) {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@aaqu/fromcubes-portal-react",
-  "version": "0.1.0-alpha.24",
+  "version": "0.1.0-alpha.25",
   "description": "Fromcubes Portal - React for Node-RED with Tailwind CSS and auto complete",
   "type": "commonjs",
   "keywords": [