@a9n-shoji/rvw 0.8.0 → 0.8.1

package/CHANGELOG.md

@@ -5,6 +5,16 @@
 
 ## [Unreleased]
 
+## [0.8.1] - 2026-09-14
+
+### Changed
+
+- コメント対象とコメント内のcode参照を、現在選択中のcommitへ安全に配置できる場合はその比較documentで直接開き、変更・削除・曖昧な場合は投稿時点のsourceへfallbackするようにした
+
+### Fixed
+
+- 承認後にコメントのみのreviewが追加されたPull Requestで、GitHub上の現在の承認数が0件として表示される問題を修正
+
 ## [0.8.0] - 2026-09-13
 
 ### Added

package/README.md

@@ -112,7 +112,7 @@ viewerはこの流れのために次を提供します。
 - ファイル名fuzzy検索、Gitによるrealtime全文fixed-string検索（case / whole-word、file grouping、行jump）
 - PR全体、PR本文、ファイル全体、行範囲、Walkthrough全体へのコメント
 - コメントと返信のsafe GFM表示（repository内link／同一commit相対画像、表示専用Mermaid、
-  exact commitへ固定したinline code referenceを含む）
+  global対象commitへ安全に配置し、できなければexact commitへfallbackするinline code referenceを含む）
 - 未解決／解決済み、返信、Outdated追跡
 - Agentへ渡す一件・一覧・複数選択した`rvw://comment/<uuid>`参照のコピー
 - Agentが提示したWalkthrough、exact code reference、選択可能なMermaid node
@@ -291,7 +291,8 @@ rvw Skillを使って、https://github.com/owner/repository/pull/123 の未解
 Agentにreview結果をRVWへ残してもらう場合は、対象PRとコメント作成を明示します。Agentはcommit済みの
 exact sourceを確認し、通常の未解決threadを一件ずつ作成します。指摘や回答の理解に別の実装箇所が
 必要なら、投稿本文の`rvw-ref:<id>` linkと同じ投稿に保存したtyped referenceから、その時点のcommitを
-globalなcommit選択を変えずに開けます。
+globalなcommit選択を変えずに開けます。global対象commitへ安全に配置できるreferenceは現在の比較で直接開き、
+内容変更や削除などで配置できない場合は投稿時点のexact sourceへfallbackします。
 
 ```text
 rvw Skillを使って、https://github.com/owner/repository/pull/123 をreviewし、見つけた指摘をRVWのコメントとして作成してください。

package/dist/cli.mjs

@@ -18762,7 +18762,7 @@ function parseWalkthroughUri(uri) {
 }
 
 // src/shared/constants.ts
-var APP_VERSION = "0.8.0";
+var APP_VERSION = "0.8.1";
 var PROTOCOL_VERSION = 5;
 var VIEWER_ID_HEADER = "x-rvw-viewer-id";
 var VIEWER_OPEN_LEASE_HEADER = "x-rvw-viewer-open-lease";
@@ -21493,6 +21493,7 @@ function imageContentTypeHeader(contentType2) {
 
 // src/infrastructure/github/github-client.ts
 var ghPullRequestSchema = external_exports.object({
+  id: external_exports.string().min(1),
   author: external_exports.object({ login: external_exports.string().min(1) }).nullable(),
   headRepository: external_exports.object({ name: external_exports.string().min(1) }).nullable(),
   headRepositoryOwner: external_exports.object({ login: external_exports.string().min(1) }).nullable(),
@@ -21507,17 +21508,36 @@ var ghPullRequestSchema = external_exports.object({
   baseRefOid: external_exports.string().regex(GIT_OBJECT_ID_PATTERN),
   headRefName: external_exports.string().min(1),
   headRefOid: external_exports.string().regex(GIT_OBJECT_ID_PATTERN),
-  createdAt: external_exports.string(),
-  latestReviews: external_exports.array(external_exports.object({ state: external_exports.string() }))
+  createdAt: external_exports.string()
 });
 var ghPullRequestStatusSchema = external_exports.object({
+  id: external_exports.string().min(1),
   state: external_exports.enum(["OPEN", "CLOSED", "MERGED"]),
-  isDraft: external_exports.boolean(),
-  latestReviews: external_exports.array(external_exports.object({ state: external_exports.string() }))
+  isDraft: external_exports.boolean()
 });
-function approvalCount(latestReviews) {
-  return latestReviews.filter((review) => review.state === "APPROVED").length;
-}
+var ghOpinionatedReviewsSchema = external_exports.object({
+  data: external_exports.object({
+    node: external_exports.object({
+      latestOpinionatedReviews: external_exports.object({
+        nodes: external_exports.array(external_exports.object({ state: external_exports.string() })),
+        pageInfo: external_exports.object({
+          hasNextPage: external_exports.boolean(),
+          endCursor: external_exports.string().nullable()
+        })
+      })
+    }).nullable()
+  })
+});
+var opinionatedReviewsQuery = `query PullRequestOpinionatedReviews($id: ID!, $after: String) {
+  node(id: $id) {
+    ... on PullRequest {
+      latestOpinionatedReviews(first: 100, after: $after) {
+        nodes { state }
+        pageInfo { hasNextPage endCursor }
+      }
+    }
+  }
+}`;
 function parsePullRequestUrl(url2) {
   const match2 = /^https:\/\/github\.com\/([^/]+)\/([^/]+)\/pull\/(\d+)(?:\/.*)?$/.exec(url2);
   if (!match2?.[1] || !match2[2] || !match2[3]) {
@@ -21547,12 +21567,80 @@ var GitHubClient = class {
       });
     }
   }
+  async getApprovalCount(pullRequestId) {
+    let approvalCount = 0;
+    let after = null;
+    const seenCursors = /* @__PURE__ */ new Set();
+    let hasNextPage = true;
+    while (hasNextPage) {
+      const args = [
+        "api",
+        "graphql",
+        "--hostname",
+        "github.com",
+        "-f",
+        `query=${opinionatedReviewsQuery}`,
+        "-f",
+        `id=${pullRequestId}`
+      ];
+      if (after !== null) args.push("-f", `after=${after}`);
+      let output;
+      try {
+        const result = await this.processRunner("gh", args, { timeoutMs: 6e4 });
+        output = result.stdout.toString("utf8").trimEnd();
+      } catch (error51) {
+        if (error51 instanceof RvwError && error51.code === "PROCESS_FAILED") {
+          throw new RvwError(
+            "GITHUB_ERROR",
+            "Pull Request\u306EApprove\u6570\u3092GitHub\u304B\u3089\u53D6\u5F97\u3067\u304D\u307E\u305B\u3093\u3067\u3057\u305F\u3002",
+            {
+              cause: error51,
+              details: error51.details,
+              suggestions: ["PR\u306E\u95B2\u89A7\u6A29\u9650\u3068gh\u8A8D\u8A3C\u3092\u78BA\u8A8D\u3057\u3066\u304F\u3060\u3055\u3044\u3002"]
+            }
+          );
+        }
+        throw error51;
+      }
+      let decoded;
+      try {
+        decoded = JSON.parse(output);
+      } catch (error51) {
+        throw new RvwError("GITHUB_ERROR", "GitHub CLI\u306EPull Request review\u5FDC\u7B54\u304C\u4E0D\u6B63\u3067\u3059\u3002", {
+          cause: error51
+        });
+      }
+      const parsed = ghOpinionatedReviewsSchema.safeParse(decoded);
+      if (!parsed.success || parsed.data.data.node === null) {
+        throw new RvwError("GITHUB_ERROR", "GitHub CLI\u306EPull Request review\u5FDC\u7B54\u304C\u4E0D\u6B63\u3067\u3059\u3002", {
+          details: parsed.success ? { pullRequestId } : parsed.error.flatten()
+        });
+      }
+      const reviews = parsed.data.data.node.latestOpinionatedReviews;
+      approvalCount += reviews.nodes.filter((review) => review.state === "APPROVED").length;
+      hasNextPage = reviews.pageInfo.hasNextPage;
+      if (!hasNextPage) break;
+      const nextCursor = reviews.pageInfo.endCursor;
+      if (nextCursor === null || seenCursors.has(nextCursor)) {
+        throw new RvwError(
+          "GITHUB_ERROR",
+          "GitHub CLI\u306EPull Request review pagination\u5FDC\u7B54\u304C\u4E0D\u6B63\u3067\u3059\u3002",
+          {
+            details: { pullRequestId }
+          }
+        );
+      }
+      seenCursors.add(nextCursor);
+      after = nextCursor;
+    }
+    return approvalCount;
+  }
   async getPullRequestStatus(reference) {
     let output;
     try {
       const result = await this.processRunner(
         "gh",
-        ["pr", "view", reference, "--json", "state,isDraft,latestReviews"],
+        ["pr", "view", reference, "--json", "id,state,isDraft"],
         { timeoutMs: 6e4 }
       );
       output = result.stdout.toString("utf8").trimEnd();
@@ -21583,7 +21671,7 @@ var GitHubClient = class {
     return {
       state: parsed.data.state,
       isDraft: parsed.data.isDraft,
-      approvalCount: approvalCount(parsed.data.latestReviews)
+      approvalCount: await this.getApprovalCount(parsed.data.id)
     };
   }
   async getPullRequestStatuses(references) {
@@ -21625,6 +21713,7 @@ var GitHubClient = class {
   async getPullRequest(reference, cwd, options = {}) {
     await this.assertAuthenticated();
     const fields = [
+      "id",
       "author",
       "number",
       "url",
@@ -21639,15 +21728,15 @@ var GitHubClient = class {
       "headRefName",
       "headRefOid",
       "headRepository",
-      "headRepositoryOwner",
-      "latestReviews"
+      "headRepositoryOwner"
     ].join(",");
     const args = ["pr", "view"];
     if (reference !== void 0 && reference.length > 0) args.push(reference);
     args.push("--json", fields);
     let output;
     try {
-      output = await runText("gh", args, { cwd, timeoutMs: 6e4 });
+      const result = await this.processRunner("gh", args, { cwd, timeoutMs: 6e4 });
+      output = result.stdout.toString("utf8").trimEnd();
     } catch (error51) {
       if (error51 instanceof RvwError && error51.code === "PROCESS_FAILED") {
         throw new RvwError("GITHUB_ERROR", "Pull Request\u60C5\u5831\u3092GitHub\u304B\u3089\u53D6\u5F97\u3067\u304D\u307E\u305B\u3093\u3067\u3057\u305F\u3002", {
@@ -21690,7 +21779,7 @@ var GitHubClient = class {
       updatedAt: parsed.data.updatedAt,
       state: parsed.data.state,
       isDraft: parsed.data.isDraft,
-      approvalCount: approvalCount(parsed.data.latestReviews)
+      approvalCount: await this.getApprovalCount(parsed.data.id)
     };
   }
   async getAttachment(absoluteUrl) {
@@ -44315,6 +44404,23 @@ var RvwService = class {
       this.createCommentPlacementRequestContext()
     );
   }
+  async placeCodeReferenceAtCommit(pullRequestId, sourceOid, reference, destinationOid) {
+    assertCodeReferencePath(reference.path);
+    return await this.placeCommentAtCommit(
+      {
+        pullRequestId,
+        target: {
+          kind: "document",
+          documentKind: "repository-file",
+          sourceOid,
+          path: reference.path,
+          startLine: reference.startLine,
+          endLine: reference.endLine
+        }
+      },
+      destinationOid
+    );
+  }
   async resolveCommentPlacements(pullRequestId, commentIds, destinations, expectedPullRequestContentFingerprint) {
     const pullRequest = this.getPullRequest(pullRequestId);
     const contentFingerprint = this.assertPullRequestContentFingerprint(
@@ -49477,6 +49583,11 @@ var resolveCommentPlacementsSchema = external_exports.object({
     ])
   ).min(1).max(4)
 });
+var resolveCodeReferencePlacementSchema = external_exports.object({
+  sourceOid: external_exports.string().regex(GIT_OBJECT_ID_PATTERN),
+  destinationOid: external_exports.string().regex(GIT_OBJECT_ID_PATTERN),
+  reference: codeReferenceInputSchema
+});
 
 // src/server/app.ts
 var oidSchema = external_exports.string().regex(GIT_OBJECT_ID_PATTERN);
@@ -49954,6 +50065,18 @@ function createApp(service, options) {
       )
     });
   });
+  app.post("/api/pull-requests/:pullRequestId/code-reference-placement", async (context) => {
+    const input = resolveCodeReferencePlacementSchema.parse(await context.req.json());
+    return context.json({
+      ok: true,
+      placement: await service.placeCodeReferenceAtCommit(
+        context.req.param("pullRequestId"),
+        input.sourceOid,
+        input.reference,
+        input.destinationOid
+      )
+    });
+  });
   app.get("/api/comments/:id/placement", async (context) => {
     const comment3 = service.database.getComment(context.req.param("id"));
     if (!comment3)