@a-t-h-i/bot-lobby 0.6.10 → 0.6.12

package/README.md

@@ -325,6 +325,14 @@ knowledge, standards, decisions and completed tasks — files on the left, the
 open file's entries on the right (a heading, a bullet, a paragraph), one of
 them picked. Files past the compaction threshold are marked.
 
+Completion is gated on compaction: the engine refuses `complete` while any
+knowledge file is over the threshold (default 20,000 chars,
+`knowledge.compactionThreshold`). The Master first disperses domain-relevant
+facts where they belong with `action=knowledge (domain=designer|backend|qa)`
+— per-agent files fill up through that dispersal — then rewrites each
+oversized file with `action=compact` (which archives the previous version)
+before the task closes.
+
 - `e` edits the picked entry: it comes into the prompt (Shift+Enter for a new
   line, Enter saves). `n` adds an entry after it, `d d` deletes it, `E` edits
   the whole file in pi's editor. Every write archives the version before
@@ -361,6 +369,12 @@ planner), and those agents can look at what you drew and add to it.
   sessions are all look-only gets no drawing tool.
 - `t` **checks** the session: joins the room for a moment and says whether the
   server can be reached, who is in it, and how much is on the board. `r` renames it.
+- `orchestrate action=whiteboard [name=...]` lets the Master create its own
+  session: a room on the configured collaboration server, assigned to itself,
+  with the join link returned. Its seat (opened by `excalidraw_read` /
+  `excalidraw_draw`) holds the room alive for the pi session's lifetime, so it
+  needs no one else in the room. The room is not guaranteed to persist after
+  the last connection leaves.
 
 **What an assigned agent can do.** It gets two tools and the room link:
 `excalidraw_read` describes the board in words (shapes with their labels, arrows
@@ -647,6 +661,7 @@ unavailable, it runs again on the fallback instead of failing the task.
 | Scouts and the QA gate can't edit code | Scouts get read-only tools; the QA gate adds only `bash` for tests |
 | New dependencies and architecture changes need approval | Parsed from worker reports; the domain is blocked until resolved |
 | Only the Master writes knowledge | Agents can only propose it |
+| Knowledge is compacted before done | `complete` is refused while any knowledge file is over the threshold; disperse with `action=knowledge (domain=designer\|backend\|qa)`, then `action=compact` |
 | "Done" is earned | Needs a plan, a passing QA gate that ran checks (or your explicit acceptance), and no open blockers; on the fast track, a finished worker step, and QA's part only when the change needs tests |
 | Parallel workers don't clobber files | Edits need a file-desk claim |
 | A crash doesn't corrupt a task | State is on disk; tasks resume from their state |

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@a-t-h-i/bot-lobby",
-  "version": "0.6.10",
+  "version": "0.6.12",
   "description": "Structured multi-agent software engineering orchestrator for Pi",
   "type": "module",
   "license": "Apache-2.0",

package/src/excalidraw/client.ts

@@ -13,7 +13,7 @@
  */
 import { HttpsProxyAgent } from "https-proxy-agent";
 import { io, type Socket } from "socket.io-client";
-import { DEFAULT_SERVER, seal, unseal, type RoomLink } from "./room.ts";
+import { DEFAULT_ORIGIN, DEFAULT_SERVER, seal, unseal, type RoomLink } from "./room.ts";
 import { describeScene, mergeElements, plainText, planDraw, sceneBounds, visible, type DrawOutcome, type DrawRequest, type Scene, type SceneElement } from "./scene.ts";
 
 /** The part of a socket.io client a seat uses; tests and other transports can stand in for it. */
@@ -56,7 +56,16 @@ function defaultConnect(server: string): SocketLike {
   // Where a network lets plain HTTPS through but not a websocket, the seat falls back to long-polling, as a browser does.
   // socket.io types `agent` for browsers (string | boolean); in Node it is passed on to the http and ws requests as an http.Agent.
   const agent = proxy ? { agent: new HttpsProxyAgent(proxy) as unknown as string } : {};
-  return io(server, { transports: ["websocket", "polling"], tryAllTransports: true, autoUnref: true, timeout: 8000, ...agent });
+  // Excalidraw's collaboration server refuses handshakes whose Origin is not on its allowlist, so a seat presents the site a browser would come from.
+  let site = DEFAULT_ORIGIN;
+  if (server !== DEFAULT_SERVER) {
+    try {
+      site = new URL(server).origin;
+    } catch {
+      /* fall back to DEFAULT_ORIGIN */
+    }
+  }
+  return io(server, { transports: ["websocket", "polling"], tryAllTransports: true, autoUnref: true, timeout: 8000, extraHeaders: { Origin: site }, ...agent });
 }
 
 /**

package/src/pi/tools.ts

@@ -58,6 +58,7 @@ const OrchestrateSchema = Type.Object({
   roster: Type.Optional(Type.Array(Type.String(), { description: "track: who takes part — any of designer, backend, qa, researcher" })),
   text: Type.Optional(Type.String({ description: "decide/complete/knowledge: the decision, completion summary, or knowledge text" })),
   file: Type.Optional(Type.String({ description: "compact: the knowledge file to rewrite, e.g. knowledge.md" })),
+  name: Type.Optional(Type.String({ description: "whiteboard: name for the new Excalidraw session" })),
   kind: Type.Optional(
     StringEnum(["knowledge", "standard", "decision", "completed"] as const, {
       description: "knowledge: which persistent file the text belongs to",
@@ -72,7 +73,7 @@ const DESCRIPTION = [
   "dependency), propose (record the proposal and request approval), plan (record the internal",
   "plan, or amend it later with the full revised plan), implement (delegate a step to a domain worker, or several domains in parallel with assignments), qa (final quality gate and the only",
   "review), knowledge (record approved knowledge or a decision),",
-  "compact (replace a knowledge file with a rewritten version, archiving the old one),",
+  "compact (replace a knowledge file with a rewritten version, archiving the old one, dispersing domain-relevant facts to action=knowledge (domain=designer|backend|qa) first), whiteboard (create your own Excalidraw session and assign it to yourself),",
   "resolve_approval (approve or reject a request), complete (declare the task done after the gates",
   "pass), block/resume (escalate or continue), budget (under a time budget: where it stands, or ask the",
   "user for more minutes with a reason), track (the task's path and who takes part: show it, or correct it with",

package/src/roles/reviewer.ts

@@ -30,6 +30,14 @@ function parseVerdict(text: string | undefined): Verdict {
   return "blocked";
 }
 
+/** The verdict token may sit in the heading itself (`## Verdict PASS`), leaving an empty body. */
+function verdictHeading(sections: Map<string, string>): string | undefined {
+  for (const heading of sections.keys()) {
+    if (heading.includes("verdict")) return heading;
+  }
+  return undefined;
+}
+
 /** The severity a finding was tagged with, or undefined when it carries none. */
 function taggedSeverity(text: string): Severity | undefined {
   const match = /^\[([^\]]+)\]/.exec(text);
@@ -58,7 +66,7 @@ export function parseReviewResult(domain: Domain, raw: string): ReviewResult {
   const verification = findSection(sections, "verification") ?? "";
   const requiredChanges = bullets(findSection(sections, "required changes"));
   const entries = bullets(findSection(sections, "findings"));
-  let verdict = parseVerdict(findSection(sections, "verdict"));
+  let verdict = parseVerdict(`${verdictHeading(sections) ?? ""}\n${findSection(sections, "verdict") ?? ""}`);
   let downgraded: string | undefined;
   let relaxed: string | undefined;
   const checked = executedChecks(verification).length > 0;

package/src/workflow/workflow.ts

@@ -20,6 +20,7 @@ import { ownerlessTask, readTaskArtifact, removeTaskScratchpads, saveTask, selec
 import { dataRoot, readDataRoots } from "../state/project.ts";
 import { appendCompletedTask, appendDecision, applyKnowledge, readFileOr, writeFileEnsured, type KnowledgeKind } from "../knowledge/store.ts";
 import { compactKnowledgeFile, overThreshold } from "../knowledge/compactor.ts";
+import { ExcalidrawBook } from "../excalidraw/sessions.ts";
 import { knowledgeDir, type KnowledgeAgent } from "../knowledge/paths.ts";
 import { writeScratchpad } from "../state/persistence.ts";
 import { spawnPiProcess, type ProcessRunner, type RelayAsk } from "../execution/pi-runner.ts";
@@ -75,6 +76,7 @@ export const ORCHESTRATE_ACTIONS = [
   "qa",
   "knowledge",
   "compact",
+  "whiteboard",
   "complete",
   "block",
   "resume",
@@ -112,6 +114,8 @@ export interface OrchestrateParams {
   kind?: KnowledgeKind;
   /** compact: the knowledge file being rewritten. */
   file?: string;
+  /** whiteboard: name for the new Excalidraw session. */
+  name?: string;
   approvalId?: string;
   decision?: "approved" | "rejected";
   note?: string;
@@ -1270,6 +1274,19 @@ function handleCompact(task: Task, params: OrchestrateParams, deps: WorkflowDeps
   return `Compacted ${agent}/${file}: ${outcome.before} -> ${outcome.after} chars. Previous version archived at ${outcome.archive}.`;
 }
 
+/**
+ * The Master creates its own whiteboard: a room on the configured server,
+ * assigned to itself so its seat keeps the room alive for this pi session.
+ */
+function handleWhiteboard(task: Task, params: OrchestrateParams, deps: WorkflowDeps): string {
+  const book = new ExcalidrawBook({ root: deps.root });
+  const made = book.create(params.name?.trim() || undefined);
+  if (!made.session) throw new Error(made.notice);
+  book.toggleAgent(made.session.id, "master");
+  recordDecision(task, `Created Excalidraw session "${made.session.name}" and assigned it to Master.`);
+  return `Created Excalidraw session "${made.session.name}" and assigned it to you. Join link: ${made.session.link}. Call excalidraw_read to open your seat; the connection stays open for this pi session and keeps the room alive without anyone else in it. It ends when the pi session ends.`;
+}
+
 /** §63: record history, drop scratchpads, then mark the task completed. */
 async function handleComplete(task: Task, params: OrchestrateParams, deps: WorkflowDeps): Promise<string> {
   // The fast track completes straight from its work; the full workflow from review.
@@ -1279,6 +1296,9 @@ async function handleComplete(task: Task, params: OrchestrateParams, deps: Workf
   if (task.state === "blocked") throw new Error("cannot complete: the task is blocked, and the user did not accept its work as it is");
   const blockers = completionBlockers(task, pendingApprovals(task).length);
   if (blockers.length > 0) throw new Error(`cannot complete: ${blockers.join("; ")}`);
+  // The gate refuses before any side effect, so a refusal leaves the task untouched.
+  const oversized = overThreshold(readDataRoots(deps.root, deps.configDir), deps.config.knowledge.compactionThreshold);
+  if (oversized.length > 0) throw new Error(`cannot complete: knowledge files over the compaction threshold: ${oversized.map((entry) => `${entry.agent}/${entry.file} (${entry.chars})`).join(", ")}. First record domain-relevant facts where they belong with action=knowledge (domain=designer|backend|qa), then rewrite each oversized file with action=compact, then call complete again.`);
   const summary = params.text?.trim() || task.proposal || task.title;
   flushDecisions(deps, task);
   recordCompletion(deps, task, summary);
@@ -1286,12 +1306,7 @@ async function handleComplete(task: Task, params: OrchestrateParams, deps: Workf
   task.blockers = [];
   if (task.state === "implementing") transition(task, "reviewing");
   transition(task, "completed");
-  const oversized = overThreshold(readDataRoots(deps.root, deps.configDir), deps.config.knowledge.compactionThreshold);
-  const advice =
-    oversized.length > 0
-      ? `\nKnowledge files over the compaction threshold: ${oversized.map((entry) => `${entry.agent}/${entry.file} (${entry.chars})`).join(", ")}. Compact them with action=compact when convenient.`
-      : "";
-  return `Task ${task.id} completed. History recorded and temporary scratchpads removed.${advice}`;
+  return `Task ${task.id} completed. History recorded and temporary scratchpads removed.`;
 }
 
 /** Asked when the oracle completes a task QA has not passed (the user told it to finish, say). */
@@ -1653,6 +1668,7 @@ const HANDLERS: Record<OrchestrateAction, (task: Task, params: OrchestrateParams
   qa: handleQa,
   knowledge: handleKnowledge,
   compact: handleCompact,
+  whiteboard: handleWhiteboard,
   complete: handleComplete,
   block: handleBlock,
   resume: handleResume,