@_linked/cli 1.14.0 → 1.15.0

package/CHANGELOG.md

@@ -1,5 +1,53 @@
 # Changelog
 
+## 1.15.0
+
+### Minor Changes
+
+- [#86](https://github.com/linked-cm/cli/pull/86) [`1f8908f`](https://github.com/linked-cm/cli/commit/1f8908fa276a5b65ed3ffe1c1e3bc23417ef9043) Thanks [@flyon](https://github.com/flyon)! - Always rewrite emitted ESM import specifiers
+
+  `linked build` appends `.js` (or `/index.js`) to relative specifiers in `lib/esm` for every package, with no
+  opt-in. The rewrite covers the emitted `.d.ts` declarations as well as the `.js`, so consumers on TypeScript
+  `node16`/`nodenext` resolution get valid declarations. For a package that already writes `.js` specifiers the
+  rewrite is a no-op.
+
+  It runs at the end of the build, after the assets and hand-written declarations have been copied into `lib` and
+  after stale output has been removed, so every specifier is resolved against the files the package actually ships.
+  Asset imports such as `./styles.scss` resolve and are left as written, copied `.d.ts` files are rewritten too, and
+  a leftover `x.js` can no longer make `./x` point at a file the cleanup then deletes.
+
+  Also in this release:
+
+  - The `missing_extension` rule is gone from the import check, in the build gate and in `linked check-imports`.
+    Extensionless relative imports in source no longer fail the build; the rewrite warns about any relative
+    specifier it cannot resolve, and Vite, Metro and `tsc` catch the rest. `outside_package` and the
+    internal-import rule remain hard errors for every package.
+  - The rule that stops a package reaching into another Linked package's internals now actually fires. It matched
+    only import paths containing the literal string `lincd`, so after the rename to the `@_linked/*` scope it was a
+    no-op for every current package: `@_linked/core/lib/esm/utils/Shape` passed. It now matches `@_linked/<pkg>/...`
+    as well as `lincd`-prefixed package names, on a `/src/` or `/lib/` path segment, and is called
+    `isInternalLinkedImport`. This can fail builds that previously passed — which is the point: such an import
+    breaks when the other package changes its build layout and bypasses its exports map. Import the public subpath
+    instead. Relative specifiers are exempt, so a local `./lib/helpers` is still fine.
+  - Both import rules now see every form that names a module — `export ... from`, `import()` in value and type
+    position, and `import x = require()` — not just `import ... from`.
+  - `linked check-imports` prints the report and exits 1 when an import is invalid, instead of exiting 0.
+  - `linked build` reports failures accurately: a step that fails names itself instead of a bare "Build failed",
+    and a failed build always exits non-zero, including under `--silent` and when building updated packages.
+  - `isImportOutsideOfPackage` normalises the path before judging it, so `./a..b` is no longer flagged and
+    `../a/../b` is counted as the one level it actually climbs.
+  - A relative specifier with a trailing slash (`./file/`) names a directory, so it resolves to `./file/index.js`
+    and never to a sibling `./file.js`.
+
+  A package without a `tsconfig-esm.json` has no ESM build, so the rewrite step is skipped rather than failing. When
+  `tsconfig-esm.json` is present but `lib/esm` was not emitted, the build fails.
+
+## 1.14.1
+
+### Patch Changes
+
+- [#83](https://github.com/linked-cm/cli/pull/83) [`566cb44`](https://github.com/linked-cm/cli/commit/566cb44f8728f25e852987ed4426063df9575492) Thanks [@flyon](https://github.com/flyon)! - React Native template: the integration test setup now tells apart "Docker is not installed", "Docker Compose is unavailable" and "Compose Fuseki is not running" (unit-tested in the scaffold); the integration Jest config comment says "Integration tests". README: document that `linked build` exits 1 whenever the build does not succeed (including in a `linkedApp` or a package without `linkedPackage: true`), and 0 with warnings. Reworded a stale migration comment in `linked start`.
+
 ## 1.14.0
 
 ### Minor Changes

package/README.md

@@ -41,6 +41,10 @@ linked build-updated              # incremental: only packages that changed sinc
 linked build-package <file>       # walk up from a file path to find its package and rebuild
 ```
 
+`linked build` exits with code 1 whenever the build does not succeed, including when it is run in a `linkedApp` or
+in a package without `"linkedPackage": true` (it used to exit 0 there). A build that finishes with warnings still
+exits 0.
+
 ### Publishing / release
 
 ```bash
@@ -89,28 +93,21 @@ The CLI recognizes two flags in `package.json`:
 
 The legacy `lincd: true` / `lincdApp: true` flags are no longer read. Migrate to `linkedPackage` / `linkedApp`.
 
-### `"linked": {"extensionlessImports": true}`
-
-```json
-{
-  "linkedPackage": true,
-  "type": "module",
-  "linked": {"extensionlessImports": true}
-}
-```
+### Extensionless relative imports
 
-By default `linked build` rejects relative imports without an extension (`./shapes/Example`), because Node's ESM
-loader cannot resolve them. Set this flag when the package source must use extensionless imports, for example a
-shapes package consumed as TypeScript source by Metro (which does not map `.js` specifiers to `.ts` files).
-With the flag, `linked build`:
+Package source may use extensionless relative imports (`./shapes/Example` rather than `./shapes/Example.js`) —
+useful for a shapes package consumed as TypeScript source by Metro, which does not map `.js` specifiers to `.ts`
+files. No configuration is needed. After compiling ESM, `linked build` rewrites every relative specifier in
+`lib/esm` — in the emitted `.js` and in the `.d.ts` declarations beside them, so consumers on TypeScript
+`node16`/`nodenext` resolution get valid declarations — to `./x.js` or `./dir/index.js`, so Node can load the
+output. For a package that already writes `.js` specifiers the rewrite is a no-op.
 
-- skips the import check;
-- after compiling ESM, rewrites every relative specifier in `lib/esm` (static imports and exports, `export * as`,
-  side-effect imports and `import()` with a literal) to `./x.js` or `./dir/index.js`, so Node can load the output;
-- fails if `lib/esm` was not emitted;
-- finishes "with warnings" and lists each specifier it could not resolve (left unchanged).
+The build finishes "with warnings" and lists each relative specifier it could not resolve (left unchanged), and
+fails when `tsconfig-esm.json` is present but `lib/esm` was not emitted. A package without a `tsconfig-esm.json`
+has no ESM build, so the step is skipped.
 
-Requirements: `"linkedPackage": true`, `"type": "module"` and a `tsconfig-esm.json` in the package.
+The import check (`linked check-imports`, also run as the first build step) still fails the build for imports
+that reach outside the package source root, and for imports into another linked package's `/src/` or `/lib/`.
 
 ## API-only backend
 
@@ -168,8 +165,8 @@ workspaces monorepo for Expo SDK 57 / React Native 0.86 / React 19.2 with an API
     src/shell/              env.ts (API URL), storage.ts (BackendAPIStore)
     src/components/         PersonOverview / PersonPreview: example add/edit/delete screen
     __tests__/              unit tests; __tests__/integration/ runs against the API and Fuseki
-  packages/<prefix>-shapes/ Linked shapes package: TypeScript source, extensionless imports,
-                            "linked": {"extensionlessImports": true} so `linked build` emits Node-loadable lib/esm
+  packages/<prefix>-shapes/ Linked shapes package: TypeScript source with extensionless imports; `linked build`
+                            rewrites the emitted specifiers so lib/esm is Node-loadable
   services/api/             API-only backend (`linked start --api-only`) on @_linked/server, Fuseki through
                             linked.backend.datasets.json, node --test unit tests
 ```

package/defaults/app-react-native/README.md

@@ -87,9 +87,9 @@ cd apps/mobile && npx expo export --platform ios --output-dir /tmp/export
   `@_linked/server/shapes/quadstores/BackendAPIStore`): the root barrel pulls express, webpack and react-dom.
   ESLint `no-restricted-imports` enforces it.
 - **Shapes package imports are extensionless** (`./shapes/Example`, not `./shapes/Example.js`): Metro does not
-  map `.js` specifiers to `.ts` source. `"linked": {"extensionlessImports": true}` in its `package.json` makes
-  `linked build` skip the import check and add `.js` to the emitted `lib/esm` specifiers. The app, Jest and the
-  API in development consume `src/` through the `react-native` and `development` export conditions.
+  map `.js` specifiers to `.ts` source. No configuration is needed — `linked build` always adds `.js` to the
+  relative specifiers in the emitted `lib/esm` JS and declarations. The app, Jest and the API in development
+  consume `src/` through the `react-native` and `development` export conditions.
 - **Decorators** work with the stock `babel-preset-expo`. The one custom Babel plugin,
   `apps/mobile/babel/stripJsonImportAttributes.js`, strips `with { type: 'json' }` from dynamic `import()`, which
   Metro rejects and Linked ontology packages use; `__tests__/stripJsonImportAttributes.test.ts` covers it. After

package/defaults/app-react-native/apps/mobile/__tests__/composePort.test.ts

@@ -0,0 +1,33 @@
+import { describeComposePortFailure } from './integration/apiEnv';
+
+describe('describeComposePortFailure', () => {
+  test('docker not installed', () => {
+    const error = Object.assign(new Error('spawnSync docker ENOENT'), { code: 'ENOENT' });
+    expect(describeComposePortFailure({ error, status: null })).toMatch(/^Docker is not installed/);
+  });
+
+  test('docker compose unavailable', () => {
+    const message = describeComposePortFailure({
+      status: 1,
+      stderr: "docker: 'compose' is not a docker command.\nSee 'docker --help'",
+    });
+    expect(message).toMatch(/^Docker Compose is not available/);
+    expect(message).toContain('is not a docker command');
+  });
+
+  test('non-zero exit mentioning compose', () => {
+    expect(describeComposePortFailure({ status: 125, stderr: 'unknown command: docker compose' })).toMatch(
+      /^Docker Compose is not available/,
+    );
+  });
+
+  test('service not running', () => {
+    const message = describeComposePortFailure({ status: 1, stderr: 'service "fuseki" is not running' });
+    expect(message).toMatch(/Compose Fuseki is not running/);
+    expect(message).toContain('npm run fuseki:up');
+  });
+
+  test('exit 0 without a port counts as not running', () => {
+    expect(describeComposePortFailure({ status: 0, stdout: '' })).toMatch(/Compose Fuseki is not running/);
+  });
+});

package/defaults/app-react-native/apps/mobile/__tests__/integration/apiEnv.ts

@@ -28,7 +28,33 @@ export function readApiEnvFile(): Record<string, string> {
   return existsSync(envFile) ? parseEnvFile(readFileSync(envFile, 'utf8')) : {};
 }
 
-export type FusekiEnv = { baseUrl: string; user: string; password: string };
+/** The parts of a `spawnSync('docker', ['compose', 'port', 'fuseki', '3030'])` result that explain a failure. */
+export type ComposePortResult = {
+  error?: (Error & { code?: string }) | undefined;
+  status: number | null;
+  stdout?: string | null;
+  stderr?: string | null;
+};
+
+/**
+ * Why `docker compose port fuseki 3030` gave no port: Docker is not installed, Docker Compose is unavailable, or
+ * this repo's Compose Fuseki is not running.
+ */
+export function describeComposePortFailure(result: ComposePortResult): string {
+  const output = (result.stderr || result.error?.message || result.stdout || '').trim();
+  if (result.error?.code === 'ENOENT') {
+    return 'Docker is not installed or not on PATH (`docker` could not be started). Install Docker, then run `npm run fuseki:up`.';
+  }
+  const composeMissing =
+    /is not a docker command/i.test(output) ||
+    (result.status !== 0 && /compose/i.test(output) && !/not running|no container/i.test(output));
+  if (composeMissing) {
+    return `Docker Compose is not available (\`docker compose port fuseki 3030\`: ${output}). Install the Docker Compose plugin, then run \`npm run fuseki:up\`.`;
+  }
+  return `this repo's Compose Fuseki is not running (\`docker compose port fuseki 3030\`: ${output}). Run \`npm run fuseki:up\`.`;
+}
+
+export type FusekiEnv ={ baseUrl: string; user: string; password: string };
 
 /**
  * The Fuseki the tests talk to. services/api/.env is the source, and the shell wins: FUSEKI_BASE_URL, or

package/defaults/app-react-native/apps/mobile/__tests__/integration/globalSetup.ts

@@ -4,7 +4,16 @@
 import { type ChildProcess, spawn, spawnSync } from 'node:child_process';
 import { resolve } from 'node:path';
 
-import { API_PORT, API_URL, FUSEKI_DATASET, apiDir, readApiEnvFile, repoRoot, resolveFusekiEnv } from './apiEnv';
+import {
+  API_PORT,
+  API_URL,
+  FUSEKI_DATASET,
+  apiDir,
+  describeComposePortFailure,
+  readApiEnvFile,
+  repoRoot,
+  resolveFusekiEnv,
+} from './apiEnv';
 
 // The variables that select S3FileStore (services/api/src/fileStoreEnv.ts); blanked even when unset anywhere.
 const S3_ENV_KEYS = ['AWS_ACCESS_KEY_ID', 'AWS_SECRET_ACCESS_KEY', 'AWS_REGION', 'S3_BUCKET_ENDPOINT', 'S3_FILES_BUCKET_NAME'];
@@ -40,12 +49,7 @@ function assertSafeTarget(baseUrl: string) {
 
   const compose = spawnSync('docker', ['compose', 'port', 'fuseki', '3030'], { cwd: repoRoot, encoding: 'utf8' });
   const composePort = compose.status === 0 ? /:(\d+)\s*$/.exec(compose.stdout.trim())?.[1] : undefined;
-  if (!composePort) {
-    refuse(
-      `this repo's Compose Fuseki is not running (\`docker compose port fuseki 3030\`: ` +
-        `${(compose.stderr || compose.error?.message || compose.stdout || '').trim()}). Run \`npm run fuseki:up\`.`,
-    );
-  }
+  if (!composePort) refuse(describeComposePortFailure(compose));
   if (composePort !== urlPort) {
     refuse(`port ${urlPort} is not the Compose Fuseki port ${composePort}. Set FUSEKI_PORT=${composePort}.`);
   }

package/defaults/app-react-native/apps/mobile/jest.integration.config.js

@@ -1,4 +1,4 @@
-// Round-trip tests against a real API and Fuseki: `npm run fuseki:up && npm run test:integration`.
+// Integration tests against a real API and Fuseki: `npm run fuseki:up && npm run test:integration`.
 // Same preset, transforms and module mapping as the unit config in package.json. jest-expo replaces the global
 // fetch with a stubbed `expo/fetch` that never sends a request (it is not a jest mock), so the environment saves
 // Node's fetch and restoreNodeFetch.ts reinstates it.

package/defaults/app-react-native/packages/app-shapes/package.json

@@ -4,9 +4,6 @@
   "private": true,
   "type": "module",
   "linkedPackage": true,
-  "linked": {
-    "extensionlessImports": true
-  },
   "exports": {
     ".": {
       "types": "./src/index.ts",

package/lib/esm/cli-methods.d.ts

@@ -93,7 +93,7 @@ export declare const buildBackend: () => Promise<boolean>;
 export declare const upgradePackages: () => Promise<void>;
 export declare const createPackage: (name: any, uriBase?: any, basePath?: string) => Promise<void>;
 export declare const register: (registryURL: any) => Promise<void>;
-export declare const buildPackage: (target: any, target2: any, packagePath?: string, logResults?: boolean) => Promise<any>;
+export declare const buildPackage: (target: any, target2: any, packagePath?: string, logResults?: boolean) => Promise<boolean>;
 type BuildStep = {
     name: string;
     apply: () => Promise<unknown>;

package/lib/esm/cli-methods.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"cli-methods.d.ts","sourceRoot":"","sources":["../../src/cli-methods.ts"],"names":[],"mappings":"AA4BA,OAAO,KAAK,EAAC,cAAc,EAAC,MAAM,iBAAiB,CAAC;AAgBpD;;;;;;GAMG;AAKH,OAAO,EACL,uBAAuB,EACvB,wBAAwB,EACxB,gBAAgB,EACjB,MAAM,gBAAgB,CAAC;AACxB,OAAO,EAAC,uBAAuB,EAAE,wBAAwB,EAAE,gBAAgB,EAAC,CAAC;AAoB7E,MAAM,MAAM,WAAW,GAAG,KAAK,GAAG,cAAc,CAAC;AAEjD,KAAK,WAAW,GAAG;IACjB,OAAO,EAAE,MAAM,CAAC;IAChB,SAAS,EAAE,MAAM,CAAC;IAClB,SAAS,EAAE,MAAM,CAAC;IAClB,UAAU,EAAE,MAAM,CAAC;CACpB,CAAC;AAEF,eAAO,MAAM,SAAS,GAAU,SAAI,EAAE,iBAAwB,EAAE,UAAS;IAAC,OAAO,CAAC,EAAE,MAAM,CAAC;IAAC,SAAS,CAAC,EAAE,MAAM,CAAC;IAAC,SAAS,CAAC,EAAE,MAAM,CAAC;IAAC,WAAW,CAAC,EAAE,OAAO,CAAC;IAAC,QAAQ,CAAC,EAAE,WAAW,CAAA;CAAM,kBAgNtL,CAAC;AAEF;;;GAGG;AACH,wBAAgB,mBAAmB,CACjC,SAAS,EAAE,MAAM,EACjB,SAAS,EAAE,MAAM,GAChB,MAAM,CAcR;AAED;;;GAGG;AACH,eAAO,MAAM,iBAAiB,QAAsB,CAAC;AAkBrD,2EAA2E;AAC3E,eAAO,MAAM,eAAe,eAAe,CAAC;AAE5C;;;GAGG;AACH,wBAAgB,iBAAiB,CAAC,SAAS,EAAE,MAAM,GAAG,MAAM,CAAC,MAAM,EAAE,MAAM,CAAC,CAM3E;AA8BD;;;;;GAKG;AACH,wBAAsB,sBAAsB,CAC1C,YAAY,EAAE,MAAM,EACpB,EAAE,EAAE,WAAW,EACf,OAAO,GAAE;IAAC,WAAW,CAAC,EAAE,OAAO,CAAC;IAAC,WAAW,CAAC,EAAE,MAAM,CAAA;CAAM,GAC1D,OAAO,CAAC,IAAI,CAAC,CAkGf;AAGD,eAAO,MAAM,oBAAoB;;CAA2B,CAAC;AA0F7D,wBAAgB,IAAI,CAAC,GAAG,QAAQ,OAAA,QAK/B;AACD,wBAAgB,QAAQ,CAAC,GAAG,MAAM,OAAA,QAIjC;AACD,wBAAgB,cAAc,CAAC,MAAM,KAAA,EAAE,IAAI,KAAA,QAyB1C;AA2CD,wBAAgB,kCAAkC,CAChD,aAAa,KAAA,EACb,YAAY,EAAE,CACZ,YAAY,KAAA,EACZ,YAAY,KAAA,KACT,CAAC,GAAG,EAAE,cAAc,KAAK,OAAO,CAAC,GAAG,CAAC,EAC1C,UAAU,KAAA,EACV,IAAI,UAAQ,GACX,OAAO,CAAC,IAAI,CAAC,CAqNf;AA+ID,wBAAgB,QAAQ,CAAC,OAAO,KAAA,QAkU/B;AA2ED,eAAO,MAAM,cAAc,GACzB,WAAM,EACN,aAAQ,EACR,iBAAwB,kBA6FzB,CAAC;AAmBF,eAAO,MAAM,gBAAgB,GAAa,iBAAiB,MAAM,EAAE,OAAM,MAAsB,WAkB9F,CAAC;AAIF,eAAO,MAAM,cAAc,GACzB,SAAI,EACJ,mBAAmB,MAAM,EACzB,OAAM,MAAsB,EAC5B,gBAAe,OAAe,WAsC/B,CAAC;AAiGF,eAAO,MAAM,gBAAgB,GAAa,SAAI;;;;;CAc7C,CAAC;AAgBF;;GAEG;AACH,eAAO,MAAM,YAAY,cAaxB,CAAC;AACF,eAAO,MAAM,WAAW,GAAU,SAAI,EAAE,iBAAwB,kBA0B/D,CAAC;AAEF,eAAO,MAAM,kBAAkB,GAAU,SAAI,EAAE,iBAAwB,kBAmCtE,CAAC;AACF,eAAO,MAAM,eAAe,GAAU,SAAI,EAAE,iBAAwB,kBAuCnE,CAAC;AAKF,eAAO,MAAM,YAAY,GACvB,eAAc,MAA0B,EACxC,QAAO,MAAU,EAAE,wDAAwD;AAC3E,iBAAgB,GAAG,CAAC,MAAM,EAAE;IAAC,IAAI,EAAE,MAAM,CAAC;IAAC,UAAU,EAAE,MAAM,CAAA;CAAC,EAAE,CAAa,qBA0G9E,CAAC;AAEF,eAAO,MAAM,cAAc,qBAuB1B,CAAC;AACF,eAAO,MAAM,QAAQ,GAAU,cAAa,MAAsB,qBAwDjE,CAAC;AAEF,eAAO,MAAM,SAAS,GACpB,YAAY,MAAM,EAClB,SAAS;IAAC,KAAK,EAAE,OAAO,CAAA;CAAC,mBAoB1B,CAAC;AAEF,eAAO,MAAM,SAAS,GACpB,aAAa,MAAM,EACnB,QAAQ,MAAM,EACd,SAAS;IAAC,KAAK,EAAE,OAAO,CAAA;CAAC,kBAiH1B,CAAC;AACF,eAAO,MAAM,WAAW,GACtB,WAAU,OAAe,EACzB,iBAAkB,iBA8DnB,CAAC;AACF,eAAO,MAAM,QAAQ,sBAKpB,CAAC;AACF,eAAO,MAAM,aAAa,qBAqHzB,CAAC;AACF,eAAO,MAAM,YAAY,wBAiExB,CAAC;AAEF,eAAO,MAAM,eAAe,qBAoK3B,CAAC;AAEF,eAAO,MAAM,aAAa,GACxB,SAAI,EACJ,aAAQ,EACR,iBAAwB,kBA4HzB,CAAC;AAqBF,eAAO,MAAM,QAAQ,GAAa,gBAAW,kBAuD5C,CAAC;AAEF,eAAO,MAAM,YAAY,GACvB,WAAM,EACN,YAAO,EACP,oBAA2B,EAC3B,aAAY,OAAc,iBAiJ3B,CAAC;AAEF,KAAK,SAAS,GAAG;IACf,IAAI,EAAE,MAAM,CAAC;IAEb,KAAK,EAAE,MAAM,OAAO,CAAC,OAAO,CAAC,CAAC;CAC/B,CAAC;AAKF,eAAO,MAAM,cAAc,GAAI,YAAO,EAAE,aAAa,MAAM,KAAG,SAAS,EAwGtE,CAAC;AACF,eAAO,MAAM,cAAc,GAAU,oBAA2B,kBAyB/D,CAAC;AACF,eAAO,MAAM,iBAAiB,GAAU,oBAA2B,qBAWlE,CAAC;AACF,eAAO,MAAM,iBAAiB,GAAU,oBAA2B;;EAelE,CAAC;AAEF,eAAO,IAAI,cAAc,GAAa,OAAM,OAAe,kBA0K1D,CAAC;AAsBF,eAAO,IAAI,cAAc,GACvB,SAAI,EACJ,UAAK,EACL,UAAK,EACL,oBAAe,oBA6DhB,CAAC;AAEF,eAAO,IAAI,YAAY,GACrB,SAAI,EACJ,WAAM,EACN,YAAO,EACP,wBAAuB,OAAe,EACtC,OAAM,OAAe,kBAqHtB,CAAC;AAeF,eAAO,IAAI,4BAA4B,GACrC,aAAQ,EACR,YAAO,EACP,iBAAY,EACZ,gBAAW,qBA4CZ,CAAC;AAOF,eAAO,IAAI,cAAc,GAAa,aAAQ,EAAE,YAAO,SAMtD,CAAC;AACF,eAAO,IAAI,YAAY,GAAmB,iBAAwB,kBA8FjE,CAAC;AAEF,eAAO,IAAI,wBAAwB,GAAa,gBAAW,EAAE,YAAO,SA6BnE,CAAC;AAEF;;;GAGG;AACH,eAAO,MAAM,cAAc,GAAU,gBAAW,qBA8B/C,CAAC"}
+{"version":3,"file":"cli-methods.d.ts","sourceRoot":"","sources":["../../src/cli-methods.ts"],"names":[],"mappings":"AA2BA,OAAO,KAAK,EAAC,cAAc,EAAC,MAAM,iBAAiB,CAAC;AAgBpD;;;;;;GAMG;AAKH,OAAO,EACL,uBAAuB,EACvB,wBAAwB,EACxB,gBAAgB,EACjB,MAAM,gBAAgB,CAAC;AACxB,OAAO,EAAC,uBAAuB,EAAE,wBAAwB,EAAE,gBAAgB,EAAC,CAAC;AAoB7E,MAAM,MAAM,WAAW,GAAG,KAAK,GAAG,cAAc,CAAC;AAEjD,KAAK,WAAW,GAAG;IACjB,OAAO,EAAE,MAAM,CAAC;IAChB,SAAS,EAAE,MAAM,CAAC;IAClB,SAAS,EAAE,MAAM,CAAC;IAClB,UAAU,EAAE,MAAM,CAAC;CACpB,CAAC;AAEF,eAAO,MAAM,SAAS,GAAU,SAAI,EAAE,iBAAwB,EAAE,UAAS;IAAC,OAAO,CAAC,EAAE,MAAM,CAAC;IAAC,SAAS,CAAC,EAAE,MAAM,CAAC;IAAC,SAAS,CAAC,EAAE,MAAM,CAAC;IAAC,WAAW,CAAC,EAAE,OAAO,CAAC;IAAC,QAAQ,CAAC,EAAE,WAAW,CAAA;CAAM,kBAgNtL,CAAC;AAEF;;;GAGG;AACH,wBAAgB,mBAAmB,CACjC,SAAS,EAAE,MAAM,EACjB,SAAS,EAAE,MAAM,GAChB,MAAM,CAcR;AAED;;;GAGG;AACH,eAAO,MAAM,iBAAiB,QAAsB,CAAC;AAkBrD,2EAA2E;AAC3E,eAAO,MAAM,eAAe,eAAe,CAAC;AAE5C;;;GAGG;AACH,wBAAgB,iBAAiB,CAAC,SAAS,EAAE,MAAM,GAAG,MAAM,CAAC,MAAM,EAAE,MAAM,CAAC,CAM3E;AA8BD;;;;;GAKG;AACH,wBAAsB,sBAAsB,CAC1C,YAAY,EAAE,MAAM,EACpB,EAAE,EAAE,WAAW,EACf,OAAO,GAAE;IAAC,WAAW,CAAC,EAAE,OAAO,CAAC;IAAC,WAAW,CAAC,EAAE,MAAM,CAAA;CAAM,GAC1D,OAAO,CAAC,IAAI,CAAC,CAkGf;AAGD,eAAO,MAAM,oBAAoB;;CAA2B,CAAC;AA0F7D,wBAAgB,IAAI,CAAC,GAAG,QAAQ,OAAA,QAK/B;AACD,wBAAgB,QAAQ,CAAC,GAAG,MAAM,OAAA,QAIjC;AACD,wBAAgB,cAAc,CAAC,MAAM,KAAA,EAAE,IAAI,KAAA,QAyB1C;AA2CD,wBAAgB,kCAAkC,CAChD,aAAa,KAAA,EACb,YAAY,EAAE,CACZ,YAAY,KAAA,EACZ,YAAY,KAAA,KACT,CAAC,GAAG,EAAE,cAAc,KAAK,OAAO,CAAC,GAAG,CAAC,EAC1C,UAAU,KAAA,EACV,IAAI,UAAQ,GACX,OAAO,CAAC,IAAI,CAAC,CAqNf;AA+ID,wBAAgB,QAAQ,CAAC,OAAO,KAAA,QAkU/B;AA2ED,eAAO,MAAM,cAAc,GACzB,WAAM,EACN,aAAQ,EACR,iBAAwB,kBA6FzB,CAAC;AAmBF,eAAO,MAAM,gBAAgB,GAAa,iBAAiB,MAAM,EAAE,OAAM,MAAsB,WAkB9F,CAAC;AAIF,eAAO,MAAM,cAAc,GACzB,SAAI,EACJ,mBAAmB,MAAM,EACzB,OAAM,MAAsB,EAC5B,gBAAe,OAAe,WAsC/B,CAAC;AAiGF,eAAO,MAAM,gBAAgB,GAAa,SAAI;;;;;CAc7C,CAAC;AAgBF;;GAEG;AACH,eAAO,MAAM,YAAY,cAaxB,CAAC;AACF,eAAO,MAAM,WAAW,GAAU,SAAI,EAAE,iBAAwB,kBA0B/D,CAAC;AAEF,eAAO,MAAM,kBAAkB,GAAU,SAAI,EAAE,iBAAwB,kBAmCtE,CAAC;AACF,eAAO,MAAM,eAAe,GAAU,SAAI,EAAE,iBAAwB,kBAuCnE,CAAC;AAMF,eAAO,MAAM,YAAY,GACvB,eAAc,MAA0B,EACxC,QAAO,MAAU,EAAE,wDAAwD;AAC3E,iBAAgB,GAAG,CAAC,MAAM,EAAE;IAAC,IAAI,EAAE,MAAM,CAAC;IAAC,UAAU,EAAE,MAAM,CAAA;CAAC,EAAE,CAAa,qBA2F9E,CAAC;AAEF,eAAO,MAAM,cAAc,qBAuB1B,CAAC;AACF,eAAO,MAAM,QAAQ,GAAU,cAAa,MAAsB,qBAwDjE,CAAC;AAEF,eAAO,MAAM,SAAS,GACpB,YAAY,MAAM,EAClB,SAAS;IAAC,KAAK,EAAE,OAAO,CAAA;CAAC,mBAoB1B,CAAC;AAEF,eAAO,MAAM,SAAS,GACpB,aAAa,MAAM,EACnB,QAAQ,MAAM,EACd,SAAS;IAAC,KAAK,EAAE,OAAO,CAAA;CAAC,kBAiH1B,CAAC;AACF,eAAO,MAAM,WAAW,GACtB,WAAU,OAAe,EACzB,iBAAkB,iBA8DnB,CAAC;AACF,eAAO,MAAM,QAAQ,sBAKpB,CAAC;AACF,eAAO,MAAM,aAAa,qBAqHzB,CAAC;AACF,eAAO,MAAM,YAAY,wBAiExB,CAAC;AAEF,eAAO,MAAM,eAAe,qBAoK3B,CAAC;AAEF,eAAO,MAAM,aAAa,GACxB,SAAI,EACJ,aAAQ,EACR,iBAAwB,kBA4HzB,CAAC;AAqBF,eAAO,MAAM,QAAQ,GAAa,gBAAW,kBAuD5C,CAAC;AAEF,eAAO,MAAM,YAAY,GACvB,WAAM,EACN,YAAO,EACP,oBAA2B,EAC3B,aAAY,OAAc,qBAyK3B,CAAC;AAEF,KAAK,SAAS,GAAG;IACf,IAAI,EAAE,MAAM,CAAC;IAGb,KAAK,EAAE,MAAM,OAAO,CAAC,OAAO,CAAC,CAAC;CAC/B,CAAC;AAMF,eAAO,MAAM,cAAc,GAAI,YAAO,EAAE,aAAa,MAAM,KAAG,SAAS,EA8GtE,CAAC;AAEF,eAAO,MAAM,cAAc,GAAU,oBAA2B,kBAyB/D,CAAC;AACF,eAAO,MAAM,iBAAiB,GAAU,oBAA2B,qBAWlE,CAAC;AACF,eAAO,MAAM,iBAAiB,GAAU,oBAA2B;;EAelE,CAAC;AAEF,eAAO,IAAI,cAAc,GAAa,OAAM,OAAe,kBA0K1D,CAAC;AAsBF,eAAO,IAAI,cAAc,GACvB,SAAI,EACJ,UAAK,EACL,UAAK,EACL,oBAAe,oBA6DhB,CAAC;AAEF,eAAO,IAAI,YAAY,GACrB,SAAI,EACJ,WAAM,EACN,YAAO,EACP,wBAAuB,OAAe,EACtC,OAAM,OAAe,kBAiHtB,CAAC;AAeF,eAAO,IAAI,4BAA4B,GACrC,aAAQ,EACR,YAAO,EACP,iBAAY,EACZ,gBAAW,qBA4CZ,CAAC;AAOF,eAAO,IAAI,cAAc,GAAa,aAAQ,EAAE,YAAO,SAMtD,CAAC;AACF,eAAO,IAAI,YAAY,GAAmB,iBAAwB,kBA8FjE,CAAC;AAEF,eAAO,IAAI,wBAAwB,GAAa,gBAAW,EAAE,YAAO,SA6BnE,CAAC;AAEF;;;GAGG;AACH,eAAO,MAAM,cAAc,GAAU,gBAAW,qBA8B/C,CAAC"}

package/lib/esm/cli-methods.js

@@ -14,7 +14,7 @@ import { getEnvFile } from 'env-cmd/dist/get-env-vars.js';
 import fs from 'fs-extra';
 import path, { dirname } from 'path';
 import { createInterface } from 'readline';
-import { debugInfo, execp, execPromise, getFileImports, getFiles, getLastCommitTime, getPackageJSON, isImportOutsideOfPackage, isImportWithMissingExtension, isInvalidLINCDImport, needsRebuilding, } from './utils.js';
+import { debugInfo, execp, execPromise, getFileImports, getFiles, getLastCommitTime, getPackageJSON, isImportOutsideOfPackage, isInternalLinkedImport, needsRebuilding, } from './utils.js';
 import { renameShippedDotfiles } from './utils/shippedDotfiles.js';
 import { planPackageSetup } from './utils/packageSetup.js';
 import { rewriteExtensionlessImports } from './utils/esmSpecifiers.js';
@@ -1400,9 +1400,10 @@ export const createComponent = (name_1, ...args_1) => __awaiter(void 0, [name_1,
         log(`Added an import of this file from ${chalk.magenta(indexPath)}`);
     }
 });
-//read the source of all ts/tsx files in the src folder
-//if there is an import that imports a lincd package with /src/ in it, then warn
-//if there is an import that imports something from outside the src folder, then warn
+// Reads the source of all ts/tsx files in the src folder and fails on imports
+// that reach outside the package source root ('outside_package'), or that point
+// into another Linked package's /src/ or /lib/ ('internal_linked'). Extensionless relative
+// imports are fine: `linked build` rewrites the emitted ESM specifiers.
 export const checkImports = (...args_1) => __awaiter(void 0, [...args_1], void 0, function* (sourceFolder = getSourceFolder(), depth = 0, // Used to check if the import is outside the src folder
 invalidImports = new Map()) {
     if (!fs.existsSync(sourceFolder)) {
@@ -1413,12 +1414,8 @@ invalidImports = new Map()) {
     // Start checking each file in the source folder
     for (const file of dir) {
         const filename = path.join(sourceFolder, file);
-        // Skip test sources. Test files (and their helpers/probes)
-        // are not part of the shipped ESM contract, so the missing-extension rule
-        // isn't load-bearing for them; enforcing it only blocks `linked build`
-        // (the real ESM-output gate stays in force for shipped source). This is
-        // what makes `linked build` green for packages whose tests use
-        // extensionless imports (e.g. @_linked/core).
+        // Skip test sources. Test files (and their helpers/probes) are not part
+        // of the shipped package, so the import rules do not apply to them.
         if (/(?:^|[\\/])(?:tests?|__tests__|test-helpers)(?:[\\/]|$)/.test(filename) ||
             /\.(?:test|spec)\.tsx?$/.test(file) ||
             /^type-probe.*\.tsx?$/.test(file)) {
@@ -1432,16 +1429,13 @@ invalidImports = new Map()) {
                 if (statSync(filename).isDirectory()) {
                     yield checkImports(filename, depth + 1, invalidImports);
                 }
-                else {
-                    // Ignore all files that aren't one of the following:
-                    // - .ts
-                    // - .tsx
-                    continue;
-                }
             }
             catch (e) {
                 console.log(e);
             }
+            // A directory has now been recursed into, and any other file is not a
+            // source file: either way there is nothing here to read imports from.
+            continue;
         }
         const allImports = yield getFileImports(filename);
         if (!invalidImports.has(filename)) {
@@ -1454,15 +1448,9 @@ invalidImports = new Map()) {
                     importPath: i,
                 });
             }
-            if (isInvalidLINCDImport(i, depth)) {
+            if (isInternalLinkedImport(i)) {
                 invalidImports.get(filename).push({
-                    type: 'lincd',
-                    importPath: i,
-                });
-            }
-            if (isImportWithMissingExtension(i)) {
-                invalidImports.get(filename).push({
-                    type: 'missing_extension',
+                    type: 'internal_linked',
                     importPath: i,
                 });
             }
@@ -1481,26 +1469,22 @@ invalidImports = new Map()) {
                 if (type === 'outside_package') {
                     message += ' which is outside the package source root';
                 }
-                if (type === 'lincd') {
-                    message +=
-                        ' which should not contain /src/ or /lib/ in the import path';
-                }
-                if (type === 'missing_extension') {
+                if (type === 'internal_linked') {
                     message +=
-                        ' which should end with a file extension. Like .js or .scss';
+                        " which reaches into another Linked package's /src/ or /lib/." +
+                            ' That breaks when its build layout changes and bypasses its' +
+                            ' exports map. Import its public subpath instead.';
                 }
                 res += chalk.red(message + '\n');
             });
         });
-        // Throw so buildStep aborts the compile pipeline — relative imports MUST
-        // have .js (or .scss) extensions for native-ESM-compatible output.
+        // Throw so buildStep aborts the compile pipeline: importing from outside
+        // the package, or into another Linked package's /src/ or /lib/, breaks the
+        // published package.
         throw res;
     }
-    else if (depth === 0 && invalidImports.size === 0) {
-        // console.info('All imports OK');
-        // process.exit(0);
-        return true;
-    }
+    // Nothing invalid: all imports OK.
+    return true;
 });
 export const depCheckStaged = () => __awaiter(void 0, void 0, void 0, function* () {
     console.log('Checking dependencies of staged files');
@@ -2202,7 +2186,6 @@ export const register = function (registryURL) {
     }
 };
 export const buildPackage = (target_1, target2_1, ...args_1) => __awaiter(void 0, [target_1, target2_1, ...args_1], void 0, function* (target, target2, packagePath = process.cwd(), logResults = true) {
-    var _a;
     // Ensure packagePath is absolute and points to a directory containing package.json; if not, go up until we find one
     // First, resolve to absolute path
     let currentPath = path.isAbsolute(packagePath)
@@ -2276,7 +2259,20 @@ export const buildPackage = (target_1, target2_1, ...args_1) => __awaiter(void 0
                     }
                     return previousResult && true;
                 }
-                else if (typeof stepResult === 'object' && stepResult.error) {
+                else if (
+                //a step may report a detail alongside success, e.g. how many files
+                //it changed. Not a warning: the build stays clean.
+                stepResult &&
+                    typeof stepResult === 'object' &&
+                    stepResult.info) {
+                    if (logResults) {
+                        spinner.succeed(step.name + ' - ' + stepResult.info);
+                    }
+                    return previousResult && true;
+                }
+                else if (stepResult &&
+                    typeof stepResult === 'object' &&
+                    stepResult.error) {
                     if (logResults) {
                         spinner.fail(step.name + ' - ' + stepResult.error);
                         spinner.stop();
@@ -2287,13 +2283,21 @@ export const buildPackage = (target_1, target2_1, ...args_1) => __awaiter(void 0
                     //failed and should stop
                     return false;
                 }
+                //anything else — notably a literal false, which several steps return
+                //on failure — is a failure. Name the step, so the build does not end
+                //on a bare 'Build failed'.
+                const failure = step.name + ' failed';
+                if (logResults) {
+                    spinner.fail(failure);
+                    spinner.stop();
+                }
+                else {
+                    console.error(chalk.red(failure));
+                }
+                return false;
             });
         });
     };
-    if (((_a = pkgJson.linked) === null || _a === void 0 ? void 0 : _a.extensionlessImports) === true) {
-        const skipped = "Skipping the import check: package.json sets 'linked.extensionlessImports'";
-        logResults ? spinner.info(skipped) : console.log(skipped);
-    }
     planBuildSteps(pkgJson, packagePath).forEach(buildStep);
     let success = yield buildProcess.catch((err) => {
         let msg = typeof err === 'string' || err instanceof Error
@@ -2306,22 +2310,21 @@ export const buildPackage = (target_1, target2_1, ...args_1) => __awaiter(void 0
                 symbol: chalk.red('✖'),
                 // text: 'Build failed',
             });
+            console.log(msg);
         }
         else {
             console.error(chalk.red(packagePath.split('/').pop(), ' - Build failed:'));
             console.error(err);
-            return msg;
         }
-        console.log(msg);
+        //a failed build always resolves to false, never to a truthy message:
+        //callers decide success by the return value.
+        return false;
     });
-    //will be undefined if there was an error
-    if (typeof success !== 'undefined' && success !== false) {
+    if (success === true) {
         if (logResults) {
             spinner.stopAndPersist({
                 symbol: chalk.greenBright('✔'),
-                text: success === true && !warned
-                    ? 'Build successful'
-                    : 'Build successful with warnings',
+                text: warned ? 'Build successful with warnings' : 'Build successful',
             });
         }
     }
@@ -2333,52 +2336,31 @@ export const buildPackage = (target_1, target2_1, ...args_1) => __awaiter(void 0
             });
         }
     }
-    return success;
+    //true only when every step succeeded (warnings included); false otherwise.
+    return success === true;
 });
-// The ordered `linked build` steps for a linkedPackage. A package whose source
-// uses extensionless relative imports (`"linked": {"extensionlessImports": true}`)
-// skips the import check and gets `.js` added to its emitted ESM specifiers.
-export const planBuildSteps = (pkgJson, packagePath) => {
-    var _a;
-    const extensionlessImports = ((_a = pkgJson.linked) === null || _a === void 0 ? void 0 : _a.extensionlessImports) === true;
-    const steps = [];
-    if (!extensionlessImports) {
-        steps.push({
-            name: 'Checking imports',
-            apply: () => checkImports(packagePath + '/src'),
-        });
-    }
-    steps.push({
+// The ordered `linked build` steps for a linkedPackage. Source may use
+// extensionless relative imports: once `lib/esm` holds everything it will ship,
+// every package gets `.js` added to the relative specifiers in it (JS and
+// declarations). For a package that already writes `.js` this is a no-op.
+export const planBuildSteps = (pkgJson, packagePath) => [
+    {
+        name: 'Checking imports',
+        apply: () => checkImports(packagePath + '/src'),
+    },
+    {
         name: 'Compiling ESM',
         apply: () => __awaiter(void 0, void 0, void 0, function* () {
             return compilePackageESM(packagePath);
         }),
-    });
-    if (extensionlessImports) {
-        steps.push({
-            name: 'Rewriting ESM import specifiers',
-            apply: () => __awaiter(void 0, void 0, void 0, function* () {
-                const libEsm = path.join(packagePath, 'lib', 'esm');
-                if (!fs.existsSync(libEsm)) {
-                    return {
-                        error: "lib/esm was not emitted. 'linked.extensionlessImports' needs an ESM build: add tsconfig-esm.json to the package.",
-                    };
-                }
-                const { unresolved } = yield rewriteExtensionlessImports(libEsm);
-                if (unresolved.length > 0) {
-                    return `could not resolve ${unresolved.length} import(s), left unchanged: ${unresolved.join(', ')}`;
-                }
-                return true;
-            }),
-        });
-    }
-    steps.push({
+    },
+    {
         name: 'Compiling CJS',
         apply: () => __awaiter(void 0, void 0, void 0, function* () {
             return compilePackageCJS(packagePath);
         }),
-    });
-    steps.push({
+    },
+    {
         name: 'Copying files to lib folder',
         apply: () => __awaiter(void 0, void 0, void 0, function* () {
             const files = yield glob(packagePath + '/src/**/*.{json,d.ts,css,scss}');
@@ -2400,8 +2382,8 @@ export const planBuildSteps = (pkgJson, packagePath) => {
                 return allResults.every((r) => r === true);
             });
         }),
-    });
-    steps.push({
+    },
+    {
         name: 'Dual package support',
         apply: () => {
             // Skip if no tsconfig files (e.g. pure-CSS packages).
@@ -2415,19 +2397,48 @@ export const planBuildSteps = (pkgJson, packagePath) => {
                 return res === '';
             });
         },
-    });
-    steps.push({
+    },
+    {
         name: 'Removing old files from lib folder',
         apply: () => __awaiter(void 0, void 0, void 0, function* () {
             return removeOldFiles(packagePath);
         }),
-    });
-    steps.push({
+    },
+    {
+        // MUST run after 'Copying files to lib folder' and after 'Removing old
+        // files from lib folder', because the rewrite resolves each specifier
+        // against the files actually present in lib/esm:
+        // - the copy step brings in the assets (`./x.scss`) and hand-written
+        //   `.d.ts` from src; before it, an asset import looks unresolvable (a
+        //   spurious "build with warnings") and a copied `.d.ts` is never rewritten;
+        // - the cleanup step deletes stale output; before it, a leftover `x.js`
+        //   makes './x' resolve to './x.js' and the cleanup then removes the file
+        //   the specifier now points at.
+        name: 'Rewriting ESM import specifiers',
+        apply: () => __awaiter(void 0, void 0, void 0, function* () {
+            // No tsconfig-esm.json means the ESM compile was skipped (e.g. pure-CSS
+            // packages), so there is nothing to rewrite and nothing to fail over.
+            if (!fs.existsSync(path.join(packagePath, 'tsconfig-esm.json'))) {
+                return true;
+            }
+            const libEsm = path.join(packagePath, 'lib', 'esm');
+            if (!fs.existsSync(libEsm)) {
+                return {
+                    error: 'lib/esm was not emitted while tsconfig-esm.json is present. Check the ESM compile.',
+                };
+            }
+            const { changed, unresolved } = yield rewriteExtensionlessImports(libEsm);
+            if (unresolved.length > 0) {
+                return `could not resolve ${unresolved.length} import(s), left unchanged: ${unresolved.join(', ')}`;
+            }
+            return changed > 0 ? { info: `rewrote ${changed} file(s)` } : true;
+        }),
+    },
+    {
         name: 'Checking dependencies',
         apply: () => depCheck(packagePath),
-    });
-    return steps;
-};
+    },
+];
 export const compilePackage = (...args_1) => __awaiter(void 0, [...args_1], void 0, function* (packagePath = process.cwd()) {
     //echo 'compiling CJS' && tsc -p tsconfig-cjs.json && echo 'compiling ESM' && tsc -p tsconfig-esm.json
     // let cjsConfig = fs.existsSync(path.join(packagePath,'tsconfig-cjs.json'));
@@ -2751,12 +2762,10 @@ export var buildUpdated = function (back_1, target_1, target2_1) {
                     // log('path: ' + pathToBuild);
                     return buildPackage(null, null, pathToBuild, false)
                         .then((res) => {
-                        //empty string or true is success
-                        //false is success with warnings
-                        //any other string is the build error text
-                        //undefined result means it failed
-                        if (typeof res === 'undefined' || typeof res === 'string') {
-                            logError('Failed to build ' + pkg.packageName + '. ' + res ? res : '');
+                        //buildPackage returns true only when the build succeeded
+                        //(warnings included); anything else is a failure.
+                        if (res !== true) {
+                            logError('Failed to build ' + pkg.packageName);
                             process.exit(1);
                         }
                         else {