@8ms/helpers 1.2.10 → 1.2.12

package/package.json

@@ -1,7 +1,7 @@
 {
     "name":            "@8ms/helpers",
     "license":         "UNLICENSED",
-    "version":         "1.2.10",
+    "version":         "1.2.12",
     "repository":      {
         "type": "git",
         "url":  "git+https://github.com/8millionstories-organisation/8ms-helpers-ts.git"

package/url/writeUrlContents.d.ts

@@ -7,5 +7,5 @@ type WriteUrlContents = {
  *
  * Requires fs-extra
  */
-declare const saveUrlContents: ({ filePath, url }: WriteUrlContents) => Promise<unknown>;
+declare const saveUrlContents: ({ filePath, url }: WriteUrlContents) => Promise<void>;
 export default saveUrlContents;

package/url/writeUrlContents.js

@@ -12,18 +12,31 @@ const createDirectory_1 = __importDefault(require("../file/createDirectory"));
  */
 const saveUrlContents = async ({ filePath, url }) => {
     const fs = require('fs-extra');
-    return new Promise(async (resolve, reject) => {
-        (0, axios_1.default)({
-            method: "get",
-            url,
-            responseType: "stream"
-        })
-            .then(async (response) => {
-            await (0, createDirectory_1.default)({
-                filePath,
+    await (0, createDirectory_1.default)({
+        filePath,
+    });
+    const writer = fs.createWriteStream(filePath);
+    await (0, axios_1.default)({
+        method: "get",
+        url,
+        responseType: "stream"
+    })
+        .then(response => {
+        return new Promise(async (resolve, reject) => {
+            response.data.pipe(writer);
+            let error = null;
+            writer.on('error', err => {
+                error = err;
+                writer.close();
+                reject(err);
+            });
+            writer.on('close', () => {
+                if (!error) {
+                    resolve(true);
+                }
+                //no need to call the reject here, as it will have been called in the
+                //'error' stream;
             });
-            response.data.pipe(fs.createWriteStream(filePath));
-            resolve(true);
         });
     });
 };