@7365admin1/module-hygiene 4.30.1 → 4.30.2

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@7365admin1/module-hygiene",
   "license": "MIT",
-  "version": "4.30.1",
+  "version": "4.30.2",
   "author": "7365admin1",
   "main": "dist/index.js",
   "module": "dist/index.mjs",

package/test/require-photo-on-completion.test.mjs

@@ -19,6 +19,7 @@ import test from "node:test";
 import assert from "node:assert/strict";
 import {
   COMPLETION_PHOTO_MESSAGE,
+  readCompletion,
   requiresCompletionPhoto,
 } from "./.build/completion-photo.util.mjs";
 
@@ -127,6 +128,68 @@ test("REJECTING is never blocked, even completing the set", () => {
   );
 });
 
+/* ── which approve finishes the set: ONE definition with the clients ───── */
+
+test("an approve finishes the set when every other unit is approved or rejected", () => {
+  const units = [
+    { unit: "u1", approve: true, reject: false, status: "completed" },
+    { unit: "u2", approve: false, reject: true, status: "completed" },
+    { unit: "u3", approve: false, reject: false, status: "open" },
+  ];
+  assert.equal(readCompletion(units, "u3").completesSet, true);
+  // Intermediate: another unit is still untouched.
+  assert.equal(readCompletion(units, "u1").completesSet, false);
+});
+
+test("actioned means approve/reject, NOT status — status at rest is open/closed", () => {
+  /*
+   * Staging holds units that are `closed` while approved or rejected. The units
+   * list (`isFullyActioned`) and both clients count those as done, so the photo
+   * rule must too, or the server and the screen disagree about the last tick.
+   */
+  const units = [
+    { unit: "u1", approve: true, reject: false, status: "closed" },
+    { unit: "u2", approve: false, reject: false, status: "open" },
+  ];
+  assert.equal(readCompletion(units, "u2").completesSet, true);
+
+  // And a status alone, with neither flag, is not an action.
+  const statusOnly = [
+    { unit: "u1", approve: false, reject: false, status: "completed" },
+    { unit: "u2", approve: false, reject: false, status: "open" },
+  ];
+  assert.equal(readCompletion(statusOnly, "u2").completesSet, false);
+});
+
+test("a one-unit set: its only tick finishes it; an empty set finishes nothing", () => {
+  assert.equal(readCompletion([{ unit: "u1" }], "u1").completesSet, true);
+  assert.deepEqual(readCompletion([], "u1"), {
+    completesSet: false,
+    hasEvidence: false,
+  });
+});
+
+test("ids compare as strings (ObjectId vs the route param)", () => {
+  const oid = { toString: () => "68f05fbe0c11062938dadad9" };
+  const units = [
+    { unit: oid, approve: false, reject: false },
+    { unit: "u2", approve: true, reject: false },
+  ];
+  assert.equal(
+    readCompletion(units, "68f05fbe0c11062938dadad9").completesSet,
+    true
+  );
+});
+
+test("evidence counts only OTHER units' photos", () => {
+  const units = [
+    { unit: "u1", approve: false, reject: true, attachment: ["f1"] },
+    { unit: "u2", approve: false, reject: false, attachment: [] },
+  ];
+  assert.equal(readCompletion(units, "u2").hasEvidence, true);
+  assert.equal(readCompletion(units, "u1").hasEvidence, false);
+});
+
 /* ── controls ──────────────────────────────────────────────────────────── */
 
 test("CONTROL: the rule can actually say yes", () => {