@7365admin1/module-hygiene 4.28.2-staging.10 → 4.29.0

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@7365admin1/module-hygiene",
   "license": "MIT",
-  "version": "4.28.2-staging.10",
+  "version": "4.29.0",
   "author": "7365admin1",
   "main": "dist/index.js",
   "module": "dist/index.mjs",

package/test/hygiene-checkout-decision.util.test.mjs

@@ -4,6 +4,7 @@ import test from "node:test";
 import {
   CHECKOUT_DECIDABLE_STATUS,
   CHECKOUT_DECISIONS,
+  applyCheckOutDecision,
   buildCheckOutDecision,
   isCheckOutDecision,
 } from "./.build/hygiene-checkout-decision.util.mjs";
@@ -62,3 +63,106 @@ test("the decision vocabulary is exactly the two the client calls", () => {
   assert.equal(isCheckOutDecision("reject"), false);
   assert.equal(isCheckOutDecision(""), false);
 });
+
+/*
+  Returning the drawn-down quantity to stock on a disapproval.
+
+  A fake stands in for the repository update. It behaves the way the real one
+  does: the row is decided once, and every later attempt matches nothing —
+  which the repository turns into a 404. These tests exist so that a refused
+  decision can never reach the stock call, because a second credit or a second
+  deduction is money the client cannot see going wrong.
+*/
+
+function fakeRow() {
+  let pending = true;
+  const credits = [];
+
+  return {
+    credits,
+    // Mirrors `{ _id, status: "pending" }`: decides once, then matches nothing.
+    decide: async () => {
+      if (!pending) {
+        throw new Error(
+          "Check out item not found or is no longer pending approval.",
+        );
+      }
+      pending = false;
+      return 1;
+    },
+    returnStock: async () => {
+      credits.push(1);
+    },
+  };
+}
+
+test("a disapproval returns the quantity to stock exactly once", async () => {
+  const row = fakeRow();
+
+  assert.equal(
+    await applyCheckOutDecision("disapprove", row.decide, row.returnStock),
+    1,
+  );
+  assert.deepEqual(row.credits, [1]);
+});
+
+test("an approval moves no stock", async () => {
+  const row = fakeRow();
+
+  await applyCheckOutDecision("approve", row.decide, row.returnStock);
+
+  assert.deepEqual(row.credits, []);
+});
+
+test("disapproving twice does not credit stock twice", async () => {
+  const row = fakeRow();
+
+  await applyCheckOutDecision("disapprove", row.decide, row.returnStock);
+
+  await assert.rejects(
+    () => applyCheckOutDecision("disapprove", row.decide, row.returnStock),
+    /no longer pending/,
+  );
+
+  assert.deepEqual(row.credits, [1]);
+});
+
+test("approving after a disapproval is refused, so nothing is deducted again", async () => {
+  const row = fakeRow();
+
+  await applyCheckOutDecision("disapprove", row.decide, row.returnStock);
+
+  await assert.rejects(
+    () => applyCheckOutDecision("approve", row.decide, row.returnStock),
+    /no longer pending/,
+  );
+
+  assert.deepEqual(row.credits, [1]);
+});
+
+test("a decision that matched no row never reaches the stock call", async () => {
+  const credits = [];
+
+  const decided = await applyCheckOutDecision(
+    "disapprove",
+    async () => 0,
+    async () => credits.push(1),
+  );
+
+  assert.equal(decided, 0);
+  assert.deepEqual(credits, []);
+});
+
+test("a failed stock return propagates, so the caller can abort the transaction", async () => {
+  await assert.rejects(
+    () =>
+      applyCheckOutDecision(
+        "disapprove",
+        async () => 1,
+        async () => {
+          throw new Error("Supply not found.");
+        },
+      ),
+    /Supply not found/,
+  );
+});

package/.changeset/hygiene-checkout-approval.md

@@ -1,5 +0,0 @@
----
-"@7365admin1/module-hygiene": minor
----
-
-Add approve / disapprove to hygiene check out items (repository, controller and decision util).