@7365admin1/module-hygiene 4.28.1-staging.9 → 4.28.2-staging.10

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@7365admin1/module-hygiene",
   "license": "MIT",
-  "version": "4.28.1-staging.9",
+  "version": "4.28.2-staging.10",
   "author": "7365admin1",
   "main": "dist/index.js",
   "module": "dist/index.mjs",
@@ -13,7 +13,7 @@
     "build": "tsup src/index.ts --format cjs,esm --dts",
     "release": "yarn run build && changeset publish",
     "lint": "tsc",
-    "test": "tsup src/utils/hygiene-dashboard-metrics.util.ts --format esm --out-dir test/.build --no-dts --silent && node --test \"test/*.test.mjs\""
+    "test": "tsup src/utils/hygiene-dashboard-metrics.util.ts src/utils/hygiene-checkout-decision.util.ts --format esm --out-dir test/.build --no-dts --silent && node --test \"test/*.test.mjs\""
   },
   "devDependencies": {
     "@changesets/cli": "^2.26.0",
@@ -27,7 +27,7 @@
     "typescript": "^4.9.4"
   },
   "dependencies": {
-    "@7365admin1/core": "^3.41.0",
+    "@7365admin1/core": "^3.50.1",
     "@7365admin1/node-server-utils": "^1.6.0",
     "@types/qrcode": "^1.5.6",
     "@types/urllib": "^2.33.0",

package/test/hygiene-checkout-decision.util.test.mjs

@@ -0,0 +1,64 @@
+import assert from "node:assert/strict";
+import test from "node:test";
+
+import {
+  CHECKOUT_DECIDABLE_STATUS,
+  CHECKOUT_DECISIONS,
+  buildCheckOutDecision,
+  isCheckOutDecision,
+} from "./.build/hygiene-checkout-decision.util.mjs";
+
+/*
+  The check out item approval decision, without a database.
+
+  These assertions pin the two things the repository relies on: the `$set` the
+  decision produces, and the status the update must MATCH on. If the second one
+  is ever dropped, approving an already-decided item stops being a refusal and
+  starts silently overwriting the first decision — which is the failure the
+  match filter exists to prevent.
+*/
+
+const NOW = "2026-09-04T09:00:00.000Z";
+
+test("approving flips the row to completed and records approve, not reject", () => {
+  const set = buildCheckOutDecision("approve", null, NOW);
+
+  assert.equal(set.status, "completed");
+  assert.equal(set.approve, true);
+  assert.equal(set.reject, false);
+  assert.equal(set.updatedAt, NOW);
+});
+
+test("disapproving also terminates the row, and keeps the remarks", () => {
+  const set = buildCheckOutDecision("disapprove", "wrong item drawn", NOW);
+
+  assert.equal(set.status, "completed");
+  assert.equal(set.approve, false);
+  assert.equal(set.reject, true);
+  assert.equal(set.remarks, "wrong item drawn");
+});
+
+test("remarks are never undefined — an absent remark is an empty string", () => {
+  assert.equal(buildCheckOutDecision("approve", undefined, NOW).remarks, "");
+  assert.equal(buildCheckOutDecision("approve", null, NOW).remarks, "");
+});
+
+test("no third status value enters the vocabulary", () => {
+  // `allowedCheckOutItemStatus` is ["pending", "completed"]. A decision must
+  // land inside it, whichever way it goes.
+  for (const decision of CHECKOUT_DECISIONS) {
+    assert.equal(buildCheckOutDecision(decision, "", NOW).status, "completed");
+  }
+});
+
+test("only a pending row is decidable", () => {
+  assert.equal(CHECKOUT_DECIDABLE_STATUS, "pending");
+});
+
+test("the decision vocabulary is exactly the two the client calls", () => {
+  assert.deepEqual([...CHECKOUT_DECISIONS], ["approve", "disapprove"]);
+  assert.ok(isCheckOutDecision("approve"));
+  assert.ok(isCheckOutDecision("disapprove"));
+  assert.equal(isCheckOutDecision("reject"), false);
+  assert.equal(isCheckOutDecision(""), false);
+});

package/.changeset/hygiene-dashboard-metrics.md

@@ -1,29 +0,0 @@
----
-"@7365admin1/module-hygiene": patch
----
-
-Hygiene dashboard metrics: report the selected period honestly instead of fabricating figures
-
-The dashboard's metric calculations were computed inline inside
-`hygiene-dashboard.repository.ts` and were wrong in four ways. They now live in
-`src/utils/hygiene-dashboard-metrics.util.ts`, covered by unit tests (`yarn test`),
-so a change to a metric fails a test rather than a screen. What a consumer of the
-dashboard endpoints sees change:
-
-- **Trend comparisons follow the selected period.** The "vs previous" figure was
-  always computed against yesterday, whatever range the user picked, so a
-  month-to-month comparison was really a day-to-day one. It now compares the
-  selected period against the period immediately before it.
-- **Day boundaries are Singapore time.** Period start/end were taken from the
-  server host's midnight, so a host on UTC put work into the wrong day. All
-  boundaries are now computed in `Asia/Singapore`.
-- **No invented percentages on an empty prior period.** When the previous period
-  had no data, the change was reported as `100%` (or `0`) as if measured. It now
-  returns `null`, so the UI can show "no comparison available" rather than a
-  number nobody can reproduce.
-- **The supply alert percentage is no longer hard-coded.** It was emitted as a
-  fixed value regardless of stock; it is now derived, and reports its reason when
-  there is no prior period to compare against.
-
-No API surface changes and no consumer code change is required — the same fields
-are returned, with `null` now possible where a comparison genuinely cannot be made.