@7365admin1/layer-common 4.97.0 → 4.97.1-staging.501

package/utils/hid-enrolment-subject.ts

@@ -0,0 +1,366 @@
+/**
+ * WHO A HID ENROLMENT IS FOR — the pure decisions behind the subject picker.
+ *
+ * `HidUserEnrollment.vue` can enrol a resident or a staff member. The write path
+ * always carried both (`subjectLink` maps them onto `person` or `member`); what
+ * was missing was a way to choose. These are the parts of that choice worth
+ * testing on their own, kept here because a `.vue` component has no test harness
+ * in this repo.
+ */
+
+/**
+ * What the ENROLLING dropdown offers. Three of these four are the server's own
+ * permission categories; `service_provider_staff` is this screen's own value
+ * and deliberately not one of them - see `subjectLinkOf`.
+ */
+export type HidEnrolmentSubject =
+  | "resident"
+  | "property_management"
+  | "service_provider_staff";
+
+/**
+ * The dropdown's options, in the order they are drawn.
+ *
+ * `title`/`value` because `AppSelect` takes that shape.
+ */
+export const HID_ENROLMENT_SUBJECTS: ReadonlyArray<{
+  title: string;
+  value: HidEnrolmentSubject;
+}> = [
+  { title: "Resident", value: "resident" },
+  { title: "Member", value: "property_management" },
+  { title: "Service provider", value: "service_provider_staff" },
+];
+
+/**
+ * What an EDIT calls the subject it is already attached to.
+ *
+ * Wider than the dropdown on purpose. An identity's category cannot change after
+ * it is created, so an edit states it rather than offering it — and the records
+ * in the wild include `service_provider`, which the dropdown does not offer yet
+ * but `openEdit` does resolve. Falling back to the first option would label a
+ * contractor "Resident", which is worse than saying nothing useful.
+ */
+export function subjectCategoryLabel(category: unknown): string {
+  const labels: Record<string, string> = {
+    resident: "Resident",
+    property_management: "Member",
+    // The dropdown's own value: ONE PERSON from a provider company.
+    service_provider_staff: "Service provider",
+    // The server's category, which names a COMPANY. Records in the wild carry
+    // it, and an edit must not call such a row a resident.
+    service_provider: "Service provider",
+    visitor: "Visitor",
+  };
+  return labels[String(category ?? "")] ?? "Unknown";
+}
+
+/**
+ * One page of `GET /api/members`, read defensively.
+ *
+ * `paginate` puts `{ items, pages }` at the root, but `items` sits under `data`
+ * on some of this product's endpoints, so both are read — the same allowance
+ * `readCandidatePage` makes. A response that carries neither is an empty page
+ * rather than a thrown error: an empty staff picker with a placeholder beats a
+ * broken dialog.
+ */
+export function readMemberPage(response: unknown): {
+  items: Record<string, unknown>[];
+  pages: number;
+  total: number;
+} {
+  const source = (response && typeof response === "object" ? response : {}) as Record<string, unknown>;
+  const nested = (source.data && typeof source.data === "object" ? source.data : {}) as Record<string, unknown>;
+  const raw = Array.isArray(source.items)
+    ? source.items
+    : Array.isArray(nested.items)
+      ? nested.items
+      : [];
+  const pages = Number(source.pages ?? nested.pages ?? 1);
+  const items = raw.filter((row): row is Record<string, unknown> => Boolean(row) && typeof row === "object");
+  /*
+   * `total` drives "showing 10 of 23" and the Load more button. It falls back to
+   * the page's own length, not to zero, so a response without it simply reads as
+   * "this is everything" — a missing count must never make the button offer a
+   * page that is not there.
+   */
+  const total = Number(source.total ?? nested.total ?? items.length);
+  return {
+    items,
+    pages: Number.isFinite(pages) && pages > 0 ? Math.floor(pages) : 1,
+    total: Number.isFinite(total) && total >= 0 ? Math.floor(total) : items.length,
+  };
+}
+
+/**
+ * Can this member actually be enrolled?
+ *
+ * Reader access is bound by USER id — `resolvePermissionUserBindings` in
+ * `iservice365-core` drops every subject without one — so a member with no app
+ * account cannot be given access and is not a candidate. The id arrives as a
+ * string from JSON but may be an object if a caller passes a raw document, so
+ * both are read rather than trusting the shape.
+ */
+export function memberHasAccount(row: Record<string, unknown> | null | undefined): boolean {
+  const user = row?.user;
+  if (!user) return false;
+  if (typeof user === "object") {
+    const id = (user as { _id?: unknown; toString?: () => string })._id ?? user;
+    return Boolean(String(id ?? "").trim());
+  }
+  return Boolean(String(user).trim());
+}
+
+/**
+ * How a member reads in the picker: their name, and their role beneath it.
+ *
+ * THE ACCOUNT'S NAME FIRST, then the membership's. The two diverge — a
+ * membership is created with whatever name was typed at invite time, and the
+ * person may have set their own on the account since — and the account name is
+ * the one they are known by. `userName` comes from the members endpoint's own
+ * lookup into `users`; a member with no account has none, but such a row is not
+ * a candidate anyway (`memberHasAccount`).
+ *
+ * Every step falls back, because a row with no name at all still has to be
+ * selectable rather than blank, or it cannot be told apart from the next one.
+ */
+export function memberCandidateOf(row: Record<string, unknown>): {
+  subjectId: string;
+  name: string;
+  subtitle: string;
+} {
+  const text = (value: unknown) => String(value ?? "").trim();
+  return {
+    subjectId: text(row._id),
+    name: text(row.userName) || text(row.name) || text(row.email) || "Member",
+    subtitle: text(row.roleName) || text(row.email) || "",
+  };
+}
+
+/**
+ * Why somebody the operator can see elsewhere is not in this list.
+ *
+ * Left unexplained, an absence reads as a broken screen — the same reason the
+ * resident cascade carries `unitResidentNote`. Returns "" when there is nothing
+ * to say, so the caller can render it unconditionally.
+ */
+export function hiddenSubjectNote(count: number, noun: "resident" | "member"): string {
+  if (!Number.isFinite(count) || count <= 0) return "";
+  const whole = Math.floor(count);
+  const subject = whole === 1 ? `1 ${noun}` : `${whole} ${noun}s`;
+  const verb = whole === 1 ? "is" : "are";
+  const holder = whole === 1 ? "that person has" : "they have";
+  return `${subject} at this site ${verb} not listed:`
+    + ` HID enrollment needs an app account, and ${holder} none yet.`;
+}
+
+/* ── THE LINK THAT REACHES THE DEVICE ──────────────────────────────────── */
+
+/**
+ * WHICH SUBJECT FIELD AN ENROLMENT WRITES, and what the identity is called.
+ *
+ * This is the one decision in the dialog that changes who a door lets in, so it
+ * lives here with tests rather than inline in the template's script.
+ *
+ * `service_provider_staff` links through `member`, NOT `serviceProvider`, and
+ * that is the whole design:
+ *
+ * - `serviceProvider` names a `site.service-providers` row, which is a COMPANY.
+ *   `resolvePermissionUserBindings` expands one into every active member of
+ *   that organisation with NO site filter, so granting it puts a 200-person
+ *   firm on a door that eight of them attend.
+ * - A provider employee's membership lives in `members` with `siteId` set to
+ *   this site - `members` carries a unique index on `{org, siteId, user, type}`,
+ *   so it cannot exist there without one. That makes the person site-scoped by
+ *   construction, which is the whole point.
+ *
+ * The identity `type` is `"contractor"` rather than `"staff"`, and it is load
+ * bearing on the server as well as here: core's `permissionSubjectOfIdentity`
+ * reads it to tell a contractor's `member` link from a property-management one,
+ * and files the grant under `service_provider_member` or `property_management`
+ * accordingly. It is also what the Access Permissions tabs filter on.
+ *
+ * An earlier version filed provider staff under `property_management`, since that
+ * category's subject list already accepts these rows. It worked for access and
+ * failed for identity: `permissionIdentityType` derives the identity's type from
+ * the category, so every contractor came back as `staff` - and because the
+ * reconcile rewrites the identity it finds, the `"contractor"` written here was
+ * overwritten seconds later.
+ *
+ * An empty `subjectId` returns `{}` ON PURPOSE. Sending `person: ""` is not
+ * "leave this alone", it is "clear it": the server reads an empty string as the
+ * link being removed and then refuses the write for having no subject at all.
+ */
+export function subjectLinkOf(
+  category: unknown,
+  subjectId: unknown,
+): {
+  person?: string;
+  member?: string;
+  serviceProvider?: string;
+  type?: "resident" | "staff" | "contractor";
+} {
+  const id = String(subjectId ?? "").trim();
+  if (!id) return {};
+  const of = (
+    field: "person" | "member" | "serviceProvider",
+    type: "resident" | "staff" | "contractor",
+  ) => ({
+    person: field === "person" ? id : "",
+    member: field === "member" ? id : "",
+    serviceProvider: field === "serviceProvider" ? id : "",
+    type,
+  });
+  switch (String(category ?? "")) {
+    case "resident":
+      return of("person", "resident");
+    case "service_provider_staff":
+      return of("member", "contractor");
+    case "service_provider":
+      return of("serviceProvider", "contractor");
+    default:
+      return of("member", "staff");
+  }
+}
+
+/**
+ * Which PERMISSION CATEGORY an enrolment's access grant is stored under.
+ *
+ * Mirrors `permissionSubjectOfIdentity` in core, which reads the stored links
+ * rather than this dropdown: a `member` link resolves to `property_management`
+ * whatever the identity's `type` says. Provider staff therefore share the staff
+ * category, which is correct - they are validated against the same subject list
+ * - and the identity `type` is what tells them apart on screen.
+ */
+export function permissionCategoryOf(category: unknown): string {
+  const value = String(category ?? "");
+  if (value === "resident") return "resident";
+  if (value === "service_provider") return "service_provider";
+  if (value === "service_provider_staff") return "service_provider_member";
+  return "property_management";
+}
+
+/**
+ * The dropdown value for a grant's category — the inverse of
+ * `permissionCategoryOf`.
+ *
+ * An edit STATES the subject type rather than offering it, because an identity's
+ * category cannot change after it is created. This is how a stored record is
+ * turned back into the value the form holds, and it is wider than the dropdown on
+ * purpose: records in the wild carry `service_provider`, which names a COMPANY
+ * and which the dropdown does not offer.
+ *
+ * Paired with `subjectOfIdentity` so the mapping lives in one place. `openEdit`
+ * used to repeat the whole links-and-type ternary inline, which is how the copy
+ * in `HidAccessPermissions.vue` was able to go stale without anything noticing.
+ */
+export function enrolmentSubjectOfCategory(category: unknown): string {
+  const value = String(category ?? "");
+  if (value === "resident") return "resident";
+  if (value === "service_provider_member") return "service_provider_staff";
+  if (value === "service_provider") return "service_provider";
+  return "property_management";
+}
+
+/* ── PROVIDER STAFF AS PICKER ROWS ─────────────────────────────────────── */
+
+/**
+ * Can this provider employee be enrolled?
+ *
+ * Two conditions, and both have to be checked here rather than trusted from the
+ * list. An app account, because reader access is bound by user id
+ * (`memberHasAccount`). And an ACTIVE membership: `getProviderMembersBySite`
+ * returns everyone who is not deleted, so a suspended person is in the list the
+ * Members screen draws - marked, deliberately, so the property manager can see
+ * them. Offering a suspended person a door is a different matter.
+ */
+export function providerCanEnrol(
+  row: Record<string, unknown> | null | undefined,
+): boolean {
+  if (!memberHasAccount(row)) return false;
+  return String(row?.status ?? "").trim() === "active";
+}
+
+/**
+ * How a provider employee reads in the picker: their name, their company and
+ * the service beneath it.
+ *
+ * The company comes FIRST in the subtitle. Two contractors with the same first
+ * name are common, and which firm somebody belongs to is what the property
+ * manager actually recognises them by - the service type alone ("Security")
+ * describes half the list.
+ */
+export function providerCandidateOf(row: Record<string, unknown>): {
+  subjectId: string;
+  name: string;
+  subtitle: string;
+} {
+  const text = (value: unknown) => String(value ?? "").trim();
+  const parts = [text(row.company), text(row.typeLabel)].filter(Boolean);
+  return {
+    subjectId: text(row._id),
+    name: text(row.name) || text(row.email) || "Service provider",
+    subtitle: parts.join(" · ") || text(row.role) || text(row.email) || "",
+  };
+}
+
+/**
+ * Does this list tell us who has an app account?
+ *
+ * `GET /api/service-providers/site-members` only began returning `user` in core
+ * 3.130; before that the service layer dropped it even though the repository
+ * projected it. Frontend and backend deploy separately, so this screen can run
+ * against either. Asked of the ROWS rather than of a version number: the key is
+ * present on every row or on none.
+ *
+ * It matters because the answer flips a filter from "cannot be bound to a door"
+ * to "unknown", and a screen that silently reports NOBODY can be enrolled is
+ * worse than one that offers somebody the server then refuses by name.
+ */
+export function providerAccountsKnown(
+  rows: ReadonlyArray<Record<string, unknown>>,
+): boolean {
+  return rows.some((row) => Boolean(row) && typeof row === "object" && "user" in row);
+}
+
+/**
+ * Who may be offered a door, from whatever the endpoint returned.
+ *
+ * With accounts known, both conditions apply (`providerCanEnrol`). Without them,
+ * active membership is all that can be checked here — the server still refuses
+ * anyone it cannot bind, with a message naming them, which is a better failure
+ * than an empty picker.
+ */
+export function providerEnrollableRows<T extends Record<string, unknown>>(
+  rows: ReadonlyArray<T>,
+): T[] {
+  const known = providerAccountsKnown(rows);
+  return rows.filter((row) =>
+    known ? providerCanEnrol(row) : String(row?.status ?? "").trim() === "active",
+  );
+}
+
+/* ── THE SERVICE FILTER'S "ALL" ────────────────────────────────────────── */
+
+/**
+ * WHY "ALL SERVICES" CANNOT BE THE EMPTY STRING HERE.
+ *
+ * `filterProviderMembers` reads an empty `type` as "do not filter", and the
+ * Members screen's own filter uses `value: ""` for All services - but that screen
+ * draws a Vuetify `v-select`, which renders an empty value perfectly well.
+ *
+ * `AppSelect` does not. Its `hasSingleValue` is false for `""`, so the field
+ * falls back to the placeholder, draws in the placeholder's grey, and the option
+ * is never marked as the chosen one in the menu. The filter worked; it just
+ * looked like nothing was selected and like only the real services existed.
+ *
+ * So the option carries a real value here and is translated on the way to the
+ * filter. Changing `AppSelect` instead would touch every one of its callers.
+ */
+export const HID_ALL_SERVICES = "all";
+
+/** The `type` to filter by: "" for All services, the service code otherwise. */
+export function serviceFilterOf(selected: unknown): string {
+  const value = String(selected ?? "").trim();
+  return value === HID_ALL_SERVICES ? "" : value;
+}

package/utils/hid-permission-assignments.ts

@@ -0,0 +1,259 @@
+/**
+ * WHO IS ASSIGNED TO A HID READER — the editing model behind the permissions
+ * dialog.
+ *
+ * This is the step that actually grants access. Enrolling a person gives the
+ * reader a face, a card or a PIN it can RECOGNISE; it puts nobody in the group
+ * the access rule is attached to, so a recognised person is still refused at
+ * the door (access log event 6). `PUT /sites/:siteId/permissions` is the only
+ * call in the system that writes that group membership.
+ *
+ * Two contracts make this file necessary rather than inlining the logic in the
+ * component:
+ *
+ * 1. **The PUT REPLACES the whole assignment set for the reader.** The server
+ *    keeps other readers' rows and overwrites this reader's with exactly what
+ *    is sent. The candidate list, however, is fetched ONE CATEGORY AT A TIME.
+ *    Saving from the tab in front of you while sending only that tab's people
+ *    would silently revoke every resident if you were looking at the service
+ *    providers tab. So the edit state is held for the whole reader and the
+ *    payload is always built from all of it.
+ *
+ * 2. **The body schema accepts three keys and nothing else.**
+ *    `hidPermissionAssignmentSchema` is `{ subjectId, category, intercom }`,
+ *    and Joi rejects unknown keys rather than stripping them. The candidate
+ *    rows carry `name`, `subtitle`, `location` and friends for display, so the
+ *    payload has to be narrowed deliberately — passing a candidate straight
+ *    through is a 400.
+ */
+
+/**
+ * The real categories. `intercom` is a candidate FILTER, never a category.
+ *
+ * Mirrors `HID_PERMISSION_CATEGORIES` in core, and has to: `seedAssignments`
+ * DROPS a row whose category is not in this list, so a category missing here
+ * silently loses that grant from the edit state - and the save that follows,
+ * being a whole-reader replace, would revoke it.
+ */
+export const HID_PERMISSION_CATEGORIES: THidPermissionCategory[] = [
+  "resident",
+  "property_management",
+  "service_provider",
+  "service_provider_member",
+];
+
+export type HidAssignmentState = Map<string, { category: THidPermissionCategory; intercom: boolean }>;
+
+/** Body row for `updateSitePermissions` — exactly the keys Joi allows. */
+export type HidAssignmentPayload = {
+  subjectId: string;
+  category: THidPermissionCategory;
+  intercom: boolean;
+};
+
+function isRealCategory(value: unknown): value is THidPermissionCategory {
+  return HID_PERMISSION_CATEGORIES.includes(value as THidPermissionCategory);
+}
+
+/**
+ * The reader's CURRENT assignments, as the edit state.
+ *
+ * Seeded from `getSitePermissions`, which returns every category at once —
+ * that is what makes a whole-reader payload possible from a one-category view.
+ * Rows with an unrecognised category are dropped rather than carried: sending
+ * one back fails the enum check and takes the entire save with it.
+ */
+export function seedAssignments(
+  assignments: readonly THidPermissionAssignment[] | undefined | null,
+): HidAssignmentState {
+  const state: HidAssignmentState = new Map();
+  if (!Array.isArray(assignments)) return state;
+  for (const assignment of assignments) {
+    const subjectId = String(assignment?.subjectId ?? "");
+    if (!subjectId || !isRealCategory(assignment?.category)) continue;
+    state.set(subjectId, {
+      category: assignment.category,
+      intercom: assignment.intercom === true,
+    });
+  }
+  return state;
+}
+
+/**
+ * Add or remove one person.
+ *
+ * `saved` is the state the dialog opened with, and it is consulted for one
+ * reason: the `intercom` flag. Nothing here edits that flag, but
+ * `userHasSiteIntercomPermission` reads it off these same rows, so it must
+ * survive a round trip through the checkbox.
+ *
+ * - **Untick then save** drops it, which is right — an unassigned person
+ *   holding a dangling intercom right would keep answering the door panel
+ *   after losing the door.
+ * - **Untick then re-tick, without saving** must restore it. Removing from the
+ *   draft forgets the flag, so re-adding recovers it from `saved`; otherwise a
+ *   misclick corrected a second later would silently revoke intercom on the
+ *   next save, with nothing on screen to show it had happened.
+ */
+export function setAssignment(
+  state: HidAssignmentState,
+  saved: HidAssignmentState,
+  subjectId: string,
+  category: THidPermissionCategory,
+  selected: boolean,
+): HidAssignmentState {
+  const next: HidAssignmentState = new Map(state);
+  const id = String(subjectId ?? "");
+  if (!id || !isRealCategory(category)) return next;
+  if (!selected) {
+    next.delete(id);
+    return next;
+  }
+  const intercom = next.get(id)?.intercom ?? saved.get(id)?.intercom ?? false;
+  next.set(id, { category, intercom: intercom === true });
+  return next;
+}
+
+/** The whole reader's assignments, narrowed to the three keys the API accepts. */
+export function toAssignmentPayload(state: HidAssignmentState): HidAssignmentPayload[] {
+  return [...state.entries()].map(([subjectId, value]) => ({
+    subjectId,
+    category: value.category,
+    intercom: value.intercom === true,
+  }));
+}
+
+/**
+ * The server sends `selected` with each candidate, describing what is SAVED.
+ * Once the dialog is open the local edit state is the truth, so the flag is
+ * recomputed rather than trusted — otherwise paging or searching would redraw
+ * a row with the saved value and quietly discard an unsaved tick.
+ */
+export function applySelection(
+  candidates: readonly THidPermissionCandidate[] | undefined | null,
+  state: HidAssignmentState,
+): THidPermissionCandidate[] {
+  if (!Array.isArray(candidates)) return [];
+  return candidates.map((candidate) => ({
+    ...candidate,
+    selected: state.has(String(candidate?.subjectId ?? "")),
+  }));
+}
+
+/** Per-category totals for the dialog header, counted over the whole reader. */
+export function countByCategory(state: HidAssignmentState): Record<THidPermissionCategory, number> {
+  /*
+   * Every category seeded at zero, and the increment guarded.
+   * `counts[category] += 1` on a key this object does not hold yields NaN, so a
+   * category added to the union but missed here would print "NaN" beside a tab
+   * rather than a number. That is exactly what happened when
+   * `service_provider_member` was added.
+   */
+  const counts = HID_PERMISSION_CATEGORIES.reduce(
+    (seeded, category) => ({ ...seeded, [category]: 0 }),
+    {} as Record<THidPermissionCategory, number>,
+  );
+  for (const value of state.values()) {
+    counts[value.category] = (counts[value.category] ?? 0) + 1;
+  }
+  return counts;
+}
+
+/** Has anything changed since the dialog opened? Drives the Save button. */
+export function hasChanges(saved: HidAssignmentState, draft: HidAssignmentState): boolean {
+  if (saved.size !== draft.size) return true;
+  for (const [subjectId, value] of draft) {
+    const before = saved.get(subjectId);
+    if (!before) return true;
+    if (before.category !== value.category) return true;
+    if (before.intercom !== value.intercom) return true;
+  }
+  return false;
+}
+
+/**
+ * What a listing response tells us: the rows, and how many pages exist.
+ *
+ * It deliberately does NOT return the current page, and the caller must keep
+ * owning that. `paginate` in `@7365admin1/node-server-utils` returns only
+ * `{ items, pages, pageRange }` — it never echoes the page it was asked for. A
+ * caller that read one back therefore got a default on every fetch and pinned
+ * itself to page one, so the pager moved and the rows never did.
+ *
+ * `items` sits at the root on some of these endpoints and under `data` on
+ * others, so both are read.
+ */
+export function readCandidatePage(response: unknown): {
+  items: THidPermissionCandidate[];
+  pages: number;
+  pageRange: string;
+} {
+  const source = (response && typeof response === "object" ? response : {}) as Record<string, unknown>;
+  const nested = (source.data && typeof source.data === "object" ? source.data : {}) as Record<string, unknown>;
+  const items = Array.isArray(source.items)
+    ? source.items
+    : Array.isArray(nested.items)
+      ? nested.items
+      : [];
+  const pages = Number(source.pages ?? nested.pages ?? 1);
+  // `paginate` builds this ("1-10 of 37") and the table renders it verbatim.
+  // Without it the pager draws its placeholder, "-- - -- of --".
+  const pageRange = String(source.pageRange ?? nested.pageRange ?? "");
+  return {
+    items: items as THidPermissionCandidate[],
+    pages: Number.isFinite(pages) && pages > 0 ? pages : 1,
+    pageRange,
+  };
+}
+
+/* ── THE SUBJECT AN IDENTITY NAMES ─────────────────────────────────────── */
+
+/**
+ * WHICH GRANT AN ENROLLED PERSON'S ACCESS IS FILED UNDER.
+ *
+ * Mirrors `permissionSubjectOfIdentity` in core, which is the authority. This
+ * repository cannot import it - layer-common does not depend on the core
+ * package - so there is a copy, and the point of putting it HERE is that there
+ * is only one.
+ *
+ * There used to be two: a local `subjectOf` in `HidAccessPermissions.vue` and
+ * the same ternary inline in `HidUserEnrollment.vue`. The first was stale. It
+ * read every `member` link as `property_management`, so granting a contractor
+ * from the permissions screen wrote a staff assignment - and the reconcile then
+ * derived `staff` from that category and rewrote the identity's `type`, moving
+ * the person out of the service-provider tab and into the member one. The
+ * screen for managing contractors reclassified them by being used.
+ *
+ * A `member` link is how BOTH a property-management member and a service
+ * provider's own employee are stored - the person's membership at this site -
+ * so the identity's `type` is the discriminator. `"contractor"` is written by
+ * the enrolment form and re-confirmed by `permissionIdentityType` on every
+ * reconcile, so the two agree instead of one overwriting the other.
+ *
+ * Returns null for a visitor and for an identity linked to nobody. Visitor
+ * access comes from `user_access_rules` rather than a group, so there is nothing
+ * to switch; an identity holding only an account link names no subject to
+ * assign. Both are still DRAWN by the permissions screen, disabled, with a
+ * reason - dropping them silently is what once made the pager say "1-9 of 9"
+ * over seven rows.
+ */
+export function subjectOfIdentity(
+  identity: Record<string, unknown> | null | undefined,
+): { subjectId: string; category: THidPermissionCategory } | null {
+  if (!identity) return null;
+  if (identity.person) {
+    return { subjectId: String(identity.person), category: "resident" };
+  }
+  if (identity.member) {
+    return {
+      subjectId: String(identity.member),
+      category: String(identity.type ?? "") === "contractor"
+        ? "service_provider_member"
+        : "property_management",
+    };
+  }
+  if (identity.serviceProvider) {
+    return { subjectId: String(identity.serviceProvider), category: "service_provider" };
+  }
+  return null;
+}

package/utils/hid-reader-selection.ts

@@ -0,0 +1,52 @@
+/**
+ * WHICH HID READER THE OPERATOR IS WORKING ON — the one rule behind it.
+ *
+ * Every HID screen used to hold its own `ref("")` and default it to
+ * `readers[0]`, so picking HID 2 on HID Reader Users and clicking through to
+ * HID Cards put you back on HID 1. They are separate PAGES, so the component
+ * unmounted and the ref was rebuilt from scratch every time — there was no way
+ * to make a choice stick. "I am working on HID 2" is a mode, not a per-screen
+ * preference.
+ *
+ * Navigation between those pages is a route change rather than a page load
+ * (`NavigationItem.vue` renders the menu's `route` through `:to`), so the
+ * module-scoped ref in `useHidReaderSelection` survives it. This file holds the
+ * part worth testing: deciding whether a remembered choice may still be used.
+ */
+
+export type HidReaderChoice = { siteId: string; readerId: string };
+
+/** Anything with an id — the four screens all carry a different reader shape. */
+type ReaderLike = { _id?: unknown };
+
+export const EMPTY_HID_READER_CHOICE: HidReaderChoice = { siteId: "", readerId: "" };
+
+/**
+ * The reader a screen should show, given what this site actually has.
+ *
+ * A remembered id is honoured ONLY when it belongs to this site and is still in
+ * the list. That single condition covers every way it goes stale:
+ *
+ * - the operator switched site, so the id belongs to a site they have left
+ * - the reader was deleted or deactivated since they chose it
+ * - nothing has been chosen yet
+ *
+ * In all three the first reader is returned instead. The alternative — using
+ * the id anyway — sends requests for a reader the site does not own, which come
+ * back empty and read on screen as a reader with no users, no cards and no
+ * logs, rather than as the mistake it is.
+ */
+export function resolveHidReaderId(
+  siteId: string,
+  readers: readonly ReaderLike[] | null | undefined,
+  choice: HidReaderChoice = EMPTY_HID_READER_CHOICE,
+): string {
+  const ids = (Array.isArray(readers) ? readers : [])
+    .map((reader) => String(reader?._id ?? ""))
+    .filter(Boolean);
+
+  if (choice.siteId === String(siteId ?? "") && ids.includes(choice.readerId)) {
+    return choice.readerId;
+  }
+  return ids[0] ?? "";
+}