@7365admin1/layer-common 4.2.9-staging.277 → 4.2.9-staging.279

package/components/VehicleForm.vue

@@ -54,6 +54,21 @@
             </v-combobox>
           </v-col>
 
+          <!--
+            The `:key` remount exists for ONE case: an edit dialog opens with a
+            block/level/unit already stored, `withUnresolved` shows
+            "Loading unit..." until the list arrives, and Vuetify needs the
+            remount to swap in the real name. `&& vehicle.<field>` limits it to
+            exactly that case.
+
+            Without the guard it also fired on an EMPTY field: pick a Block, the
+            level list refetches, `levelListDataPending` flips, the key changes,
+            and Vue destroys and recreates the Level autocomplete underneath the
+            person using it - discarding whatever they had typed to filter it and
+            taking the open menu with it. That is the "eats keystrokes" half of
+            the Season Pass dialog report. An empty field has nothing unresolved
+            to redraw, so it has nothing to gain from the remount.
+          -->
           <v-col v-if="shouldShowField('block')" cols="12">
             <InputLabel class="text-capitalize" title="Block" required />
             <v-autocomplete
@@ -61,7 +76,9 @@
               :items="blockItems"
               autocomplete="off"
               :key="
-                blockListDataPending ? 'block-list-pending' : 'block-list-ready'
+                blockListDataPending && vehicle.block
+                  ? 'block-list-pending'
+                  : 'block-list-ready'
               "
               :loading="blockListDataPending"
               item-value="value"
@@ -79,7 +96,9 @@
               :items="levelItems"
               autocomplete="off"
               :key="
-                levelListDataPending ? 'level-list-pending' : 'level-list-ready'
+                levelListDataPending && vehicle.level
+                  ? 'level-list-pending'
+                  : 'level-list-ready'
               "
               :loading="levelListDataPending"
               density="comfortable"
@@ -96,7 +115,9 @@
               :items="unitItems"
               autocomplete="off"
               :key="
-                unitListDataPending ? 'unit-list-pending' : 'unit-list-ready'
+                unitListDataPending && vehicle.unit
+                  ? 'unit-list-pending'
+                  : 'unit-list-ready'
               "
               :loading="unitListDataPending"
               density="comfortable"
@@ -881,10 +902,18 @@ async function submit() {
 
   processing.value = true;
   try {
+    // Whitespace only. This used to be
+    // `charAt(0).toUpperCase() + slice(1).toLowerCase()`, which re-cased the
+    // WHOLE string: picking "Resident Season Pass" from the list saved
+    // "Resident season pass", and "VIP/Preferred Parking Pass" saved
+    // "Vip/preferred parking pass". Because the combobox adds any value it does
+    // not recognise as a new custom type, the re-cased copy came back as a
+    // SECOND entry in the list next to the original - which is how the Season
+    // Pass Type chooser stacked up near-duplicate options. The value the person
+    // picked is the value that is stored.
     const SPTVal = vehicle?.seasonPassType as string;
     if (SPTVal) {
-      vehicle.seasonPassType =
-        SPTVal?.charAt(0)?.toUpperCase() + SPTVal?.slice(1)?.toLowerCase();
+      vehicle.seasonPassType = SPTVal.trim();
     }
 
     const {

package/components/VisitorManagement.vue

@@ -2034,15 +2034,27 @@ const selectedVisitorObject = computed<Record<string, any>>(() => {
   ];
   includedKeys.unshift(...(typeFieldMap[type] ?? []));
 
-  let locationString = "N/A";
-
-  if (obj?.block?.name || obj?.level?.name || obj?.unitName) {
-    locationString = `${obj.block?.name} / ${obj.level?.name} / ${obj.unitName}`;
-  } else if (obj?.block?.name) {
-    locationString = obj.block?.name;
-  } else {
-    locationString = "N/A";
-  }
+  /**
+   * V-07: THE DETAIL DIALOG PRINTED `undefined / undefined / 12-34`.
+   *
+   * The guard was an OR over the three parts, but the string interpolated all
+   * THREE unconditionally - so a visitor recorded against a unit with no block
+   * and no level (every walk-in registered from the unit number alone) got the
+   * word `undefined` twice, joined by the separators, in front of a perfectly
+   * good unit. The `else if (block)` branch below it could never run: the OR
+   * above had already matched on the same block.
+   *
+   * Only the parts that EXIST are joined now, which is the same rule
+   * `useSecurityUtils().formatLocation` already applies everywhere else, so a
+   * full location still reads `Block A / Level 12 / 12-34` exactly as before
+   * and a partial one reads `12-34` instead of two undefineds.
+   */
+  const locationParts = [obj?.block?.name, obj?.level?.name, obj?.unitName]
+    .filter((part) => part !== null && part !== undefined && part !== "");
+
+  const locationString = locationParts.length
+    ? locationParts.join(" / ")
+    : "N/A";
 
   return {
     ...Object.fromEntries(

package/package.json

@@ -2,7 +2,7 @@
   "name": "@7365admin1/layer-common",
   "license": "MIT",
   "type": "module",
-  "version": "4.2.9-staging.277",
+  "version": "4.2.9-staging.279",
   "author": "7365admin1",
   "main": "./nuxt.config.ts",
   "//files": "What a consumer extending this layer actually loads. Without this npm ships the whole working tree - the changesets, the CI workflows, the render harness in tools/ and any scratch directory that happened to exist at publish time. Nuxt resolves a layer by directory, so every runtime directory below has to stay listed; adding a new top-level runtime directory means adding it here too.",