@7365admin1/layer-common 4.2.3 → 4.2.5-staging.270

package/CHANGELOG.md

@@ -1,5 +1,29 @@
 # @iservice365/layer-common
 
+## 4.2.4
+
+### Patch Changes
+
+- 23b3b39: Fix the shared date/time field: a date the user types or picks now reaches the payload.
+
+  `Input/DateTimePicker` displayed a read-only Vuetify text field over a hidden native input. Typing went into Vuetify's own copy of the value — it displayed, it passed the required rule, and both models stayed empty, so `startDate: ""` and `endDate: ""` were submitted. Picking from the calendar drove the invisible input, whose segments never completed, and set nothing. The field is now the native input itself, two-way bound.
+
+  Affects every form that takes a date: bulletin board, people, vehicle season pass, building unit lease and the cleaning schedule filters.
+
+- 05428e8: Send vehicle season pass dates as real instants, not zoneless wall-clock strings
+
+  A pass entered as expiring 05/12/2026 at 6:45 pm was stored as 06/12/2026 at
+  2:45 am. The season pass form sent `start` and `end` as `YYYY-MM-DDTHH:mm` with
+  no timezone, so the server parsed them in its own zone (UTC) while the browser
+  rendered the result back in SGT: exactly +8h on both fields, with the expiry
+  rolling into the next day.
+
+  Both date fields now bind the picker's `utc` model, the same binding the
+  bulletin board and people forms already use, and the subscription preset buttons
+  write a UTC instant instead of a wall clock. The picker also prefers a value
+  written by the parent over its own copy of the last typed one, so a preset
+  clicked after typing no longer leaves the old date on screen.
+
 ## 4.2.3
 
 ### Patch Changes
@@ -468,11 +492,11 @@
   `utils/console-tier.ts` + `composables/useConsoleTier.ts` mirror the server's
   own rule from two endpoints the console already calls, unprojected:
 
-                      GET /api/members/user/:user/app/admin    the Seven365 staff membership
-                      GET /api/roles/id/:role                  that membership's role document
+                        GET /api/members/user/:user/app/admin    the Seven365 staff membership
+                        GET /api/roles/id/:role                  that membership's role document
 
-                      owner  = member.type === "admin" && role.type === "admin" && role.default === true
-                      staff  = member.type === "admin" && role.type === "admin"
+                        owner  = member.type === "admin" && role.type === "admin" && role.default === true
+                        staff  = member.type === "admin" && role.type === "admin"
 
   `role.default` is the marker because it is the only property of a platform
   staff role no API caller can set - `role.controller.ts` validates create and

package/components/BulletinBoardForm.vue

@@ -193,7 +193,6 @@ const today = computed(() => {
   const yyyy = d.getFullYear();
   const mm = String(d.getMonth() + 1).padStart(2, "0");
   const dd = String(d.getDate()).padStart(2, "0");
-  console.log("${yyyy}-${mm}-${dd}", `${yyyy}-${mm}-${dd}`);
   return `${yyyy}-${mm}-${dd}`;
 });
 

package/components/Input/DateTimePicker.vue

@@ -1,42 +1,54 @@
 <template>
-  <div class="d-flex flex-column">
-    <v-text-field
-      v-bind="$attrs"
-      class="filter-field"
-      ref="dateTimePickerRef"
-      :model-value="dateTimeFormattedReadOnly"
-      autocomplete="off"
-      :placeholder="inputPlaceholder"
-      :rules="rules"
-      style="z-index: 10"
-      @click="openDatePicker"
-    >
-      <template #append-inner>
-        <v-icon icon="mdi-calendar" @click.stop="openDatePicker" />
-      </template>
-    </v-text-field>
-    <div class="w-100 d-flex align-end ga-3 hidden-input">
-      <input
-        ref="dateInput"
-        :type="inputType"
-        v-model="dateTime"
-        :min="minValue"
-      />
-    </div>
-  </div>
+  <v-text-field
+    v-bind="$attrs"
+    ref="dateTimePickerRef"
+    class="filter-field"
+    v-model="fieldValue"
+    :type="inputType"
+    :label="placeholder || undefined"
+    :min="minValue"
+    :rules="rules"
+    persistent-placeholder
+    autocomplete="off"
+  />
 </template>
 
 <script setup lang="ts">
-import { ref, computed, watch } from "vue";
+import { ref, computed } from "vue";
+
+/*
+ * The field the user edits IS the native date input now.
+ *
+ * It used to be two elements: a read-only Vuetify text field for show, and a
+ * zero-height `opacity: 0` native input behind it that `showPicker()` was
+ * called on. That arrangement broke every way a user can enter a date:
+ *
+ *  - TYPING went into Vuetify's own internal copy of the value (the text field
+ *    was bound with `:model-value` and nothing listened for the update), so the
+ *    typed date DISPLAYED and PASSED the required-rule while both models here
+ *    stayed empty - `startDate: ""` went to the API, and nothing could ever be
+ *    Upcoming.
+ *  - PICKING a date drove the invisible input. A partly-filled
+ *    `datetime-local` has an empty value until every segment is set, and the
+ *    segments were invisible, so the picker closed and set nothing.
+ *  - An End Date that was typed stayed invalid for the same reason as the
+ *    first point, so an announcement with a real end date could not be created
+ *    at all.
+ *
+ * One visible native input has the browser's own picker, its own typing, and a
+ * real `v-model`, which is all three fixes.
+ */
 
 const prop = defineProps({
   rules: {
     type: Array as PropType<Array<any>>,
     default: () => [],
   },
+  // Rendered as the field's label: a native date input always draws its own
+  // dd/mm/yyyy segments, so a placeholder would never be seen.
   placeholder: {
     type: String,
-    default: "DD/MM/YYYY, HH:MM AM/PM",
+    default: "",
   },
   dateOnly: {
     type: Boolean,
@@ -48,11 +60,10 @@ const prop = defineProps({
   },
 });
 
-const { formatDateISO8601 } = useUtils();
-const dateTime = defineModel<string | null>({ default: null }); //2025-10-10T13:09 format
-const dateTimeUTC = defineModel<string | null>("utc", { default: null }); // UTC format
+const dateTime = defineModel<string | null>({ default: null }); // 2025-10-10T13:09, local
+const dateTimeUTC = defineModel<string | null>("utc", { default: null }); // ISO 8601, UTC
 
-const dateTimeFormattedReadOnly = ref<string | null>(null);
+const dateTimePickerRef = ref<HTMLInputElement | null>(null);
 const inputType = computed(() => (prop.dateOnly ? "date" : "datetime-local"));
 
 const minValue = computed(() => {
@@ -62,148 +73,60 @@ const minValue = computed(() => {
   }
   return prop.min;
 });
-const inputPlaceholder = computed(
-  () =>
-    prop.placeholder ||
-    (prop.dateOnly ? "MM/DD/YYYY" : "DD/MM/YYYY, HH:MM AM/PM")
-);
-
-const dateInput = ref<HTMLInputElement | null>(null);
-const dateTimePickerRef = ref<HTMLInputElement | null>(null);
-let nativeInput: HTMLInputElement | null = null;
-
-const isInitialLoad = ref(true);
-
-function handleNativeInputClick(e: MouseEvent) {
-  e.stopPropagation();
-  openDatePicker();
-}
-
-function openDatePicker() {
-  setTimeout(() => {
-    dateInput.value?.showPicker?.();
-  }, 0);
-}
 
 function validate() {
   (dateTimePickerRef.value as any)?.validate();
 }
 
-function convertToReadableFormat(dateStr: string): string {
-  if (!dateStr) return "";
+const pad = (n: number) => String(n).padStart(2, "0");
 
-  const date = new Date(dateStr);
-  if (Number.isNaN(date.getTime())) return "";
-
-  const month = String(date.getMonth() + 1).padStart(2, "0");
-  const day = String(date.getDate()).padStart(2, "0");
-  const year = date.getFullYear();
-
-  if (prop.dateOnly) {
-    return `${day}/${month}/${year}`;
+// What the native input accepts: `YYYY-MM-DD` or `YYYY-MM-DDTHH:mm`, local time.
+function toInputValue(value: string | null): string {
+  if (!value) return "";
+  if (/^\d{4}-\d{2}-\d{2}$/.test(value)) {
+    return prop.dateOnly ? value : `${value}T00:00`;
   }
-
-  let hours = date.getHours();
-  const minutes = String(date.getMinutes()).padStart(2, "0");
-
-  const ampm = hours >= 12 ? "PM" : "AM";
-  hours = hours % 12;
-  hours = hours ? hours : 12;
-
-  const formattedTime = `${String(hours).padStart(2, "0")}:${minutes} ${ampm}`;
-
-  return `${day}/${month}/${year}, ${formattedTime}`;
-}
-
-function toDateOnlyInputValue(dateStr: string): string {
-  if (!dateStr) return "";
-  if (/^\d{4}-\d{2}-\d{2}$/.test(dateStr)) return dateStr;
-  const date = new Date(dateStr);
+  const date = new Date(value);
   if (Number.isNaN(date.getTime())) return "";
-  const year = date.getFullYear();
-  const month = String(date.getMonth() + 1).padStart(2, "0");
-  const day = String(date.getDate()).padStart(2, "0");
-  return `${year}-${month}-${day}`;
+  const day = `${date.getFullYear()}-${pad(date.getMonth() + 1)}-${pad(date.getDate())}`;
+  return prop.dateOnly
+    ? day
+    : `${day}T${pad(date.getHours())}:${pad(date.getMinutes())}`;
 }
 
-function handleInitialDate() {
-  const dateDefault = dateTime.value;
-  const dateUTC = dateTimeUTC.value;
-  if (dateDefault) {
-    dateTimeFormattedReadOnly.value = convertToReadableFormat(dateDefault);
-    if (prop.dateOnly) {
-      dateTimeUTC.value = toDateOnlyInputValue(dateDefault);
-    } else {
-      const localDate = new Date(dateDefault);
-      dateTimeUTC.value = localDate.toISOString();
-    }
-  } else if (dateUTC) {
-    dateTimeFormattedReadOnly.value = convertToReadableFormat(dateUTC);
-    if (prop.dateOnly) {
-      dateTime.value = toDateOnlyInputValue(dateUTC);
-    } else {
-      const localDate = new Date(dateUTC);
-      dateTime.value = formatDateISO8601(localDate);
-    }
-  } else {
-    dateTimeFormattedReadOnly.value = null;
-  }
+// What the API stores: a date-only field stays `YYYY-MM-DD`, everything else
+// becomes UTC.
+function toUTCValue(value: string | null): string | null {
+  if (!value) return null;
+  if (prop.dateOnly) return toInputValue(value).slice(0, 10) || null;
+  const date = new Date(value);
+  if (Number.isNaN(date.getTime())) return null;
+  return date.toISOString();
 }
 
-watch(
-  dateTime,
-  (dateVal) => {
-    if (isInitialLoad.value) return; // ignore the first run
-    if (!dateVal) {
-      dateTimeFormattedReadOnly.value = null;
-      dateTimeUTC.value = null;
-      return;
-    }
-
-    dateTimeFormattedReadOnly.value = convertToReadableFormat(dateVal);
-    if (prop.dateOnly) {
-      dateTimeUTC.value = toDateOnlyInputValue(dateVal);
-    } else {
-      const localDate = new Date(dateVal);
-      dateTimeUTC.value = localDate.toISOString();
+// The one value the field is bound to. A getter and a setter instead of a pair
+// of watchers: no initial-load flag, no chance of the two models fighting each
+// other, and it behaves the same on the server as in the browser.
+const fieldValue = computed({
+  get: () => {
+    // The two models only agree when the setter below wrote them together. When
+    // a PARENT writes one of them - the season pass dialog's subscription
+    // buttons write the UTC one - the other still holds this component's copy
+    // of whatever was in the field before, and reading that copy first would
+    // leave the field showing a date the form is no longer holding.
+    // Disagreement means the parent wrote, so the parent wins.
+    if (dateTimeUTC.value && toUTCValue(dateTime.value) !== dateTimeUTC.value) {
+      return toInputValue(dateTimeUTC.value);
     }
+    return toInputValue(dateTime.value || dateTimeUTC.value);
   },
-  { immediate: false }
-);
-
-watch(
-  dateTimeUTC,
-  () => {
-    handleInitialDate();
+  set: (value: string | null) => {
+    dateTime.value = value || null;
+    dateTimeUTC.value = toUTCValue(value);
   },
-  { immediate: true }
-);
-
-onMounted(async () => {
-  await nextTick();
-  isInitialLoad.value = false;
-  // Wait until Vuetify renders its internal input
-  nativeInput = (dateTimePickerRef.value as any)?.$el?.querySelector(
-    "input"
-  );
-  if (nativeInput) {
-    nativeInput.addEventListener("click", handleNativeInputClick);
-  }
-});
-
-onBeforeUnmount(() => {
-  nativeInput?.removeEventListener("click", handleNativeInputClick);
-  nativeInput = null;
 });
 
 defineExpose({
   validate,
 });
 </script>
-
-<style scoped>
-.hidden-input {
-  opacity: 0;
-  height: 0;
-}
-</style>

package/components/VehicleForm.vue

@@ -58,7 +58,7 @@
             <InputLabel class="text-capitalize" title="Block" required />
             <v-autocomplete
               v-model="vehicle.block"
-              :items="blocksArray"
+              :items="blockItems"
               autocomplete="off"
               :key="
                 blockListDataPending ? 'block-list-pending' : 'block-list-ready'
@@ -76,7 +76,7 @@
             <InputLabel class="text-capitalize" title="Level" required />
             <v-autocomplete
               v-model="vehicle.level"
-              :items="levelsArray"
+              :items="levelItems"
               autocomplete="off"
               :key="
                 levelListDataPending ? 'level-list-pending' : 'level-list-ready'
@@ -93,7 +93,7 @@
             <InputLabel class="text-capitalize" title="Unit" required />
             <v-autocomplete
               v-model="vehicle.unit"
-              :items="unitsArray"
+              :items="unitItems"
               autocomplete="off"
               :key="
                 unitListDataPending ? 'unit-list-pending' : 'unit-list-ready'
@@ -268,7 +268,7 @@
                     />
                     <InputDateTimePicker
                       ref="startDateRef"
-                      v-model="vehicle.start"
+                      v-model:utc="vehicle.start"
                       :rules="[validStartDateRule]"
                     />
                   </v-col>
@@ -281,7 +281,7 @@
                     />
                     <InputDateTimePicker
                       ref="expiryDateRef"
-                      v-model="vehicle.end"
+                      v-model:utc="vehicle.end"
                       :rules="[validExpiryDateRule]"
                     />
                   </v-col>
@@ -439,7 +439,7 @@ const prop = defineProps({
   },
 });
 
-const { requiredRule, formatDateISO8601, debounce } = useUtils();
+const { requiredRule, debounce } = useUtils();
 const {
   addVehicle,
   getCustomSeasonPassTypes,
@@ -532,10 +532,78 @@ const shouldShowField = (fieldKey: string): boolean => {
   return visibleFields?.includes(fieldKey);
 };
 
+/**
+ * Block / Level / Unit are ids bound to autocompletes whose `:items` come from
+ * the site's own lists. Vuetify renders the RAW model value when it is not in
+ * that list, which is how the Season Pass edit dialog came to show
+ * `6a31fd37917fb18ef1a21a0a` in all three fields instead of names.
+ *
+ * Two different causes end in the same place, and neither is fixable in the
+ * repository: the site list has simply not arrived yet, and - measured on
+ * staging - a stored unit id that points at a building unit which has since
+ * been DELETED, so it can NEVER appear in the list however the row is fetched.
+ *
+ * So the fix is here, at the display layer: an id with no name gets an explicit
+ * item saying why there is no name. A Mongo id is not a name, and a blank field
+ * with no explanation is not better than one.
+ *
+ * The stored value is left untouched - the field still submits the same id, so
+ * saving an unrelated edit does not silently rewrite someone's unit.
+ */
+function withUnresolved(
+  items: TDefaultOptionObj[],
+  value: unknown,
+  pending: boolean,
+  noun: string
+): TDefaultOptionObj[] {
+  const id =
+    typeof value === "string" ? value : ((value as any)?._id ?? "");
+  if (!id || items.some((item) => item.value === id)) return items;
+
+  return [
+    {
+      title: pending
+        ? `Loading ${noun}…`
+        : `This ${noun} is no longer on the site list (${id})`,
+      value: id,
+    },
+    ...items,
+  ];
+}
+
+const blockItems = computed(() =>
+  withUnresolved(
+    blocksArray.value,
+    vehicle.block,
+    blockListDataPending.value,
+    "block"
+  )
+);
+
+const levelItems = computed(() =>
+  withUnresolved(
+    levelsArray.value,
+    vehicle.level,
+    levelListDataPending.value,
+    "level"
+  )
+);
+
+const unitItems = computed(() =>
+  withUnresolved(
+    unitsArray.value,
+    vehicle.unit,
+    unitListDataPending.value,
+    "unit"
+  )
+);
+
 const searchUnitName = computed(() => {
+  // Same rule as the fields: never put a raw id in front of a person. The
+  // dialog title used to fall through to `vehicle.unit`, so a deleted unit
+  // titled the panel with its ObjectId.
   return (
-    unitsArray.value.find((u) => u.value === vehicle.unit)?.title ||
-    vehicle.unit
+    unitsArray.value.find((u) => u.value === vehicle.unit)?.title || "-"
   );
 });
 
@@ -881,15 +949,20 @@ async function submit() {
 
 // }
 
+/*
+ * The subscription buttons write the same thing the picker writes: a real
+ * instant.
+ *
+ * `formatDateISO8601` returns `YYYY-MM-DDTHH:mm` with no zone - the browser's
+ * WALL CLOCK, not a moment in time. Sent to the API as-is, the server parsed it
+ * in its own zone (UTC) and a pass entered as 05/12/2026 6:45 pm came back as
+ * 06/12/2026 2:45 am. These two fields now carry UTC end to end, so the preset
+ * and the picker cannot disagree about what "now" meant.
+ */
 watch(selectedSubscriptionDuration, (duration) => {
-  const dateNowISO = formatDateISO8601(new Date());
-  const weeksLaterISO = (week: number) => {
-    const now = new Date();
-    const dateWeekLater = new Date(
-      now.getTime() + week * 7 * 24 * 60 * 60 * 1000
-    );
-    return formatDateISO8601(dateWeekLater);
-  };
+  const dateNowISO = new Date().toISOString();
+  const weeksLaterISO = (week: number) =>
+    new Date(Date.now() + week * 7 * 24 * 60 * 60 * 1000).toISOString();
 
   if (duration === "custom") {
     vehicle.start = "";
@@ -1042,10 +1115,12 @@ const resetVehicleDetails = () => {
 };
 
 function handleCloseMatchDialog() {
+  // Close only. This used to null `vehicle.unit` whenever the panel had found
+  // matches, so backing out of the picker with the header X wiped a Unit the
+  // user had chosen BEFORE opening it and painted the field required-in-red.
+  // The panel's own close button never did that; the two now agree. Backing out
+  // of a picker is not a decision to discard what you already had.
   showMatchingPeopleDialog.value = false;
-  if (matchingPeople.value.length > 0) {
-    vehicle.unit = null;
-  }
 }
 
 onMounted(() => {

package/package.json

@@ -2,7 +2,7 @@
   "name": "@7365admin1/layer-common",
   "license": "MIT",
   "type": "module",
-  "version": "4.2.3",
+  "version": "4.2.5-staging.270",
   "author": "7365admin1",
   "main": "./nuxt.config.ts",
   "//files": "What a consumer extending this layer actually loads. Without this npm ships the whole working tree - the changesets, the CI workflows, the render harness in tools/ and any scratch directory that happened to exist at publish time. Nuxt resolves a layer by directory, so every runtime directory below has to stay listed; adding a new top-level runtime directory means adding it here too.",