@7365admin1/layer-common 4.123.0 → 4.123.1

package/CHANGELOG.md

@@ -1,5 +1,11 @@
 # @iservice365/layer-common
 
+## 4.123.1
+
+### Patch Changes
+
+- 2a14035: Robots Setup: "Floors on the map" now names the robot that reports a floor the map lacks and lists the map's floors; a lift whose gateway exists but is not connected offers "Open lift queue" instead of "Connect gateway" (which would replace its code).
+
 ## 4.123.0
 
 ### Minor Changes
@@ -3252,11 +3258,11 @@ Monthly report: a month that had patrols opens the list of that month's patrol r
   `utils/console-tier.ts` + `composables/useConsoleTier.ts` mirror the server's
   own rule from two endpoints the console already calls, unprojected:
 
-                                                                                                                                                                                                                                                                                                                                                                                                                                          GET /api/members/user/:user/app/admin    the Seven365 staff membership
-                                                                                                                                                                                                                                                                                                                                                                                                                                          GET /api/roles/id/:role                  that membership's role document
+                                                                                                                                                                                                                                                                                                                                                                                                                                            GET /api/members/user/:user/app/admin    the Seven365 staff membership
+                                                                                                                                                                                                                                                                                                                                                                                                                                            GET /api/roles/id/:role                  that membership's role document
 
-                                                                                                                                                                                                                                                                                                                                                                                                                                          owner  = member.type === "admin" && role.type === "admin" && role.default === true
-                                                                                                                                                                                                                                                                                                                                                                                                                                          staff  = member.type === "admin" && role.type === "admin"
+                                                                                                                                                                                                                                                                                                                                                                                                                                            owner  = member.type === "admin" && role.type === "admin" && role.default === true
+                                                                                                                                                                                                                                                                                                                                                                                                                                            staff  = member.type === "admin" && role.type === "admin"
 
   `role.default` is the marker because it is the only property of a platform
   staff role no API caller can set - `role.controller.ts` validates create and

package/package.json

@@ -2,7 +2,7 @@
   "name": "@7365admin1/layer-common",
   "license": "MIT",
   "type": "module",
-  "version": "4.123.0",
+  "version": "4.123.1",
   "author": "7365admin1",
   "main": "./nuxt.config.ts",
   "//files": "What a consumer extending this layer actually loads. Without this npm ships the whole working tree - the changesets, the CI workflows, the render harness in tools/ and any scratch directory that happened to exist at publish time. Nuxt resolves a layer by directory, so every runtime directory below has to stay listed; adding a new top-level runtime directory means adding it here too.",

package/utils/robot-setup.ts

@@ -186,14 +186,12 @@ export function robotSetupSteps(input: TSetupInput): TSetupStep[] {
 
   // 5. Floors present: one per floor the robots report.
   const floors = floorsOf(map);
-  const reported = [
-    ...new Set<number>(
-      Object.values(input.states ?? {})
-        .filter((s) => s?.ok && s.floorKnown === true && Number.isInteger(s.floorNo))
-        .map((s) => Number(s.floorNo)),
-    ),
-  ];
+  const onFloor = (robots ?? [])
+    .map((r) => ({ name: String(r?.name || "A robot"), s: input.states?.[String(r?._id)] }))
+    .filter((x) => x.s?.ok && x.s.floorKnown === true && Number.isInteger(x.s.floorNo));
+  const reported = [...new Set<number>(onFloor.map((x) => Number(x.s!.floorNo)))];
   const missing = reported.filter((f) => !floors.includes(f));
+  const who = (f: number) => onFloor.filter((x) => Number(x.s!.floorNo) === f).map((x) => x.name).join(", ");
   if (map === undefined) {
     steps.push({ key: "floors", title: "Floors on the map", status: "check", reason: "Could not read the saved building map.", button: { label: "Open building map", target: "map" } });
   } else if (!map) {
@@ -206,7 +204,7 @@ export function robotSetupSteps(input: TSetupInput): TSetupStep[] {
       reason: !floors.length
         ? "The saved map has no floors. Use Edit map → Add floor."
         : missing.length
-          ? `Robots report ${missing.map(floorName).join(", ")}, which the map does not have. Add ${missing.length === 1 ? "it" : "them"} in Edit map → Add floor.`
+          ? `${missing.map((f) => `${who(f)} report${who(f).includes(",") ? "" : "s"} ${floorName(f)}`).join("; ")} - the map has no such floor (it has ${floors.map(floorName).join(", ")}). Add it in Edit map → Add floor, or check the floor set in the robot's own app.`
           : `${floors.map(floorName).join(", ")}${reported.length ? " - every floor the robots report." : "."}`,
       button: { label: "Edit floors", target: "map" },
     });
@@ -268,7 +266,8 @@ export function robotSetupSteps(input: TSetupInput): TSetupStep[] {
           ? "Floor and door are read from the real lift."
           : "Floor and door not decoded yet - waiting on the lift company's register list."
         : undefined,
-      button: { label: up.length ? "Open lift queue" : "Connect gateway", target: "lifts" },
+      // An existing (not connected) gateway is checked on the lift queue; Connect there would replace its code.
+      button: { label: up.length || gws.length ? "Open lift queue" : "Connect gateway", target: "lifts" },
     });
   }