@7365admin1/layer-common 3.2.2-staging.138 → 3.2.2-staging.139

package/components/OvernightParkingManagement.vue

@@ -42,6 +42,19 @@
         {{ formatDateDDMMYYYYLocal(value) }}
       </template>
 
+      <!--
+        The column had no slot, so an OBJECT `invitedBy` printed its raw JSON
+        into the cell - `{ "_id": "u-1", "name": "Unit A-12-01" }`. Never seen,
+        because the table had never drawn a row. `types/overnight-parking.d.ts`
+        declares `{ _id, name }`; every OTHER collection in `core` stores
+        `invitedBy` as a plain id/name string, and the overnight parking model
+        has no such field at all - so both shapes are read rather than betting
+        on one, and an absent value says N/A instead of nothing.
+      -->
+      <template #item.invitedBy="{ value }">
+        {{ (typeof value === "object" ? value?.name : value) || "N/A" }}
+      </template>
+
       <!--
         The same four words, the same four meanings - approved/expired/
         rejected/pending map to ok/neutral/err/warn in `utils/status.ts`,
@@ -114,6 +127,15 @@
         </v-card-actions>
       </v-card>
     </v-dialog>
+
+    <!--
+      Approve/Reject had NO failure path at all: `confirmAction` was a
+      try/finally with no catch, so a 400/403/network failure left the dialog
+      open, the spinner off and not one word on screen - the guard cannot tell
+      a saved approval from a refused one. The shared `Snackbar` is what every
+      other screen in the layer uses to say so.
+    -->
+    <Snackbar v-model="messageSnackbar" :text="snackbarMessage" :color="messageColor" />
   </v-row>
 </template>
 
@@ -225,7 +247,10 @@ function formatStatus(status: TOvernightParkingRequest["status"]) {
   }
 }
 
-const { data: overnightParkingRequests, pending: isPendingOvernightParkingRequests, refresh: refreshOvernightParkingRequests } = await useLazyAsyncData<TOvernightParkingRequest[]>(() => getOvernightParkingRequests({ site: props.site, status: statusFilter.value }), { immediate: true })
+// `page` was read by the pager and never sent to the API, so page 2 re-fetched
+// page 1 - with the API's `limit` of 10, every request past the tenth was
+// unreachable. It is part of the query now.
+const { data: overnightParkingRequests, pending: isPendingOvernightParkingRequests, refresh: refreshOvernightParkingRequests } = await useLazyAsyncData<TOvernightParkingRequest[]>(() => getOvernightParkingRequests({ site: props.site, status: statusFilter.value, page: page.value }), { immediate: true })
 
 
 watch(overnightParkingRequests, (data: any) => {
@@ -257,6 +282,8 @@ function handleRowClick(data: { item?: TOvernightParkingRequest }) {
 }
 
 function handleUpdatePage(value: number) {
+  page.value = value;
+  refreshOvernightParkingRequests();
   emits("update:page", value);
 }
 
@@ -272,9 +299,21 @@ function closeActionDialog() {
   actionDialog.open = false
 }
 
+const snackbarMessage = ref("")
+const messageColor = ref("")
+const messageSnackbar = ref(false)
+
+function showMessage(msg: string, color: string) {
+  snackbarMessage.value = msg
+  messageColor.value = color
+  messageSnackbar.value = true
+}
+
 async function confirmAction() {
   if (!actionDialog.requestId || !remarks.value.trim()) return
 
+  const verb = actionDialog.action === 'approved' ? 'approve' : 'reject'
+
   try {
     actionLoading.value = true
     await updateOvernightParkingRequest(actionDialog.requestId, {
@@ -282,8 +321,14 @@ async function confirmAction() {
       remarks: remarks.value.trim(),
     })
     actionDialog.open = false
+    // One refresh. The second, unawaited call fired the same GET a second time
+    // and could land BEFORE the first, putting the pre-update rows back.
     await refreshOvernightParkingRequests()
-    refreshOvernightParkingRequests()
+    showMessage(`Request ${actionDialog.action}.`, "success")
+  } catch (error: any) {
+    // The dialog stays OPEN on failure, with the remarks still typed, so the
+    // action can be retried rather than silently lost.
+    showMessage(error?.data?.message || `Failed to ${verb} this request. Please try again.`, "error")
   } finally {
     actionLoading.value = false
   }
@@ -291,6 +336,9 @@ async function confirmAction() {
 
 watch([statusFilter], ([newStatus], [oldStatus]) => {
   if (newStatus === oldStatus) return
+  // A new filter is a new result set - staying on page 3 of the old one asks
+  // the API for a page that usually does not exist, and the table draws empty.
+  page.value = 1
   refreshOvernightParkingRequests()
 }, { immediate: false })
 </script>

package/package.json

@@ -2,7 +2,7 @@
   "name": "@7365admin1/layer-common",
   "license": "MIT",
   "type": "module",
-  "version": "3.2.2-staging.138",
+  "version": "3.2.2-staging.139",
   "author": "7365admin1",
   "main": "./nuxt.config.ts",
   "//files": "What a consumer extending this layer actually loads. Without this npm ships the whole working tree - the changesets, the CI workflows, the render harness in tools/ and any scratch directory that happened to exist at publish time. Nuxt resolves a layer by directory, so every runtime directory below has to stay listed; adding a new top-level runtime directory means adding it here too.",