@7365admin1/core 3.88.0 → 3.89.0

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@7365admin1/core",
   "license": "MIT",
-  "version": "3.88.0",
+  "version": "3.89.0",
   "author": "7365admin1",
   "main": "dist/index.js",
   "module": "dist/index.mjs",
@@ -13,7 +13,7 @@
     "build": "tsup src/index.ts --format cjs,esm --dts && shx cp -r src/public dist && shx cp -r src/utils/handlebars dist",
     "release": "yarn run build && changeset publish",
     "lint": "tsc",
-    "test": "tsup src/config.ts src/utils/building-map.util.ts src/utils/robot-cloud.util.ts src/utils/robot-adapter.util.ts src/utils/png-encoder.util.ts src/services/demo.adapter.ts src/utils/robot-fault.util.ts src/utils/robot-tracking.util.ts src/utils/robot-apps.util.ts src/utils/robot-permission.util.ts src/utils/lift-contract.util.ts src/models/robot-building-map.model.ts src/utils/anpr-revoke.util.ts src/utils/anpr-plate.util.ts src/utils/vehicle-request.util.ts src/utils/camera-view.util.ts src/utils/camera-bulk-import.util.ts src/utils/dashboard-metrics.util.ts src/utils/camera-capability.util.ts src/utils/camera-playback.util.ts src/services/camera-device-http.service.ts src/utils/camera-alert.util.ts src/utils/dahua-protocol.util.ts src/utils/site-name.util.ts src/utils/service-provider-invite.util.ts src/utils/notification-category.util.ts src/utils/hid-card.util.ts src/utils/hid-json.util.ts src/utils/hid-access.util.ts src/models/customer-site.model.ts src/models/site-camera.model.ts src/models/member.model.ts src/models/subscription.model.ts src/utils/session-id.util.ts src/utils/occurrence-query.util.ts src/utils/occurrence-book-create.util.ts src/utils/update-result.util.ts src/utils/hid-amico-authz.util.ts src/utils/promo-code-currency.util.ts src/utils/console-audit.util.ts src/utils/org-suspension.util.ts src/utils/session-revoke.util.ts src/models/hid-amico.model.ts src/models/patrol-email.model.ts src/utils/patrol-email-pdf.util.ts src/utils/visitor-status.util.ts src/utils/self-service-email.util.ts src/utils/hid-secret.util.ts src/models/visitor-invite.model.ts src/models/guard-invite.model.ts src/utils/site-timezone.util.ts src/utils/bulletin-service-apps.util.ts src/models/bulletin-board.model.ts src/utils/vehicle-import.util.ts src/utils/expired-vehicle-sweep.util.ts src/models/vehicle.model.ts src/controllers/chat.controller.ts src/utils/file-owner.util.ts src/utils/console-permission.util.ts src/utils/role-scope.util.ts src/utils/org-default-roles.util.ts src/utils/org-modules.util.ts src/utils/site-modules.util.ts src/utils/resident-app-modules.util.ts src/utils/resident-default-role.util.ts src/utils/invite-role-scope.util.ts src/models/personal-emergency-chain.model.ts src/utils/self-signup-files.util.ts src/models/person.model.ts src/utils/module-gate.util.ts src/utils/member-lookup.util.ts src/utils/notification-access.util.ts src/utils/module-access.util.ts src/services/module-gate.service.ts src/controllers/site.controller.ts src/controllers/organization.controller.ts src/controllers/member.controller.ts src/utils/org-owner-repair.util.ts src/utils/socket-session.util.ts src/utils/people-create-gate.util.ts src/utils/service-app-type.util.ts --format esm --out-dir test/.build --no-dts --silent && node --test test/*.test.mjs",
+    "test": "tsup src/config.ts src/utils/building-map.util.ts src/utils/robot-cloud.util.ts src/utils/robot-adapter.util.ts src/utils/png-encoder.util.ts src/services/demo.adapter.ts src/utils/robot-fault.util.ts src/utils/robot-tracking.util.ts src/utils/robot-apps.util.ts src/utils/robot-permission.util.ts src/utils/robot-network.util.ts src/utils/lift-contract.util.ts src/models/robot-building-map.model.ts src/utils/anpr-revoke.util.ts src/utils/anpr-plate.util.ts src/utils/vehicle-request.util.ts src/utils/camera-view.util.ts src/utils/camera-bulk-import.util.ts src/utils/dashboard-metrics.util.ts src/utils/camera-capability.util.ts src/utils/camera-playback.util.ts src/services/camera-device-http.service.ts src/utils/camera-alert.util.ts src/utils/dahua-protocol.util.ts src/utils/site-name.util.ts src/utils/service-provider-invite.util.ts src/utils/notification-category.util.ts src/utils/hid-card.util.ts src/utils/hid-json.util.ts src/utils/hid-access.util.ts src/models/customer-site.model.ts src/models/site-camera.model.ts src/models/member.model.ts src/models/subscription.model.ts src/utils/session-id.util.ts src/utils/occurrence-query.util.ts src/utils/occurrence-book-create.util.ts src/utils/update-result.util.ts src/utils/hid-amico-authz.util.ts src/utils/promo-code-currency.util.ts src/utils/console-audit.util.ts src/utils/org-suspension.util.ts src/utils/session-revoke.util.ts src/models/hid-amico.model.ts src/models/patrol-email.model.ts src/utils/patrol-email-pdf.util.ts src/utils/visitor-status.util.ts src/utils/self-service-email.util.ts src/utils/hid-secret.util.ts src/models/visitor-invite.model.ts src/models/guard-invite.model.ts src/utils/site-timezone.util.ts src/utils/bulletin-service-apps.util.ts src/models/bulletin-board.model.ts src/utils/vehicle-import.util.ts src/utils/expired-vehicle-sweep.util.ts src/models/vehicle.model.ts src/controllers/chat.controller.ts src/utils/file-owner.util.ts src/utils/console-permission.util.ts src/utils/role-scope.util.ts src/utils/org-default-roles.util.ts src/utils/org-modules.util.ts src/utils/site-modules.util.ts src/utils/resident-app-modules.util.ts src/utils/resident-default-role.util.ts src/utils/invite-role-scope.util.ts src/models/personal-emergency-chain.model.ts src/utils/self-signup-files.util.ts src/models/person.model.ts src/utils/module-gate.util.ts src/utils/member-lookup.util.ts src/utils/notification-access.util.ts src/utils/module-access.util.ts src/services/module-gate.service.ts src/controllers/site.controller.ts src/controllers/organization.controller.ts src/controllers/member.controller.ts src/utils/org-owner-repair.util.ts src/utils/socket-session.util.ts src/utils/people-create-gate.util.ts src/utils/service-app-type.util.ts --format esm --out-dir test/.build --no-dts --silent && node --test test/*.test.mjs",
     "test:camera": "yarn test",
     "test:e2e": "yarn build && node --test --test-concurrency=1 --test-timeout=600000 \"test/e2e/*.test.mjs\""
   },

package/test/e2e/harness.mjs

@@ -876,6 +876,12 @@ function buildApp(nsu, core) {
   {
     const { createRobot, getRobots, updateRobot, deleteRobot } = core.useRobotController();
 
+    // Seven365 console: every robot at every client's site. Mounted before the
+    // id routes, as in API-core.
+    const n = core.useRobotNetworkController();
+    robots.get("/network", requireAuth, n.listNetworkRobots);
+    robots.get("/network/summary", requireAuth, n.getNetworkSummary);
+
     robots.post("/", requireAuth, createRobot);
     robots.get("/organization/:organization/site/:site", requireAuth, getRobots);
     robots.patch("/:id([0-9a-fA-F]{24})", requireAuth, updateRobot);
@@ -894,6 +900,12 @@ function buildApp(nsu, core) {
     robots.post(`${SESSION}/refresh`, requireAuth, m.refreshLiftSession);
     robots.post(`${SESSION}/release`, requireAuth, m.releaseLiftSession);
     robots.get("/:id([0-9a-fA-F]{24})/lift-session", requireAuth, m.getRobotLiftSession);
+
+    // State and command, for DEMO-brand robots only in these tests: the demo
+    // adapter reaches no network, so no vendor cloud is ever contacted.
+    const f = core.useRobotFleetController();
+    robots.get("/:id([0-9a-fA-F]{24})/state", requireAuth, f.getState);
+    robots.post("/:id([0-9a-fA-F]{24})/command", requireAuth, f.sendCommand);
   }
 
   // mirrors iservice365-API-core/src/routes/attendance-settings.route.ts

package/test/e2e/robot-network.e2e.test.mjs

@@ -0,0 +1,269 @@
+// End-to-end proof of the Seven365 console's all-robots view (owner, 2026-09-23:
+// "Seven365 Super Admin can see ALL the robots deployed to ALL its clients'
+// sites"), and that Super Admin holds every robot right at ANY client's site.
+//
+// Who may list: the super-admin MEMBERSHIP (a `members` row of type "admin"
+// whose role is a live role of type "admin") with the cross-client grant -
+// never an email, never a role NAME. Case 3 is an ordinary organisation role
+// merely NAMED "Super Admin", and it is refused.
+//
+// Everything runs against the throwaway harness (in-process MongoDB, loopback
+// Redis and mail sink). Robots are the DEMO brand, which reaches no network, so
+// no vendor cloud is contacted. Credential values are obvious fakes and are only
+// asserted ABSENT.
+//
+// Run with: yarn test:e2e
+
+import { after, before, describe, it } from "node:test";
+import assert from "node:assert/strict";
+import { ObjectId } from "mongodb";
+
+import { startHarness } from "./harness.mjs";
+
+const PASSWORD = "Robot-Passw0rd!";
+const STAFF = "net-staff@e2e.example.com";       // Seven365 super admin (seeded shape: permissions [])
+const STAR = "net-star@e2e.example.com";         // Seven365 staff, role holds "*"
+const PARTIAL = "net-partial@e2e.example.com";   // Seven365 staff ticked for promo codes only
+const MANAGER = "net-manager@e2e.example.com";   // client A's manager, role holds "*"
+const NAMED = "net-named@e2e.example.com";       // an org role merely NAMED "Super Admin"
+
+describe("robot network view - Seven365 super admin only", { concurrency: 1 }, () => {
+  let h;
+  const id = {};
+  const sid = {};
+
+  before(async () => {
+    h = await startHarness();
+    Object.assign(id, await seed(h));
+    for (const [k, email] of Object.entries({ STAFF, STAR, PARTIAL, MANAGER, NAMED })) {
+      sid[k] = await h.login(email, PASSWORD);
+    }
+  }, { timeout: 300000 });
+
+  after(async () => {
+    if (h) await h.stop();
+  });
+
+  const list = (qs = "", who = "STAFF") => h.api(`/robots/network${qs}`, { sid: sid[who] });
+
+  it("1. no session is a 401 on both routes", async () => {
+    assert.equal((await h.api("/robots/network")).status, 401);
+    assert.equal((await h.api("/robots/network/summary")).status, 401);
+  });
+
+  it("2. a client's own manager (role '*') is refused - it is not a platform membership", async () => {
+    assert.equal((await list("", "MANAGER")).status, 401);
+    assert.equal((await h.api("/robots/network/summary", { sid: sid.MANAGER })).status, 401);
+  });
+
+  it("3. an organisation role merely NAMED 'Super Admin' is refused", async () => {
+    assert.equal((await list("", "NAMED")).status, 401);
+  });
+
+  it("4. staff without the cross-client grant are refused", async () => {
+    assert.equal((await list("", "PARTIAL")).status, 401);
+  });
+
+  it("5. super admin sees every client's robots, named, without credentials or removed ones", async () => {
+    const res = await list("?limit=50");
+    assert.equal(res.status, 200, JSON.stringify(res.body));
+    const names = res.body.items.map((r) => r.name).sort();
+    assert.deepEqual(names, ["A demo 1", "A legacy", "B guard", "B scrubber"]);
+    assert.equal(res.body.total, 4);
+    assert.equal(names.includes("A removed"), false);
+
+    const legacy = res.body.items.find((r) => r.name === "A legacy");
+    assert.equal(legacy.client.name, "Net Client A");
+    assert.equal(legacy.site.name, "Net Site A");
+    // written before `type` / `brand` existed: shown as the model's defaults
+    assert.equal(legacy.type, "cleaning");
+    assert.equal(legacy.brand, "ounitech");
+    assert.equal(res.body.items.find((r) => r.name === "A demo 1").demo, true);
+    assert.equal(legacy.demo, false);
+
+    const raw = JSON.stringify(res.body);
+    assert.equal(raw.includes("appKey") || raw.includes("appToken") || raw.includes("e2e-fake"), false);
+    // default order: client, then site
+    assert.deepEqual(res.body.items.map((r) => r.client.name), [
+      "Net Client A", "Net Client A", "Net Client B", "Net Client B",
+    ]);
+  });
+
+  it("6. a staff role holding '*' sees the same", async () => {
+    const res = await list("?limit=50", "STAR");
+    assert.equal(res.status, 200);
+    assert.equal(res.body.total, 4);
+  });
+
+  it("7. filters: client, site, class (incl. legacy rows), brand, search by client name", async () => {
+    const byOrg = await list(`?org=${id.orgB}`);
+    assert.deepEqual(byOrg.body.items.map((r) => r.name).sort(), ["B guard", "B scrubber"]);
+
+    const bySite = await list(`?site=${id.siteA}`);
+    assert.equal(bySite.body.total, 2);
+
+    const cleaning = await list("?type=cleaning&limit=50");
+    assert.deepEqual(cleaning.body.items.map((r) => r.name).sort(), ["A demo 1", "A legacy", "B scrubber"]);
+    const security = await list("?type=security");
+    assert.deepEqual(security.body.items.map((r) => r.name), ["B guard"]);
+
+    const ounitech = await list("?brand=ounitech&limit=50");
+    assert.deepEqual(ounitech.body.items.map((r) => r.name).sort(), ["A legacy", "B guard", "B scrubber"]);
+
+    const search = await list("?search=client%20b");
+    assert.equal(search.body.total, 2);
+    const pattern = await list("?search=.*");
+    assert.equal(pattern.body.total, 0, "a search is text, not a regex");
+  });
+
+  it("8. sort and pagination", async () => {
+    const page1 = await list("?sort=name&order=desc&limit=3&page=1");
+    assert.deepEqual(page1.body.items.map((r) => r.name), ["B scrubber", "B guard", "A legacy"]);
+    assert.equal(page1.body.pages, 2);
+    const page2 = await list("?sort=name&order=desc&limit=3&page=2");
+    assert.deepEqual(page2.body.items.map((r) => r.name), ["A demo 1"]);
+  });
+
+  it("9. bad input is a 400 for staff", async () => {
+    assert.equal((await list("?type=drone")).status, 400);
+    assert.equal((await list("?org=nope")).status, 400);
+    assert.equal((await list("?limit=1000")).status, 400);
+    assert.equal((await list("?sort=appKey")).status, 400);
+  });
+
+  it("10. the summary counts stored data and claims no fault count", async () => {
+    const res = await h.api("/robots/network/summary", { sid: sid.STAFF });
+    assert.equal(res.status, 200);
+    assert.equal(res.body.total, 4);
+    assert.equal(res.body.sites, 2);
+    assert.deepEqual(res.body.byType, [{ key: "cleaning", count: 3 }, { key: "security", count: 1 }]);
+    assert.equal(res.body.demo, 1);
+    assert.deepEqual(
+      res.body.byClient.map((c) => [c.name, c.count, c.sites]),
+      [["Net Client A", 2, 1], ["Net Client B", 2, 1]],
+    );
+    assert.deepEqual(res.body.faults, { live: false, count: null });
+  });
+
+  // ---- Super Admin holds every robot right at ANY client's site ----------
+
+  it("11. super admin reads live state and commands a robot at a client it is not a member of", async () => {
+    const state = await h.api(`/robots/${id.demoA}/state`, { sid: sid.STAFF });
+    assert.equal(state.status, 200, JSON.stringify(state.body));
+    const cmd = await h.api(`/robots/${id.demoA}/command`, {
+      method: "POST", sid: sid.STAFF, body: { kind: "return" },
+    });
+    assert.equal(cmd.status, 202, JSON.stringify(cmd.body));
+    // and a client's manager still cannot reach another client's robot
+    assert.equal((await h.api(`/robots/${id.scrubberB}/state`, { sid: sid.MANAGER })).status, 404);
+  });
+
+  it("12. super admin saves a building map and asks for the lift at another client's site", async () => {
+    const map = await h.api("/robots/building-maps", {
+      method: "POST",
+      sid: sid.STAFF,
+      body: {
+        robotId: String(id.demoA),
+        name: "Net tower",
+        levels: [{ floorNo: 1, elevationM: 0 }, { floorNo: 2 }],
+        lifts: [{ name: "Lift A", x: 1, y: 1, floors: [1, 2] }],
+      },
+    });
+    assert.equal(map.status, 201, JSON.stringify(map.body));
+    const mapId = map.body.id ?? map.body._id ?? map.body.map?._id;
+    assert.ok(mapId, JSON.stringify(map.body));
+
+    const lift = await h.api(`/robots/building-maps/${mapId}/lifts/Lift%20A/sessions`, {
+      method: "POST", sid: sid.STAFF, body: { robotId: String(id.demoA), fromFloor: 1, toFloor: 2 },
+    });
+    assert.equal(lift.status, 201, JSON.stringify(lift.body));
+    const queue = await h.api(`/robots/building-maps/${mapId}/lifts`, { sid: sid.STAFF });
+    assert.equal(queue.status, 200);
+  });
+
+  it("13. super admin edits and removes a robot at another client's site; it leaves the network list", async () => {
+    const edit = await h.api(`/robots/${id.scrubberB}`, {
+      method: "PATCH", sid: sid.STAFF, body: { name: "B scrubber (renamed)" },
+    });
+    assert.equal(edit.status, 200);
+    const remove = await h.api(`/robots/${id.scrubberB}`, { method: "DELETE", sid: sid.STAFF });
+    assert.equal(remove.status, 200);
+    const res = await list("?limit=50");
+    assert.equal(res.body.items.some((r) => r.name.startsWith("B scrubber")), false);
+    assert.equal(res.body.total, 3);
+  });
+});
+
+async function seed(h) {
+  const now = new Date().toISOString();
+  const orgA = new ObjectId();
+  const orgB = new ObjectId();
+  const siteA = new ObjectId();
+  const siteB = new ObjectId();
+  const staffRole = new ObjectId();
+  const starRole = new ObjectId();
+  const partialRole = new ObjectId();
+  const managerRole = new ObjectId();
+  const namedRole = new ObjectId();
+
+  await h.db.collection("organizations").insertMany([
+    { _id: orgA, name: "Net Client A", email: "neta@e2e.example.com", type: "org", nature: "property_management_agency", status: "active", createdAt: now },
+    { _id: orgB, name: "Net Client B", email: "netb@e2e.example.com", type: "org", nature: "property_management_agency", status: "active", createdAt: now },
+  ]);
+  await h.db.collection("sites").insertMany([
+    { _id: siteA, name: "Net Site A", org: orgA, orgId: orgA, status: "active" },
+    { _id: siteB, name: "Net Site B", org: orgB, orgId: orgB, status: "active" },
+  ]);
+  await h.db.collection("roles").insertMany([
+    { _id: staffRole, name: "Super Admin", type: "admin", default: true, permissions: [], status: "active" },
+    { _id: starRole, name: "Ops", type: "admin", permissions: ["*"], status: "active" },
+    { _id: partialRole, name: "Promo desk", type: "admin", permissions: ["promo-codes:see-all-promo-codes"], status: "active" },
+    { _id: managerRole, name: "Manager A", org: orgA, type: "organization", permissions: ["*"], status: "active" },
+    { _id: namedRole, name: "Super Admin", org: orgA, type: "organization", permissions: ["*"], status: "active" },
+  ]);
+
+  const emails = [STAFF, STAR, PARTIAL, MANAGER, NAMED];
+  const users = await h.db.collection("users").insertMany(
+    emails.map((email) => ({ email, name: email.split("@")[0], status: "active", createdAt: now })),
+  );
+  const hashed = await h.hashPassword(PASSWORD);
+  await h.db.collection("users").updateMany({ email: { $in: emails } }, { $set: { password: hashed } });
+  const [staff, star, partial, manager, named] = [0, 1, 2, 3, 4].map((i) => users.insertedIds[i]);
+
+  await h.db.collection("members").insertMany([
+    { user: staff, type: "admin", role: staffRole, status: "active" },
+    { user: star, type: "admin", role: starRole, status: "active" },
+    { user: partial, type: "admin", role: partialRole, status: "active" },
+    { user: manager, org: orgA, type: "organization", role: managerRole, status: "active" },
+    { user: named, org: orgA, type: "organization", role: namedRole, status: "active" },
+  ]);
+
+  const robot = (name, org, site, extra = {}) => ({
+    name,
+    appKey: "e2e-fake-key",
+    appToken: "e2e-fake-token",
+    createdBy: manager,
+    createdByName: "net-manager",
+    robotSn: "",
+    metadata: { orgId: org, siteId: site, administratorId: "" },
+    status: "",
+    createdAt: new Date(),
+    deletedAt: "",
+    ...extra,
+  });
+
+  const res = await h.db.collection("robots").insertMany([
+    // written before `type` / `brand` existed, and before `deletedAt` was always set
+    (() => { const r = robot("A legacy", orgA, siteA); delete r.deletedAt; return r; })(),
+    robot("A demo 1", orgA, siteA, { type: "cleaning", brand: "demo", robotSn: "DEMO-0001" }),
+    robot("A removed", orgA, siteA, { type: "cleaning", brand: "ounitech", deletedAt: new Date() }),
+    robot("B scrubber", orgB, siteB, { type: "cleaning", brand: "ounitech" }),
+    robot("B guard", orgB, siteB, { type: "security", brand: "ounitech" }),
+  ]);
+
+  return {
+    orgA, orgB, siteA, siteB,
+    demoA: res.insertedIds[1],
+    scrubberB: res.insertedIds[3],
+  };
+}

package/test/robot-network.test.mjs

@@ -0,0 +1,93 @@
+import assert from "node:assert/strict";
+import { test } from "node:test";
+
+import {
+  NETWORK_PROJECTION,
+  escapeRegex,
+  networkListPipeline,
+  networkMatch,
+  networkSummaryPipeline,
+  shapeNetworkSummary,
+} from "./.build/utils/robot-network.util.mjs";
+
+/* --------------------------------------------------------------------------
+ * The Seven365 console's all-robots list (owner, 2026-09-23). The pipeline is
+ * where it can go wrong quietly: a removed robot listed, a credential
+ * projected, a filter on the default class that loses every row written before
+ * the field existed, or a search string treated as a pattern.
+ * ------------------------------------------------------------------------ */
+
+const ORG = "64b7f0c2a1b2c3d4e5f60718";
+const SITE = "64b7f0c2a1b2c3d4e5f60719";
+
+test("a removed robot never lists: the soft-delete test is always first", () => {
+  const [first] = networkListPipeline({});
+  assert.deepEqual(first.$match.deletedAt, { $in: ["", null] });
+  const [summaryFirst] = networkSummaryPipeline();
+  assert.deepEqual(summaryFirst.$match.deletedAt, { $in: ["", null] });
+});
+
+test("the credentials can never leave: the projection is an allow-list without them", () => {
+  assert.equal("appKey" in NETWORK_PROJECTION, false);
+  assert.equal("appToken" in NETWORK_PROJECTION, false);
+  const facet = networkListPipeline({}).at(-1).$facet.items;
+  assert.deepEqual(facet.at(-1).$project, NETWORK_PROJECTION);
+});
+
+test("client and site filters are ObjectIds on the indexed metadata fields", () => {
+  const m = networkMatch({ org: ORG, site: SITE });
+  assert.equal(String(m["metadata.orgId"]), ORG);
+  assert.equal(String(m["metadata.siteId"]), SITE);
+  assert.equal(typeof m["metadata.orgId"], "object");
+});
+
+test("filtering on the DEFAULT class/brand still finds rows written before the field existed", () => {
+  assert.deepEqual(networkMatch({ type: "cleaning" }).type, { $in: ["cleaning", null, ""] });
+  assert.deepEqual(networkMatch({ brand: "ounitech" }).brand, { $in: ["ounitech", null, ""] });
+  // A non-default value is matched exactly.
+  assert.equal(networkMatch({ type: "security" }).type, "security");
+  assert.equal(networkMatch({ brand: "demo" }).brand, "demo");
+});
+
+test("a search string is data, not a pattern", () => {
+  assert.equal(escapeRegex("a.b*(c)"), String.raw`a\.b\*\(c\)`);
+  const search = networkListPipeline({ search: "Tower (1)" }).find((s) => s.$match?.$or);
+  assert.equal(search.$match.$or[0].name.$regex, String.raw`Tower \(1\)`);
+  // and the escaped pattern matches the literal text only
+  assert.ok(new RegExp(escapeRegex("a.b*(c)")).test("xa.b*(c)y"));
+  assert.equal(new RegExp(escapeRegex("a.b")).test("axb"), false);
+  // searches the joined client and site names too
+  const fields = search.$match.$or.map((c) => Object.keys(c)[0]);
+  assert.deepEqual(fields, ["name", "robotSn", "client.name", "site.name"]);
+});
+
+test("paging is bounded and the default order groups by client then site", () => {
+  const p = networkListPipeline({ page: 3, limit: 500 });
+  const facet = p.at(-1).$facet.items;
+  assert.equal(facet[1].$limit, 100, "limit capped at 100");
+  assert.equal(facet[0].$skip, 200);
+  const sort = p.find((s) => s.$sort).$sort;
+  assert.deepEqual(Object.keys(sort), ["client.name", "site.name", "name", "_id"]);
+  const bySite = networkListPipeline({ sort: "site", order: "desc" }).find((s) => s.$sort).$sort;
+  assert.deepEqual(bySite, { "site.name": -1, _id: 1 });
+});
+
+test("the summary never claims a fault count it did not measure", () => {
+  const s = shapeNetworkSummary({
+    total: [{ n: 5 }],
+    sites: [{ n: 2 }],
+    byType: [{ _id: "cleaning", count: 4 }, { _id: "security", count: 1 }],
+    byBrand: [{ _id: "demo", count: 3 }, { _id: "ounitech", count: 2 }],
+    byClient: [{ _id: ORG, name: "Client A", count: 5, sites: 2 }],
+  });
+  assert.equal(s.total, 5);
+  assert.equal(s.sites, 2);
+  assert.deepEqual(s.byType, [{ key: "cleaning", count: 4 }, { key: "security", count: 1 }]);
+  assert.equal(s.demo, 3);
+  assert.equal(s.byClient[0].name, "Client A");
+  assert.deepEqual(s.faults, { live: false, count: null });
+  // empty collection: zeros, not a crash
+  const empty = shapeNetworkSummary(undefined);
+  assert.equal(empty.total, 0);
+  assert.deepEqual(empty.byType.map((t) => t.count), [0, 0]);
+});