@7365admin1/core 3.82.0 → 3.83.0

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@7365admin1/core",
   "license": "MIT",
-  "version": "3.82.0",
+  "version": "3.83.0",
   "author": "7365admin1",
   "main": "dist/index.js",
   "module": "dist/index.mjs",
@@ -13,7 +13,7 @@
     "build": "tsup src/index.ts --format cjs,esm --dts && shx cp -r src/public dist && shx cp -r src/utils/handlebars dist",
     "release": "yarn run build && changeset publish",
     "lint": "tsc",
-    "test": "tsup src/config.ts src/utils/robot-cloud.util.ts src/utils/robot-tracking.util.ts src/utils/robot-apps.util.ts src/utils/robot-permission.util.ts src/utils/lift-contract.util.ts src/utils/anpr-revoke.util.ts src/utils/anpr-plate.util.ts src/utils/vehicle-request.util.ts src/utils/camera-view.util.ts src/utils/camera-bulk-import.util.ts src/utils/dashboard-metrics.util.ts src/utils/camera-capability.util.ts src/utils/camera-playback.util.ts src/services/camera-device-http.service.ts src/utils/camera-alert.util.ts src/utils/dahua-protocol.util.ts src/utils/site-name.util.ts src/utils/service-provider-invite.util.ts src/utils/notification-category.util.ts src/utils/hid-card.util.ts src/utils/hid-json.util.ts src/utils/hid-access.util.ts src/models/customer-site.model.ts src/models/site-camera.model.ts src/models/member.model.ts src/models/subscription.model.ts src/utils/session-id.util.ts src/utils/occurrence-query.util.ts src/utils/occurrence-book-create.util.ts src/utils/update-result.util.ts src/utils/hid-amico-authz.util.ts src/utils/promo-code-currency.util.ts src/utils/console-audit.util.ts src/utils/org-suspension.util.ts src/utils/session-revoke.util.ts src/models/hid-amico.model.ts src/models/patrol-email.model.ts src/utils/patrol-email-pdf.util.ts src/utils/visitor-status.util.ts src/utils/self-service-email.util.ts src/utils/hid-secret.util.ts src/models/visitor-invite.model.ts src/models/guard-invite.model.ts src/utils/site-timezone.util.ts src/utils/bulletin-service-apps.util.ts src/models/bulletin-board.model.ts src/utils/vehicle-import.util.ts src/utils/expired-vehicle-sweep.util.ts src/models/vehicle.model.ts src/controllers/chat.controller.ts src/utils/file-owner.util.ts src/utils/console-permission.util.ts src/utils/role-scope.util.ts src/utils/org-default-roles.util.ts src/utils/org-modules.util.ts src/utils/site-modules.util.ts src/utils/resident-app-modules.util.ts src/utils/resident-default-role.util.ts src/utils/invite-role-scope.util.ts src/models/personal-emergency-chain.model.ts src/utils/self-signup-files.util.ts src/models/person.model.ts src/utils/module-gate.util.ts src/utils/member-lookup.util.ts src/utils/notification-access.util.ts src/utils/module-access.util.ts src/services/module-gate.service.ts src/controllers/site.controller.ts src/controllers/organization.controller.ts src/controllers/member.controller.ts src/utils/org-owner-repair.util.ts src/utils/socket-session.util.ts src/utils/people-create-gate.util.ts src/utils/service-app-type.util.ts --format esm --out-dir test/.build --no-dts --silent && node --test test/*.test.mjs",
+    "test": "tsup src/config.ts src/utils/robot-cloud.util.ts src/utils/robot-adapter.util.ts src/utils/robot-tracking.util.ts src/utils/robot-apps.util.ts src/utils/robot-permission.util.ts src/utils/lift-contract.util.ts src/utils/anpr-revoke.util.ts src/utils/anpr-plate.util.ts src/utils/vehicle-request.util.ts src/utils/camera-view.util.ts src/utils/camera-bulk-import.util.ts src/utils/dashboard-metrics.util.ts src/utils/camera-capability.util.ts src/utils/camera-playback.util.ts src/services/camera-device-http.service.ts src/utils/camera-alert.util.ts src/utils/dahua-protocol.util.ts src/utils/site-name.util.ts src/utils/service-provider-invite.util.ts src/utils/notification-category.util.ts src/utils/hid-card.util.ts src/utils/hid-json.util.ts src/utils/hid-access.util.ts src/models/customer-site.model.ts src/models/site-camera.model.ts src/models/member.model.ts src/models/subscription.model.ts src/utils/session-id.util.ts src/utils/occurrence-query.util.ts src/utils/occurrence-book-create.util.ts src/utils/update-result.util.ts src/utils/hid-amico-authz.util.ts src/utils/promo-code-currency.util.ts src/utils/console-audit.util.ts src/utils/org-suspension.util.ts src/utils/session-revoke.util.ts src/models/hid-amico.model.ts src/models/patrol-email.model.ts src/utils/patrol-email-pdf.util.ts src/utils/visitor-status.util.ts src/utils/self-service-email.util.ts src/utils/hid-secret.util.ts src/models/visitor-invite.model.ts src/models/guard-invite.model.ts src/utils/site-timezone.util.ts src/utils/bulletin-service-apps.util.ts src/models/bulletin-board.model.ts src/utils/vehicle-import.util.ts src/utils/expired-vehicle-sweep.util.ts src/models/vehicle.model.ts src/controllers/chat.controller.ts src/utils/file-owner.util.ts src/utils/console-permission.util.ts src/utils/role-scope.util.ts src/utils/org-default-roles.util.ts src/utils/org-modules.util.ts src/utils/site-modules.util.ts src/utils/resident-app-modules.util.ts src/utils/resident-default-role.util.ts src/utils/invite-role-scope.util.ts src/models/personal-emergency-chain.model.ts src/utils/self-signup-files.util.ts src/models/person.model.ts src/utils/module-gate.util.ts src/utils/member-lookup.util.ts src/utils/notification-access.util.ts src/utils/module-access.util.ts src/services/module-gate.service.ts src/controllers/site.controller.ts src/controllers/organization.controller.ts src/controllers/member.controller.ts src/utils/org-owner-repair.util.ts src/utils/socket-session.util.ts src/utils/people-create-gate.util.ts src/utils/service-app-type.util.ts --format esm --out-dir test/.build --no-dts --silent && node --test test/*.test.mjs",
     "test:camera": "yarn test",
     "test:e2e": "yarn build && node --test --test-concurrency=1 --test-timeout=600000 \"test/e2e/*.test.mjs\""
   },

package/test/robot-adapter.test.mjs

@@ -0,0 +1,179 @@
+import assert from "node:assert/strict";
+import { test } from "node:test";
+
+import {
+  ROBOT_CAPABILITIES,
+  clearRobotAdapters,
+  commandSupported,
+  missingForTier,
+  registerRobotAdapter,
+  registeredRobotBrands,
+  robotAdapterFor,
+  robotTier,
+  supports,
+  uncontrollableFleetWarning,
+} from "./.build/utils/robot-adapter.util.mjs";
+
+/* --------------------------------------------------------------------------
+ * The goal changed: fleet management for every brand and model on the market,
+ * not one vendor. That only works if the screens ask the ROBOT what it can do
+ * instead of assuming, so these guard the capability model and the registry.
+ *
+ * The capability names and the tier requirements are Open-RMF's, verbatim from
+ * the "Fleet Adapters" table in ros2multirobotbook. Keeping them is what lets a
+ * brand's datasheet be read straight into a tier.
+ * ----------------------------------------------------------------------- */
+
+const ALL = Object.fromEntries(ROBOT_CAPABILITIES.map((c) => [c, true]));
+const caps = (...names) => Object.fromEntries(names.map((n) => [n, true]));
+
+/* ------------------------------------------------------------------ tiers */
+
+test("everything supported is Full Control", () => {
+  assert.equal(robotTier(ALL), "full-control");
+});
+
+test("nothing supported is no-interface — a real answer, not an error", () => {
+  // Our own security robot is this today: a web page on a building's LAN.
+  assert.equal(robotTier({}), "no-interface");
+  assert.equal(robotTier(null), "no-interface");
+  assert.equal(robotTier(undefined), "no-interface");
+});
+
+test("a tier needs EVERY requirement — partial credit misses the point", () => {
+  const nearlyFull = { ...ALL };
+  delete nearlyFull.relocalize;
+  assert.notEqual(robotTier(nearlyFull), "full-control");
+
+  const trafficLight = caps(
+    "readLocation", "pauseResume", "battery", "sendToDock",
+    "startProcess", "pauseProcess", "processCompletion",
+  );
+  assert.equal(robotTier(trafficLight), "traffic-light");
+
+  const { battery, ...noBattery } = trafficLight;
+  assert.notEqual(robotTier(noBattery), "traffic-light");
+});
+
+test("Ounitech today does not reach even Read Only", () => {
+  // What their documented API actually gives: pose, dock, and "start a process"
+  // (start-area-cleaning). No battery, no path/ETA, no reliable completion.
+  const ounitech = caps("readLocation", "sendToDock", "startProcess");
+  assert.equal(robotTier(ounitech), "no-interface");
+
+  // And this is the ask that moves them, in order.
+  assert.deepEqual(missingForTier(ounitech, "read-only"), [
+    "pathAndEta",
+    "battery",
+    "processCompletion",
+  ]);
+  assert.deepEqual(missingForTier(ounitech, "traffic-light"), [
+    "pauseResume",
+    "battery",
+    "pauseProcess",
+    "processCompletion",
+  ]);
+});
+
+test("a capability set with false values does not count as support", () => {
+  assert.equal(supports({ battery: false }, "battery"), false);
+  assert.equal(supports({ battery: true }, "battery"), true);
+  assert.equal(supports({}, "battery"), false);
+  assert.equal(supports(null, "battery"), false);
+});
+
+test("a prototype key is not a capability", () => {
+  // hasOwnProperty, not a bare lookup - otherwise "constructor" reads as true.
+  assert.equal(supports({}, "constructor"), false);
+  assert.equal(supports({}, "toString"), false);
+});
+
+/* ------------------------------------------- the shared-space safety rule */
+
+test("two uncontrollable fleets in one space is refused", () => {
+  // Open-RMF: at most ONE read-only fleet in a shared space, "having none is
+  // ideal". A read-only cleaning fleet plus a no-interface security robot is
+  // exactly the pair to warn about.
+  assert.equal(uncontrollableFleetWarning(["read-only"]).ok, true);
+  assert.equal(uncontrollableFleetWarning(["no-interface"]).ok, true);
+  assert.equal(uncontrollableFleetWarning(["full-control", "read-only"]).ok, true);
+
+  const bad = uncontrollableFleetWarning(["read-only", "no-interface"]);
+  assert.equal(bad.ok, false);
+  assert.equal(bad.count, 2);
+  assert.match(bad.message, /at most one/i);
+});
+
+test("controllable fleets never trigger the warning, however many", () => {
+  const many = ["full-control", "full-control", "traffic-light", "traffic-light"];
+  assert.equal(uncontrollableFleetWarning(many).ok, true);
+  assert.equal(uncontrollableFleetWarning([]).ok, true);
+});
+
+/* --------------------------------------------------------------- commands */
+
+test("a command the brand never claimed is refused", () => {
+  const readOnlyish = caps("readLocation");
+  for (const kind of ["full", "area", "spot", "return", "pause", "navigate", "relocalize"]) {
+    assert.equal(commandSupported(readOnlyish, kind), false, kind);
+  }
+  assert.equal(commandSupported(ALL, "navigate"), true);
+});
+
+test("each command maps to the capability it actually needs", () => {
+  assert.equal(commandSupported(caps("startProcess"), "area"), true);
+  assert.equal(commandSupported(caps("startProcess"), "return"), false);
+  assert.equal(commandSupported(caps("sendToDock"), "return"), true);
+  assert.equal(commandSupported(caps("pauseProcess"), "cancel"), true);
+  assert.equal(commandSupported(caps("navigateToPoint"), "navigate"), true);
+});
+
+test("an unknown command kind is refused, not defaulted", () => {
+  for (const kind of ["selfDestruct", "", null, undefined, "constructor"]) {
+    assert.equal(commandSupported(ALL, kind), false, String(kind));
+  }
+});
+
+/* --------------------------------------------------------------- registry */
+
+test("an adapter is found by brand, and never by fallback", () => {
+  clearRobotAdapters();
+  const a = { brand: "brand-a", displayName: "Brand A", capabilities: ALL, listRobots: async () => [], getRobot: async () => null };
+  registerRobotAdapter(a);
+
+  assert.equal(robotAdapterFor("brand-a"), a);
+  // Falling back to the only registered adapter would send one brand's robot a
+  // command in a protocol it does not speak.
+  assert.equal(robotAdapterFor("brand-b"), null);
+  assert.equal(robotAdapterFor(""), null);
+  assert.equal(robotAdapterFor(null), null);
+  assert.equal(robotAdapterFor(undefined), null);
+  assert.equal(robotAdapterFor(42), null);
+});
+
+test("an adapter without a brand is refused at registration", () => {
+  clearRobotAdapters();
+  assert.throws(() => registerRobotAdapter({ displayName: "x" }), /must name its brand/);
+  assert.throws(() => registerRobotAdapter(null), /must name its brand/);
+});
+
+test("the brand list reports each brand's tier, for a settings picker", () => {
+  clearRobotAdapters();
+  registerRobotAdapter({ brand: "good", displayName: "Good", capabilities: ALL, listRobots: async () => [], getRobot: async () => null });
+  registerRobotAdapter({ brand: "poor", displayName: "Poor", capabilities: caps("readLocation"), listRobots: async () => [], getRobot: async () => null });
+
+  assert.deepEqual(registeredRobotBrands().sort((x, y) => x.brand.localeCompare(y.brand)), [
+    { brand: "good", displayName: "Good", tier: "full-control" },
+    { brand: "poor", displayName: "Poor", tier: "no-interface" },
+  ]);
+});
+
+test("re-registering a brand replaces it rather than duplicating", () => {
+  clearRobotAdapters();
+  const base = { brand: "x", displayName: "One", capabilities: {}, listRobots: async () => [], getRobot: async () => null };
+  registerRobotAdapter(base);
+  registerRobotAdapter({ ...base, displayName: "Two" });
+
+  assert.equal(registeredRobotBrands().length, 1);
+  assert.equal(robotAdapterFor("x").displayName, "Two");
+});