@7365admin1/core 3.73.0 → 3.73.1

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@7365admin1/core",
   "license": "MIT",
-  "version": "3.73.0",
+  "version": "3.73.1",
   "author": "7365admin1",
   "main": "dist/index.js",
   "module": "dist/index.mjs",

package/test/e2e/person-write-scope.e2e.test.mjs

@@ -260,6 +260,63 @@ describe("people writes are scoped to a site the caller can reach", { concurrenc
     assert.equal(res.status, 200, JSON.stringify(res.body));
     assert.equal((await load(id.residentPerson)).name, "Resubmitted By Themselves");
   });
+
+  // ---- creating a person: POST /api/people -------------------------------
+  // The signed-in branch of `add` used to check only that somebody was signed
+  // in, while `site`/`org` came from the body. The reach gate is enforced by
+  // default now; these cases pin both halves of that.
+
+  const newPerson = (tag) => ({
+    name: `Created ${tag}`,
+    contact: "90000001",
+    type: "guest",
+    isOwner: false,
+    org: String(id.orgB),
+    site: String(id.siteB),
+  });
+  const countCreated = (tag) =>
+    h.db.collection("site.people").countDocuments({ name: `Created ${tag}` });
+
+  record("13. an outsider cannot create a person at site B", async () => {
+    const res = await h.api("/people", { method: "POST", body: newPerson("outsider"), sid: outsiderSid });
+
+    assert.equal(res.status, 401, JSON.stringify(res.body));
+    assert.equal(await countCreated("outsider"), 0, "nothing may be written");
+  });
+
+  record("14. nor by naming only site B's organisation", async () => {
+    const { site, ...orgOnly } = newPerson("outsider-org");
+    const res = await h.api("/people", { method: "POST", body: orgOnly, sid: outsiderSid });
+
+    assert.equal(res.status, 401, JSON.stringify(res.body));
+    assert.equal(await countCreated("outsider-org"), 0);
+  });
+
+  record("15. the site's own manager CAN create one", async () => {
+    // `web-app-property-management components/PeopleFormMgmt.vue` -> `usePeople.create`
+    const res = await h.api("/people", { method: "POST", body: newPerson("manager"), sid: managerSid });
+
+    assert.equal(res.status, 201, JSON.stringify(res.body));
+    assert.equal(await countCreated("manager"), 1);
+  });
+
+  record("16. and so can the agency guard posted at site B", async () => {
+    // the field guard app registers visitors at the site it is posted to
+    const res = await h.api("/people", { method: "POST", body: newPerson("guard"), sid: guardSid });
+
+    assert.equal(res.status, 201, JSON.stringify(res.body));
+    assert.equal(await countCreated("guard"), 1);
+  });
+
+  record("17. log mode is a real kill switch: the outsider is let through", async () => {
+    process.env.PEOPLE_CREATE_REACH_MODE = "log";
+    try {
+      const res = await h.api("/people", { method: "POST", body: newPerson("logmode"), sid: outsiderSid });
+      assert.equal(res.status, 201, JSON.stringify(res.body));
+    } finally {
+      delete process.env.PEOPLE_CREATE_REACH_MODE;
+    }
+  });
 });
 
 async function seed(h) {

package/test/people-create-gate.test.mjs

@@ -7,10 +7,9 @@
  * `site.people` is the collection every site-reach decision reads its verdict
  * from, so a row written there manufactures reach into another client's estate.
  *
- * This gate ships SWITCHED OFF (`log`): it records what it would refuse and
- * refuses nothing, because a person row carries no `createdBy` and the real
- * refusal count is only knowable from live traffic. These tests pin that
- * default, so it cannot become enforcing by accident.
+ * The gate shipped in `log` first and is ENFORCED by default since 2026-09-15,
+ * after a staging measurement showed nobody legitimate is refused. These tests
+ * pin that default; `log` stays available as the kill switch.
  */
 import test from "node:test";
 import assert from "node:assert/strict";
@@ -21,11 +20,12 @@ import {
   peopleCreateVerdict,
 } from "./.build/utils/people-create-gate.util.mjs";
 
-test("the code default is LOG - it must not ship refusing anybody", () => {
-  assert.equal(PEOPLE_CREATE_REACH_MODE_DEFAULT, "log");
-  assert.equal(peopleCreateReachMode({}), "log");
-  // An unrecognised value falls back to the safe default rather than enforcing.
-  assert.equal(peopleCreateReachMode({ PEOPLE_CREATE_REACH_MODE: "nonsense" }), "log");
+test("the code default is ENFORCE, with log kept as the kill switch", () => {
+  assert.equal(PEOPLE_CREATE_REACH_MODE_DEFAULT, "enforce");
+  assert.equal(peopleCreateReachMode({}), "enforce");
+  // An unrecognised value falls back to the default, so a typo cannot reopen the hole.
+  assert.equal(peopleCreateReachMode({ PEOPLE_CREATE_REACH_MODE: "nonsense" }), "enforce");
+  assert.equal(peopleCreateReachMode({ PEOPLE_CREATE_REACH_MODE: "log" }), "log");
   assert.equal(peopleCreateReachMode({ PEOPLE_CREATE_REACH_MODE: "ENFORCE" }), "enforce");
   assert.equal(peopleCreateReachMode({ PEOPLE_CREATE_REACH_MODE: "off" }), "off");
 });
@@ -63,9 +63,12 @@ test("OFF does not even look", () => {
 });
 
 test("the flag is the only thing between counting and refusing", () => {
-  // If this ever fails, the default has been changed and people who can create
-  // a person today may stop being able to - which is the RP-5 line.
+  // The default refuses an unreachable estate; `log` is the kill switch that
+  // counts instead. If either half fails, the hole is open or the switch is gone.
   const unreachable = { reachable: false };
-  assert.equal(peopleCreateVerdict({ mode: peopleCreateReachMode({}), ...unreachable }).refuse, false);
-  assert.equal(peopleCreateVerdict({ mode: "enforce", ...unreachable }).refuse, true);
+  assert.equal(peopleCreateVerdict({ mode: peopleCreateReachMode({}), ...unreachable }).refuse, true);
+  assert.equal(
+    peopleCreateVerdict({ mode: peopleCreateReachMode({ PEOPLE_CREATE_REACH_MODE: "log" }), ...unreachable }).refuse,
+    false,
+  );
 });