@7365admin1/core 3.66.0 → 3.67.0

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@7365admin1/core",
   "license": "MIT",
-  "version": "3.66.0",
+  "version": "3.67.0",
   "author": "7365admin1",
   "main": "dist/index.js",
   "module": "dist/index.mjs",

package/test/notification-access.test.mjs

@@ -41,21 +41,50 @@ const enforced = (over = {}) =>
 const WO = { category: "workOrder", siteId: SITE };
 const on = (fn) => withEnv({ NOTIFY_ACCESS_FILTER: "on", MODULE_LIST_GATE: undefined }, fn);
 
-test("the code default is LOG; anything unrecognised is log", () => {
-  assert.equal(notifyAccessMode({}), "log");
-  assert.equal(notifyAccessMode({ NOTIFY_ACCESS_FILTER: "garbage" }), "log");
-  assert.equal(notifyAccessMode({ NOTIFY_ACCESS_FILTER: "ON" }), "on");
+test("the code default is ON; anything unrecognised falls back to that default", () => {
+  // Owner, 2026-09-13: turn the filter on. Unset env => the code default.
+  assert.equal(notifyAccessMode({}), "on");
+  assert.equal(notifyAccessMode({ NOTIFY_ACCESS_FILTER: "garbage" }), "on");
+  assert.equal(notifyAccessMode({ NOTIFY_ACCESS_FILTER: "LOG" }), "log");
   assert.equal(notifyAccessMode({ NOTIFY_ACCESS_FILTER: "off" }), "off");
 });
 
-test("LOG never drops: the denied recipient is counted and still sent to", async () => {
+test("the DEFAULT drops, with no env var set at all", async () => {
+  // The flip itself: this is the test that fails if the default goes back to
+  // `log`. `undefined` means "nothing set on the server", i.e. production.
+  const { data } = enforced({ rows: [member()] });
+  const sent = await withEnv({ NOTIFY_ACCESS_FILTER: undefined, MODULE_LIST_GATE: undefined }, () =>
+    filterByAccess([USER], WO, data),
+  );
+  assert.deepEqual(sent, [], "the denied recipient is dropped by the default alone");
+});
+
+test("LOG still never drops: the denied recipient is counted and still sent to", async () => {
   const { data } = enforced({ rows: [member()] });
   const report = await notificationAccessReport([USER], WO, data);
   assert.deepEqual(report.dropByModule, [USER], "control: the list does deny work orders");
-  const sent = await withEnv({ NOTIFY_ACCESS_FILTER: undefined }, () => filterByAccess([USER], WO, data));
+  // A lead putting it back to `log` must still send to everyone, with no deploy.
+  const sent = await withEnv({ NOTIFY_ACCESS_FILTER: "log" }, () => filterByAccess([USER], WO, data));
   assert.deepEqual(sent, [USER]);
 });
 
+test("a client with NO enforced list is untouched by the default being on", async () => {
+  // Why the flip is safe on the day it ships: no organisation and no site had an
+  // enforced list, so the filter returns early and reads nothing.
+  const { data, calls } = fakeGate({
+    orgs: { [ORG]: { _id: ORG } },
+    sites: { [SITE]: SITE_DOC },
+    roles: { r1: { permissions: ["*"] } },
+    rows: [member()],
+  });
+  assert.deepEqual(await filterByAccess([USER], WO, data), [USER]);
+  // It does read the org and the site to find out whether a list is enforced.
+  // What it must not do is the expensive part: `members.user` has no index to
+  // use, so a members/roles read on every send is the cost worth avoiding.
+  assert.equal(calls.members, undefined, "no members read while nothing is enforced");
+  assert.equal(calls.roles, undefined, "no roles read while nothing is enforced");
+});
+
 test("ON drops only the member whose client list denies the module", async () => {
   const other = member({ user: USER_2, org: "9".repeat(24), siteId: SITE }); // a provider: own org, no list
   const { data } = enforced({ rows: [member(), other] });