@7365admin1/core 3.64.5 → 3.65.1

package/test/module-gate.fixtures.mjs

@@ -0,0 +1,108 @@
+/*
+ * Shared fakes for the module-gate tests: an in-memory `TModuleGateData`, so
+ * the SHIPPED service and utils run with no database. Not a test file itself
+ * (`node --test test/*.test.mjs` does not pick it up).
+ */
+import { moduleListHash } from "./.build/utils/module-gate.util.mjs";
+
+export const ORG = "a".repeat(24);
+export const OTHER_ORG = "b".repeat(24);
+export const SITE = "c".repeat(24);
+export const OTHER_SITE = "d".repeat(24); // belongs to OTHER_ORG
+export const USER = "e".repeat(24);
+export const USER_2 = "f".repeat(24);
+
+export const CLIENT_SAVE = "client.modules-changed";
+export const SITE_SAVE = "site.modules-changed";
+// In the past: a real save row is never stamped later than now.
+export const SAVED_AT = "2026-01-01T00:00:00.000Z";
+
+/** The console-audit row the NEW save path writes for `list`. */
+export const ackRow = (list, createdAt = SAVED_AT) => ({
+  after: { modules: list.join(", "), moduleCount: list.length, gateListHash: moduleListHash(list) },
+  createdAt,
+});
+
+/** A row the OLD save path wrote: no fingerprint. */
+export const oldRow = (list) => ({ after: { modules: list.join(", "), moduleCount: list.length }, createdAt: SAVED_AT });
+
+export const member = (over = {}) => ({
+  _id: "m".repeat(23) + "1",
+  user: USER,
+  type: "security_agency",
+  org: ORG,
+  siteId: "",
+  status: "active",
+  role: "r1",
+  ...over,
+});
+
+/**
+ * `throwOn` names loaders that reject. `calls` counts every loader call, so a
+ * test can prove a path reads NOTHING.
+ */
+export function fakeGate({
+  rows = [],
+  orgs = {},
+  sites = {},
+  saves = {},
+  staff = false,
+  members = [],
+  roles = {},
+  throwOn = [],
+} = {}) {
+  const calls = {};
+  const hit = (name) => {
+    calls[name] = (calls[name] ?? 0) + 1;
+    if (throwOn.includes(name)) throw new Error(`${name} is down`);
+  };
+  const data = {
+    async membershipsOf(ids) {
+      hit("membershipsOf");
+      return rows.filter((r) => ids.includes(String(r.user)));
+    },
+    async org(id) {
+      hit("org");
+      return orgs[id] ?? null;
+    },
+    async site(id) {
+      hit("site");
+      return sites[id] ?? null;
+    },
+    async latestSave(action, org, target) {
+      hit("latestSave");
+      return saves[`${action}|${target}`] ?? null;
+    },
+    async isPlatformStaff() {
+      hit("isPlatformStaff");
+      return staff;
+    },
+    async staffMembers(query) {
+      hit("staffMembers");
+      calls.staffMembersQuery = query;
+      return members;
+    },
+    async roles(ids) {
+      hit("roles");
+      return Object.fromEntries(ids.filter((id) => roles[id]).map((id) => [id, roles[id]]));
+    },
+  };
+  return { data, calls };
+}
+
+/** Run `fn` with these env values, then put the environment back. */
+export async function withEnv(env, fn) {
+  const saved = Object.fromEntries(Object.keys(env).map((k) => [k, process.env[k]]));
+  for (const [k, v] of Object.entries(env)) {
+    if (v === undefined) delete process.env[k];
+    else process.env[k] = v;
+  }
+  try {
+    return await fn();
+  } finally {
+    for (const [k, v] of Object.entries(saved)) {
+      if (v === undefined) delete process.env[k];
+      else process.env[k] = v;
+    }
+  }
+}

package/test/module-gate.test.mjs

@@ -235,3 +235,67 @@ test("moduleImpact survives junk input", () => {
     );
   }
 });
+
+/* ── the switch, the acknowledged-save marker, one member's deny list ── */
+
+import {
+  MODULE_LIST_GATE_DEFAULT,
+  moduleListGateOn,
+  moduleListHash,
+  enforcedModuleList,
+  deniedForMembership,
+  GATE_LIST_HASH_FIELD,
+} from "./.build/utils/module-gate.util.mjs";
+
+test("MODULE_LIST_GATE: on by default; off/false/0/no switch the whole gate off", () => {
+  assert.equal(MODULE_LIST_GATE_DEFAULT, "on");
+  assert.equal(moduleListGateOn({}), true);
+  assert.equal(moduleListGateOn({ MODULE_LIST_GATE: "on" }), true);
+  assert.equal(moduleListGateOn({ MODULE_LIST_GATE: "typo" }), true, "a typo keeps the default");
+  for (const off of ["off", " OFF ", "false", "0", "no"]) {
+    assert.equal(moduleListGateOn({ MODULE_LIST_GATE: off }), false, off);
+  }
+});
+
+test("the list fingerprint ignores order, duplicates and junk; empty is no fingerprint", () => {
+  assert.equal(moduleListHash(["b", "a"]), moduleListHash(["a", "b", "a", 7, " "]));
+  assert.notEqual(moduleListHash(["a"]), moduleListHash(["a", "b"]));
+  assert.equal(moduleListHash([]), "");
+  assert.equal(moduleListHash(undefined), "");
+  assert.match(moduleListHash(["a"]), /^[0-9a-f]{64}$/);
+});
+
+test("a stored list is enforced only when its latest save carries its fingerprint", () => {
+  const list = ["visitor-mgmt"];
+  const row = (hash, createdAt = "2026-09-12T00:00:00.000Z") => ({ after: { [GATE_LIST_HASH_FIELD]: hash }, createdAt });
+  assert.deepEqual(enforcedModuleList(list, row(moduleListHash(list))), { list, since: "2026-09-12T00:00:00.000Z" });
+  for (const save of [undefined, null, {}, { after: null }, row(""), row(moduleListHash(["other"]))]) {
+    assert.deepEqual(enforcedModuleList(list, save), { list: [], since: "" }, JSON.stringify(save));
+  }
+  // An empty stored list is absent whatever the row says.
+  assert.deepEqual(enforcedModuleList([], row(moduleListHash([]))), { list: [], since: "" });
+});
+
+test("deniedForMembership: residents and org-less rows are exempt; since is the latest save", () => {
+  const orgList = ["visitor-mgmt", "nfc-patrol"];
+  const siteList = ["visitor-mgmt"];
+  const save = (list, at) => ({ after: { [GATE_LIST_HASH_FIELD]: moduleListHash(list) }, createdAt: at });
+  const args = {
+    membership: { org: "a".repeat(24), type: "security_agency" },
+    org: { modules: orgList },
+    orgSave: save(orgList, "2026-09-12T00:00:00.000Z"),
+    site: { orgId: "a".repeat(24), metadata: { modules: siteList } },
+    siteSave: save(siteList, "2026-09-13T00:00:00.000Z"),
+  };
+  const both = deniedForMembership(args);
+  assert.ok(both.denied.includes("nfc-patrol"), "the site tier narrows inside its own org");
+  assert.equal(both.since, "2026-09-13T00:00:00.000Z");
+
+  for (const membership of [{ ...args.membership, type: "resident" }, { type: "admin" }, null]) {
+    assert.deepEqual(deniedForMembership({ ...args, membership }), { denied: [], since: "" });
+  }
+  // A site of ANOTHER organisation never narrows (Q1: providers follow their own company).
+  const elsewhere = deniedForMembership({ ...args, site: { ...args.site, orgId: "b".repeat(24) } });
+  assert.ok(!elsewhere.denied.includes("nfc-patrol"));
+  assert.equal(elsewhere.since, "2026-09-12T00:00:00.000Z");
+});