@7365admin1/core 3.64.3-staging.286 → 3.64.3-staging.287

package/.changeset/site-update-ignores-derived-resident-modules.md

@@ -0,0 +1,16 @@
+---
+"@7365admin1/core": patch
+---
+
+Stop refusing Site Settings saves that send back `metadata.residentAppModulesEffective`.
+
+`GET /api/sites/:id` attaches the derived `residentAppModulesEffective` to
+`metadata` on every read, and the Site Settings screens save by sending the
+metadata they read straight back. `updateSiteSchema` does not allow that key, so
+`PATCH /api/sites/id/:id` refused the whole save with "is not allowed" — the
+resident-app configuration panel, the HID QR code pass and the HID face-reader
+toggle all failed.
+
+`updateById` now drops the derived key before validating. It is never stored and
+is recomputed on the next read, so nothing is lost; every stored key, including
+`residentAppModules`, is validated and saved exactly as before.

package/dist/index.js

@@ -38517,6 +38517,13 @@ function residentAppModulesAboveCeiling(orgModules, requested) {
 function residentAppModulesAboveCeilingMessage(rejected) {
   return `This client has not been given ${rejected.join(", ")} in the resident app, so a site cannot switch it on. Ask Seven365 to add it to the organisation first.`;
 }
+function withoutDerivedSiteMetadata(metadata) {
+  if (!metadata || typeof metadata !== "object" || Array.isArray(metadata)) {
+    return metadata;
+  }
+  const { residentAppModulesEffective: _derived, ...stored } = metadata;
+  return stored;
+}
 function asModules(value) {
   return value && typeof value === "object" && !Array.isArray(value) ? value : {};
 }
@@ -38704,8 +38711,9 @@ function useSiteController() {
   }
   async function updateById(req, res, next) {
     try {
+      const body = req.body?.metadata ? { ...req.body, metadata: withoutDerivedSiteMetadata(req.body.metadata) } : req.body;
       const { error, value } = updateSiteSchema.validate(
-        { _id: req.params.id, ...req.body },
+        { _id: req.params.id, ...body },
         { abortEarly: false }
       );
       if (error) {