@7365admin1/core 3.59.0 → 3.59.2

package/CHANGELOG.md

@@ -1,5 +1,25 @@
 # @iservice365/core
 
+## 3.59.2
+
+### Patch Changes
+
+- db311b7: Resident self-sign-up: record the documents the app never managed to upload, so a reviewer can see one is missing.
+
+  Dropping id-less file entries kept the applicant, but it also made the registration indistinguishable from one with nothing attached — the reviewer console renders `Files:` with an empty list either way, and a person was approved in that state without the tenancy agreement it was meant to carry.
+
+  `unsentFileNames` reports the names of the entries `dropUnsentFiles` throws away, and `addResidentSelfSignUp` pins them onto the person as `filesNotUploaded` — the same way `status` and `platform` are pinned, never accepted from the caller (it is absent from the self-sign-up allow-list, which validates with `stripUnknown`). The key is omitted entirely when every upload landed, so a normal registration is written exactly as it is today. Names are bounded to 10 entries of 120 characters because the route is pre-login.
+
+## 3.59.1
+
+### Patch Changes
+
+- 9daa1cb: Resident self-sign-up: drop file entries the app never managed to upload, instead of refusing the whole registration.
+
+  The registration wizard lists a document optimistically and patches in the `id` the upload returns. When the upload fails it keeps the entry, with no `id`, and sends it - so `schemaFiles.id.required()` returned 400 `"files[0].id" is required` for the entire sign-up, and the app only logged it. Residents saw a Submit button that did nothing.
+
+  The self-sign-up path now drops id-less entries before validating. Strictly widening: the authenticated staff path (`schemaPerson`) and `schemaFiles` itself are unchanged, an entry with an `id` is passed through untouched, and a body with no `files` key is unchanged.
+
 ## 3.59.0
 
 ### Minor Changes

package/dist/index.d.ts

@@ -4713,6 +4713,13 @@ type TPerson = {
     plates?: TPlates[];
     isOwner?: boolean;
     files?: TFiles[];
+    /**
+     * Attachments the resident-app wizard listed but never actually uploaded, so
+     * they arrived with no `id` and were dropped from `files`. Pinned
+     * server-side on the pre-login self-signup path only - never accepted from a
+     * caller. See `utils/self-signup-files.util.ts`.
+     */
+    filesNotUploaded?: string[];
     plateNumber?: string;
     platform?: string;
     approvedBy?: TApprover;
@@ -4772,6 +4779,12 @@ declare function MPerson(value: TPerson): {
     deletedAt: string | Date | undefined;
     acceptedTermsAt: string;
     acceptedTerms?: ObjectId | undefined;
+    plateNumber: string;
+    platForm: string;
+    approvedBy: TApprover;
+    countryCode: string;
+    callingCode: string;
+    filesNotUploaded?: string[] | undefined;
     _id: ObjectId | undefined;
     user: string | ObjectId;
     name: string;
@@ -4794,11 +4807,6 @@ declare function MPerson(value: TPerson): {
     plates: TPlates[];
     isOwner: boolean;
     files: TFiles[];
-    plateNumber: string;
-    platForm: string;
-    approvedBy: TApprover;
-    countryCode: string;
-    callingCode: string;
 };
 type visitorType = "guest" | "walk-in" | "contractor" | "delivery";
 type visitorPersonService = {

package/dist/index.js

@@ -17778,6 +17778,11 @@ var schemaPerson = import_joi17.default.object({
   plates: import_joi17.default.array().items(schemaPlate).optional().allow(null),
   isOwner: import_joi17.default.boolean().required(),
   files: import_joi17.default.array().items(schemaFiles).optional().allow(null),
+  // Set by `addResidentSelfSignUp`, not by any caller: it is absent from the
+  // self-signup allow-list, which validates with `stripUnknown`. It is named
+  // here only because `MPerson` runs `schemaPerson` over the finished payload
+  // and Joi refuses unknown keys.
+  filesNotUploaded: import_joi17.default.array().items(import_joi17.default.string()).optional(),
   password: import_joi17.default.string().optional().allow(null, ""),
   plateNumber: import_joi17.default.string().optional().allow(null, ""),
   platform: import_joi17.default.string().valid("web", "mobile").optional().allow(null, ""),
@@ -17934,6 +17939,11 @@ function MPerson(value) {
     plates: value.plates ?? [],
     isOwner: value.isOwner ?? false,
     files: value.files ?? [],
+    // Conditional, because this return is a WHITELIST: everything not named
+    // here is dropped on the way to the database, and a bare
+    // `filesNotUploaded: value.filesNotUploaded` would add an `undefined` key
+    // to every person ever written. Absent when every upload landed.
+    ...value.filesNotUploaded?.length ? { filesNotUploaded: value.filesNotUploaded } : {},
     plateNumber: value.plateNumber ?? "",
     platForm: value.platform ?? "",
     approvedBy: value.approvedBy ?? { id: "", name: "" },
@@ -58521,6 +58531,24 @@ function useGuestManagementController() {
 var import_joi71 = __toESM(require("joi"));
 var import_node_server_utils143 = require("@7365admin1/node-server-utils");
 var import_node_server_utils144 = require("@7365admin1/node-server-utils");
+
+// src/utils/self-signup-files.util.ts
+function dropUnsentFiles(body) {
+  if (!Array.isArray(body?.files))
+    return body;
+  return { ...body, files: body.files.filter((file) => file?.id) };
+}
+var MAX_UNSENT_FILE_NAMES = 10;
+var MAX_UNSENT_FILE_NAME_LENGTH = 120;
+function unsentFileNames(body) {
+  if (!body || !Array.isArray(body.files))
+    return [];
+  return body.files.filter((file) => file && !file.id).slice(0, MAX_UNSENT_FILE_NAMES).map(
+    (file) => typeof file.name === "string" && file.name.trim() ? file.name.trim().slice(0, MAX_UNSENT_FILE_NAME_LENGTH) : "Unnamed document"
+  );
+}
+
+// src/controllers/person.controller.ts
 function usePersonController() {
   const {
     getAll: _getAll,
@@ -58559,7 +58587,9 @@ function usePersonController() {
     return actor;
   }
   async function addResidentSelfSignUp(req, res, next) {
-    const { error, value } = schemaResidentSelfSignUp.validate(req.body, {
+    const body = dropUnsentFiles(req.body);
+    const notUploaded = unsentFileNames(req.body);
+    const { error, value } = schemaResidentSelfSignUp.validate(body, {
       abortEarly: false,
       stripUnknown: true
     });
@@ -58580,7 +58610,10 @@ function usePersonController() {
       // "pending" or "active", so a caller who sent `platform: "web"` got a
       // live account without anyone reviewing them.
       status: SELF_SIGNUP_STATUS,
-      platform: SELF_SIGNUP_PLATFORM
+      platform: SELF_SIGNUP_PLATFORM,
+      // Pinned the same way, and omitted entirely when every upload landed, so
+      // a normal registration is written exactly as it is written today.
+      ...notUploaded.length > 0 ? { filesNotUploaded: notUploaded } : {}
     };
     try {
       const data = await _add(payload);