@7365admin1/core 3.53.7 → 3.53.8

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@7365admin1/core",
   "license": "MIT",
-  "version": "3.53.7",
+  "version": "3.53.8",
   "author": "7365admin1",
   "main": "dist/index.js",
   "module": "dist/index.mjs",

package/test/notification-category.util.test.mjs

@@ -13,6 +13,7 @@ import {
   ORG_MARKETPLACE_VENDOR_FIELD,
   categoriesForPermissions,
   categorySupportsChannel,
+  notificationCategory,
   notificationCategoryLabel,
 } from "./.build/utils/notification-category.util.mjs";
 
@@ -42,7 +43,7 @@ describe("notification categories", () => {
     }
   });
 
-  it("the four safety categories now send, and are on by default and switchable", () => {
+  it("the four safety categories are on by default and switchable", () => {
     const safety = NOTIFICATION_CATEGORIES.filter((c) => c.safety);
 
     assert.deepEqual(keys(safety), [
@@ -56,7 +57,6 @@ describe("notification categories", () => {
       // nothing about them is special-cased: no "locked" flag, so they behave
       // like any other switch.
       assert.ok(!("locked" in category));
-      assert.equal(category.rendered, true, category.key);
 
       // a safety alert is permission-scoped, never a resident default — a
       // category with no resource would reach nobody.
@@ -71,7 +71,6 @@ describe("notification categories", () => {
   it("a role holding only the safety module is offered only that switch", () => {
     const cases = {
       "incident-reports:create": "incidentReport",
-      "emergency-contact:update": "emergencyContact",
       "virtual-patrol:see-all": "virtualPatrol",
       "site-settings:update": "cameraFault",
     };
@@ -143,7 +142,7 @@ describe("notification categories", () => {
       (c) => c.channels.email,
     ).map((c) => c.key);
 
-    assert.deepEqual(emailCapable, ["serviceProviderInvite"]);
+    assert.deepEqual(emailCapable, []);
   });
 
   it("every channel a category cannot use explains itself in plain words", () => {
@@ -174,10 +173,50 @@ describe("notification categories", () => {
   it("channel support is a fact about the category, not a preference", () => {
     assert.equal(categorySupportsChannel("workOrder", "push"), true);
     assert.equal(categorySupportsChannel("workOrder", "email"), false);
-    assert.equal(categorySupportsChannel("serviceProviderInvite", "email"), true);
+    assert.equal(categorySupportsChannel("serviceProviderInvite", "email"), false);
     assert.equal(categorySupportsChannel("not-a-module", "push"), false);
   });
 
+  // -------------------------------------------------------------------------
+  // What the September 2026 audit fixed. Both of these FAIL against the
+  // catalogue as it stood before it: `serviceProviderInvite` declared
+  // `email: true` and `emergencyContact` declared `rendered: true`.
+  // -------------------------------------------------------------------------
+
+  it("no category offers a switchable Email row, because no sender reads one", () => {
+    // `filterRecipients`/`isChannelEnabled` are never called with "email"
+    // anywhere in the estate, so a movable Email switch would govern nothing.
+    for (const category of NOTIFICATION_CATEGORIES) {
+      assert.equal(
+        category.channels.email,
+        false,
+        `${category.key} offers a live Email switch that no sender consults`,
+      );
+      assert.ok(
+        category.channelNote?.email,
+        `${category.key} dims Email without saying why`,
+      );
+    }
+  });
+
+  it("emergency contacts are not offered, because nothing calls their sender", () => {
+    // The sender exists in `notification.service.ts`, but emergency contacts
+    // are written in `iservice365-API-core` and the caller there was never
+    // merged. A switch over a message that cannot arrive is the defect this
+    // whole catalogue exists to prevent.
+    const category = notificationCategory("emergencyContact");
+    assert.equal(category.rendered, false);
+
+    for (const permissions of [["emergency-contact:update"], ["*"]]) {
+      assert.ok(
+        !keys(categoriesForPermissions({ permissions, isResident: true })).includes(
+          "emergencyContact",
+        ),
+        `offered to ${permissions.join()}`,
+      );
+    }
+  });
+
   it("category keys are unique", () => {
     const all = NOTIFICATION_CATEGORIES.map((c) => c.key);
     assert.equal(new Set(all).size, all.length);
@@ -332,7 +371,6 @@ const BEFORE = {
     "prelovedMarketplace",
     "serviceProviderInvite",
     "incidentReport",
-    "emergencyContact",
     "virtualPatrol",
     "cameraFault",
   ],
@@ -340,7 +378,7 @@ const BEFORE = {
     "bulletin-board": ["bulletinBoard"],
     "bulletin-board-mgmt": ["bulletinBoard"],
     "bulletin-videos-mgmt": ["bulletinBoard"],
-    "emergency-contact": ["emergencyContact"],
+    "emergency-contact": [],
     "event-mgmt": ["event"],
     "facility-booking-mgmt": ["facilityBooking"],
     "facility-mgmt": ["facilityBooking"],
@@ -413,11 +451,7 @@ describe("existing categories are untouched by the marketplace addition", () =>
     for (const category of NOTIFICATION_CATEGORIES) {
       if (NEW_KEYS.includes(category.key)) continue;
 
-      assert.equal(
-        category.channels.email,
-        category.key === "serviceProviderInvite",
-        category.key,
-      );
+      assert.equal(category.channels.email, false, category.key);
       assert.equal(category.channels.inApp, true, category.key);
       assert.equal(category.channels.push, true, category.key);
     }