@7365admin1/core 3.52.2-staging.235 → 3.52.2-staging.237

package/.changeset/vehicle-anpr-revoke-safety.md

@@ -0,0 +1,11 @@
+---
+"@7365admin1/core": patch
+---
+
+Vehicle management: make deleting and editing a vehicle safe against the ANPR cameras.
+
+Deleting a vehicle no longer reports success when the plate is still on a camera. `bypass` now defaults to false, `removePlateNumber` returns an explicit per-camera outcome instead of swallowing its error, and a delete that cannot be confirmed on every camera holding the plate is refused with the record left intact so it can be retried. A site with no ANPR camera has nothing to revoke and now deletes successfully instead of failing with "No site cameras found."
+
+Each camera is asked for its own record id before the removal, because a Dahua `recNo` is a per-device sequence number and the one stored on the vehicle only matches whichever camera was written last. Editing only the vehicle's name now removes the old whitelist record before inserting the new one, instead of leaving the previous entry on the camera for good.
+
+Also: `pullVehicleByRecNo` is scoped to the person or site the plate belongs to (it matched on the record id alone, which is not unique across devices), the paginated camera lookups no longer skip their last page, and editing or deleting a vehicle now requires `vehicle-mgmt:update-vehicle` / `vehicle-mgmt:delete-vehicle` on the server, matching the gate the apps already apply in the browser.

package/.changeset/vehicle-create-fail-closed.md

@@ -0,0 +1,10 @@
+---
+"@7365admin1/core": patch
+---
+
+Vehicle ANPR: create now fails closed, an unregistered vehicle can be deleted, and camera errors are readable
+
+- `add()` no longer reports "added to whitelist successfully" when nothing was written to a camera. Camera failures are collected per camera, any plate already written is taken back off, and the whole create is refused. A site with no active ANPR camera saves the vehicle but says plainly that the barrier does not know about it.
+- Deleting a vehicle with a blank or missing `recno` is no longer rejected by request validation. The per-camera revoke guarantee is unchanged.
+- Dahua's own reply (`Invalid Authority!`, `{"ErrorCode":...}`) is logged server-side and no longer put into the message the operator sees, on create, approve and edit.
+- Editing a vehicle restores the previous plate on the camera if the re-insert fails, instead of leaving the resident locked out by a change the database then rolls back.

package/dist/index.d.ts

@@ -2505,6 +2505,31 @@ declare function useBuildingUnitController(): {
     getAllLevelsWithUnits: (req: Request, res: Response, next: NextFunction) => Promise<void>;
 };
 
+/**
+ * "Was this plate actually taken off the camera?" — the one place that answers
+ * it, for the three paths that revoke an ANPR whitelist/blocklist record:
+ * deleting a vehicle, and the two branches of editing one.
+ *
+ * The reason this file exists: `removePlateNumber` used to `catch`, log, and
+ * return `undefined`, so a device that refused, timed out or was unreachable
+ * came back looking exactly like one that had removed the record. The delete
+ * path then reported "Vehicle deleted successfully." while the plate was still
+ * on the barrier — the vehicle could keep driving in after the record was gone
+ * from the system, and there was nothing on screen to say so.
+ *
+ * Nothing here talks to a device or to the database, so it is testable on its
+ * own — see `test/anpr-revoke.test.mjs`.
+ */
+/** One camera's answer to "remove this record". */
+type AnprRevokeOutcome = {
+    /** True ONLY when the device confirmed the removal, or held nothing to remove. */
+    ok: boolean;
+    /** HTTP status the device answered with, when it answered at all. */
+    statusCode?: number;
+    /** Why it failed, in words an operator can act on. Empty when `ok`. */
+    reason: string;
+};
+
 declare enum CameraType {
     IP = "ip",
     ANPR = "anpr"
@@ -2573,7 +2598,7 @@ declare function useDahuaService(): {
         password: string;
         mode: string;
         recno: string;
-    }) => Promise<urllib.HttpClientResponse<any> | undefined>;
+    }) => Promise<AnprRevokeOutcome>;
     updatePlateNumber: (value: {
         host: string;
         username: string;
@@ -2592,6 +2617,18 @@ declare function useDahuaService(): {
         password: string;
         mode: string;
         plateNumber: string;
+        /**
+         * Treat a device that did not answer 200 as an error rather than as "the
+         * plate is not on this camera".
+         *
+         * `useDahuaDigest` does not throw on a bad status, so a 401 or a 500 comes
+         * back as an empty body, which `parseDahuaFind` reads as `found=0`. For the
+         * visitor check-in callers that has always meant "not blocklisted" and is
+         * left exactly as it is — a camera fault must not stop a visitor at the
+         * gate. For the vehicle revoke paths it would mean "nothing to remove", and
+         * they must not conclude that from a camera that never answered.
+         */
+        requireOk?: boolean;
     }) => Promise<any>;
     bulkInsertPlateNumber: (value: {
         host: string;
@@ -4109,7 +4146,7 @@ declare function useCameraViewService(): {
         userId?: string;
     }) => Promise<{
         reason: string;
-        verified: "recorder-video-port" | "nothing";
+        verified: "nothing" | "recorder-video-port";
         verifiedDescription: string;
         cameraVerified: null;
         relayVerified: null;
@@ -4123,7 +4160,7 @@ declare function useCameraViewService(): {
         driftSeconds: null;
         detailUnavailableReason: string | null;
     } | {
-        verified: "recorder-video-port" | "nothing";
+        verified: "nothing" | "recorder-video-port";
         verifiedDescription: string;
         cameraVerified: null;
         relayVerified: null;
@@ -4166,7 +4203,7 @@ declare function useCameraViewService(): {
     }) => Promise<{
         cameras: ({
             reason: string;
-            verified: "recorder-video-port" | "nothing";
+            verified: "nothing" | "recorder-video-port";
             verifiedDescription: string;
             cameraVerified: null;
             relayVerified: null;
@@ -4180,7 +4217,7 @@ declare function useCameraViewService(): {
             lastFrameAt: string | null;
             unavailableReason: string | null;
         } | {
-            verified: "recorder-video-port" | "nothing";
+            verified: "nothing" | "recorder-video-port";
             verifiedDescription: string;
             cameraVerified: null;
             relayVerified: null;
@@ -5011,7 +5048,12 @@ declare function usePersonRepo(): {
         plateNumber: string;
         recNo: string;
     }, session?: ClientSession) => Promise<void>;
-    pullVehicleByRecNo: (recNo: string, session?: ClientSession) => Promise<void>;
+    pullVehicleByRecNo: (recNo: string, scope: {
+        peopleId?: string | ObjectId;
+        site?: string | ObjectId;
+        /** Used INSTEAD of `recNo` when the vehicle never got a record id. */
+        plateNumber?: string;
+    }, session?: ClientSession) => Promise<void>;
     getByUserId: (userId: string | ObjectId) => Promise<TPerson | null>;
     reviewResidentPerson: (_id: ObjectId | string, value: Partial<TPerson>, session?: ClientSession) => Promise<mongodb.UpdateResult<TPerson>>;
     addFromVisitor: (value: visitorPersonRepo, session?: ClientSession) => Promise<mongodb.InsertOneResult<TPerson>>;