@7365admin1/core 3.52.18 → 3.52.19

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@7365admin1/core",
   "license": "MIT",
-  "version": "3.52.18",
+  "version": "3.52.19",
   "author": "7365admin1",
   "main": "dist/index.js",
   "module": "dist/index.mjs",

package/test/e2e/onboarding-org-save-diagnosis.e2e.test.mjs

@@ -0,0 +1,220 @@
+// Why onboarding step 1 answers `{"status":"error","message":"Failed to update
+// organization."}` on production, and what the person is supposed to do about it.
+//
+// Reported live from `org.app.iservice365.org/onboarding/getting-started`: the
+// "Organization Details" modal is filled in, Submit is pressed, and the single
+// `PUT /api/organizations/:id` behind it comes back 500 with that exact body.
+// The web app maps any 5xx to "The server could not save your details. Please
+// try again in a moment." — so nobody, on either side of the wire, learns
+// anything at all about what went wrong.
+//
+// The handler is `organization.repo.ts update()`. Inside its `try` there are
+// exactly two awaited calls: `collection.updateOne` and `delNamespace()`.
+// `delNamespace` swallows every error of its own (`node-server-utils@1.6.0`
+// `useCache`), and `new ObjectId(id)` cannot throw for the 24-hex id in the
+// URL. So the 500 is a MongoDB WRITE ERROR on `organizations` — and the catch
+// throws it away, keeping only `error.message` in a log line with no error
+// code, no key and no organisation id.
+//
+// The write error this collection actually produces is a duplicate key.
+// `organizations` has carried a UNIQUE index since the first version of this
+// repository — `createUniqueIndex()` was `createIndex({ name: 1 }, { unique:
+// true })` (36150ea0), later re-pointed at `email`, and `06ee8915` ("remove
+// unique email index and support multiple orgs per email") stopped CREATING a
+// unique one. Nothing has ever DROPPED the one already built, and `setup.ts`
+// only logs when the re-create conflicts. So the index outlives the code that
+// wanted it.
+//
+// `add()` already knows this — it maps a duplicate to "Organization already
+// exist." `update()` does not, and that asymmetry is the whole defect: create
+// says what is wrong, save says nothing.
+//
+// Everything below is created and thrown away by the harness: an in-process
+// MongoDB replica set, a loopback Redis, a loopback mail sink. No staging or
+// production database, Redis, mailbox or endpoint is touched.
+//
+// Run with: yarn build && node --test test/e2e/onboarding-org-save-diagnosis.e2e.test.mjs
+
+import { after, before, describe, it } from "node:test";
+import assert from "node:assert/strict";
+import { ObjectId } from "mongodb";
+
+import { startHarness } from "./harness.mjs";
+
+const PASSWORD = "OrgSave-Passw0rd!";
+const OWNER = "os-owner@e2e.example.com";
+const TAKEN_NAME = "Benar Property Org";
+
+describe("onboarding step 1 says what is wrong when the save is refused", { concurrency: 1 }, () => {
+  let h;
+  const id = {};
+  const result = [];
+
+  const record = (name, fn) =>
+    it(name, async () => {
+      try {
+        await fn();
+        result.push(["PASS", name]);
+      } catch (error) {
+        result.push(["FAIL", name]);
+        throw error;
+      }
+    });
+
+  before(async () => {
+    h = await startHarness();
+    Object.assign(id, await seed(h));
+  }, { timeout: 300000 });
+
+  after(async () => {
+    if (h) await h.stop();
+    console.log("\n--- onboarding organisation save: per-case result ---");
+    for (const [verdict, name] of result) console.log(`${verdict}  ${name}`);
+  });
+
+  let ownerSid;
+
+  const ownOrg = async () =>
+    await h.db.collection("organizations").findOne({ _id: id.ownOrg });
+
+  /**
+   * The body `OrgDetails.vue submit()` sends, verbatim.
+   *
+   * `utils/onboarding-org-details.js orgUpdatePayload()` deletes every empty
+   * value before it leaves the browser, which is why Industry, Registration
+   * Number, the alternate contact number, Country and State/Province are ABSENT
+   * here rather than sent as "" — the organisation record has no field for the
+   * last two at all, and `Joi.string()` rejects "" for the rest.
+   */
+  const modalBody = (name) => ({
+    name,
+    type: "business",
+    email: "os-benar@e2e.example.com",
+    contact: "+63 9569346664",
+  });
+
+  record("0. baseline — the owner signs in and reaches their own organisation", async () => {
+    ownerSid = await h.login(OWNER, PASSWORD);
+
+    assert.equal(
+      await h.db.collection("members").countDocuments({ user: id.owner }),
+      0,
+      "the owner must hold no membership — reach is by `createdBy` (DV-0248)",
+    );
+    assert.equal((await ownOrg()).name, "Ben Org");
+  });
+
+  record("1. renaming onto a name another organisation already holds", async () => {
+    const res = await h.api(`/organizations/${id.ownOrg}`, {
+      method: "PUT",
+      sid: ownerSid,
+      body: modalBody(TAKEN_NAME),
+    });
+
+    // Before the fix this is the production failure exactly:
+    //   500 {"status":"error","message":"Failed to update organization."}
+    assert.equal(
+      res.status,
+      400,
+      `expected an actionable 400, got ${res.status} ${JSON.stringify(res.body)}`,
+    );
+    assert.match(
+      String(res.body.message),
+      /already/i,
+      `the person must be told what to change: ${JSON.stringify(res.body)}`,
+    );
+    assert.match(
+      String(res.body.message),
+      /name/i,
+      `and WHICH field: ${JSON.stringify(res.body)}`,
+    );
+    assert.equal((await ownOrg()).name, "Ben Org", "nothing may be written");
+  });
+
+  record("2. the message never quotes the other client's record", async () => {
+    const res = await h.api(`/organizations/${id.ownOrg}`, {
+      method: "PUT",
+      sid: ownerSid,
+      body: modalBody(TAKEN_NAME),
+    });
+
+    const text = JSON.stringify(res.body);
+    assert.ok(!text.includes(String(id.otherOrg)), `leaks an id: ${text}`);
+    assert.ok(!/index|E11000|keyPattern|dup key/i.test(text), `leaks driver internals: ${text}`);
+  });
+
+  // ---- the control: the same request with a free name MUST go through -------
+
+  record("3. control — a free name saves, so case 1 is the name and not the route", async () => {
+    const res = await h.api(`/organizations/${id.ownOrg}`, {
+      method: "PUT",
+      sid: ownerSid,
+      body: modalBody("Ben Org Renamed"),
+    });
+
+    assert.equal(res.status, 200, JSON.stringify(res.body));
+
+    const saved = await ownOrg();
+    assert.equal(saved.name, "Ben Org Renamed");
+    assert.equal(saved.type, "business");
+    assert.equal(saved.contact, "+63 9569346664");
+  });
+
+  record("4. and the guard is unchanged — no session is still refused", async () => {
+    const res = await h.api(`/organizations/${id.ownOrg}`, {
+      method: "PUT",
+      body: modalBody("Ben Org Again"),
+    });
+
+    assert.equal(res.status, 401, JSON.stringify(res.body));
+    assert.equal((await ownOrg()).name, "Ben Org Renamed", "must be untouched");
+  });
+});
+
+async function seed(h) {
+  const now = new Date().toISOString();
+  const otherOrg = new ObjectId();
+  const ownOrg = new ObjectId();
+
+  const orgs = h.db.collection("organizations");
+
+  // The index the first version of this repository created at every boot
+  // (`setup.ts` -> `createUniqueIndex()`), and which nothing has ever dropped.
+  await orgs.createIndex({ name: 1 }, { unique: true });
+
+  await orgs.insertMany([
+    {
+      _id: otherOrg,
+      name: TAKEN_NAME,
+      email: "os-other@e2e.example.com",
+      type: "business",
+      nature: "property_management_agency",
+      status: "active",
+      createdAt: now,
+    },
+    {
+      _id: ownOrg,
+      name: "Ben Org",
+      email: "os-benorg@e2e.example.com",
+      type: "business",
+      nature: "property_management_agency",
+      status: "active",
+      contact: "+65 00000000",
+      createdAt: now,
+    },
+  ]);
+
+  const users = await h.db.collection("users").insertMany([
+    { email: OWNER, name: "os-owner", status: "active", createdAt: now },
+  ]);
+  const owner = users.insertedIds[0];
+
+  const hashed = await h.hashPassword(PASSWORD);
+  await h.db.collection("users").updateOne({ _id: owner }, { $set: { password: hashed } });
+
+  // DV-0248: the creator road is the only relationship a self-signup owner
+  // holds at step 1.
+  await orgs.updateOne({ _id: ownOrg }, { $set: { createdBy: owner } });
+
+  return { owner, ownOrg, otherOrg };
+}