@7365admin1/core 3.52.16-staging.267 → 3.52.16-staging.268

package/.changeset/org-update-diagnosable-error.md

@@ -0,0 +1,14 @@
+---
+"@7365admin1/core": patch
+---
+
+Say what is wrong when an organisation cannot be saved.
+
+`PUT /api/organizations/:id` — the write behind onboarding step 1 and the staff
+Client List edit — collapsed every MongoDB write error into a 500 reading
+"Failed to update organization.", with only `error.message` in the log. A
+duplicate-key refusal (the `organizations` collection still carries a unique
+index an earlier version of this file created and nothing ever dropped) is now
+a 400 naming the field the caller has to change, a typed error raised
+underneath is no longer turned into a 500, and the log line carries the error
+name, code, key and the organisation id.

package/dist/index.js

@@ -11683,6 +11683,19 @@ function MOrg(value) {
 
 // src/repositories/organization.repo.ts
 var import_mongodb19 = require("mongodb");
+var DUPLICATE_FIELD_LABEL = {
+  name: "name",
+  email: "email address"
+};
+function duplicatedField(error) {
+  if (error?.code !== 11e3 && !/duplicate/i.test(error?.message ?? "")) {
+    return "";
+  }
+  const fromPattern = Object.keys(error?.keyPattern ?? {})[0];
+  if (fromPattern)
+    return fromPattern;
+  return /index:\s*([A-Za-z0-9_]+?)_\d/.exec(error?.message ?? "")?.[1] ?? "";
+}
 function useOrgRepo() {
   const db2 = import_node_server_utils21.useAtlas.getDb();
   if (!db2) {
@@ -11764,8 +11777,21 @@ function useOrgRepo() {
       await delNamespace();
       return id;
     } catch (error) {
-      import_node_server_utils21.logger.log({ level: "error", message: error.message });
-      throw new import_node_server_utils21.InternalServerError("Failed to update organization.");
+      import_node_server_utils21.logger.log({
+        level: "error",
+        message: `Organization update failed for ${id}: ${error?.name ?? "Error"}${error?.code !== void 0 ? ` code=${error.code}` : ""}${duplicatedField(error) ? ` key=${duplicatedField(error)}` : ""} fields=[${Object.keys(value ?? {}).join(",")}] ${error?.message ?? ""}`
+      });
+      if (error instanceof import_node_server_utils21.AppError)
+        throw error;
+      const field = duplicatedField(error);
+      if (field) {
+        throw new import_node_server_utils21.BadRequestError(
+          `Another organization already uses this ${DUPLICATE_FIELD_LABEL[field] ?? field}. Please use a different one.`
+        );
+      }
+      throw new import_node_server_utils21.InternalServerError(
+        `Failed to update organization${error?.code !== void 0 ? ` (${error.code})` : ""}.`
+      );
     }
   }
   async function getAll({