@7365admin1/core 3.51.1-staging.229 → 3.52.1-staging.230

package/CHANGELOG.md

@@ -1,5 +1,78 @@
 # @iservice365/core
 
+## 3.52.0
+
+### Minor Changes
+
+- bd4bd88: Add a bulk camera import on the existing guided path.
+
+  `POST /api/site-cameras/bulk` accepts a site and up to 200 rows from the
+  technician survey sheet, derives each camera's relay address from its recorder
+  and channel number, and returns a per-row result. `commit: false` previews and
+  writes nothing; `commit: true` writes the rows that passed. Rows that are ANPR,
+  that carry a hand-written address, or whose channel is outside 1-256 are refused
+  by name, and a camera already at the site is reported as a duplicate rather than
+  as a write error. Creates `type: "ip"` cameras only and needs the same write
+  gate as the single-camera form.
+
+### Patch Changes
+
+- 5af369c: Record who added, changed or removed a camera.
+
+  "Who changed this camera's address, and when" had no answer anywhere in the system: a camera record
+  carries `createdAt`/`updatedAt` and no actor, and a write overwrites the previous `host` in place. At
+  Seventh Condominium that turned a one-line port correction into nine days.
+
+  `add`, `updateById` and `deleteById` on site cameras now append a row to the existing append-only
+  `console-audit` collection, with the actor from the session, the camera id, and `before`/`after`
+  values drawn from a per-action allow-list. No schema changes, no migration, and no new collection.
+
+  The allow-list is the boundary that matters: a camera document holds a device credential, and
+  `username` and `password` are not on it. `loadForWrite` still never reads them.
+
+- 16a9105: Decouple the camera health sweep from the wall's tile ceiling.
+
+  `getSiteHealth` sliced its input to `maxTiles` (9), so a health request covering a 150-camera site
+  answered for the first nine cameras and said nothing at all about the other 141 — and did not report
+  that it had shortened the list. No client could build a site-wide "which of my cameras is down" view,
+  however it asked.
+
+  Health is now bounded by its own `maxHealthCameras` (`CAMERA_HEALTH_MAX_CAMERAS`, default 200), and a
+  request past that cap comes back with `requested` / `returned` / `truncated` instead of a quietly
+  partial list. The device fan-out is unchanged: `maxConcurrentProbes` still bounds probes in flight at
+  4, the reachability probe is still cached per recorder, and `probeCamera` still reads a cached device
+  probe rather than making a fresh one — so a 150-camera sweep costs a recorder no more than a 9-camera
+  one after the first pass.
+
+- 398b374: HID Amico: stop silently deriving the credential encryption key from
+  ACCESS_TOKEN_SECRET. Reading still accepts the legacy key so existing credentials
+  keep working (and now logs an error saying so), but writing a new credential
+  refuses with a message naming HID_AMICO_SECRET, so a later rotation of the JWT
+  signing secret cannot orphan credentials that were written after this.
+- 8113e31: HID face registration: never retain the captured photo. Identity `metadata` is stripped of
+  `photo` and of any inline `data:image/...` value on every write, and reader notification
+  payloads (`user_image`, `access_photo`) are redacted of image data before they are persisted
+  as audit events. Enrollment state (`facialEnrolled`, `facialEnrolledAt`, `facialData`,
+  `imageTimestamp`) is unchanged.
+- b097964: Constrain a site camera's `direction` to a fixed set instead of accepting any string.
+
+  `Joi.string().allow("entry", "exit", "both", "none")` reads like a whitelist but is not one — on a
+  validator that already accepts every non-empty string, `.allow()` only adds permitted values, so the
+  field rejected nothing. It is now `.valid()`.
+
+  The accepted set is `entry | exit | both | none | visitors | residents`: the four values the staging
+  collection actually holds (measured read-only across all 22 rows), plus the two extra options
+  layer-common's live `CameraForm.vue` offers for ANPR cameras. No stored camera and no reachable form
+  is refused. Whether `visitors` and `residents` are directions at all is a product question; dropping
+  them later is a zero-row migration.
+
+- Visitor list: decide the Guests tab by "every requested status is pre-arrival"
+  instead of matching one specific status set, so the tab keeps filtering on the
+  expected arrival date for both the approved+pending request sent by
+  layer-common `main` and the approved+pending+rejected request sent by
+  layer-common `staging` (DV-0080). Extracted as `isPreCheckInStatusOnly` with
+  tests pinning each case.
+
 ## 3.51.0
 
 ### Minor Changes

package/dist/index.d.ts

@@ -4822,7 +4822,7 @@ declare function useVisitorTransactionRepo(): {
     checkOutBySiteAndPlate: (site: string | ObjectId, plateNumber: string, session?: ClientSession) => Promise<mongodb.WithId<bson.Document> | null>;
     resendEmailInvitedResident: (visitorId: string, updatedBy: string | ObjectId) => Promise<any>;
     getSelfServiceVisitorPreview: (id: string | ObjectId) => Promise<mongodb.WithId<bson.Document> | null>;
-    patchFields: (id: string | ObjectId, fields: Record<string, any>) => Promise<void>;
+    patchFields: (id: string | ObjectId, fields: Record<string, any>, session?: ClientSession) => Promise<void>;
     updateStatusByLeadId: (leadId: string | ObjectId, status: string) => Promise<void>;
 };
 
@@ -4831,6 +4831,7 @@ declare function useVisitorTransactionService(): {
     updateVisitorTransactionById: (id: string | ObjectId, value: TVisitorTransaction) => Promise<string>;
     processTransactionDahuaStatus: () => Promise<void>;
     inviteVisitor: (value: TVisitorTransaction, userId: string) => Promise<ObjectId[]>;
+    createInvitedMemberDocuments: (leadId: string | ObjectId, status: VisitorStatus) => Promise<ObjectId[]>;
     deleteVisitorTransaction: (id: string) => Promise<void>;
 };
 

package/dist/index.js

@@ -20850,10 +20850,10 @@ function useVisitorTransactionRepo() {
       throw new Error(error.message);
     }
   }
-  async function patchFields(id, fields) {
+  async function patchFields(id, fields, session) {
     const _id = (0, import_node_server_utils48.toObjectId)(id);
     try {
-      await collection.updateOne({ _id }, { $set: fields });
+      await collection.updateOne({ _id }, { $set: fields }, { session });
     } catch (error) {
       throw new Error(error.message);
     }
@@ -50480,7 +50480,8 @@ function useVisitorTransactionService() {
     getExpiredCheckedOutTransactionsBySite: _getExpiredCheckedOutTransactionsBySite,
     updateManyDahuaSyncStatus: _updateManyDahuaSyncStatus,
     getVisitorTransactionById: _getVisitorTransactionById,
-    deleteVisitorTransaction: _deleteVisitorTransaction
+    deleteVisitorTransaction: _deleteVisitorTransaction,
+    patchFields: _patchFields
   } = useVisitorTransactionRepo();
   const { getById } = useBuildingUnitRepo();
   const {
@@ -51321,6 +51322,74 @@ function useVisitorTransactionService() {
       session?.endSession();
     }
   }
+  async function createInvitedMemberDocuments(leadId, status) {
+    const lead = await _getVisitorTransactionById(String(leadId));
+    if (!lead?.inviterId)
+      return [];
+    const members = Array.isArray(lead.members) ? lead.members : [];
+    if (members.length === 0)
+      return [];
+    if (!members.every((member) => !member._id))
+      return [];
+    const session = import_node_server_utils134.useAtlas.getClient()?.startSession();
+    if (!session) {
+      throw new Error("Unable to start session for people service.");
+    }
+    try {
+      session.startTransaction();
+      const memberPayload = {
+        block: lead.block ? String(lead.block) : void 0,
+        level: lead.level ? String(lead.level) : void 0,
+        unit: lead.unit ? String(lead.unit) : void 0,
+        unitName: lead.unitName,
+        org: lead.org ? String(lead.org) : void 0,
+        site: lead.site ? String(lead.site) : void 0,
+        type: lead.type,
+        contractorType: lead.contractorType,
+        company: lead.company,
+        purpose: lead.purpose,
+        expectedCheckIn: lead.expectedCheckIn ? new Date(lead.expectedCheckIn).toISOString() : void 0,
+        arrivalTime: lead.arrivalTime,
+        duration: lead.duration,
+        isOvernightParking: lead.isOvernightParking,
+        numberOfPassengers: lead.numberOfPassengers,
+        status,
+        inviterId: String(lead.inviterId),
+        leadId: String(lead._id),
+        // Explicit - MVisitorTransaction defaults an undefined checkIn to now,
+        // and an approved invitation hasn't arrived yet.
+        checkIn: null
+      };
+      const insertedIds = [];
+      for (const member of members) {
+        const memberId = await _add(
+          {
+            ...memberPayload,
+            name: member.name ?? "",
+            nric: member.nric ?? "",
+            contact: member.contact ?? "",
+            email: member.email ?? "",
+            plateNumber: member.plateNumber ?? ""
+          },
+          session
+        );
+        member._id = memberId;
+        insertedIds.push(memberId);
+      }
+      await _patchFields(leadId, { members }, session);
+      await session.commitTransaction();
+      return insertedIds;
+    } catch (error) {
+      import_node_server_utils134.logger.error(
+        "Error creating member documents for approved invitation:",
+        error
+      );
+      await session.abortTransaction();
+      throw error;
+    } finally {
+      session?.endSession();
+    }
+  }
   async function deleteVisitorTransaction(id) {
     const visitor = await _getVisitorTransactionById(id);
     if (!visitor) {
@@ -51353,6 +51422,7 @@ function useVisitorTransactionService() {
     updateVisitorTransactionById,
     processTransactionDahuaStatus,
     inviteVisitor,
+    createInvitedMemberDocuments,
     deleteVisitorTransaction
     // changeVisitorTransactionKeysById,
   };
@@ -55312,6 +55382,7 @@ function useVisitorTransactionController() {
     add: _add,
     updateVisitorTransactionById: _updateVisitorTransactionById,
     inviteVisitor: _inviteVisitor,
+    createInvitedMemberDocuments: _createInvitedMemberDocuments,
     deleteVisitorTransaction: _deleteVisitorTransaction
     // changeVisitorTransactionKeysById: _changeVisitorTransactionKeysById,
   } = useVisitorTransactionService();
@@ -55636,8 +55707,36 @@ function useVisitorTransactionController() {
       const remarks = approval?.remarks ?? req.body.remarks;
       const isApprovalTransition = nextStatus === "approved" /* APPROVED */ || nextStatus === "rejected" /* REJECTED */;
       const current = isApprovalTransition ? await _getVisitorTransactionById(_id) : null;
-      const updateBody = approval ? { ...req.body, status: nextStatus } : req.body;
+      const needsMemberFanOut = nextStatus === "approved" /* APPROVED */ && !!current?.inviterId && Array.isArray(current.members) && current.members.length > 0 && current.members.every((member) => !member._id);
+      const { members: _unusedMembers, ...bodyWithoutMembers } = req.body;
+      const baseBody = needsMemberFanOut ? bodyWithoutMembers : req.body;
+      const updateBody = approval ? { ...baseBody, status: nextStatus } : baseBody;
       await _updateVisitorTransactionById(_id, updateBody);
+      let invitedMemberIds = [];
+      if (needsMemberFanOut) {
+        try {
+          invitedMemberIds = await _createInvitedMemberDocuments(
+            _id,
+            nextStatus
+          );
+        } catch (fanOutError) {
+          import_node_server_utils137.logger.log({
+            level: "error",
+            message: `Failed to create member documents for approved invitation ${_id}: ${fanOutError?.message}`
+          });
+        }
+      }
+      for (const insertedId of invitedMemberIds) {
+        resendEmailInvitedResident(
+          String(insertedId),
+          String(current?.inviterId)
+        ).catch((error2) => {
+          import_node_server_utils137.logger.log({
+            level: "error",
+            message: `Failed to send invitation email: ${error2?.message}`
+          });
+        });
+      }
       if (isApprovalTransition && current && current.type === "contractor" /* CONTRACTOR */) {
         try {
           await _updateStatusByLeadId(_id, nextStatus);