@7365admin1/core 3.51.1-staging.225 → 3.51.1-staging.226

package/.changeset/site-camera-direction-valid.md

@@ -0,0 +1,15 @@
+---
+"@7365admin1/core": patch
+---
+
+Constrain a site camera's `direction` to a fixed set instead of accepting any string.
+
+`Joi.string().allow("entry", "exit", "both", "none")` reads like a whitelist but is not one — on a
+validator that already accepts every non-empty string, `.allow()` only adds permitted values, so the
+field rejected nothing. It is now `.valid()`.
+
+The accepted set is `entry | exit | both | none | visitors | residents`: the four values the staging
+collection actually holds (measured read-only across all 22 rows), plus the two extra options
+layer-common's live `CameraForm.vue` offers for ANPR cameras. No stored camera and no reachable form
+is refused. Whether `visitors` and `residents` are directions at all is a product question; dropping
+them later is a zero-row migration.

package/dist/index.js

@@ -19414,14 +19414,47 @@ var schemaUpdateSiteCamera = import_joi20.default.object({
    * write callers in the estate (layer-common `CameraForm.vue` and
    * `iservice365-mobile-app-security`) offer exactly those values.
    *
-   * `direction` is deliberately left on `.allow()`: `CameraForm.vue` also
-   * offers "visitors" and "residents", which are outside the intended
-   * entry|exit|both|none set, so constraining it would 400 two of the form's
-   * own five options. That mismatch needs a product decision, not a schema edit.
+   * `direction` is now `.valid()` too, but over a WIDER set than the intended
+   * one - deliberately, because tightening to the intended set alone would
+   * break a live form.
+   *
+   * Measured read-only on the staging `site.cameras` collection on 2026-08-28,
+   * all 22 rows, no nulls and no missing field:
+   *
+   *     none 13 (all type:ip)   both 6 (4 anpr, 2 ip)   entry 2 (anpr)   exit 1 (anpr)
+   *
+   * So every stored value is inside `entry|exit|both|none` and no real row
+   * would be rejected by the narrow set. The write callers are the problem, not
+   * the data. Swept by path across the org, not by credential:
+   *
+   * - layer-common `CameraForm.vue` (LIVE, the camera add/edit form) offers
+   *   five ANPR options: entry, exit, both, **visitors**, **residents**. The
+   *   last two are outside the intended set and are held by 0 of 22 rows -
+   *   nobody has ever picked them - but the options are on screen today, so the
+   *   narrow set would turn two of five into a 400.
+   * - `iservice365-web-app-security` `VehicleCameraSettingAdd.vue` offers a
+   *   third vocabulary entirely (approach, depart, both). It is an ORPHAN: the
+   *   string `VehicleCameraSetting` appears nowhere else in that repository on
+   *   `staging` or `main`, so no page or component can mount it and no user can
+   *   reach it. `approach`/`depart` are therefore NOT accepted here.
+   * - the bulk import (`site-camera.controller.ts` `addBulk`) always writes
+   *   `direction: "none"`.
+   *
+   * So the set below is: what real data holds, plus what a reachable form can
+   * actually send. That is still a genuine tightening - `.allow()` on a
+   * `Joi.string()` accepts EVERY non-empty string, including a 10 MB one - and
+   * it breaks nothing.
+   *
+   * **Follow-up for product:** are "visitors" and "residents" directions at
+   * all, or lane designations that belong in a different field? If they should
+   * not be offered, removing them from `CameraForm.vue` and dropping the two
+   * entries here is a one-line change with a **zero-row** migration, because no
+   * stored camera uses either. Until someone answers that, refusing them would
+   * be breaking a form on a guess.
    */
   category: import_joi20.default.string().valid("standard", "resident", "visitor").required(),
   guardPost: import_joi20.default.number().integer().optional(),
-  direction: import_joi20.default.string().optional().allow("entry", "exit", "both", "none"),
+  direction: import_joi20.default.string().optional().valid("entry", "exit", "both", "none", "visitors", "residents"),
   status: import_joi20.default.string().optional().valid("active", "inactive", "deleted"),
   name: import_joi20.default.string().optional().allow(null, "")
 });
@@ -19455,9 +19488,9 @@ var schemaSiteCamera = import_joi20.default.object({
    * today. Every client in the estate already sends the lower-case pair.
    */
   type: import_joi20.default.string().trim().lowercase().valid("ip", "anpr").required(),
-  /** See the note on `schemaUpdateSiteCamera` for why `direction` stays as it is. */
+  /** See the note on `schemaUpdateSiteCamera` for the `direction` set and why it is wider than the intended one. */
   category: import_joi20.default.string().valid("standard", "resident", "visitor").required(),
-  direction: import_joi20.default.string().required().allow("entry", "exit", "both", "none"),
+  direction: import_joi20.default.string().required().valid("entry", "exit", "both", "none", "visitors", "residents"),
   guardPost: import_joi20.default.number().integer().optional(),
   status: import_joi20.default.string().optional().valid("active", "inactive", "deleted"),
   name: import_joi20.default.string().optional().allow(null, ""),