@7365admin1/core 3.50.1-staging.218 → 3.50.1

package/CHANGELOG.md

@@ -1,5 +1,11 @@
 # @iservice365/core
 
+## 3.50.1
+
+### Patch Changes
+
+- f92756f: Constrain site camera `category` and `status` with Joi `.valid()` instead of `.allow()`
+
 ## 3.50.0
 
 ### Minor Changes

package/dist/index.d.ts

@@ -4557,12 +4557,6 @@ type TVisitorTransaction = {
     createdBy?: string | ObjectId;
     updatedBy?: string | ObjectId;
     isMembersAdded?: boolean;
-    approval?: {
-        approvedBy?: string | ObjectId;
-        status?: VisitorStatus;
-        remarks?: string;
-        approvedAt?: string | Date;
-    };
 };
 declare const schemaVisitorTransaction: Joi.ObjectSchema<any>;
 /**

package/dist/index.js

@@ -19707,18 +19707,7 @@ var schemaUpdateVisTrans = import_joi21.default.object({
       contact: import_joi21.default.string().optional().allow(null, "")
     })
   ).optional().allow(null),
-  updatedBy: import_joi21.default.string().hex().length(24).optional(),
-  // Audit trail for the Approve/Reject action on a self-service submission -
-  // `status` here drives the transition (and is mirrored onto the top-level
-  // `status` field by the controller, since that's what list/report queries
-  // filter on); `approvedBy`/`approvedAt`/`remarks` are kept nested so the
-  // "who/when/why" doesn't crowd the top-level document shape.
-  approval: import_joi21.default.object({
-    approvedBy: import_joi21.default.string().hex().length(24).optional().allow(null, ""),
-    status: import_joi21.default.string().valid("approved" /* APPROVED */, "rejected" /* REJECTED */).optional(),
-    remarks: import_joi21.default.string().optional().allow(null, ""),
-    approvedAt: import_joi21.default.date().iso().optional()
-  }).optional()
+  updatedBy: import_joi21.default.string().hex().length(24).optional()
 });
 function MVisitorTransaction(value) {
   const { error } = schemaVisitorTransaction.validate(value, {
@@ -54645,13 +54634,10 @@ function useVisitorTransactionController() {
       return;
     }
     try {
-      const approval = req.body.approval;
-      const nextStatus = approval?.status ?? req.body.status;
-      const remarks = approval?.remarks ?? req.body.remarks;
+      const nextStatus = req.body.status;
       const isApprovalTransition = nextStatus === "approved" /* APPROVED */ || nextStatus === "rejected" /* REJECTED */;
       const current = isApprovalTransition ? await _getVisitorTransactionById(_id) : null;
-      const updateBody = approval ? { ...req.body, status: nextStatus } : req.body;
-      await _updateVisitorTransactionById(_id, updateBody);
+      await _updateVisitorTransactionById(_id, req.body);
       if (isApprovalTransition && current && current.type === "guest" /* GUEST */ && current.email && current.status !== nextStatus) {
         try {
           if (nextStatus === "approved" /* APPROVED */) {
@@ -54686,7 +54672,7 @@ function useVisitorTransactionController() {
               handlebar: "self-service-visitor-rejected",
               context: {
                 name: current.name,
-                remarks: remarks || ""
+                remarks: req.body.remarks || ""
               }
             });
             await sendEmail({