@7365admin1/core 3.48.1-staging.190 → 3.48.1-staging.191

package/.changeset/manpower-designation-site-scope.md

@@ -0,0 +1,11 @@
+---
+"@7365admin1/core": patch
+---
+
+Scope the manpower designation routes to the estate, and stamp who filed the plan
+from the session. `/api/manpower-designations` carried `requireAuth` and nothing
+else on all three routes: any signed-in account could file a manning plan into
+another estate, read any estate's guard-strength plan, or rewrite one by id alone.
+`createdBy` and `createdByName` were taken from the request body, so the plan could
+be attributed to anybody. Reach is now checked on the site named in the request and
+on the stored row for the update, and the two identity fields come from the session.

package/dist/index.d.ts

@@ -8807,6 +8807,7 @@ declare class MManpowerDesignations implements Partial<TManpowerDesignations> {
 declare function useManpowerDesignationRepo(): {
     createManpowerDesignations: (value: TManpowerDesignations) => Promise<mongodb.InsertOneResult<bson.Document>>;
     getManpowerDesignationsBySiteId: (_id: string | ObjectId, serviceProviderId?: string | ObjectId) => Promise<mongodb.WithId<bson.Document> | null>;
+    getManpowerDesignationsById: (_id: string | ObjectId) => Promise<mongodb.WithId<bson.Document> | null>;
     updateManpowerDesignations: (_id: string | ObjectId, value: TManpowerDesignationsUpdate) => Promise<number>;
     createIndexes: () => Promise<string>;
 };

package/dist/index.js

@@ -76993,6 +76993,14 @@ function useManpowerDesignationRepo() {
       throw error;
     }
   }
+  async function getManpowerDesignationsById(_id) {
+    try {
+      _id = new import_mongodb151.ObjectId(_id);
+    } catch (error) {
+      return null;
+    }
+    return await collection.findOne({ _id });
+  }
   async function updateManpowerDesignations(_id, value) {
     try {
       _id = new import_mongodb151.ObjectId(_id);
@@ -77016,6 +77024,7 @@ function useManpowerDesignationRepo() {
   return {
     createManpowerDesignations,
     getManpowerDesignationsBySiteId,
+    getManpowerDesignationsById,
     updateManpowerDesignations,
     createIndexes
   };
@@ -77028,8 +77037,17 @@ function useManpowerDesignationCtrl() {
   const {
     createManpowerDesignations: _createManpowerDesignations,
     getManpowerDesignationsBySiteId: _getManpowerDesignationsBySiteId,
+    getManpowerDesignationsById: _getManpowerDesignationsById,
     updateManpowerDesignations: _updateManpowerDesignations
   } = useManpowerDesignationRepo();
+  async function requireDesignationReach(req, _id) {
+    const row = await _getManpowerDesignationsById(_id);
+    const { canReach } = await siteReachOf(req);
+    if (!row || !await canReach({ site: row.siteId })) {
+      throw new import_node_server_utils241.NotFoundError("Manpower designations not found.");
+    }
+    return row;
+  }
   async function createManpowerDesignations(req, res, next) {
     try {
       const payload = { ...req.body };
@@ -77038,6 +77056,12 @@ function useManpowerDesignationCtrl() {
         next(new import_node_server_utils241.BadRequestError(error.message));
         return;
       }
+      const { actor, canReach } = await siteReachOf(req);
+      if (!await canReach({ site: payload.siteId })) {
+        throw new import_node_server_utils241.NotFoundError("Site not found.");
+      }
+      payload.createdBy = actor.id;
+      payload.createdByName = actor.name;
       const result = await _createManpowerDesignations(payload);
       return res.json(result);
     } catch (error) {
@@ -77058,6 +77082,7 @@ function useManpowerDesignationCtrl() {
         next(new import_node_server_utils241.BadRequestError(error.message));
         return;
       }
+      await requireSiteReach(req, id);
       const result = await _getManpowerDesignationsBySiteId(
         id,
         serviceProviderId
@@ -77082,6 +77107,7 @@ function useManpowerDesignationCtrl() {
         next(new import_node_server_utils241.BadRequestError(error.message));
         return;
       }
+      await requireDesignationReach(req, _id);
       const result = await _updateManpowerDesignations(_id, payload);
       return res.json(result);
     } catch (error) {