@7365admin1/core 3.48.1-staging.174 → 3.48.1-staging.175

package/.changeset/site-billing-configuration-scope.md

@@ -0,0 +1,5 @@
+---
+"@7365admin1/core": patch
+---
+
+Scope the site billing configuration routes to the estate, and take createdBy from the session

package/dist/index.d.ts

@@ -6253,6 +6253,23 @@ declare function useSiteBillingConfigurationRepo(): {
     createIndexes: () => Promise<string>;
 };
 
+/**
+ * Billing configuration is per-estate — the tax rate, the rounding and the
+ * payment settings every bill at that site is calculated from.
+ *
+ * Every one of these five handlers carried `requireAuth` and nothing else. The
+ * record id came from the URL and the site came from the caller's own query or
+ * body, so any signed-in account on the platform could read another client's
+ * billing settings, change their tax rate, move a configuration to a different
+ * estate, or delete it. `createdBy` was read off the raw `user` COOKIE with a
+ * fall back to the body, so the "who set this up" name was client-supplied.
+ *
+ * The rule is the existing one — `requireSiteReach`, i.e. `entitleSite` — asked
+ * about the site the request names on the way in, and about the STORED site for
+ * the id routes, which name no site at all. `PUT` asks twice: once about where
+ * the record is and once about where the body wants to move it, because a MOVE
+ * needs the destination checked too. `createdBy` now comes from the session.
+ */
 declare function useSiteBillingConfigurationController(): {
     add: (req: Request, res: Response, next: NextFunction) => Promise<void>;
     getAll: (req: Request, res: Response, next: NextFunction) => Promise<void>;

package/dist/index.js

@@ -58897,11 +58897,6 @@ function useSiteBillingConfigurationController() {
   } = useSiteBillingConfigurationRepo();
   const { add: _add } = useSiteBillingConfigurationService();
   async function add(req, res, next) {
-    const cookies = req.headers.cookie?.split(";").map((cookie) => cookie.trim().split("=")).reduce(
-      (acc, [key, value2]) => ({ ...acc, [key]: value2 }),
-      {}
-    );
-    req.body.createdBy = cookies?.["user"] ? cookies["user"].toString() : req.body.createdBy;
     const data = { ...req.body };
     const { error, value } = schemaBillingConfiguration.validate(data);
     if (error) {
@@ -58909,7 +58904,8 @@ function useSiteBillingConfigurationController() {
       return;
     }
     try {
-      const question = await _add(value);
+      await requireSiteReach(req, value.site);
+      const question = await _add({ ...value, createdBy: callerId(req) });
       res.status(201).json({
         message: "Site Billing Configuration added successfully.",
         data: question
@@ -58953,6 +58949,7 @@ function useSiteBillingConfigurationController() {
       }
     });
     try {
+      await requireSiteReach(req, site);
       const data = await _getAll({
         search,
         page,
@@ -58981,6 +58978,7 @@ function useSiteBillingConfigurationController() {
     }
     try {
       const building = await _getById(id);
+      await requireSiteReach(req, building?.site);
       res.json({
         message: "Successfully retrieved site billing configuration.",
         data: { building }
@@ -59003,6 +59001,10 @@ function useSiteBillingConfigurationController() {
       return;
     }
     try {
+      const current = await _getById(_id);
+      await requireSiteReach(req, current?.site);
+      if (req.body?.site)
+        await requireSiteReach(req, req.body.site);
       const result = await _updateById(_id, req.body);
       res.status(200).json({ message: result });
       return;
@@ -59022,6 +59024,8 @@ function useSiteBillingConfigurationController() {
       return;
     }
     try {
+      const current = await _getById(_id);
+      await requireSiteReach(req, current?.site);
       await _deleteById(_id);
       res.status(200).json({ message: "Successfully deleted site billing configuration." });
       return;