@7365admin1/core 3.47.1-staging.140 → 3.47.1-staging.141

package/.changeset/organization-read-scope.md

@@ -0,0 +1,44 @@
+---
+"@7365admin1/core": minor
+---
+
+Scope the organisation lookups so they stop mapping one client to another.
+
+Four reads on `/api/organizations` carried `requireAuth` and nothing more, and
+every one took its key straight from the URL:
+
+- `GET /api/organizations/user/:user` — which organisations ANY person belongs to
+- `GET /api/organizations/orgs/:email` — the same, keyed on ANY email address
+- `GET /api/organizations/name/:name` — any organisation, by name
+- `GET /api/organizations/email/:email` — any organisation, by email address
+
+Together those are a cross-client directory and an account-enumeration oracle: a
+resident of one estate could map which clients an address or a user id belongs
+to across the whole platform.
+
+Each is now decided from the session:
+
+- `user/:user` — the caller's own id, or Seven365 staff. Every live caller asks
+  about itself: the seven service-provider app layouts, the org app, and the
+  resident mobile app all pass the signed-in user's own id.
+- `orgs/:email` — the caller's own address, compared case-insensitively after
+  being resolved from the session, or Seven365 staff. All three live callers
+  pass the signed-in user's own address.
+- `name/:name` — Seven365 staff. Its only caller is the staff console's client
+  list.
+- `email/:email` — Seven365 staff. No caller exists in any repository in the
+  organisation.
+
+A key that does not exist is refused exactly as one that does, so the refusal
+itself is not an oracle.
+
+`GET /api/organizations/id/:id` is deliberately NOT guarded here: the same
+controller function is mounted a second time, unauthenticated, at
+`/api/organizations/org/id/:id`, which the sign-up-invite screens call before an
+account exists. Guarding the handler would guard both mounts and break
+registration. That one needs the alias split first.
+
+`GET /api/organizations/` (the full client list) is also unchanged and is
+recorded as a decision for the leads: it is reached from a live signup path that
+must move onto the organisation `POST /api/organizations/onboarding` already
+returns before the list can be staff-gated.

package/dist/index.js

@@ -21171,6 +21171,7 @@ async function recordConsoleAction(entry) {
 // src/controllers/organization.controller.ts
 function useOrgController() {
   const { getOrgsByMembership } = useMemberRepo();
+  const { getUserById: _getUserById } = useUserRepo();
   const {
     getByName: _getByName,
     getById: _getById,
@@ -21298,6 +21299,9 @@ function useOrgController() {
     const user = req.params.user;
     const type = req.query.type ?? "";
     try {
+      if (user !== callerId(req)) {
+        await requirePlatformStaff(req);
+      }
       const data = await getOrgsByMembership({
         search,
         page,
@@ -21323,6 +21327,7 @@ function useOrgController() {
       return;
     }
     try {
+      await requirePlatformStaff(req);
       const data = await _getByName(name);
       res.json(data);
       return;
@@ -21360,6 +21365,7 @@ function useOrgController() {
       return;
     }
     try {
+      await requirePlatformStaff(req);
       const data = await _getByEmail(email);
       if (!data) {
         next(new import_node_server_utils54.NotFoundError("Organization not found."));
@@ -21387,6 +21393,10 @@ function useOrgController() {
     }
     const email = req.params.email;
     try {
+      const self = await _getUserById(callerId(req)).catch(() => null);
+      if (!self?.email || self.email.toLowerCase() !== email.toLowerCase()) {
+        await requirePlatformStaff(req);
+      }
       const data = await _getOrgsByEmail(email);
       res.json(data);
       return;