@7365admin1/core 3.42.2 → 3.42.3

package/CHANGELOG.md

@@ -1,5 +1,32 @@
 # @iservice365/core
 
+## 3.42.3
+
+### Patch Changes
+
+- 854dd11: Editing a building no longer creates duplicate levels or orphaned units
+
+  Updating a block inserted a brand-new level document for every level name in the
+  payload, without checking whether that name was already a level on the block. A
+  client that posted the block's existing level names back — which the block
+  editor's own full-levels payload does — got a second "Level 1" document, a
+  second entry in `building.levels`, and units still pointing at the first one.
+
+  The submitted names are now reconciled against the block's existing ACTIVE
+  levels first. A name that already matches an existing level is left alone and
+  keeps its `_id`, so nothing that references it is orphaned; only genuinely new
+  names are inserted.
+
+  Matching is case- and whitespace-insensitive, using the same normalisation the
+  import path already uses, so "Level 1", "level 1" and "Level  1" are
+  one level. Only the match key is normalised — the stored name keeps its
+  original spelling, so two genuinely different levels are never merged.
+
+  Removals are deliberately not inferred from this payload; deleting a level keeps
+  its own guarded path.
+
+  Worth a QA pass on building edit — this changes what a block update writes.
+
 ## 3.42.2
 
 ### Patch Changes

package/dist/index.d.ts

@@ -7846,6 +7846,7 @@ declare function useBuildingLevelRepo(): {
         message: string;
         data: bson.Document[];
     }>;
+    getActiveLevelsByIds: (ids: (string | ObjectId)[], session?: ClientSession) => Promise<TBuildingLevel[]>;
 };
 
 declare function useBuildingLevelService(): {

package/dist/index.js

@@ -30292,6 +30292,20 @@ function useBuildingLevelRepo() {
       }
     }
   }
+  async function getActiveLevelsByIds(ids, session) {
+    if (!ids || ids.length === 0)
+      return [];
+    let objectIds;
+    try {
+      objectIds = ids.map((id) => new import_mongodb56.ObjectId(id));
+    } catch {
+      throw new import_node_server_utils88.BadRequestError("Invalid level ID format.");
+    }
+    return collection.find(
+      { _id: { $in: objectIds }, status: "active" /* ACTIVE */ },
+      { projection: { _id: 1, name: 1 }, session }
+    ).toArray();
+  }
   async function updateLevelById(_id, value, session) {
     try {
       _id = new import_mongodb56.ObjectId(_id);
@@ -30490,7 +30504,8 @@ function useBuildingLevelRepo() {
     deleteById,
     bulkWriteLevels,
     batchUpdateByIds,
-    getBuildingLevelList
+    getBuildingLevelList,
+    getActiveLevelsByIds
   };
 }
 
@@ -30511,7 +30526,10 @@ function useBuildingService() {
   } = useBuildingUnitRepo();
   const { updateStatusById } = useFileRepo();
   const { deleteFile } = useFileService();
-  const { bulkWriteLevels: _bulkWriteLevels } = useBuildingLevelRepo();
+  const {
+    bulkWriteLevels: _bulkWriteLevels,
+    getActiveLevelsByIds: _getActiveLevelsByIds
+  } = useBuildingLevelRepo();
   function normalizeImportKey(value) {
     return String(value ?? "").trim().replace(/\s+/g, " ").toLowerCase();
   }
@@ -30605,23 +30623,37 @@ function useBuildingService() {
         );
       }
       if (data.levels) {
-        const levelsPayload = (data.levels ?? []).map((levelName) => ({
-          blockId: id,
-          site: building.site.toString(),
-          name: levelName,
-          status: "active" /* ACTIVE */,
-          createdAt: /* @__PURE__ */ new Date(),
-          updatedAt: null,
-          deletedAt: null
-        }));
-        let levels;
-        if (levelsPayload.length > 0) {
-          levels = await _bulkWriteLevels(levelsPayload, session);
-        }
-        if (levels) {
-          building.levels.push(...Object.values(levels.insertedIds));
-          data.levels = building.levels.map((id2) => id2.toString());
+        const submittedNames = data.levels ?? [];
+        const existingLevels = await _getActiveLevelsByIds(
+          building.levels,
+          session
+        );
+        const seenKeys = new Set(
+          existingLevels.map((level) => normalizeImportKey(level.name))
+        );
+        const newNames = submittedNames.filter((name) => {
+          const key = normalizeImportKey(name);
+          if (seenKeys.has(key))
+            return false;
+          seenKeys.add(key);
+          return true;
+        });
+        if (newNames.length > 0) {
+          const levelsPayload = newNames.map((name) => ({
+            blockId: id,
+            site: building.site.toString(),
+            name,
+            status: "active" /* ACTIVE */,
+            createdAt: /* @__PURE__ */ new Date(),
+            updatedAt: null,
+            deletedAt: null
+          }));
+          const levels = await _bulkWriteLevels(levelsPayload, session);
+          if (levels) {
+            building.levels.push(...Object.values(levels.insertedIds));
+          }
         }
+        data.levels = building.levels.map((levelId) => levelId.toString());
       }
       const buildingUnitData = {};
       if (data.name && building.name !== data.name) {