@7365admin1/core 3.41.0 → 3.42.0

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@7365admin1/core",
   "license": "MIT",
-  "version": "3.41.0",
+  "version": "3.42.0",
   "author": "7365admin1",
   "main": "dist/index.js",
   "module": "dist/index.mjs",

package/test/site-name.util.test.mjs

@@ -0,0 +1,146 @@
+import assert from "node:assert/strict";
+import test from "node:test";
+
+import {
+  distinguishingTokens,
+  findSiteNameClash,
+  matchSiteName,
+  normalizeSiteName,
+  siteNameClashMessage,
+} from "./.build/utils/site-name.util.mjs";
+
+// ---------------------------------------------------------------------------
+// The report: two real, different properties in one organisation.
+// ---------------------------------------------------------------------------
+
+test("Winsland House II can be created alongside Winsland House I", () => {
+  assert.equal(matchSiteName("Winsland House II", "Winsland House I"), null);
+  assert.equal(matchSiteName("Winsland House I", "Winsland House II"), null);
+  assert.equal(matchSiteName("Winsland House III", "Winsland House II"), null);
+});
+
+test("the old rule would have blocked it — one character apart", () => {
+  // Guards the reason this fix exists: the names ARE within the old threshold
+  // of 2, so nothing but the significant-token rule is letting them through.
+  const a = normalizeSiteName("Winsland House I");
+  const b = normalizeSiteName("Winsland House II");
+
+  assert.equal(b.length - a.length, 1);
+  assert.notDeepEqual(distinguishingTokens(a), distinguishingTokens(b));
+});
+
+// ---------------------------------------------------------------------------
+// Significant tokens: numerals, digits, letters.
+// ---------------------------------------------------------------------------
+
+test("Roman numerals I to X are all distinct from each other", () => {
+  const numerals = ["I", "II", "III", "IV", "V", "VI", "VII", "VIII", "IX", "X"];
+
+  for (const a of numerals) {
+    for (const b of numerals) {
+      if (a === b) continue;
+      assert.equal(
+        matchSiteName(`Parc Vista ${a}`, `Parc Vista ${b}`),
+        null,
+        `${a} should not collide with ${b}`,
+      );
+    }
+  }
+});
+
+test("towers, phases, blocks and wings are told apart", () => {
+  assert.equal(matchSiteName("Tower A", "Tower B"), null);
+  assert.equal(matchSiteName("Marina Bay Tower A", "Marina Bay Tower B"), null);
+  assert.equal(matchSiteName("Phase 1", "Phase 2"), null);
+  assert.equal(matchSiteName("Kent Ridge Phase 1", "Kent Ridge Phase 2"), null);
+  assert.equal(matchSiteName("Block 5", "Block 15"), null);
+  assert.equal(matchSiteName("Bedok Block 105", "Bedok Block 106"), null);
+  assert.equal(matchSiteName("Riverside Wing C", "Riverside Wing D"), null);
+  assert.equal(matchSiteName("The Sail Stack 2", "The Sail Stack 3"), null);
+});
+
+test("a numeral and its digit are the same building", () => {
+  assert.equal(matchSiteName("Winsland House 1", "Winsland House I"), "near-duplicate");
+  assert.equal(matchSiteName("Parc Vista 4", "Parc Vista IV"), "near-duplicate");
+  assert.deepEqual(distinguishingTokens("winsland house ix"), ["9"]);
+});
+
+test("adding a numeral to a bare name is a different site", () => {
+  assert.equal(matchSiteName("Winsland House II", "Winsland House"), null);
+  assert.equal(matchSiteName("Winsland House", "Winsland House II"), null);
+});
+
+// ---------------------------------------------------------------------------
+// Real duplicates that must STILL be caught.
+// ---------------------------------------------------------------------------
+
+test("an exact repeat is a duplicate", () => {
+  assert.equal(matchSiteName("Winsland House II", "Winsland House II"), "duplicate");
+});
+
+test("case differences are a duplicate", () => {
+  assert.equal(matchSiteName("winsland house ii", "Winsland House II"), "duplicate");
+  assert.equal(matchSiteName("WINSLAND HOUSE II", "Winsland House II"), "duplicate");
+  assert.equal(matchSiteName("WiNsLaNd HoUsE ii", "Winsland House II"), "duplicate");
+});
+
+test("leading, trailing and doubled whitespace is a duplicate", () => {
+  assert.equal(matchSiteName("  Winsland House II", "Winsland House II"), "duplicate");
+  assert.equal(matchSiteName("Winsland House II   ", "Winsland House II"), "duplicate");
+  assert.equal(matchSiteName("Winsland  House   II", "Winsland House II"), "duplicate");
+  assert.equal(matchSiteName("\tWinsland House II\n", "Winsland House II"), "duplicate");
+});
+
+test("punctuation differences are a duplicate", () => {
+  assert.equal(matchSiteName("St. John's Court", "St Johns Court"), "duplicate");
+  assert.equal(matchSiteName("Marina-Bay Residences", "Marina Bay Residences"), "duplicate");
+});
+
+test("a typo in the same building is a near-duplicate", () => {
+  assert.equal(matchSiteName("Winsland Hosue II", "Winsland House II"), "near-duplicate");
+  assert.equal(matchSiteName("Winsland Huse II", "Winsland House II"), "near-duplicate");
+  assert.equal(matchSiteName("Marina Bay Residence", "Marina Bay Residences"), "near-duplicate");
+});
+
+test("genuinely unrelated names never collide", () => {
+  assert.equal(matchSiteName("Winsland House II", "Orchard Central"), null);
+  assert.equal(matchSiteName("Parc Vista", "Park Vista Residences"), null);
+});
+
+test("a blank or missing name is not treated as a clash", () => {
+  assert.equal(matchSiteName("", "Winsland House II"), null);
+  assert.equal(matchSiteName("   ", "Winsland House II"), null);
+  assert.equal(matchSiteName("Winsland House II", undefined), null);
+  assert.equal(matchSiteName(null, "Winsland House II"), null);
+});
+
+// ---------------------------------------------------------------------------
+// What the service actually calls.
+// ---------------------------------------------------------------------------
+
+test("findSiteNameClash reports which existing site matched", () => {
+  const existing = ["Orchard Central", "Winsland House I", "Winsland House II"];
+
+  assert.equal(findSiteNameClash("Winsland House III", existing), null);
+  assert.deepEqual(findSiteNameClash("winsland house ii", existing), {
+    name: "Winsland House II",
+    match: "duplicate",
+  });
+  assert.deepEqual(findSiteNameClash("Winsland Hosue I", existing), {
+    name: "Winsland House I",
+    match: "near-duplicate",
+  });
+});
+
+test("the message names the site and says what to do, without telling anyone to call support", () => {
+  const duplicate = siteNameClashMessage("Winsland House II", "duplicate");
+  const near = siteNameClashMessage("Winsland House II", "near-duplicate");
+
+  for (const message of [duplicate, near]) {
+    assert.match(message, /Winsland House II/);
+    assert.doesNotMatch(message, /support/i);
+    assert.doesNotMatch(message, /Failed to add site/i);
+  }
+
+  assert.match(near, /block, tower, phase, or number/);
+});