@7365admin1/core 3.32.2-staging.77 → 3.32.2-staging.78

package/.changeset/site-name-similarity-check.md

@@ -0,0 +1,26 @@
+---
+"@7365admin1/core": patch
+---
+
+Stop rejecting site names that only differ by their building number
+
+Adding a site refused any name within a Levenshtein distance of 2 of an
+existing site in the same organisation, and told the user to contact support.
+That is exactly one character, so "Winsland House II" could not be added next
+to "Winsland House I". The same rule blocked "Tower A" beside "Tower B",
+"Phase 2" beside "Phase 1" and "Block 15" beside "Block 5" — the standard way
+buildings are named here.
+
+The check now treats trailing numbers, Roman numerals and single letters as the
+part that tells two buildings apart: if they differ, the names are different
+sites and the distance is never measured. Real duplicates are still refused —
+an exact repeat, a different capitalisation, stray or doubled whitespace,
+punctuation-only differences, and a one or two character typo within the same
+building. "House 1" and "House I" are still read as the same building.
+
+The refusal now names the site it matched and says what to do about it instead
+of pointing the user at support.
+
+`site.repo.getByExactName` also built its case-insensitive regex from the raw
+name; a name containing regex characters either threw or matched a site it is
+not. It is escaped.

package/dist/index.js

@@ -11811,8 +11811,9 @@ function useSiteRepo() {
     } catch (error2) {
       throw new import_node_server_utils19.BadRequestError("Invalid org ID format.");
     }
+    const escapedName = name.replace(/[.*+?^${}()|[\]\\]/g, "\\$&");
     const query2 = {
-      name: { $regex: new RegExp(`^${name}$`, "i") },
+      name: { $regex: new RegExp(`^${escapedName}$`, "i") },
       // Case-insensitive exact match
       orgId,
       status: { $ne: "deleted" }
@@ -35083,7 +35084,57 @@ function useCustomerSiteRepo() {
 
 // src/services/customer-site.service.ts
 var import_node_server_utils98 = require("@7365admin1/node-server-utils");
+
+// src/utils/site-name.util.ts
 var import_fast_levenshtein = __toESM(require("fast-levenshtein"));
+var ROMAN = /^(?=[ivx])(x{0,3})(ix|iv|v?i{0,3})$/;
+var ROMAN_VALUE = { i: 1, v: 5, x: 10 };
+function normalizeSiteName(name) {
+  return String(name ?? "").normalize("NFKC").toLowerCase().replace(/[‘’']/g, "").replace(/[^a-z0-9]+/g, " ").trim();
+}
+function romanToNumber(token) {
+  let total = 0;
+  for (let i = 0; i < token.length; i++) {
+    const value = ROMAN_VALUE[token[i]];
+    const next = ROMAN_VALUE[token[i + 1]];
+    total += next && next > value ? -value : value;
+  }
+  return total;
+}
+function distinguishingTokens(normalized) {
+  if (!normalized)
+    return [];
+  return normalized.split(" ").filter((t) => /^\d+$/.test(t) || ROMAN.test(t) || /^[a-z]$/.test(t)).map((t) => ROMAN.test(t) ? String(romanToNumber(t)) : t);
+}
+function matchSiteName(candidate, existing) {
+  const a = normalizeSiteName(candidate);
+  const b = normalizeSiteName(existing);
+  if (!a || !b)
+    return null;
+  if (a === b)
+    return "duplicate";
+  const tokensA = distinguishingTokens(a).join(" ");
+  const tokensB = distinguishingTokens(b).join(" ");
+  if (tokensA !== tokensB)
+    return null;
+  return import_fast_levenshtein.default.get(a, b) <= 2 ? "near-duplicate" : null;
+}
+function findSiteNameClash(candidate, existingNames) {
+  for (const name of existingNames) {
+    const match = matchSiteName(candidate, name);
+    if (match)
+      return { name, match };
+  }
+  return null;
+}
+function siteNameClashMessage(existingName, match) {
+  if (match === "duplicate") {
+    return `A site called "${existingName}" already exists in this organisation. Give the new site a different name, or edit "${existingName}" instead.`;
+  }
+  return `This name is within a character or two of "${existingName}", which already exists in this organisation. If it is the same property, edit "${existingName}" instead. If it is a different one, include what tells them apart \u2014 the block, tower, phase, or number \u2014 and save again.`;
+}
+
+// src/services/customer-site.service.ts
 function useCustomerSiteService() {
   const { add: _add, updateCustomerSiteById, getById: _getById } = useCustomerSiteRepo();
   const {
@@ -35105,20 +35156,18 @@ function useCustomerSiteService() {
       const exactMatches = await getSiteByExactName(value.name, value.siteOrg);
       if (exactMatches && exactMatches.length > 0) {
         throw new import_node_server_utils98.BadRequestError(
-          "Site with this name already exists in the organization."
+          siteNameClashMessage(exactMatches[0].name, "duplicate")
         );
       }
-      const threshold = 2;
       const sites = await getSiteByName(value.name);
-      if (sites && sites.length > 0) {
-        const similar = sites.filter((doc) => {
-          return doc.orgId && doc.name && doc.orgId.toString() === value.siteOrg.toString() && import_fast_levenshtein.default.get(value.name.toLowerCase(), doc.name.toLowerCase()) <= threshold;
-        });
-        if (similar.length > 0) {
-          throw new import_node_server_utils98.BadRequestError(
-            "Failed to add site, site with closely similar name found. Please contact seven365 support."
-          );
-        }
+      const candidates = (sites ?? []).filter(
+        (doc) => doc.orgId && doc.name && doc.orgId.toString() === value.siteOrg.toString()
+      ).map((doc) => doc.name);
+      const clash = findSiteNameClash(value.name, candidates);
+      if (clash) {
+        throw new import_node_server_utils98.BadRequestError(
+          siteNameClashMessage(clash.name, clash.match)
+        );
       }
       const siteId = await createSite(
         {