@7365admin1/core 3.32.2-staging.75 → 3.32.2-staging.76

package/.changeset/dahua-credential-logging.md

@@ -0,0 +1,19 @@
+---
+"@7365admin1/core": patch
+---
+
+Stop logging camera and mailer credentials
+
+Six places wrote a secret or a resident's details to stdout on an ordinary code
+path. `getTrafficJunction` dumped the whole `TSiteCamera` object — including the
+camera's `username` and plaintext `password` — on every reconnect, and
+`addPlateNumber` logged its argument, which carries the same password plus a
+resident's plate number and owner name. `checkOutBySiteAndPlate` logged the
+matched visitor transaction. `siteCameraRepo.updateById` logged the re-read
+camera document, and `vehicleService.add` logged the whole array of a site's
+cameras, both with credentials in them. `sendEmail` printed `MAILER_PASSWORD`
+itself on every message sent.
+
+All now log identifiers, counts and outcomes only, through the module's logger
+rather than `console.log`; the mailer line is removed outright because it
+carried nothing but the secret.

package/dist/index.js

@@ -22700,7 +22700,6 @@ async function sendEmail({ to, subject, text, html }) {
       pass: MAILER_PASSWORD
     }
   });
-  console.log(MAILER_EMAIL, MAILER_PASSWORD, MAILER_TRANSPORT_HOST, MAILER_TRANSPORT_PORT);
   const mailOptions = {
     from: `Seven 365 <${MAILER_EMAIL}>`,
     to,
@@ -24970,7 +24969,9 @@ function useDahuaService() {
         return;
       try {
         const result = await _checkOutBySiteAndPlate(site, plateNumber2);
-        console.log("checkOutBySiteAndPlate result", result);
+        loggerDahua.info(
+          `checkOutBySiteAndPlate matched=${Boolean(result)} type=${result?.type ?? "none"}`
+        );
         if (onDetected2 && result?.type != "resident" && result?.site) {
           onDetected2({ reload: true, site: result?.site?.toString(), siteName: camera?.siteName, cameraDirection: camera?.direction, direction });
         }
@@ -25269,7 +25270,9 @@ function useDahuaService() {
     );
   }
   async function getTrafficJunction(camera, signal, onDetected) {
-    console.log(`getTrafficJunction camera object`, camera);
+    loggerDahua.info(
+      `getTrafficJunction starting for camera ${camera?._id} [${camera?.siteName}-${camera?.direction}] host ${camera?.host}`
+    );
     let authFailureCount = 0;
     let connectionFailureCount = 0;
     let alertedFailureCount = 0;
@@ -25456,7 +25459,9 @@ function useDahuaService() {
     return match ? match[1] : null;
   }
   async function addPlateNumber(value) {
-    console.log("addPlateNumber called with value:", value);
+    loggerDahua.info(
+      `addPlateNumber called for host ${value?.host} mode ${value?.mode}`
+    );
     let recno = null;
     const validation = import_joi40.default.object({
       host: import_joi40.default.string().required(),
@@ -26116,7 +26121,7 @@ function useSiteCameraRepo() {
       }
       if (result?._id) {
         const result2 = await findOne({ _id: new import_mongodb46.ObjectId(result._id) }, void 0, { session });
-        console.log("updateById result2", result2);
+        import_node_server_utils74.logger.info(`Site camera ${result2?._id} re-read after update; reconnecting listener`);
         if (result2?._id) {
           const { listenToCamera } = useDahuaService();
           await listenToCamera(result2);
@@ -27642,7 +27647,9 @@ function useVehicleService() {
           siteCameras.push(...siteCameraReq.items);
           page++;
         } while (page <= pages);
-        console.log("add vehicle service siteCameras", siteCameras);
+        import_node_server_utils78.logger.info(
+          `addVehicle resolved ${siteCameras.length} site camera(s) for site ${value?.site}`
+        );
       }
       for (const plateNumber of plateNumbers) {
         const vehicleValue = {