@7365admin1/core 3.137.0 → 3.139.0

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@7365admin1/core",
   "license": "MIT",
-  "version": "3.137.0",
+  "version": "3.139.0",
   "author": "7365admin1",
   "main": "dist/index.js",
   "module": "dist/index.mjs",
@@ -13,7 +13,7 @@
     "build": "tsup src/index.ts --format cjs,esm --dts && shx cp -r src/public dist && shx cp -r src/utils/handlebars dist",
     "release": "yarn run build && changeset publish",
     "lint": "tsc",
-    "test": "tsup src/config.ts src/utils/building-map.util.ts src/utils/robot-cloud.util.ts src/utils/robot-adapter.util.ts src/utils/png-encoder.util.ts src/services/demo.adapter.ts src/services/ounitech.adapter.ts src/services/robot-cloud.service.ts src/services/robot-fleet.service.ts src/services/padbot.adapter.ts src/utils/padbot-sign.util.ts src/utils/padbot-mqtt.util.ts src/services/open-rmf.adapter.ts src/utils/robot-credentials.util.ts src/utils/rmf-building.util.ts src/utils/door-contract.util.ts src/utils/robot-fault.util.ts src/utils/robot-tracking.util.ts src/utils/robot-apps.util.ts src/utils/robot-permission.util.ts src/utils/robot-network.util.ts src/utils/lift-contract.util.ts src/models/robot-building-map.model.ts src/utils/anpr-revoke.util.ts src/utils/anpr-plate.util.ts src/utils/vehicle-request.util.ts src/utils/camera-view.util.ts src/utils/camera-bulk-import.util.ts src/utils/dashboard-metrics.util.ts src/utils/camera-capability.util.ts src/utils/camera-playback.util.ts src/services/camera-device-http.service.ts src/utils/camera-alert.util.ts src/utils/dahua-protocol.util.ts src/utils/site-name.util.ts src/utils/site-owner-edit.util.ts src/utils/service-provider-invite.util.ts src/utils/notification-category.util.ts src/utils/notification-kind.util.ts src/utils/notification-email.util.ts src/models/notification.model.ts src/utils/hid-card.util.ts src/utils/hid-json.util.ts src/utils/hid-access.util.ts src/models/customer-site.model.ts src/models/site-camera.model.ts src/models/site.model.ts src/models/member.model.ts src/models/subscription.model.ts src/utils/session-id.util.ts src/utils/occurrence-query.util.ts src/utils/occurrence-book-create.util.ts src/utils/update-result.util.ts src/utils/hid-amico-authz.util.ts src/utils/promo-code-currency.util.ts src/utils/console-audit.util.ts src/utils/org-suspension.util.ts src/utils/session-revoke.util.ts src/models/hid-amico.model.ts src/models/patrol-email.model.ts src/utils/patrol-email-pdf.util.ts src/utils/visitor-status.util.ts src/utils/self-service-email.util.ts src/utils/hid-secret.util.ts src/models/visitor-invite.model.ts src/models/guard-invite.model.ts src/utils/site-timezone.util.ts src/utils/bulletin-service-apps.util.ts src/models/bulletin-board.model.ts src/utils/vehicle-import.util.ts src/utils/expired-vehicle-sweep.util.ts src/models/vehicle.model.ts src/controllers/chat.controller.ts src/utils/file-owner.util.ts src/utils/console-permission.util.ts src/utils/role-scope.util.ts src/utils/org-default-roles.util.ts src/utils/org-modules.util.ts src/utils/site-modules.util.ts src/utils/resident-app-modules.util.ts src/utils/resident-default-role.util.ts src/utils/invite-role-scope.util.ts src/models/personal-emergency-chain.model.ts src/utils/self-signup-files.util.ts src/models/person.model.ts src/utils/module-gate.util.ts src/utils/member-lookup.util.ts src/utils/notification-access.util.ts src/utils/module-access.util.ts src/services/module-gate.service.ts src/controllers/site.controller.ts src/controllers/organization.controller.ts src/controllers/member.controller.ts src/utils/org-owner-repair.util.ts src/utils/socket-session.util.ts src/utils/people-create-gate.util.ts src/utils/service-app-type.util.ts src/utils/customer-site-list.util.ts src/utils/org-search.util.ts src/utils/invite-origin.util.ts src/utils/member-role-assign.util.ts src/utils/cross-site-role.util.ts src/utils/cross-site-role-fix.util.ts src/utils/visitor-search.util.ts --format esm --out-dir test/.build --no-dts --silent && node --test test/*.test.mjs",
+    "test": "tsup src/config.ts src/utils/building-map.util.ts src/utils/robot-cloud.util.ts src/utils/robot-adapter.util.ts src/utils/png-encoder.util.ts src/services/demo.adapter.ts src/services/ounitech.adapter.ts src/utils/ounitech-codes.util.ts src/services/robot-cloud.service.ts src/services/robot-fleet.service.ts src/services/padbot.adapter.ts src/utils/padbot-sign.util.ts src/utils/padbot-mqtt.util.ts src/services/open-rmf.adapter.ts src/utils/robot-credentials.util.ts src/utils/rmf-building.util.ts src/utils/door-contract.util.ts src/utils/robot-fault.util.ts src/utils/robot-tracking.util.ts src/utils/robot-apps.util.ts src/utils/robot-permission.util.ts src/utils/robot-network.util.ts src/utils/lift-contract.util.ts src/models/robot-building-map.model.ts src/utils/anpr-revoke.util.ts src/utils/anpr-plate.util.ts src/utils/vehicle-request.util.ts src/utils/camera-view.util.ts src/utils/camera-bulk-import.util.ts src/utils/dashboard-metrics.util.ts src/utils/camera-capability.util.ts src/utils/camera-playback.util.ts src/services/camera-device-http.service.ts src/utils/camera-alert.util.ts src/utils/dahua-protocol.util.ts src/utils/site-name.util.ts src/utils/site-owner-edit.util.ts src/utils/service-provider-invite.util.ts src/utils/notification-category.util.ts src/utils/notification-kind.util.ts src/utils/notification-email.util.ts src/models/notification.model.ts src/utils/hid-card.util.ts src/utils/hid-json.util.ts src/utils/hid-access.util.ts src/models/customer-site.model.ts src/models/site-camera.model.ts src/models/site.model.ts src/models/member.model.ts src/models/subscription.model.ts src/utils/session-id.util.ts src/utils/occurrence-query.util.ts src/utils/occurrence-book-create.util.ts src/utils/update-result.util.ts src/utils/hid-amico-authz.util.ts src/utils/promo-code-currency.util.ts src/utils/console-audit.util.ts src/utils/org-suspension.util.ts src/utils/session-revoke.util.ts src/models/hid-amico.model.ts src/models/patrol-email.model.ts src/utils/patrol-email-pdf.util.ts src/utils/visitor-status.util.ts src/utils/self-service-email.util.ts src/utils/hid-secret.util.ts src/models/visitor-invite.model.ts src/models/guard-invite.model.ts src/utils/site-timezone.util.ts src/utils/bulletin-service-apps.util.ts src/models/bulletin-board.model.ts src/utils/vehicle-import.util.ts src/utils/expired-vehicle-sweep.util.ts src/models/vehicle.model.ts src/controllers/chat.controller.ts src/utils/file-owner.util.ts src/utils/console-permission.util.ts src/utils/role-scope.util.ts src/utils/org-default-roles.util.ts src/utils/org-modules.util.ts src/utils/site-modules.util.ts src/utils/resident-app-modules.util.ts src/utils/resident-default-role.util.ts src/utils/invite-role-scope.util.ts src/models/personal-emergency-chain.model.ts src/utils/self-signup-files.util.ts src/models/person.model.ts src/utils/module-gate.util.ts src/utils/member-lookup.util.ts src/utils/notification-access.util.ts src/utils/module-access.util.ts src/services/module-gate.service.ts src/controllers/site.controller.ts src/controllers/organization.controller.ts src/controllers/member.controller.ts src/utils/org-owner-repair.util.ts src/utils/socket-session.util.ts src/utils/people-create-gate.util.ts src/utils/service-app-type.util.ts src/utils/customer-site-list.util.ts src/utils/org-search.util.ts src/utils/invite-origin.util.ts src/utils/member-role-assign.util.ts src/utils/cross-site-role.util.ts src/utils/cross-site-role-fix.util.ts src/utils/visitor-search.util.ts --format esm --out-dir test/.build --no-dts --silent && node --test test/*.test.mjs",
     "test:camera": "yarn test",
     "test:e2e": "yarn build && tsup src/repositories/visitor-transaction.repo.ts --format esm --out-dir test/.build-e2e/repositories --no-dts --silent && node --test --test-concurrency=1 --test-timeout=600000 \"test/e2e/*.test.mjs\""
   },

package/test/e2e/service-provider-invite-email-new-company.e2e.test.mjs

@@ -354,12 +354,15 @@ describe("SP invitation: email status, Super Admin alert, new company typed by s
 
     const repaired = await h.api(`/service-provider-invitations/${inviteId}/wrong-join/repair`, { method: "PUT", sid: adminSid });
     assert.equal(repaired.status, 200, JSON.stringify(repaired.body));
-    assert.equal(repaired.body.changed, 2);
+    // 2 memberships + the unused "Admin Service Provider" role left in JLL's role list
+    assert.equal(repaired.body.changed, 3);
     assert.equal(await h.db.collection("members").countDocuments({ user: user._id, status: "active" }), 0);
+    assert.equal((await h.db.collection("roles").findOne({ _id: spRole })).status, "deleted");
 
     const undone = await h.api(`/service-provider-invitations/${inviteId}/wrong-join/undo`, { method: "PUT", sid: adminSid });
     assert.equal(undone.status, 200, JSON.stringify(undone.body));
     assert.equal(await h.db.collection("members").countDocuments({ user: user._id, status: "active" }), 2);
+    assert.equal((await h.db.collection("roles").findOne({ _id: spRole })).status, "active", "undo restores the role");
 
     await h.api(`/service-provider-invitations/${inviteId}/wrong-join/repair`, { method: "PUT", sid: adminSid });
     const again = await h.api(`/service-provider-invitations/${inviteId}/wrong-join`, { sid: adminSid });
@@ -523,6 +526,107 @@ describe("SP invitation: email status, Super Admin alert, new company typed by s
     assert.ok(await h.db.collection("customer.sites").findOne({ org: org._id, site, status: "active" }));
     assert.equal((await h.db.collection("verifications").findOne({ _id: new ObjectId(inviteId) })).status, "complete");
   });
+
+  // ------------------- E. "two organisations" after Finish setup (2026-09-30)
+
+  // latitude.sec@ on production after Repair + Finish setup: two INACTIVE
+  // JLL memberships (older) + the unused "*" role the old sign-up left in JLL,
+  // and its own Henderson Security company with org-level owner rows (no site)
+  // engaged at Latitude through customer.sites.
+  async function latitudeShape(email) {
+    const site = new ObjectId();
+    await h.db.collection("sites").insertOne({ _id: site, name: "Latitude", orgId: id.pmOrg, status: "active" });
+    const inviteId = await invite(email, "security_agency", site);
+    await approve(inviteId);
+    const sid = await newAccount(email);
+    const user = await h.db.collection("users").findOne({ email });
+    const spRole = new ObjectId();
+    await h.db.collection("roles").insertOne({ _id: spRole, name: "Admin Service Provider", type: "security_agency", org: id.pmOrg.toString(), site: site.toString(), permissions: ["*"], status: "active", createdAt: new Date(Date.now() + 500).toISOString() });
+    const later = new Date(Date.now() + 1000);
+    await h.db.collection("members").insertMany([
+      { user: user._id, org: id.pmOrg, role: spRole, type: "organization", siteId: site, siteName: "Latitude", status: "active", createdAt: later },
+      { user: user._id, org: id.pmOrg, role: spRole, type: "security_agency", siteId: site, siteName: "Latitude", status: "active", createdAt: later },
+    ]);
+    await h.db.collection("users").updateOne({ _id: user._id }, { $set: { defaultOrg: id.pmOrg.toString() } });
+    // the 30 Sep Repair as it ran then: memberships only (the role stayed)
+    await h.db.collection("members").updateMany({ user: user._id, org: id.pmOrg }, { $set: { status: "inactive" } });
+    await h.db.collection("users").updateOne({ _id: user._id }, { $unset: { defaultOrg: "" } });
+    const applied = await h.api(`/service-provider-invitations/${inviteId}/finish-setup`, { method: "PUT", sid: adminSid, body: { companyName: "Henderson Security Services Pte Ltd" } });
+    assert.equal(applied.status, 200, JSON.stringify(applied.body));
+    return { site, inviteId, sid, user, spRole, orgId: applied.body.orgId };
+  }
+
+  it("E1. every app finds the account's OWN company: membership lookup, organisation switcher, sites", async () => {
+    const { site, sid, user, orgId } = await latitudeShape("latitude-shape@e2e.example.com");
+    for (const app of ["organization", "security_agency"]) {
+      const m = await h.api(`/members/user/${user._id}/app/${app}`, { sid });
+      assert.equal(m.status, 200, JSON.stringify(m.body));
+      assert.equal(String(m.body.org), orgId, `${app}: Henderson, not the inactive JLL row`);
+      assert.equal(m.body.status, "active");
+      assert.ok(!m.body.siteId, "org-level owner row: no site of its own");
+    }
+    const orgs = await h.api(`/organizations/user/${user._id}?type=organization&limit=50`, { sid });
+    assert.equal(orgs.status, 200, JSON.stringify(orgs.body));
+    assert.deepEqual(orgs.body.items.map((o) => String(o.value)), [orgId], "one organisation, not JLL beside it");
+    // the security app's (and the mobile apps') site list: the engaged site
+    const sites = await h.api(`/customer-sites?org=${orgId}&status=active&limit=50`, { sid });
+    assert.equal(sites.status, 200, JSON.stringify(sites.body));
+    assert.deepEqual(sites.body.items.map((x) => String(x.site)), [site.toString()]);
+  });
+
+  it("E2. Repair on an already-repaired account retires the leftover full-access role only while nobody uses it; Undo restores it", async () => {
+    const { inviteId, spRole, user } = await latitudeShape("latitude-role@e2e.example.com");
+    const preview = await h.api(`/service-provider-invitations/${inviteId}/wrong-join`, { sid: adminSid });
+    assert.equal(preview.status, 200, JSON.stringify(preview.body));
+    assert.equal(preview.body.memberships.length, 0);
+    assert.deepEqual(preview.body.leftoverRoles.map((r) => r.name), ["Admin Service Provider"]);
+
+    // someone at JLL was since given that role -> it is JLL's now, never touched
+    const other = await h.db.collection("members").insertOne({ user: new ObjectId(), org: id.pmOrg, role: spRole, type: "security_agency", status: "active", createdAt: new Date() });
+    const kept = await h.api(`/service-provider-invitations/${inviteId}/wrong-join/repair`, { method: "PUT", sid: adminSid });
+    assert.equal(kept.body.changed, 0, JSON.stringify(kept.body));
+    assert.equal((await h.db.collection("roles").findOne({ _id: spRole })).status, "active");
+    await h.db.collection("members").deleteOne({ _id: other.insertedId });
+
+    const repaired = await h.api(`/service-provider-invitations/${inviteId}/wrong-join/repair`, { method: "PUT", sid: adminSid });
+    assert.equal(repaired.status, 200, JSON.stringify(repaired.body));
+    assert.equal(repaired.body.changed, 1);
+    assert.equal((await h.db.collection("roles").findOne({ _id: spRole })).status, "deleted");
+    // Henderson is untouched
+    assert.equal(await h.db.collection("members").countDocuments({ user: user._id, status: "active" }), 2);
+
+    const undone = await h.api(`/service-provider-invitations/${inviteId}/wrong-join/undo`, { method: "PUT", sid: adminSid });
+    assert.equal(undone.status, 200, JSON.stringify(undone.body));
+    assert.equal((await h.db.collection("roles").findOne({ _id: spRole })).status, "active");
+    // Undo of a role-only repair re-activates no membership
+    assert.equal(await h.db.collection("members").countDocuments({ user: user._id, org: id.pmOrg, status: "active" }), 0);
+  });
+
+  it("E3. accept-new-company is idempotent per invitation: a retry after a half-finished attempt reuses the company; a second click is refused; one company", async () => {
+    const site = new ObjectId();
+    await h.db.collection("sites").insertOne({ _id: site, name: "Latitude", orgId: id.pmOrg, status: "active" });
+    const email = "double-click@e2e.example.com";
+    const inviteId = await invite(email, "security_agency", site);
+    await approve(inviteId);
+    const sid = await newAccount(email);
+    const user = await h.db.collection("users").findOne({ email });
+    // the first attempt died after creating the organisation (no roles, no members, invite still pending)
+    const half = new ObjectId();
+    await h.db.collection("organizations").insertOne({ _id: half, name: "Henderson Security Services Pte Ltd", type: "security_agency", nature: "security_agency", email, createdBy: user._id, invitedFrom: inviteId, status: "active", createdAt: new Date().toISOString() });
+
+    const retry = await h.api(`/service-provider-invitations/${inviteId}/accept-new-company`, { method: "PUT", sid, body: { companyName: "Henderson Security Services Pte Ltd" } });
+    assert.equal(retry.status, 200, JSON.stringify(retry.body));
+    assert.equal(retry.body.orgId, half.toString(), "the half-made company, not a second one");
+    assert.equal(await h.db.collection("organizations").countDocuments({ invitedFrom: inviteId }), 1);
+    const owners = await h.db.collection("members").find({ user: user._id, org: half, status: "active" }).toArray();
+    assert.deepEqual(owners.map((m) => m.type).sort(), ["organization", "security_agency"]);
+    assert.ok(await h.db.collection("customer.sites").findOne({ org: half, site, status: "active" }));
+
+    const again = await h.api(`/service-provider-invitations/${inviteId}/accept-new-company`, { method: "PUT", sid, body: { companyName: "Henderson Security Services Pte Ltd" } });
+    assert.equal(again.status, 400, JSON.stringify(again.body));
+    assert.equal(await h.db.collection("organizations").countDocuments({ createdBy: { $in: [user._id, user._id.toString()] } }), 1);
+    assert.equal(await h.db.collection("members").countDocuments({ user: user._id, org: half }), 2, "no duplicate owner rows");
+  });
 });
 
 async function seed(h) {

package/test/member-working-membership.test.mjs

@@ -0,0 +1,28 @@
+// latitude.sec@ (2026-09-30): an INACTIVE membership in another organisation
+// (the sender, after Repair) must never be the app's membership over the
+// person's live one. See preferWorkingMembership in member-lookup.util.ts.
+import test from "node:test";
+import assert from "node:assert/strict";
+import { preferWorkingMembership, pickLookupMembership } from "./.build/utils/member-lookup.util.mjs";
+
+const jll = { org: "jll", type: "organization", status: "inactive", siteId: "latitude" };
+const hen = { org: "hen", type: "organization", status: "active", siteId: "" };
+const other = { org: "oth", type: "organization", status: "active" };
+
+test("a working row beats an older inactive one", () => {
+  assert.equal(preferWorkingMembership([jll, hen]), hen);
+});
+test("the default organisation wins among working rows", () => {
+  assert.equal(preferWorkingMembership([jll, other, hen], "HEN"), hen);
+  assert.equal(preferWorkingMembership([jll, other, hen]), other);
+});
+test("no working row: the old answer (never not-found), deleted last", () => {
+  const sus = { org: "a", status: "suspended" };
+  const del = { org: "b", status: "deleted" };
+  assert.equal(preferWorkingMembership([del, sus]), sus);
+  assert.equal(preferWorkingMembership([del]), del);
+  assert.equal(preferWorkingMembership([]), null);
+});
+test("the lookup used by the module gate follows the same rule", () => {
+  assert.equal(pickLookupMembership([jll, hen], "organization"), hen);
+});

package/test/ounitech-api-2025-10.test.mjs

@@ -6,10 +6,14 @@ import { after, before, test } from "node:test";
 
 import { ROBOT_CLOUD_PATHS, OUNITECH_TIMESTAMP_SKEW_S } from "./.build/utils/robot-cloud.util.mjs";
 import { RobotCloudError, useRobotCloudService } from "./.build/services/robot-cloud.service.mjs";
+import { OUNITECH_CODES, ounitechCodeWords } from "./.build/utils/ounitech-codes.util.mjs";
+import { registerRobotBrand, robotManifest } from "./.build/utils/robot-adapter.util.mjs";
+import { robotFaultText } from "./.build/utils/robot-fault.util.mjs";
 import {
   createOunitechAdapter,
   ounitechRobotFromHomeRow,
   ounitechFault,
+  OUNITECH_BRAND_DEFINITION,
   ounitechJobWords,
   OUNITECH_FRESH_MS,
   ounitechMapShare,
@@ -313,7 +317,7 @@ test("status 7 costs one extra read, get-robot-state-v2.0 by robotId, to name th
   const r = await adapter().getRobot("ERROR1");
   assert.deepEqual(seen.map((s) => s.path), [ROBOT_CLOUD_PATHS.homeRobotList, ROBOT_CLOUD_PATHS.robotState]);
   assert.equal(seen[1].body.robotId, 427);
-  assert.deepEqual(r.fault, { code: "621", message: "Right wheel driver reset (fault 621)" });
+  assert.deepEqual(r.fault, { code: "621", message: "621 · Right wheel driver reset. Normal when the emergency stop is pressed or released - no action needed." });
   assert.deepEqual(ounitechFault([]), { code: "error", message: "The robot reports an error" });
 });
 
@@ -448,7 +452,7 @@ test("live state mapping, recorded reply (pure)", () => {
   assert.equal(off.statusName, "Offline");
   // a fault listed live is named even without status 7
   const faulty = ounitechRobotFromHomeRow({ robotSn: "E" }, { statusFlag: 1, rtFaultList: [{ errCode: "302", errMsg: "Clean water tank empty" }] }, now);
-  assert.deepEqual(faulty.fault, { code: "302", message: "Clean water tank empty (fault 302)" });
+  assert.deepEqual(faulty.fault, { code: "302", message: "302 · Robot can't load its map. Call Ounitech support." }, "a listed code: the maker's table wins");
 });
 
 test("cleaning readings: water levels, tanks and covers, job progress only while cleaning (pure)", async () => {
@@ -557,8 +561,8 @@ test("records: jobs, alert history, consumables, power schedule, lifts, readings
   );
   assert.deepEqual(r.alerts.items.map((x) => [x.code, x.level, x.message, x.resolved]), [
     ["734", "Notice", "IMU zero offset too large", false],
-    ["540", "Notice", "Floor check: cliff sensor switched on", false],
-    ["621", null, "Right wheel driver reset", true],
+    ["540", "Notice", "Cliff sensor switched on", false],
+    ["621", null, "Right wheel driver reset. Normal when the emergency stop is pressed or released - no action needed.", true],
   ]);
   assert.deepEqual(r.consumables.items, [{ part: "Left side brush", hours: 705.5, days: 30 }]);
   assert.deepEqual(r.power.items, [{ days: [1, 2, 3, 4, 5], time: "20:00", action: "off", enabled: true }]);
@@ -580,11 +584,11 @@ test("records: a robot not on the account says so", async () => {
 
 test("alert, reading, task and schedule mapping (pure, recorded shapes)", () => {
   const a = ounitechAlertRecord({ errMsg: "785 - (提示)定位准备完成( 5)", createTime: "2026-09-30 07:02:57" });
-  assert.deepEqual(a, { code: "785", level: "Notice", message: "Localisation ready", vendorText: "定位准备完成", resolved: false, at: "2026-09-29T23:02:57.000Z" });
+  assert.deepEqual(a, { code: "785", level: "Notice", message: "Position ready", vendorText: "定位准备完成", resolved: false, at: "2026-09-29T23:02:57.000Z" });
   assert.equal(ounitechAlertRecord({ errMsg: "999 - (警告)未知( 3)" }).message, "Robot alert 999: 未知", "unknown code: code first, the vendor's words kept");
   // Robot 424's other prod alerts (2026-09-30) read in English.
   assert.equal(ounitechAlertRecord({ errMsg: "589 - (提示)定时关机( 5)" }).message, "Switched off by the timed power schedule");
-  assert.equal(ounitechAlertRecord({ errMsg: "205 - 边刷驱动器离线( 4)" }).message, "Side brush driver offline");
+  assert.equal(ounitechAlertRecord({ errMsg: "205 - 边刷驱动器离线( 4)" }).message, "Side-brush driver offline (side brush won't turn). Check the side-brush motor wire.");
   assert.equal(ounitechAlertRecord({ errMsg: "900 - plain words" }).message, "plain words");
   assert.equal(ounitechConsumable({ unitcode: "scraper", workminutes: 60 }).part, "Scraper");
   assert.equal(ounitechAlertRecord({ errMsg: "999 - (警告)未知( 3)" }).level, "Warning");
@@ -711,11 +715,50 @@ test("diagnose: the ten reads each answered, no Wi-Fi password, no phone number"
 
 // Live, robot 424, 30 Sep: rtFaultList came as plain strings, and area "default" (centre 0,0) faulted 306.
 test("a string fault from rtFaultList: code kept, English words", () => {
-  assert.deepEqual(ounitechFault(["306 - 接收定点指定区域故障( 1)"]), { code: "306", message: "Robot couldn't receive the chosen cleaning area (fault 306)" });
-  assert.deepEqual(ounitechFault(["999 - 未知( 1)"]), { code: "999", message: "Robot alert 999: 未知" });
+  assert.deepEqual(ounitechFault(["306 - 接收定点指定区域故障( 1)"]), {
+    code: "306",
+    message: "306 · Robot couldn't receive the chosen area. Clear the fault (press and release the emergency stop), then send the task again.",
+  });
+  assert.deepEqual(ounitechFault(["999 - 未知( 1)"]), { code: "999", message: "999 · 未知" }, "unknown code: vendor code + its own text");
+  assert.deepEqual(ounitechFault(["734 - (提示)IMU零点偏移过大( 5)"]), { code: "734", message: "734 · IMU zero offset too large" }, "not in the maker's list: translated vendor text");
+  assert.deepEqual(ounitechFault([{ errCode: 563, errMsg: "机器人已故障" }]).message.startsWith("563 · Robot is in a fault state. Find the cause"), true);
   assert.deepEqual(ounitechFault(["plain words"]), { code: "error", message: "plain words" });
 });
 
+test("maker's code table: English + fix for every listed code, ranges filled, fix only where the manual gives one", () => {
+  const n = Object.keys(OUNITECH_CODES).length;
+  assert.ok(n >= 220, `${n} codes`);
+  for (const [code, [what, fix]] of Object.entries(OUNITECH_CODES)) {
+    assert.match(code, /^\d{3}$/);
+    assert.ok(what && !/[㐀-鿿]/.test(what) && !/[㐀-鿿]/.test(fix ?? ""), `${code} English only`);
+    assert.ok(!what.endsWith(".") && !(fix ?? "").endsWith("."), `${code} no trailing period (added when joined)`);
+  }
+  assert.equal(OUNITECH_CODES["734"], undefined, "734 is not in the maker's list");
+  assert.equal(ounitechCodeWords("306"), "Robot couldn't receive the chosen area. Clear the fault (press and release the emergency stop), then send the task again.");
+  assert.equal(ounitechCodeWords("588"), "Switched off with the power button", "informational: no fix");
+  assert.equal(ounitechCodeWords("750"), "Sensor or camera calibration. Recalibrate if it failed.", "range filled");
+  assert.equal(ounitechCodeWords("999"), null);
+});
+
+test("the fault notice reads the English words + fix once, no doubled period", () => {
+  const fault = ounitechFault(["306 - 接收定点指定区域故障( 1)"]);
+  assert.equal(
+    robotFaultText("HERO-OTH-CLEANING", fault).body,
+    "HERO-OTH-CLEANING reports a fault: 306 · Robot couldn't receive the chosen area. Clear the fault (press and release the emergency stop), then send the task again.",
+  );
+});
+
+test("Ounitech manifest carries the manual's fault-clearing steps; other brands none", () => {
+  registerRobotBrand(OUNITECH_BRAND_DEFINITION); // each test bundle carries its own registry
+  const steps = robotManifest("ounitech", "Q3").profile.clearFault;
+  assert.equal(steps.length, 4);
+  assert.match(steps[0], /emergency stop.*clockwise/);
+  assert.match(steps[1], /charging dock/);
+  assert.match(steps[2], /power switch at the back/);
+  assert.match(steps[3], /Child lock 3 times/);
+  assert.deepEqual(robotManifest("nope").profile.clearFault, []);
+});
+
 test("Clean area refuses an area with no centre point before anything reaches the robot", async () => {
   clearOunitechCaches();
   seen.length = 0;