@5minds/node-red-contrib-processcube 1.1.4-feature-cf47e1-m0h7fe3x → 1.1.4-feature-e7d879-m0jyro4t

package/externaltask-event-listener.js

@@ -16,14 +16,14 @@ module.exports = function (RED) {
 
             let subscription;
 
-            function externalTaskCallback(event) {
+            function externalTaskCallback() {
                 return (externalTaskNotification) => {
                     if (config.externaltask != '' && config.externaltask != externalTaskNotification.flowNodeId) return;
                     node.send({
                         payload: {
                             flowNodeInstanceId: externalTaskNotification.flowNodeInstanceId,
                             externalTaskEvent: externalTaskNotification,
-                            action: event,
+                            action: config.eventtype,
                             type: 'externaltask',
                         },
                     });
@@ -31,21 +31,17 @@ module.exports = function (RED) {
             }
 
             async function subscribe() {
-                switch (config.eventtype) {
-                    case 'created':
-                        return await client.notification.onExternalTaskCreated(externalTaskCallback('created'), {
-                            identity: currentIdentity,
-                        });
-                    case 'locked':
-                        return await client.notification.onExternalTaskLocked(externalTaskCallback('locked'), {
-                            identity: currentIdentity,
-                        });
-                    case 'unlocked':
-                        return await client.notification.onExternalTaskUnlocked(externalTaskCallback('unlocked'), {
-                            identity: currentIdentity,
-                        });
-                    default:
-                        console.error('no such event: ' + config.eventtype);
+                const eventHandlers = {
+                    created: client.notification.onExternalTaskCreated,
+                    locked: client.notification.onExternalTaskLocked,
+                    unlocked: client.notification.onExternalTaskUnlocked,
+                };
+
+                const handler = eventHandlers[config.eventtype];
+                if (handler) {
+                    return await handler(externalTaskCallback(), { identity: currentIdentity });
+                } else {
+                    console.error('no such event: ' + config.eventtype);
                 }
             }
 

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@5minds/node-red-contrib-processcube",
-    "version": "1.1.4-feature-cf47e1-m0h7fe3x",
+    "version": "1.1.4-feature-e7d879-m0jyro4t",
     "license": "MIT",
     "description": "Node-RED nodes for ProcessCube",
     "scripts": {

package/usertask-event-listener.js

@@ -17,7 +17,7 @@ module.exports = function (RED) {
             let subscription;
             const query = RED.util.evaluateNodeProperty(config.query, config.query_type, node);
 
-            function userTaskCallback(event) {
+            function userTaskCallback() {
                 return async (userTaskNotification) => {
                     if (config.usertask != '' && config.usertask != userTaskNotification.flowNodeId) return;
                     const newQuery = {
@@ -37,7 +37,7 @@ module.exports = function (RED) {
                                 flowNodeInstanceId: userTaskNotification.flowNodeInstanceId,
                                 userTaskEvent: userTaskNotification,
                                 userTask: userTask,
-                                action: event,
+                                action: config.eventtype,
                                 type: 'usertask',
                             },
                         });
@@ -46,26 +46,18 @@ module.exports = function (RED) {
             }
 
             async function subscribe() {
-                switch (config.eventtype) {
-                    case 'new':
-                        return await client.userTasks.onUserTaskWaiting(userTaskCallback('new'), {
-                            identity: currentIdentity,
-                        });
-                    case 'finished':
-                        return await client.userTasks.onUserTaskFinished(userTaskCallback('finished'), {
-                            identity: currentIdentity,
-                        });
-                    case 'reserved':
-                        return await client.userTasks.onUserTaskReserved(userTaskCallback('reserved'), {
-                            identity: currentIdentity,
-                        });
-                    case 'reservation-canceled':
-                        return await client.userTasks.onUserTaskReservationCanceled(
-                            userTaskCallback('reservation-canceled'),
-                            { identity: currentIdentity }
-                        );
-                    default:
-                        console.error('no such event: ' + config.eventtype);
+                const eventHandlers = {
+                    new: client.userTasks.onUserTaskWaiting,
+                    finished: client.userTasks.onUserTaskFinished,
+                    reserved: client.userTasks.onUserTaskReserved,
+                    'reservation-canceled': client.userTasks.onUserTaskReservationCanceled,
+                };
+
+                const handler = eventHandlers[config.eventtype];
+                if (handler) {
+                    return await handler(userTaskCallback(), { identity: currentIdentity });
+                } else {
+                    console.error('no such event: ' + config.eventtype);
                 }
             }