@5minds/node-red-contrib-processcube 0.14.0-feature-612fd3-lywvsveq → 0.14.0-feature-ebe375-lyxawl6i

package/Dockerfile

@@ -1,4 +1,4 @@
-FROM node:20 as builder
+FROM node:20 AS builder
 
 COPY ./ /src/node-red-contrib-processcube
 

package/docker-compose.yml

@@ -12,6 +12,9 @@ services:
     volumes:
       - ./nodered/:/nodered/
       - ./examples/:/examples/
+    depends_on:
+      - engine
+      - authority
   
   engine:
     image: 5minds/processcube_engine:2024-1
@@ -24,6 +27,8 @@ services:
       iam__baseUrl: http://authority:11560
       iam__allowAnonymousRootAccess: true
     command: --seed-dir=/processes --port 8000
+    depends_on:
+      - authority
 
   authority:
     image: 5minds/processcube_authority:3.0.4

package/externaltask-error.js

@@ -10,22 +10,26 @@ module.exports = function(RED) {
 
             const externalTaskId = msg.externalTaskId;
 
-            let error = msg.error;
+            let msgError = msg.error;
 
-            if (error === undefined) {
-                error.message = "An error occurred";
-                error.source = msg.payload;
+            if (msgError === undefined) {
+                msgError.message = "An error occurred";
             }
 
-            msg.payload = {
-                "error": {
-                    errorCode: config.error,
-                    errorMessage: error.message,
-                    errorDetails: error.source
-                }
-            };
+            msg.errorCode = config.error;
+            msg.errorMessage = msgError.message;
+            //msg.errorDetails = RED.util.encodeObject(msg); // circular structure
 
-            eventEmitter.emit(`handle-${externalTaskId}`, msg, true);
+            const error = new Error(msg.errorMessage);
+            error.errorCode = msg.errorCode;
+            error.errorDetails = RED.util.encodeObject(msg);
+            
+            // TODO: hack cause https://github.com/5minds/ProcessCube.Engine.Client.ts/blob/develop/src/ExternalTaskWorker.ts#L180
+            error.stack = error.errorDetails; 
+            error.externalTaskId = externalTaskId;
+            error._msgid = msg._msgid;
+
+            eventEmitter.emit(`handle-${externalTaskId}`, error, true);
             
             node.send(msg);
         });     

package/externaltask-input.js

@@ -20,7 +20,6 @@ module.exports = function(RED) {
         var flowContext = node.context().flow;
         var nodeContext = node.context();
 
-
         this.engine = this.server = RED.nodes.getNode(config.engine);
 
         const engineUrl = this.engine?.url || process.env.ENGINE_URL || 'http://engine:8000';
@@ -46,27 +45,35 @@ module.exports = function(RED) {
                 return await new Promise((resolve, reject) => {
 
                     const handleFinishTask = (msg) => {
+                        let result = RED.util.encodeObject(msg.payload);
+
+                        node.log(`handle event for external task ${externalTask.flowNodeInstanceId} and process it with result ${result} on msg._msgid ${msg._msgid}.`);
+
                         if (msg.externalTaskId) {
                             delete started_external_tasks[msg.externalTaskId];
                         }
 
                         showStatus(node, Object.keys(started_external_tasks).length);
 
-                        let result = RED.util.encodeObject(msg.payload);
 
                         resolve(result);
                     };
 
                     const handleErrorTask = (msg) => {
+
+                        node.log(`handle error event for external task ${externalTask.flowNodeInstanceId} with result ${msg} on msg._msgid ${msg._msgid}.`);
+
                         if (msg.externalTaskId) {
                             delete started_external_tasks[msg.externalTaskId];
                         }
 
                         showStatus(node, Object.keys(started_external_tasks).length);
 
-                        let result = RED.util.encodeObject(msg);
 
-                        reject(result);
+                        // TODO: with reject, the default error handling is proceed 
+                        // SEE: https://github.com/5minds/ProcessCube.Engine.Client.ts/blob/develop/src/ExternalTaskWorker.ts#L180
+                        // reject(result);
+                        resolve(msg);
                     };
 
                     eventEmitter.once(`handle-${externalTask.flowNodeInstanceId}`, (msg, isError = false) => {

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@5minds/node-red-contrib-processcube",
-    "version": "0.14.0-feature-612fd3-lywvsveq",
+    "version": "0.14.0-feature-ebe375-lyxawl6i",
     "license": "MIT",
     "description": "Node-RED nodes for ProcessCube",
     "authors": [

package/processcube-engine-config.js

@@ -13,14 +13,29 @@ module.exports = function(RED) {
         this.identity = null;
         this.registerOnIdentityChanged = function (callback) {
             identityChangedCallbacks.push(callback);
-        }
+        };
+
         this.setIdentity = (identity)  => {
             this.identity = identity;
 
             for (const callback of identityChangedCallbacks) {
                 callback(identity);
             }
-        }
+        };
+
+        var nodeContext = node.context();
+
+        this.getEngineClient = () => {
+            const engineUrl = this.url || process.env.ENGINE_URL || 'http://engine:8000';
+            let client = nodeContext.get('client');
+
+            if (!client) {
+                nodeContext.set('client', new engine_client.EngineClient(engineUrl));
+                client = nodeContext.get('client');
+            }   
+
+            return client;
+        };
 
         if (this.credentials.clientId && this.credentials.clientSecret) {
             const engineClient = new engine_client.EngineClient(this.url);