@5minds/node-red-contrib-processcube-tools 1.0.1-feature-e7a81a-mfdq8poq → 1.0.1-feature-d1ae95-mfds5a5x

package/email-receiver/email-receiver.js

@@ -19,10 +19,8 @@ module.exports = function(RED) {
             let folders;
             if (Array.isArray(imap_folder)) {
                 folders = imap_folder;
-            } else if (typeof imap_folder === 'string') {
-                folders = imap_folder.split(',').map(f => f.trim()).filter(f => f.length > 0);
             } else {
-                const errorMsg = "The 'folders' property must be an array of strings or a comma-separated string.";
+                const errorMsg = "The 'folders' property must be an array of strings.";
                 node.status({ fill: 'red', shape: 'ring', text: errorMsg });
                 node.error(errorMsg, msg);
                 return;
@@ -45,7 +43,14 @@ module.exports = function(RED) {
             };
 
             if (!finalConfig.user || !finalConfig.password || !finalConfig.port || !finalConfig.host || !finalConfig.folders) {
-                const errorMessage = 'Missing required IMAP config (user, password, port, host, or folders missing). Aborting.';
+                const missingFields = [];
+                if (!finalConfig.user) missingFields.push('user');
+                if (!finalConfig.password) missingFields.push('password');
+                if (!finalConfig.port) missingFields.push('port');
+                if (!finalConfig.host) missingFields.push('host');
+                if (!finalConfig.folders) missingFields.push('folders');
+
+                const errorMessage = `Missing required IMAP config: ${missingFields.join(', ')}. Aborting.`;
                 node.status({ fill: 'red', shape: 'ring', text: 'missing config' });
                 node.error(errorMessage);
                 return;

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@5minds/node-red-contrib-processcube-tools",
-    "version": "1.0.1-feature-e7a81a-mfdq8poq",
+    "version": "1.0.1-feature-d1ae95-mfds5a5x",
     "license": "MIT",
     "description": "Node-RED tools nodes for ProcessCube",
     "scripts": {

package/test/unit/email-receiver.unit.test.js

@@ -168,8 +168,8 @@ describe('Email Receiver Node - Unit Tests', function() {
               userType: 'str',
               password: 'testpass',
               passwordType: 'str',
-              folder: 'INBOX',
-              folderType: 'str',
+              folder: ["INBOX"],
+              folderType: 'json',
               markseen: true,
               markseenType: 'bool'
             };
@@ -201,6 +201,9 @@ describe('Email Receiver Node - Unit Tests', function() {
       // ARRANGE: Mock the Node-RED environment
       let nodeInstance;
       let inputCallback;
+      let messagesSent = 0;
+      const expectedMessages = 2;
+
       const mockRED = {
         nodes: {
           createNode: function(node, config) {
@@ -211,29 +214,58 @@ describe('Email Receiver Node - Unit Tests', function() {
             node.send = (msg) => {
               should.exist(msg);
               msg.payload.should.equal('test body');
-              done();
+              messagesSent++;
+              if (messagesSent === expectedMessages) {
+                done();
+              }
             };
             return node;
           },
           registerType: (type, constructor) => {
-            new constructor({
-              host: "imap.test.com", hostType: "str",
-              port: 993, portType: "num",
-              user: "test@test.com", userType: "str",
-              password: "testpass", passwordType: "str",
-              folder: ["INBOX", "Junk"], folderType: 'json',
-              markseen: true, markseenType: 'bool'
-            });
-          }
-        },
-        util: { evaluateNodeProperty: (value) => value },
-      };
+          const mockNode = {
+            id: 'mock-node-id',
+            on: (event, callback) => {
+              if (event === 'input') {
+                inputCallback = callback;
+              }
+            },
+            status: () => {},
+            error: () => {},
+            send: (msg) => {
+              should.exist(msg);
+              msg.payload.should.equal('test body');
+              messagesSent++;
+              if (messagesSent === expectedMessages) {
+                done();
+              }
+            },
+          };
+          // Create an instance of the node with the test configuration
+          const node = new constructor(mockNode, {
+            host: "imap.test.com", hostType: "str",
+            port: 993, portType: "num",
+            user: "test@test.com", userType: "str",
+            password: "testpass", passwordType: "str",
+            folder: ["INBOX", "Junk"], folderType: 'json',
+            markseen: true, markseenType: 'bool'
+          });
+        }
+      },
+      util: { evaluateNodeProperty: (value) => value },
+    };
 
       // ACT: Register the node, then simulate input
-      emailReceiverNode(mockRED);
-      inputCallback({});
-    });
+       emailReceiverNode(mockRED);
+    // After the node is registered, simulate an input to trigger the flow
+    setTimeout(() => {
+        if (inputCallback) {
+            inputCallback({});
+        } else {
+            done(new Error("Input callback not set up."));
+        }
+    }, 50); // Use a small timeout to ensure the mocks are fully set up
   });
+});
 
   describe('Error Handling', function() {
     it('should call node.error for invalid folder type', function(done) {
@@ -273,7 +305,7 @@ describe('Email Receiver Node - Unit Tests', function() {
           port: 993, portType: "num",
           user: "test@test.com", userType: "str",
           password: "", passwordType: "str", // Empty password should trigger error
-          folder: "INBOX", folderType: "str"
+          folder: ["INBOX"], folderType: "json"
         },
         on: (event, callback) => { if (event === 'input') nodeInstance.inputCallback = callback; },
         status: (s) => { statusCalled = true; s.fill.should.equal('red'); },