@5minds/node-red-contrib-processcube-tools 1.0.1-feature-cf0d8b-mfl5sxpl → 1.0.1-feature-00f482-mfm5528x

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@5minds/node-red-contrib-processcube-tools",
-    "version": "1.0.1-feature-cf0d8b-mfl5sxpl",
+    "version": "1.0.1-feature-00f482-mfm5528x",
     "license": "MIT",
     "description": "Node-RED tools nodes for ProcessCube",
     "scripts": {

package/test/helpers/email-sender.mocks.js

@@ -93,7 +93,7 @@ function createMockNodemailer(options = {}) {
             shouldFail: false,
             // New options for different email statuses
             rejectedEmails: [], // Array of emails to mark as rejected
-            pendingEmails: [],  // Array of emails to mark as pending
+            pendingEmails: [], // Array of emails to mark as pending
             acceptedEmails: [], // Array of emails to mark as accepted (overrides default)
         },
         options,
@@ -118,7 +118,11 @@ function createMockNodemailer(options = {}) {
                 let rejected = [];
                 let pending = [];
 
-                if (settings.rejectedEmails.length > 0 || settings.pendingEmails.length > 0 || settings.acceptedEmails.length > 0) {
+                if (
+                    settings.rejectedEmails.length > 0 ||
+                    settings.pendingEmails.length > 0 ||
+                    settings.acceptedEmails.length > 0
+                ) {
                     // Use explicit configuration
                     if (settings.rejectedEmails.includes(toEmail)) {
                         rejected = [toEmail];

package/test/unit/email-sender.unit.test.js

@@ -100,7 +100,7 @@ describe('E-Mail Sender Node Unit Tests', function () {
         it('should send email successfully and set status to "sent"', function (done) {
             let statusSet = false;
 
-            // ARRANGE: Initialisiere mockNodemailer
+            // ARRANGE: Initialize mockNodemailer
             const mockNodemailer = createMockNodemailer();
 
             // Mock the nodemailer module
@@ -147,16 +147,13 @@ describe('E-Mail Sender Node Unit Tests', function () {
             let redStatusSet = false;
 
             function checkDone() {
-                console.log('Check done - Error:', errorHandlerCalled, 'Status:', redStatusSet);
                 if (errorHandlerCalled && redStatusSet) {
                     done();
                 }
             }
 
-            // Explizit shouldFail auf true setzen
+            // Explicitly set shouldFail to true
             const mockOptions = { shouldFail: true };
-            console.log('Creating mock with options:', mockOptions); // Debug log
-
             const mockNodemailer = createMockNodemailer(mockOptions);
 
             // Mock the nodemailer module
@@ -172,14 +169,12 @@ describe('E-Mail Sender Node Unit Tests', function () {
                     }
                 },
                 statusHandler: function (status) {
-                    console.log('Status received:', status);
                     if (status.fill === 'red' && status.text === 'error sending') {
                         redStatusSet = true;
                         checkDone();
                     }
                 },
                 errorHandler: function (err) {
-                    console.log('Error received:', err);
                     expect(err.message).to.equal('Mock sendMail error');
                     errorHandlerCalled = true;
                     checkDone();
@@ -203,9 +198,7 @@ describe('E-Mail Sender Node Unit Tests', function () {
             let statusSet = false;
 
             function checkDone() {
-                console.log('checkDone called - attachmentsChecked:', attachmentsChecked, 'statusSet:', statusSet);
                 if (attachmentsChecked && statusSet) {
-                    console.log('Both conditions met, calling done');
                     done();
                 }
             }
@@ -221,54 +214,44 @@ describe('E-Mail Sender Node Unit Tests', function () {
                     content: 'This is the second test file.',
                 },
             ];
-            console.log('Test attachments configured');
 
             const mockNodemailer = createMockNodemailer({
                 onSendMail: (mailOptions) => {
-                    console.log('onSendMail called with attachments:', mailOptions.attachments);
                     expect(mailOptions.attachments).to.be.an('array').with.lengthOf(2);
                     expect(mailOptions.attachments[0].filename).to.equal('test1.txt');
                     expect(mailOptions.attachments[1].content).to.equal('This is the second test file.');
                     attachmentsChecked = true;
-                    console.log('Attachments checked successfully');
                     checkDone();
                 },
             });
-            console.log('Mock nodemailer created');
 
             // Mock the nodemailer module
             delete require.cache[require.resolve('nodemailer')];
             require.cache[require.resolve('nodemailer')] = {
                 exports: mockNodemailer,
             };
-            console.log('Nodemailer mock installed');
 
             const mockRED = createMockNodeRED({
                 onHandler: function (event, callback) {
-                    console.log('onHandler called with event:', event);
                     if (event === 'input') {
                         this.inputCallback = callback;
                     }
                 },
                 statusHandler: function (status) {
-                    console.log('statusHandler called with status:', status);
                     if (status.fill === 'green') {
                         expect(status.text).to.include('sent');
                         expect(status.shape).to.equal('dot');
                         statusSet = true;
-                        console.log('Status set successfully');
                         checkDone();
                     }
                 },
                 errorHandler: function (err) {
-                    console.log('errorHandler called with:', err);
                     done(err || new Error('Unexpected error handler called'));
                 },
             });
 
             const emailSenderNode = require('../../email-sender/email-sender.js');
             emailSenderNode(mockRED);
-            console.log('Email sender node initialized');
 
             const config = { ...emailSenderConfigs.valid };
             config.attachments = JSON.stringify(attachments);
@@ -276,7 +259,6 @@ describe('E-Mail Sender Node Unit Tests', function () {
 
             const nodeConstructor = mockRED.nodes.lastRegisteredConstructor;
             const nodeInstance = new nodeConstructor(config);
-            console.log('Node instance created');
 
             setTimeout(() => {
                 nodeInstance.inputCallback({
@@ -291,7 +273,6 @@ describe('E-Mail Sender Node Unit Tests', function () {
             let redStatusSet = false;
 
             function checkDone() {
-                console.log('Check done - Error:', errorHandlerCalled, 'Status:', redStatusSet);
                 if (errorHandlerCalled && redStatusSet) {
                     done();
                 }
@@ -330,7 +311,6 @@ describe('E-Mail Sender Node Unit Tests', function () {
                     }
                 },
                 errorHandler: function (err) {
-                    console.log('Error received:', err);
                     expect(err).to.equal("Attachment object is missing 'filename' or 'content' property.");
                     errorHandlerCalled = true;
                     checkDone();
@@ -352,25 +332,239 @@ describe('E-Mail Sender Node Unit Tests', function () {
                 topic: 'test message',
             });
         });
-    });
 
-    it('should handle rejected emails and set status to rejected', function (done) {
-        // To be implemented
-        done();
-    });
+        it('should handle rejected emails and set status to rejected', function (done) {
+            let errorHandlerCalled = false;
+            let redStatusSet = false;
 
-    it('should handle pending emails and set status to pending', function (done) {
-        // To be implemented
-        done();
-    });
+            function checkDone() {
+                if (errorHandlerCalled && redStatusSet) {
+                    done();
+                }
+            }
 
-    it('should handle a single attachment object correctly', function (done) {
-        // To be implemented
-        done();
-    });
+            // ARRANGE: Configure mock to simulate rejected emails
+            const mockOptions = {
+                rejectedEmails: ['recipient@example.com'],
+                acceptedEmails: [], // Ensure no emails are accepted
+            };
+
+            const mockNodemailer = createMockNodemailer(mockOptions);
+
+            // Mock the nodemailer module
+            delete require.cache[require.resolve('nodemailer')];
+            require.cache[require.resolve('nodemailer')] = {
+                exports: mockNodemailer,
+            };
+
+            const mockRED = createMockNodeRED({
+                onHandler: function (event, callback) {
+                    if (event === 'input') {
+                        this.inputCallback = callback;
+                    }
+                },
+                statusHandler: function (status) {
+                    if (status.fill === 'red' && status.text === 'rejected') {
+                        redStatusSet = true;
+                        checkDone();
+                    }
+                },
+                errorHandler: function (err) {
+                    expect(err.message).to.include('Email rejected: recipient@example.com');
+                    errorHandlerCalled = true;
+                    checkDone();
+                },
+            });
+
+            const emailSenderNode = require('../../email-sender/email-sender.js');
+            emailSenderNode(mockRED);
+
+            const nodeConstructor = mockRED.nodes.lastRegisteredConstructor;
+            const nodeInstance = new nodeConstructor(emailSenderConfigs.valid);
+
+            nodeInstance.inputCallback({
+                payload: 'test',
+                topic: 'test message',
+            });
+        });
 
-    it('should handle an empty attachments string without error', function (done) {
-        // To be implemented
-        done();
+        it('should handle pending emails and set status to pending', function (done) {
+            let errorHandlerCalled = false;
+            let yellowStatusSet = false;
+
+            function checkDone() {
+                if (errorHandlerCalled && yellowStatusSet) {
+                    done();
+                }
+            }
+
+            // ARRANGE: Configure mock to simulate pending emails
+            const mockOptions = {
+                pendingEmails: ['recipient@example.com'],
+                acceptedEmails: [], // Ensure no emails are accepted
+            };
+
+            const mockNodemailer = createMockNodemailer(mockOptions);
+
+            // Mock the nodemailer module
+            delete require.cache[require.resolve('nodemailer')];
+            require.cache[require.resolve('nodemailer')] = {
+                exports: mockNodemailer,
+            };
+
+            const mockRED = createMockNodeRED({
+                onHandler: function (event, callback) {
+                    if (event === 'input') {
+                        this.inputCallback = callback;
+                    }
+                },
+                statusHandler: function (status) {
+                    if (status.fill === 'yellow' && status.text === 'pending') {
+                        yellowStatusSet = true;
+                        checkDone();
+                    }
+                },
+                errorHandler: function (err) {
+                    expect(err.message).to.include('Email pending: recipient@example.com');
+                    errorHandlerCalled = true;
+                    checkDone();
+                },
+            });
+
+            const emailSenderNode = require('../../email-sender/email-sender.js');
+            emailSenderNode(mockRED);
+
+            const nodeConstructor = mockRED.nodes.lastRegisteredConstructor;
+            const nodeInstance = new nodeConstructor(emailSenderConfigs.valid);
+
+            nodeInstance.inputCallback({
+                payload: 'test',
+                topic: 'test message',
+            });
+        });
+
+        it('should handle a single attachment object correctly', function (done) {
+            let attachmentChecked = false;
+            let statusSet = false;
+
+            function checkDone() {
+                if (attachmentChecked && statusSet) {
+                    done();
+                }
+            }
+
+            // ARRANGE: Configure test with single attachment object
+            const singleAttachment = {
+                filename: 'single-test.txt',
+                content: 'This is a single test file.',
+            };
+
+            const mockNodemailer = createMockNodemailer({
+                onSendMail: (mailOptions) => {
+                    expect(mailOptions.attachments).to.be.an('array').with.lengthOf(1);
+                    expect(mailOptions.attachments[0].filename).to.equal('single-test.txt');
+                    expect(mailOptions.attachments[0].content).to.equal('This is a single test file.');
+                    attachmentChecked = true;
+                    checkDone();
+                },
+            });
+
+            // Mock the nodemailer module
+            delete require.cache[require.resolve('nodemailer')];
+            require.cache[require.resolve('nodemailer')] = {
+                exports: mockNodemailer,
+            };
+
+            const mockRED = createMockNodeRED({
+                onHandler: function (event, callback) {
+                    if (event === 'input') {
+                        this.inputCallback = callback;
+                    }
+                },
+                statusHandler: function (status) {
+                    if (status.fill === 'green') {
+                        expect(status.text).to.include('sent');
+                        expect(status.shape).to.equal('dot');
+                        statusSet = true;
+                        checkDone();
+                    }
+                },
+                errorHandler: function (err) {
+                    done(err || new Error('Unexpected error handler called'));
+                },
+            });
+
+            const emailSenderNode = require('../../email-sender/email-sender.js');
+            emailSenderNode(mockRED);
+
+            const config = { ...emailSenderConfigs.valid };
+            config.attachments = JSON.stringify(singleAttachment);
+            config.attachmentsType = 'json';
+
+            const nodeConstructor = mockRED.nodes.lastRegisteredConstructor;
+            const nodeInstance = new nodeConstructor(config);
+
+            setTimeout(() => {
+                nodeInstance.inputCallback({
+                    payload: 'test',
+                    topic: 'test message',
+                });
+            }, 100);
+        });
+
+        it('should handle an empty attachments string without error', function (done) {
+            let statusSet = false;
+
+            // ARRANGE: Create mock nodemailer to verify no attachments are processed
+            const mockNodemailer = createMockNodemailer({
+                onSendMail: (mailOptions) => {
+                    // Should be an empty array when no attachments are provided
+                    expect(mailOptions.attachments).to.be.an('array').with.lengthOf(0);
+                },
+            });
+
+            // Mock the nodemailer module
+            delete require.cache[require.resolve('nodemailer')];
+            require.cache[require.resolve('nodemailer')] = {
+                exports: mockNodemailer,
+            };
+
+            const mockRED = createMockNodeRED({
+                onHandler: function (event, callback) {
+                    if (event === 'input') {
+                        this.inputCallback = callback;
+                    }
+                },
+                statusHandler: function (status) {
+                    if (status.fill === 'green') {
+                        expect(status.text).to.include('sent');
+                        expect(status.shape).to.equal('dot');
+                        statusSet = true;
+                        done();
+                    }
+                },
+                errorHandler: function (err) {
+                    done(err || new Error('Unexpected error handler called'));
+                },
+            });
+
+            const emailSenderNode = require('../../email-sender/email-sender.js');
+            emailSenderNode(mockRED);
+
+            const config = { ...emailSenderConfigs.valid };
+            // Set attachments to empty string to test this scenario
+            config.attachments = '';
+            config.attachmentsType = 'str';
+
+            const nodeConstructor = mockRED.nodes.lastRegisteredConstructor;
+            const nodeInstance = new nodeConstructor(config);
+
+            setTimeout(() => {
+                nodeInstance.inputCallback({
+                    payload: 'test',
+                    topic: 'test message',
+                });
+            }, 100);
+        });
     });
 });