@5minds/node-red-contrib-processcube-tools 1.0.1-feature-7fb5cf-mff3dkae → 1.0.1-feature-61e7c9-mff5coiu

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@5minds/node-red-contrib-processcube-tools",
-    "version": "1.0.1-feature-7fb5cf-mff3dkae",
+    "version": "1.0.1-feature-61e7c9-mff5coiu",
     "license": "MIT",
     "description": "Node-RED tools nodes for ProcessCube",
     "scripts": {

package/test/unit/email-receiver.unit.test.js

@@ -1,7 +1,5 @@
 const should = require('should');
 const {
-  createMockImap,
-  createMockMailparser,
   createMockNodeRED,
   setupModuleMocks,
   testConfigs,
@@ -184,7 +182,16 @@ describe('Email Receiver Node - Unit Tests with Helpers', function() {
     });
 
     it('should handle connection errors gracefully', function(done) {
-      // ARRANGE: Set up connection error scenario
+      // ARRANGE: Set up connection error scenario with done() protection
+      let testCompleted = false;
+
+      const completeDone = () => {
+        if (!testCompleted) {
+          testCompleted = true;
+          done();
+        }
+      };
+
       const mockRED = createMockNodeRED({
         onHandler: function(event, callback) {
           if (event === 'input') {
@@ -193,20 +200,16 @@ describe('Email Receiver Node - Unit Tests with Helpers', function() {
         },
         statusHandler: function(status) {
           if (status.fill === 'red' && status.text && status.text.includes('error')) {
-            done(); // Success - error status was set
+            completeDone(); // Success - error status was set
           }
         },
         errorHandler: function(err) {
           // Also accept errors as valid completion
           should.exist(err);
-          done();
+          completeDone();
         }
       });
 
-      // ACT: Create node and trigger connection attempt
-      emailReceiverNode(mockRED);
-      const nodeConstructor = mockRED.nodes.lastRegisteredConstructor;
-
       // Use a config that should cause connection issues
       const badConfig = {
         ...testConfigs.valid,
@@ -214,6 +217,9 @@ describe('Email Receiver Node - Unit Tests with Helpers', function() {
         port: 12345 // Invalid port
       };
 
+      // ACT: Register node and create instance with invalid config
+      emailReceiverNode(mockRED);
+      const nodeConstructor = mockRED.nodes.lastRegisteredConstructor;
       const nodeInstance = new nodeConstructor(badConfig);
 
       // Trigger the error by sending an input message
@@ -222,7 +228,7 @@ describe('Email Receiver Node - Unit Tests with Helpers', function() {
         if (nodeInstance.inputCallback) {
           nodeInstance.inputCallback({ payload: "test" });
         } else {
-          done(new Error('inputCallback was not set on the node instance'));
+          completeDone(new Error('inputCallback was not set on the node instance'));
         }
       }, 10);
     });
@@ -234,15 +240,13 @@ describe('Email Receiver Node - Unit Tests with Helpers', function() {
       const mockRED = createMockNodeRED({
         onHandler: function(event, callback) {
           if (event === 'input') {
-            // Store the callback on the node instance
             this.inputCallback = callback;
           }
         },
         statusHandler: function(status) {
-          if (status.fill === 'green') {
-            // ASSERT: Should show connected status
-            status.text.should.containEql('connected');
-            done();
+          // ASSERT: Check for 'connected' status and then complete the test
+            if (status.fill === 'green' && status.text === 'connected') {
+              done();
           }
         }
       });
@@ -302,36 +306,4 @@ describe('Email Receiver Node - Unit Tests with Helpers', function() {
       }, 10);
     });
   });
-
-  describe('Message Verification Utilities', function() {
-    it('should verify message properties using testUtils', function() {
-      // ARRANGE: Create a test message
-      const testMessage = {
-        payload: 'test content',
-        topic: 'email/received',
-        from: 'test@example.com'
-      };
-
-      // ACT & ASSERT: Use helper to verify message properties
-      testUtils.verifyMessage(testMessage, {
-        payload: 'test content',
-        topic: 'email/received'
-      });
-
-      // Should not throw any errors if verification passes
-      testMessage.should.have.property('from', 'test@example.com');
-    });
-
-    it('should use wait utility for async operations', async function() {
-      // ARRANGE: Record start time
-      const startTime = Date.now();
-
-      // ACT: Use the wait utility
-      await testUtils.wait(100);
-
-      // ASSERT: Should have waited approximately the right amount of time
-      const elapsed = Date.now() - startTime;
-      elapsed.should.be.approximately(100, 50); // Allow 50ms tolerance
-    });
-  });
 });