@5minds/node-red-contrib-processcube-tools 1.0.1-feature-2a3502-mfe1ptiw → 1.0.1-feature-20a8ee-mff2npts

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@5minds/node-red-contrib-processcube-tools",
-    "version": "1.0.1-feature-2a3502-mfe1ptiw",
+    "version": "1.0.1-feature-20a8ee-mff2npts",
     "license": "MIT",
     "description": "Node-RED tools nodes for ProcessCube",
     "scripts": {

package/test/helpers/email-receiver.mocks.js

@@ -144,15 +144,31 @@ function createMockMailparser() {
  * Create mock Node-RED object for unit testing
  */
 function createMockNodeRED(options = {}) {
-  return {
+  // Store input callback in the mock RED context
+  let storedInputCallback = null;
+  let nodeInstance = null;
+
+  const mockRED = {
     nodes: {
       createNode: function(node, config) {
+        nodeInstance = node; // Capture the node instance
+
         // Apply config properties to node
         Object.assign(node, {
           id: config.id || 'mock-node-id',
           type: config.type || 'email-receiver',
           name: config.name || 'Mock Node',
-          on: options.onHandler || function() {},
+          on: function(event, callback) {
+            if (event === 'input') {
+              storedInputCallback = callback;
+              // Store the callback on the node instance for easy access
+              node.inputCallback = callback;
+            }
+            // Call the original onHandler if provided
+            if (options.onHandler) {
+              options.onHandler.call(node, event, callback);
+            }
+          },
           status: options.statusHandler || function() {},
           error: options.errorHandler || function() {},
           send: options.sendHandler || function() {},
@@ -166,6 +182,14 @@ function createMockNodeRED(options = {}) {
         // Store registration for verification in tests
         this.lastRegisteredType = type;
         this.lastRegisteredConstructor = constructor;
+      },
+      // Helper method to get the stored input callback
+      getInputCallback: function() {
+        return storedInputCallback;
+      },
+      // Helper method to get the node instance
+      getNodeInstance: function() {
+        return nodeInstance;
       }
     },
     util: {
@@ -181,7 +205,7 @@ function createMockNodeRED(options = {}) {
             return null;
           }
         }
-        
+
         // Simple mock implementation
         if (callback) {
           callback(null, value);
@@ -202,6 +226,8 @@ function createMockNodeRED(options = {}) {
       debug: options.logDebug || function() {}
     }
   };
+
+  return mockRED;
 }
 
 /**
@@ -247,7 +273,7 @@ const testConfigs = {
     userType: 'str',
     password: 'testpass',
     passwordType: 'str',
-    folder: 'INBOX',
+    folder: ['INBOX'],
     folderType: 'str',
     markseen: true,
     markseenType: 'bool'
@@ -271,6 +297,22 @@ const testConfigs = {
     markseenType: 'bool'
   },
 
+  invalidFolderType: {
+    id: 'test-node-4',
+    type: 'email-receiver',
+    name: 'Invalid Config Test',
+    host: '',  // Missing host
+    hostType: 'str',
+    port: 993,
+    portType: 'num',
+    user: 'test@test.com',
+    userType: 'str',
+    password: '',  // Missing password
+    passwordType: 'str',
+    folder: 123,
+    folderType: 'num'
+  },
+
   invalidConfig: {
     id: 'test-node-4',
     type: 'email-receiver',
@@ -283,7 +325,7 @@ const testConfigs = {
     userType: 'str',
     password: '',  // Missing password
     passwordType: 'str',
-    folder: 123,  // Wrong type
+    folder: ["Inbox"],
     folderType: 'num'
   },
 

package/test/unit/email-receiver.unit.test.js

@@ -116,6 +116,11 @@ describe('Email Receiver Node - Unit Tests with Helpers', function() {
     it('should call node.error for invalid folder type', function(done) {
       // ARRANGE: Set up error tracking
       const mockRED = createMockNodeRED({
+        onHandler: function(event, callback) {
+          if (event === 'input') {
+            this.inputCallback = callback;
+          }
+        },
         errorHandler: function(err) {
           // ASSERT: Should receive appropriate error message
           err.should.containEql("The 'folders' property must be an array of strings.");
@@ -126,13 +131,28 @@ describe('Email Receiver Node - Unit Tests with Helpers', function() {
       // ACT: Register node and create instance with invalid config
       emailReceiverNode(mockRED);
       const nodeConstructor = mockRED.nodes.lastRegisteredConstructor;
-      new nodeConstructor(testConfigs.invalidConfig);
+      const nodeInstance = new nodeConstructor(testConfigs.invalidFolderType);
+
+      // Trigger the error by sending an input message
+      // Use a small delay to ensure the constructor has completed
+      setTimeout(() => {
+        if (nodeInstance.inputCallback) {
+          nodeInstance.inputCallback({ payload: "test" });
+        } else {
+          done(new Error('inputCallback was not set on the node instance'));
+        }
+      }, 10);
     });
 
     it('should call node.error for missing config', function(done) {
       // ARRANGE: Set up error and status tracking
       let statusCalled = false;
       const mockRED = createMockNodeRED({
+        onHandler: function(event, callback) {
+          if (event === 'input') {
+            this.inputCallback = callback;
+          }
+        },
         statusHandler: function(status) {
           statusCalled = true;
           if (status.fill) {
@@ -150,7 +170,61 @@ describe('Email Receiver Node - Unit Tests with Helpers', function() {
       // ACT: Register node and create instance with invalid config
       emailReceiverNode(mockRED);
       const nodeConstructor = mockRED.nodes.lastRegisteredConstructor;
-      new nodeConstructor(testConfigs.invalidConfig);
+      const nodeInstance = new nodeConstructor(testConfigs.invalidConfig);
+
+      // Trigger the error by sending an input message
+      // Use a small delay to ensure the constructor has completed
+      setTimeout(() => {
+        if (nodeInstance.inputCallback) {
+          nodeInstance.inputCallback({ payload: "test" });
+        } else {
+          done(new Error('inputCallback was not set on the node instance'));
+        }
+      }, 10);
+    });
+
+    it('should handle connection errors gracefully', function(done) {
+      // ARRANGE: Set up connection error scenario
+      const mockRED = createMockNodeRED({
+        onHandler: function(event, callback) {
+          if (event === 'input') {
+            this.inputCallback = callback;
+          }
+        },
+        statusHandler: function(status) {
+          if (status.fill === 'red' && status.text && status.text.includes('error')) {
+            done(); // Success - error status was set
+          }
+        },
+        errorHandler: function(err) {
+          // Also accept errors as valid completion
+          should.exist(err);
+          done();
+        }
+      });
+
+      // ACT: Create node and trigger connection attempt
+      emailReceiverNode(mockRED);
+      const nodeConstructor = mockRED.nodes.lastRegisteredConstructor;
+
+      // Use a config that should cause connection issues
+      const badConfig = {
+        ...testConfigs.valid,
+        host: 'nonexistent.invalid.host.com',
+        port: 12345 // Invalid port
+      };
+
+      const nodeInstance = new nodeConstructor(badConfig);
+
+      // Trigger the error by sending an input message
+      // Use a small delay to ensure the constructor has completed
+      setTimeout(() => {
+        if (nodeInstance.inputCallback) {
+          nodeInstance.inputCallback({ payload: "test" });
+        } else {
+          done(new Error('inputCallback was not set on the node instance'));
+        }
+      }, 10);
     });
   });