@5minds/node-red-contrib-processcube-tools 1.0.1-feature-20a8ee-mff2npts → 1.0.1-feature-7ab4ae-mff3roeh

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@5minds/node-red-contrib-processcube-tools",
-    "version": "1.0.1-feature-20a8ee-mff2npts",
+    "version": "1.0.1-feature-7ab4ae-mff3roeh",
     "license": "MIT",
     "description": "Node-RED tools nodes for ProcessCube",
     "scripts": {

package/test/helpers/email-receiver.mocks.js

@@ -12,10 +12,21 @@ function createMockImap() {
 
     // Simulate connection behavior
     this.connect = () => {
-      // Simulate successful connection by emitting 'ready' event
-      if (this.events && this.events.ready) {
-        // Use setTimeout to simulate async behavior
-        setTimeout(() => this.events.ready(), 10);
+      // Check if we should simulate a connection error
+      if (this.config.host && this.config.host.includes('invalid')) {
+        // Simulate connection error
+        if (this.events && this.events.error) {
+          setTimeout(() => {
+            const error = new Error('Connection failed');
+            error.code = 'ENOTFOUND';
+            this.events.error(error);
+          }, 10);
+        }
+      } else {
+        // Simulate successful connection by emitting 'ready' event
+        if (this.events && this.events.ready) {
+          setTimeout(() => this.events.ready(), 10);
+        }
       }
     };
 

package/test/unit/email-receiver.unit.test.js

@@ -1,7 +1,5 @@
 const should = require('should');
 const {
-  createMockImap,
-  createMockMailparser,
   createMockNodeRED,
   setupModuleMocks,
   testConfigs,
@@ -184,7 +182,16 @@ describe('Email Receiver Node - Unit Tests with Helpers', function() {
     });
 
     it('should handle connection errors gracefully', function(done) {
-      // ARRANGE: Set up connection error scenario
+      // ARRANGE: Set up connection error scenario with done() protection
+      let testCompleted = false;
+
+      const completeDone = () => {
+        if (!testCompleted) {
+          testCompleted = true;
+          done();
+        }
+      };
+
       const mockRED = createMockNodeRED({
         onHandler: function(event, callback) {
           if (event === 'input') {
@@ -193,20 +200,16 @@ describe('Email Receiver Node - Unit Tests with Helpers', function() {
         },
         statusHandler: function(status) {
           if (status.fill === 'red' && status.text && status.text.includes('error')) {
-            done(); // Success - error status was set
+            completeDone(); // Success - error status was set
           }
         },
         errorHandler: function(err) {
           // Also accept errors as valid completion
           should.exist(err);
-          done();
+          completeDone();
         }
       });
 
-      // ACT: Create node and trigger connection attempt
-      emailReceiverNode(mockRED);
-      const nodeConstructor = mockRED.nodes.lastRegisteredConstructor;
-
       // Use a config that should cause connection issues
       const badConfig = {
         ...testConfigs.valid,
@@ -214,6 +217,9 @@ describe('Email Receiver Node - Unit Tests with Helpers', function() {
         port: 12345 // Invalid port
       };
 
+      // ACT: Register node and create instance with invalid config
+      emailReceiverNode(mockRED);
+      const nodeConstructor = mockRED.nodes.lastRegisteredConstructor;
       const nodeInstance = new nodeConstructor(badConfig);
 
       // Trigger the error by sending an input message
@@ -222,62 +228,22 @@ describe('Email Receiver Node - Unit Tests with Helpers', function() {
         if (nodeInstance.inputCallback) {
           nodeInstance.inputCallback({ payload: "test" });
         } else {
-          done(new Error('inputCallback was not set on the node instance'));
+          completeDone(new Error('inputCallback was not set on the node instance'));
         }
       }, 10);
     });
   });
 
-  describe('Message Processing', function() {
-    it('should process email message correctly', async function() {
-      // ARRANGE: Set up message capture
-      let processedMessage = null;
-      const mockRED = createMockNodeRED({
-        sendHandler: function(msg) {
-          processedMessage = msg;
-        }
-      });
-
-      // ACT: Create node and simulate email processing
-      emailReceiverNode(mockRED);
-      const nodeConstructor = mockRED.nodes.lastRegisteredConstructor;
-      const nodeInstance = new nodeConstructor(testConfigs.valid);
-
-      // Simulate input trigger (this would depend on your node's implementation)
-      // The actual trigger mechanism would need to match your node's design
-
-      await testUtils.wait(100);
-
-      // ASSERT: Message processing behavior would be verified here
-      // The specific assertions depend on your node's output format
-      should.exist(nodeInstance);
-    });
-
-    it('should handle multiple messages', async function() {
-      // ARRANGE: Set up message collection
-      const messages = [];
-      const mockRED = createMockNodeRED({
-        sendHandler: function(msg) {
-          messages.push(msg);
-        }
-      });
-
-      // ACT: Create node and simulate multiple emails
-      emailReceiverNode(mockRED);
-      const nodeConstructor = mockRED.nodes.lastRegisteredConstructor;
-      const nodeInstance = new nodeConstructor(testConfigs.valid);
-
-      await testUtils.wait(150);
-
-      // ASSERT: Should handle multiple messages appropriately
-      should.exist(nodeInstance);
-    });
-  });
-
   describe('IMAP Connection', function() {
     it('should handle connection success', function(done) {
       // ARRANGE: Set up connection tracking
       const mockRED = createMockNodeRED({
+        onHandler: function(event, callback) {
+          if (event === 'input') {
+            // Store the callback on the node instance
+            this.inputCallback = callback;
+          }
+        },
         statusHandler: function(status) {
           if (status.fill === 'green') {
             // ASSERT: Should show connected status
@@ -287,15 +253,30 @@ describe('Email Receiver Node - Unit Tests with Helpers', function() {
         }
       });
 
-      // ACT: Create node which should attempt connection
+      // ACT: Create node with config that should fail
       emailReceiverNode(mockRED);
       const nodeConstructor = mockRED.nodes.lastRegisteredConstructor;
-      new nodeConstructor(testConfigs.valid);
+      const nodeInstance = new nodeConstructor(testConfigs.valid);
+
+      // Trigger the connection attempt by sending an input message
+      setTimeout(() => {
+        if (nodeInstance.inputCallback) {
+          nodeInstance.inputCallback({ payload: "test" });
+        } else {
+          done(new Error('inputCallback was not set on the node instance'));
+        }
+      }, 10);
     });
 
     it('should handle connection errors', function(done) {
       // ARRANGE: Set up error tracking
       const mockRED = createMockNodeRED({
+        onHandler: function(event, callback) {
+          if (event === 'input') {
+            // Store the callback on the node instance
+            this.inputCallback = callback;
+          }
+        },
         errorHandler: function(err) {
           // ASSERT: Should handle connection errors gracefully
           should.exist(err);
@@ -315,39 +296,16 @@ describe('Email Receiver Node - Unit Tests with Helpers', function() {
 
       // Use invalid config to trigger connection error
       const invalidConfig = { ...testConfigs.valid, host: 'invalid.host.com' };
-      new nodeConstructor(invalidConfig);
-    });
-  });
-
-  describe('Message Verification Utilities', function() {
-    it('should verify message properties using testUtils', function() {
-      // ARRANGE: Create a test message
-      const testMessage = {
-        payload: 'test content',
-        topic: 'email/received',
-        from: 'test@example.com'
-      };
-
-      // ACT & ASSERT: Use helper to verify message properties
-      testUtils.verifyMessage(testMessage, {
-        payload: 'test content',
-        topic: 'email/received'
-      });
-
-      // Should not throw any errors if verification passes
-      testMessage.should.have.property('from', 'test@example.com');
-    });
+      const nodeInstance = new nodeConstructor(invalidConfig);
 
-    it('should use wait utility for async operations', async function() {
-      // ARRANGE: Record start time
-      const startTime = Date.now();
-
-      // ACT: Use the wait utility
-      await testUtils.wait(100);
-
-      // ASSERT: Should have waited approximately the right amount of time
-      const elapsed = Date.now() - startTime;
-      elapsed.should.be.approximately(100, 50); // Allow 50ms tolerance
+      // Trigger the connection attempt by sending an input message
+      setTimeout(() => {
+        if (nodeInstance.inputCallback) {
+          nodeInstance.inputCallback({ payload: "test" });
+        } else {
+          done(new Error('inputCallback was not set on the node instance'));
+        }
+      }, 10);
     });
   });
 });