@4players/odin-nodejs 0.11.2 → 0.11.3

package/cppsrc/odinroom.cpp

@@ -588,7 +588,7 @@ void OdinRoomWrapper::HandleAudioData() {
                 OdinDecoder* decoder = pair.second;
                 bool silent = false; 
                 OdinError rc = odin_decoder_pop(decoder, _audioSamplesBuffer, 1920, &silent);
-                if (!odin_is_error(rc) && !silent) {
+                if (rc == ODIN_ERROR_SUCCESS && !silent) {
                      // Double-check _started before calling callback
                      // This prevents calling a released ThreadSafeFunction
                      if (_started && _audioDataReceivedEventListener) {
@@ -621,8 +621,10 @@ void OdinRoomWrapper::HandleAudioData() {
                                 Napi::Object obj = Napi::Object::New(env);
                                 obj.Set("mediaId", samples->MediaId);
                                 obj.Set("peerId", (double)samples->PeerId); 
-                                obj.Set("samples16", Napi::Buffer<short>::New(env, samples->Data, samples->Len));
-                                obj.Set("samples32", Napi::Buffer<float>::New(env, samples->OriginalData, samples->Len));
+                                // Must use Copy(), not New(). New() wraps the pointer without copying.
+                                // Since we delete samples below, New() would leave JS holding a dangling pointer.
+                                obj.Set("samples16", Napi::Buffer<short>::Copy(env, samples->Data, samples->Len));
+                                obj.Set("samples32", Napi::Buffer<float>::Copy(env, samples->OriginalData, samples->Len));
                                 jsCallback.Call({obj});
                             } catch (...) {
                                 // Exception in audio callback - silently ignore
@@ -642,7 +644,11 @@ void OdinRoomWrapper::HandleAudioData() {
                 }
             }
         }
-        std::this_thread::sleep_for(std::chrono::milliseconds(10));
+        // Sleep must match the decoder frame size (1920 stereo samples @ 48kHz = 20ms).
+        // A shorter sleep (e.g. 10ms) polls faster than audio arrives, causing the
+        // decoder's jitter buffer to produce PLC (Packet Loss Concealment) frames that
+        // stretch and distort the audio stream.
+        std::this_thread::sleep_for(std::chrono::milliseconds(20));
     }
 }
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@4players/odin-nodejs",
-  "version": "0.11.2",
+  "version": "0.11.3",
   "description": "NodeJS bindings for the ODIN SDK. Use for AI enhanced human interactions, content moderation and audio processing features in a backend.",
   "main": "index.cjs",
   "types": "index.d.ts",

package/tests/audio-recording/index.js

@@ -198,8 +198,8 @@ async function run() {
         // Write audio samples to the recording
         const recorder = fileRecorder[mediaId];
         if (recorder && data.samples16) {
-            // Convert Int16Array to Buffer and write to WAV file
-            const buffer = Buffer.from(data.samples16.buffer, data.samples16.byteOffset, data.samples16.byteLength);
+            // Copy audio data into a new buffer for safe async WAV writing
+            const buffer = Buffer.from(data.samples16);
             recorder.wavEncoder.write(buffer);
             recorder.sampleCount += data.samples16.length;
         }